diff options
| author | Symious <14933944+symious@users.noreply.github.com> | 2026-09-10 02:59:59 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2026-09-09 11:59:59 -0700 |
| commit | 4f8ef2140e5c41913f3f2ab49c554c6548609684 (patch) | |
| tree | 42dd5f1052a68b6cea754f1c7d1a5114ad5d6301 /chapter02 | |
| parent | 8ac5cc6bd3b2d30af64a2c12e38b83af618af3c6 (diff) | |
| download | Simple-4f8ef2140e5c41913f3f2ab49c554c6548609684.tar.gz Simple-4f8ef2140e5c41913f3f2ab49c554c6548609684.zip | |
Fix stale copy-pasted comment on BoolNode's phiCon call (#249)
The three comment lines above `AddNode.phiCon(this, ...)` in BoolNode were
copy-pasted from MulNode and never adapted: they use `*` as the operator and
describe the rotated shape `(x * (phi cons)) * con`.
For BoolNode neither is right. The operator is a compare, and in chapters
6-9 `rotate` is hard-coded `false`, so the rotated shape is never matched;
the shapes actually handled are `(phi cons) cmp con` and
`(phi cons) cmp (phi cons)`.
Reword the comment accordingly, and in chapters 6-9 add a line noting why
rotate is off. Chapters 10-25 pass `this instanceof EQ`, so no such claim is
made there.
Comment-only change; no code is touched.
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Diffstat (limited to 'chapter02')
0 files changed, 0 insertions, 0 deletions