diff options
| author | Yichen Yan <oraluben@outlook.com> | 2023-11-01 22:08:30 +0800 |
|---|---|---|
| committer | Dibyendu Majumdar <dibyendumajumdar@users.noreply.github.com> | 2023-11-01 18:56:50 +0000 |
| commit | d3ffe6f9a935888233283962ce077ec25a01bec9 (patch) | |
| tree | d93ccfbdb034562d2fd17e4c2151cf5cddbe64e9 /chapter03/src/main/java | |
| parent | 3cad2b3c0af2418d51bb1ee46b1e24c5b362ba63 (diff) | |
| download | Simple-d3ffe6f9a935888233283962ce077ec25a01bec9.tar.gz Simple-d3ffe6f9a935888233283962ce077ec25a01bec9.zip | |
Bail out unclosed block (#25)
* Report unclosed block in parsing
* Fix tests
* Resolve comments and rebase onto chapter5
* Test `isEOF` after consume whitespaces
Diffstat (limited to 'chapter03/src/main/java')
| -rw-r--r-- | chapter03/src/main/java/com/seaofnodes/simple/Parser.java | 18 |
1 files changed, 13 insertions, 5 deletions
diff --git a/chapter03/src/main/java/com/seaofnodes/simple/Parser.java b/chapter03/src/main/java/com/seaofnodes/simple/Parser.java index 12e156ed..3d06a9c3 100644 --- a/chapter03/src/main/java/com/seaofnodes/simple/Parser.java +++ b/chapter03/src/main/java/com/seaofnodes/simple/Parser.java @@ -39,7 +39,7 @@ public class Parser { } public ReturnNode parse() { - return (ReturnNode) parseBlock(); + return (ReturnNode) parseBlock(false); } @@ -50,14 +50,22 @@ public class Parser { * '{' statements '}' * </pre> */ - private Node parseBlock() { + private Node parseBlock(boolean requireClosingBracket) { // Enter a new scope _scope.push(); Node n = null; - while (!match("}") && !_lexer.isEOF()) { + do { + if (match("}")) { + if (requireClosingBracket) break; + else throw error("unexpected '}' token"); + } else if (_lexer.isEOF()) { + if (requireClosingBracket) require("}"); + else break; + } + Node n0 = parseStatement(); if (n0 != null) n = n0; // Allow null returns from eg showGraph - } + } while (true); // Exit scope _scope.pop(); return n; @@ -73,7 +81,7 @@ public class Parser { private Node parseStatement() { if (match("return")) return parseReturn(); else if (match("int")) return parseDecl(); - else if (match("{")) return parseBlock(); + else if (match("{")) return parseBlock(true); else if (match("#showGraph")) return showGraph(); else return parseExpressionStatement(); } |
