summaryrefslogtreecommitdiff
path: root/chapter05/README.md
diff options
context:
space:
mode:
authorCliff Click <cliffc@acm.org>2026-11-16 14:25:14 -0800
committerCliff Click <cliffc@acm.org>2026-11-16 14:25:14 -0800
commit0dcd3513a633479ce228f24826db4f09e4c0fc8b (patch)
treed8fb6d0fb382df5799789e9dc1eb0fae2d381cce /chapter05/README.md
parent51a029304d8105b201bdfb81a7692b8a1b16b028 (diff)
downloadSimple-0dcd3513a633479ce228f24826db4f09e4c0fc8b.tar.gz
Simple-0dcd3513a633479ce228f24826db4f09e4c0fc8b.zip
Phi fix
Fix Phi/Add refactoring peephole to canonicalize regardless of peephole order. Treat class fcns as having `self` be the class pointer
Diffstat (limited to 'chapter05/README.md')
-rw-r--r--chapter05/README.md15
1 files changed, 15 insertions, 0 deletions
diff --git a/chapter05/README.md b/chapter05/README.md
index 40886af2..0955f36a 100644
--- a/chapter05/README.md
+++ b/chapter05/README.md
@@ -413,6 +413,21 @@ return a;
+### Factoring after strength reduction
+
+Peephole order should not hide the same arithmetic from Phi factoring.
+`Phi(x+x,y+x)` can become `Phi(x,y)+x`, but an earlier peephole may already have
+replaced `x+x` with `x*2`. The Phi matcher therefore views `x*2` as two copies of
+`x` while factoring mixed Add/Mul arms. It does not expand the graph into an Add
+that would immediately fold back to a multiply. If all arms are multiplies,
+ordinary multiply factoring still applies.
+
+[Chapter05Test](src/test/java/com/seaofnodes/simple/Chapter05Test.java)
+checks the factored operands before and after strength reduction and with either
+arm order. Later chapters extend this same view to `x<<1` when shifts arrive.
+The rule stays local to doubling; arbitrary coefficients would require creating
+another multiplication, with a less clear benefit.
+
[^1]: Click, C. (1995).
Combining Analyses, Combining Optimizations, 132.