Chapter 9 (#66)

* chapter9

* merge fixes to chapter8

* Ch 9 notes

* Ch 9 work

Add a Iterate phase, after parsing.
Add a Worklist with fast dup removal & rand pull.
Add a Node.iter() call which returns progress or null.  Peephole calls it.  Iter() also asserts that Types make monotonic progress.
Intern all types, so we can do a cheap/easy "isa" test.

* GVN

* rename temporarily

* Apply Cliff's worklist changes

* Apply Cliff's GVN changes

* Revert "GVN"

This reverts commit 9dc6db1cac7e40de4a58333cbc3c9c3e7c088e6f.

* Revert "Ch 9 work"

This reverts commit df5b74e6c017a4f237a5d1a550a83b40a7928876.

* Fix 3-1+2

Was computing as 3-(1+2) == 0, not 4 as expected.
Add tests.
Unlock in swap12.

* Missed some cut-n-paste changes

* Break up the test file per-chapter

* Fix keep-alive while looping expressions

Must "hook" LHS prior to calling peepholes

* Ch9 Region optimization

Bug fix, GVN hits 2 inProgress Loops
Bug fix lifetime tracking when parsing dead code
Bug fix debug find call
GraphViz post-iterate

* Readme overhaul

Progress on Ch 9 readme

* Fix bugs hashcode

Was relying on label() hashCode for Phi, Proj; since this is debug-only cannot be relied on.  Proj relies on _idx field, Phi needs a !inProgress check.

* Constant nodes print "#" before con

* Add a farther neighbor check

Peeps that check more than the nearest neighbor register a dependency on the Node that failed them.  Should that Node later change, the peep root is put back on the worklist and revisited.

* Fix addDeps assert

Unwind golden test print, print smarter.
Unlock edges in subsume

* Update README

* shuffle adddeps forward one

its needed again shortly in another test, so just cover it now

* Fix fuzzer bugs

Peep x+(-y) to x-y
Handle TOP inputs; didn't think it could happen before running an optimistic pass, but fuzzer proved me wrong.
Deleting an input can recursively delete the self-node.
When checking the compute() type assert, delay setting _type so the method can just be re-run in the debugger.
Missing addDep in Phi
Parser mis-handling stacked operators like "1+-2" or "1==!=<=<>=>2"
Make Work list deterministic between tests.

* Update fuzzer to run iterate (#62)

* Update fuzzer to run iterate

* Work seed is now reset by reset

* A few more fuzzer tests

Set _type in iter() even later, better debugging.
Handle dead active scopes in visiualizer.
Region ideal honors Loop invariants; finish Region ideal for single input; inProgress check is a little tighter.
Type.isConstant is true strictly for lattice centerline constants.  Clean up TypeInteger.
ideaj warning removal

* Fix all fuzzer bugs

iter() does not call peep(), instead peep() is self-recursive.  This allows Iterate() to call iter(), and not get into arbitrary recursive peep() changes that do not track on the worklist.
Div, Minus, If all monotonic.
Catch a bunch of progress issues.
Robustify IRPrinter and Iterate and Region ideal

* Reducer could run into an infinite loop (#63)

* Write up how the Evaluator works (#64)

* Write up how the Evaluator works

* Some small improvements and a slightly better wrap up.

* Series of fuzzer bugs.

Fix monotonicity for all data nodes.
Generic compute intercept for data nodes, check all inputs for TOP/BOTTOM, and again for IntDataNodes.
Fix general progress bug allow high Types as constants.
Fix progress Region 1-input has obvious idom.
Make shortcut for fuzzer; renames Fuzzer to not have "Test" in the class name.
Fix invert comment in TypeInteger

* All fuzzer tests pass

Turn off expensive assert accidentally turned on
CSE needs to join types.
Add a type join.
Missing dep in Phi

* More README

* Hacking alternative way to fix the type compute

* Node is no longer IntSupplier
Renamed Work to WorkList
Renamed Iterate to IterOptim
Renamed Node.iter() to Node.peepholeOpt()
WorkList expects elements to be of Node

* Add an example of GVN

* Rename the method depsClear to moveDepsToWorklist - to better capture what it actually does.

* Add a second example of GVN benefits

* Fix typo

* Add example of worklist opt

* Prepare to allow alternative post parse worklist opt

* Alternative WorkList opt that has following differences:
1. It does not require dependencies between nodes
2. It does not require calls from inside the Node class, and therefore runs totally independently as a post parse step.
3. It is simple

* Alternative WorkList opt that has following differences:
1. It does not require dependencies between nodes
2. It does not require calls from inside the Node class, and therefore runs totally independently as a post parse step.
3. It is simple

* The RPO list was incomplete as it only identified the subgraph accessible from the STOP node.

* Fix iter count

* Add test suggested by Xmilia

* Fix bug where after the region is peeped the phis get consistent number of inputs

* Fix bug where after the region is peeped the phis get consistent number of inputs

* Dump out stats on how many nodes we peepd during the post parse iterative opt.

* Make it easy to switch the IterOpt

* Use deps based worklist by default

* Sharper worklist add

* Copy across Cliff's changes

* Merge changes to Iterate

* Revert failing change

* Update readme

* Add comments / update docs to explain the patterns where we call addDep().

* As before, unconditionally made dep a dependent of region.

* Fix a lot of missing dep issues

Rename IterOptim -> IterPeeps
Some grammar changes in comments & readme

* Bump up fuzzer limits, more testing

Missing dep in idom calc in IfNode.
Missed idom cache clear on Region edit.

* Remove RPO based peeps

O(n^2) behavior

* Minor updates README

* fix compile bug

---------

Co-authored-by: Cliff Click <cliffc@acm.org>
Co-authored-by: XmiliaH <45106915+XmiliaH@users.noreply.github.com>
Co-authored-by: Darrick Wiebe <darrickw@untether.ai>

1 files changed, 98 insertions, 0 deletions

diff --git a/chapter09/Makefile b/chapter09/Makefile
new file mode 100644
index 00000000..b5c21b38
--- /dev/null
+++ b/chapter09/Makefile
@@ -0,0 +1,98 @@
+SHELL := /bin/bash
+.DELETE_ON_ERROR:
+
+# for printing variable values
+# usage: make print-VARIABLE
+#        > VARIABLE = value_of_variable
+print-%  : ; @echo $* = $($*)
+
+# literal space
+space := $() $()
+
+# Decide OS-specific questions
+# jar-file seperator
+ifeq ($(OS),Windows_NT)
+	SEP = ;
+else
+	SEP = :
+endif
+# Find a reasonable ctags.
+CTAGS = $(shell which ctags)
+# Hack for MacOS: /usr/bin/ctags is unfriendly, so look for ctags from brew
+ifeq ($(UNAME),Darwin)
+	CTAGS = $(shell brew list ctags 2> /dev/null | grep bin/ctags)
+endif
+
+# Fun Args to javac.  Mostly limit to java8 source definitions, and fairly
+# aggressive lint warnings.
+JAVAC_ARGS = -g
+
+# Source code
+SIMPLE := com/seaofnodes/simple
+SRC := src/main/java
+TST := src/test/java
+CLZDIR:= build/classes
+main_javas   := $(wildcard $(SRC)/$(SIMPLE)/*java $(SRC)/$(SIMPLE)/*/*java)
+test_javas   := $(wildcard $(TST)/$(SIMPLE)/*java $(TST)/$(SIMPLE)/*/*java)
+main_classes := $(patsubst $(SRC)/%java,$(CLZDIR)/main/%class,$(main_javas))
+test_classes := $(patsubst $(TST)/%java,$(CLZDIR)/test/%class,$(test_javas))
+test_cp      := $(patsubst $(TST)/$(SIMPLE)/%.java,com.seaofnodes.simple.%,$(wildcard $(TST)/$(SIMPLE)/*Test.java))
+classes = $(main_classes) $(test_classes)
+# All the libraries
+libs = $(wildcard lib/*jar)
+jars = $(subst $(space),$(SEP),$(libs))
+
+
+default_targets := $(main_classes) $(test_classes)
+# Optionally add ctags to the default target if a reasonable one was found.
+ifneq ($(CTAGS),)
+default_targets += tags
+endif
+
+default: $(default_targets)
+
+# Compile just the out-of-date files
+$(main_classes): build/classes/main/%class: $(SRC)/%java
+	@echo "compiling " $@ " because " $?
+	@[ -d $(CLZDIR)/main ] || mkdir -p $(CLZDIR)/main
+	@javac $(JAVAC_ARGS) -cp "$(CLZDIR)/main$(SEP)$(jars)" -sourcepath $(SRC) -d $(CLZDIR)/main $(main_javas)
+
+$(test_classes): $(CLZDIR)/test/%class: $(TST)/%java $(main_classes)
+	@echo "compiling " $@ " because " $?
+	@[ -d $(CLZDIR)/test ] || mkdir -p $(CLZDIR)/test
+	@javac $(JAVAC_ARGS) -cp "$(CLZDIR)/test$(SEP)$(CLZDIR)/main$(SEP)$(jars)" -sourcepath $(TST) -d $(CLZDIR)/test $(test_javas)
+
+# Base launch line for JVM tests
+JVM=nice java -ea -cp "build/classes/main${SEP}${jars}${SEP}$(CLZDIR)/test"
+
+tests:	$(default_targets)
+	@echo "testing " $(test_cp)
+	@$(JVM) org.junit.runner.JUnitCore $(test_cp)
+
+fuzzer: $(default_targets)
+	@echo "testing " $(test_cp)
+	@$(JVM) org.junit.runner.JUnitCore com.seaofnodes.simple.FuzzerWrap
+
+
+.PHONY: clean
+clean:
+	rm -rf build
+	rm -f TAGS
+	(find . -name "*~" -exec rm {} \; 2>/dev/null; exit 0)
+
+# Download libs from maven
+lib:	lib/junit-4.12.jar  lib/hamcrest-core-1.3.jar
+
+# Jars
+lib/junit-4.12.jar:
+	@[ -d lib ] || mkdir -p lib
+	@(cd lib; wget https://repo1.maven.org/maven2/junit/junit/4.12/junit-4.12.jar)
+
+lib/hamcrest-core-1.3.jar:
+	@[ -d lib ] || mkdir -p lib
+	@(cd lib; wget https://repo1.maven.org/maven2/org/hamcrest/hamcrest-core/1.3/hamcrest-core-1.3.jar)
+
+# Build emacs tags (part of a tasty emacs ide experience)
+tags:	$(main_javas) $(test_javas)
+	@rm -f TAGS
+	@$(CTAGS) -e --recurse=yes --extra=+q --fields=+fksaiS $(SRC) $(TST)