Chapter 9 (#66)

* chapter9

* merge fixes to chapter8

* Ch 9 notes

* Ch 9 work

Add a Iterate phase, after parsing.
Add a Worklist with fast dup removal & rand pull.
Add a Node.iter() call which returns progress or null.  Peephole calls it.  Iter() also asserts that Types make monotonic progress.
Intern all types, so we can do a cheap/easy "isa" test.

* GVN

* rename temporarily

* Apply Cliff's worklist changes

* Apply Cliff's GVN changes

* Revert "GVN"

This reverts commit 9dc6db1cac7e40de4a58333cbc3c9c3e7c088e6f.

* Revert "Ch 9 work"

This reverts commit df5b74e6c017a4f237a5d1a550a83b40a7928876.

* Fix 3-1+2

Was computing as 3-(1+2) == 0, not 4 as expected.
Add tests.
Unlock in swap12.

* Missed some cut-n-paste changes

* Break up the test file per-chapter

* Fix keep-alive while looping expressions

Must "hook" LHS prior to calling peepholes

* Ch9 Region optimization

Bug fix, GVN hits 2 inProgress Loops
Bug fix lifetime tracking when parsing dead code
Bug fix debug find call
GraphViz post-iterate

* Readme overhaul

Progress on Ch 9 readme

* Fix bugs hashcode

Was relying on label() hashCode for Phi, Proj; since this is debug-only cannot be relied on.  Proj relies on _idx field, Phi needs a !inProgress check.

* Constant nodes print "#" before con

* Add a farther neighbor check

Peeps that check more than the nearest neighbor register a dependency on the Node that failed them.  Should that Node later change, the peep root is put back on the worklist and revisited.

* Fix addDeps assert

Unwind golden test print, print smarter.
Unlock edges in subsume

* Update README

* shuffle adddeps forward one

its needed again shortly in another test, so just cover it now

* Fix fuzzer bugs

Peep x+(-y) to x-y
Handle TOP inputs; didn't think it could happen before running an optimistic pass, but fuzzer proved me wrong.
Deleting an input can recursively delete the self-node.
When checking the compute() type assert, delay setting _type so the method can just be re-run in the debugger.
Missing addDep in Phi
Parser mis-handling stacked operators like "1+-2" or "1==!=<=<>=>2"
Make Work list deterministic between tests.

* Update fuzzer to run iterate (#62)

* Update fuzzer to run iterate

* Work seed is now reset by reset

* A few more fuzzer tests

Set _type in iter() even later, better debugging.
Handle dead active scopes in visiualizer.
Region ideal honors Loop invariants; finish Region ideal for single input; inProgress check is a little tighter.
Type.isConstant is true strictly for lattice centerline constants.  Clean up TypeInteger.
ideaj warning removal

* Fix all fuzzer bugs

iter() does not call peep(), instead peep() is self-recursive.  This allows Iterate() to call iter(), and not get into arbitrary recursive peep() changes that do not track on the worklist.
Div, Minus, If all monotonic.
Catch a bunch of progress issues.
Robustify IRPrinter and Iterate and Region ideal

* Reducer could run into an infinite loop (#63)

* Write up how the Evaluator works (#64)

* Write up how the Evaluator works

* Some small improvements and a slightly better wrap up.

* Series of fuzzer bugs.

Fix monotonicity for all data nodes.
Generic compute intercept for data nodes, check all inputs for TOP/BOTTOM, and again for IntDataNodes.
Fix general progress bug allow high Types as constants.
Fix progress Region 1-input has obvious idom.
Make shortcut for fuzzer; renames Fuzzer to not have "Test" in the class name.
Fix invert comment in TypeInteger

* All fuzzer tests pass

Turn off expensive assert accidentally turned on
CSE needs to join types.
Add a type join.
Missing dep in Phi

* More README

* Hacking alternative way to fix the type compute

* Node is no longer IntSupplier
Renamed Work to WorkList
Renamed Iterate to IterOptim
Renamed Node.iter() to Node.peepholeOpt()
WorkList expects elements to be of Node

* Add an example of GVN

* Rename the method depsClear to moveDepsToWorklist - to better capture what it actually does.

* Add a second example of GVN benefits

* Fix typo

* Add example of worklist opt

* Prepare to allow alternative post parse worklist opt

* Alternative WorkList opt that has following differences:
1. It does not require dependencies between nodes
2. It does not require calls from inside the Node class, and therefore runs totally independently as a post parse step.
3. It is simple

* Alternative WorkList opt that has following differences:
1. It does not require dependencies between nodes
2. It does not require calls from inside the Node class, and therefore runs totally independently as a post parse step.
3. It is simple

* The RPO list was incomplete as it only identified the subgraph accessible from the STOP node.

* Fix iter count

* Add test suggested by Xmilia

* Fix bug where after the region is peeped the phis get consistent number of inputs

* Fix bug where after the region is peeped the phis get consistent number of inputs

* Dump out stats on how many nodes we peepd during the post parse iterative opt.

* Make it easy to switch the IterOpt

* Use deps based worklist by default

* Sharper worklist add

* Copy across Cliff's changes

* Merge changes to Iterate

* Revert failing change

* Update readme

* Add comments / update docs to explain the patterns where we call addDep().

* As before, unconditionally made dep a dependent of region.

* Fix a lot of missing dep issues

Rename IterOptim -> IterPeeps
Some grammar changes in comments & readme

* Bump up fuzzer limits, more testing

Missing dep in idom calc in IfNode.
Missed idom cache clear on Region edit.

* Remove RPO based peeps

O(n^2) behavior

* Minor updates README

* fix compile bug

---------

Co-authored-by: Cliff Click <cliffc@acm.org>
Co-authored-by: XmiliaH <45106915+XmiliaH@users.noreply.github.com>
Co-authored-by: Darrick Wiebe <darrickw@untether.ai>

1 files changed, 67 insertions, 0 deletions

diff --git a/chapter09/docs/09-graph1.gv b/chapter09/docs/09-graph1.gv
new file mode 100644
index 00000000..4f712c2d
--- /dev/null
+++ b/chapter09/docs/09-graph1.gv
@@ -0,0 +1,67 @@
+digraph chapter08 {
+/*
+int x = arg + arg;
+if(arg < 10) {
+    return arg + arg;
+}
+else {
+    x = x + 1;
+}
+return x;
+
+*/
+	rankdir=BT;
+	ordering="in";
+	concentrate="true";
+	compound="true";
+	subgraph cluster_Nodes {
+		Start2 [ shape=plaintext label=<
+			<TABLE BORDER="0" CELLBORDER="1" CELLSPACING="0" CELLPADDING="4">
+			<TR><TD BGCOLOR="yellow">Start</TD></TR>
+			<TR><TD>
+				<TABLE BORDER="0" CELLBORDER="1" CELLSPACING="0">
+				<TR><TD PORT="p0" BGCOLOR="yellow">$ctrl</TD><TD PORT="p1">arg</TD></TR>
+				</TABLE>
+			</TD></TR>
+			</TABLE>>
+		];
+		Stop3 [ shape=box style=filled fillcolor=yellow label="Stop" ];
+		Con_7 [ label="2" ];
+		Mul8 [ label="*" ];
+		Con_9 [ label="10" ];
+		LT10 [ label="<" ];
+		If11 [ shape=plaintext label=<
+			<TABLE BORDER="0" CELLBORDER="1" CELLSPACING="0" CELLPADDING="4">
+			<TR><TD BGCOLOR="yellow">If</TD></TR>
+			<TR><TD>
+				<TABLE BORDER="0" CELLBORDER="1" CELLSPACING="0">
+				<TR><TD PORT="p0" BGCOLOR="yellow">True</TD><TD PORT="p1" BGCOLOR="yellow">False</TD></TR>
+				</TABLE>
+			</TD></TR>
+			</TABLE>>
+		];
+		Con_16 [ label="2" ];
+		Mul17 [ label="*" ];
+		Return18 [ shape=box style=filled fillcolor=yellow label="Return" ];
+		Con_20 [ label="1" ];
+		Add21 [ label="+" ];
+		Return24 [ shape=box style=filled fillcolor=yellow label="Return" ];
+	}
+	edge [ fontname=Helvetica, fontsize=8 ];
+	Stop3 -> Return18[taillabel=0 color=red];
+	Stop3 -> Return24[taillabel=1 color=red];
+	Mul8 -> Start2:p1[taillabel=1];
+	Mul8 -> Con_7[taillabel=2];
+	LT10 -> Start2:p1[taillabel=1];
+	LT10 -> Con_9[taillabel=2];
+	If11 -> Start2:p0[taillabel=0 color=red];
+	If11 -> LT10[taillabel=1];
+	Mul17 -> Start2:p1[taillabel=1];
+	Mul17 -> Con_16[taillabel=2];
+	Return18 -> If11:p0[taillabel=0 color=red];
+	Return18 -> Mul17[taillabel=1];
+	Add21 -> Mul8[taillabel=1];
+	Add21 -> Con_20[taillabel=2];
+	Return24 -> If11:p1[taillabel=0 color=red];
+	Return24 -> Add21[taillabel=1];
+}
\ No newline at end of file