diff options
| author | Cliff Click <cliffc@acm.org> | 2024-09-13 09:40:38 -0700 |
|---|---|---|
| committer | XmiliaH <45106915+XmiliaH@users.noreply.github.com> | 2024-09-13 18:46:01 +0200 |
| commit | 4be43794169610d45e47468702c63cdfbc5deb5a (patch) | |
| tree | cce5414e14ceab8d4e4927bdf553f1e4528429a1 /chapter14/src/main | |
| parent | 703f88dbb2e1e4352a0725b7e742151739b82ea1 (diff) | |
| download | Simple-4be43794169610d45e47468702c63cdfbc5deb5a.tar.gz Simple-4be43794169610d45e47468702c63cdfbc5deb5a.zip | |
move x-x check up front
Diffstat (limited to 'chapter14/src/main')
| -rw-r--r-- | chapter14/src/main/java/com/seaofnodes/simple/node/SubNode.java | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/chapter14/src/main/java/com/seaofnodes/simple/node/SubNode.java b/chapter14/src/main/java/com/seaofnodes/simple/node/SubNode.java index 009fb30e..6d2f1711 100644 --- a/chapter14/src/main/java/com/seaofnodes/simple/node/SubNode.java +++ b/chapter14/src/main/java/com/seaofnodes/simple/node/SubNode.java @@ -22,6 +22,10 @@ public class SubNode extends Node { @Override public Type compute() { + // Sub of same is 0 + if( in(1)==in(2) ) + return TypeInteger.ZERO; + Type t1 = in(1)._type, t2 = in(2)._type; if( t1.isHigh() || t2.isHigh() ) return TypeInteger.TOP; @@ -30,9 +34,6 @@ public class SubNode extends Node { if (i1.isConstant() && i2.isConstant()) return TypeInteger.constant(i1.value()-i2.value()); } - // Sub of same is 0 - if( in(1)==in(2) ) - return TypeInteger.ZERO; return TypeInteger.BOT; } |