summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--Makefile5
-rw-r--r--README.ja.md2
-rw-r--r--README.md2
-rw-r--r--chapter17b.iml28
-rw-r--r--docs/chapter18/18-grammar.ja.md141
-rw-r--r--docs/chapter18/18-grammar.md141
-rw-r--r--docs/chapter18/Makefile1
-rw-r--r--docs/chapter18/README.ja.md226
-rw-r--r--docs/chapter18/README.md363
-rw-r--r--docs/chapter18/font-awesome-4.7.0.zipbin0 -> 669808 bytes
-rw-r--r--docs/chapter18/inline-after.json101
-rw-r--r--docs/chapter18/inline-after.svg81
-rw-r--r--docs/chapter18/inline-before.json276
-rw-r--r--docs/chapter18/inline-before.svg117
-rw-r--r--docs/chapter18/lattice.gv203
-rw-r--r--docs/chapter18/lattice.svg691
-rw-r--r--docs/chapter18/lattice2.gv85
-rw-r--r--docs/chapter18/lattice2.svg260
-rw-r--r--docs/chapter18/webtcp.min.js65
-rw-r--r--src/main/java/com/seaofnodes/simple/Ary.java36
-rw-r--r--src/main/java/com/seaofnodes/simple/CodeGen.java137
-rw-r--r--src/main/java/com/seaofnodes/simple/GlobalCodeMotion.java85
-rw-r--r--src/main/java/com/seaofnodes/simple/IRPrinter.java21
-rw-r--r--src/main/java/com/seaofnodes/simple/IterPeeps.java8
-rw-r--r--src/main/java/com/seaofnodes/simple/ListScheduler.java110
-rw-r--r--src/main/java/com/seaofnodes/simple/Parser.java684
-rw-r--r--src/main/java/com/seaofnodes/simple/SB.java74
-rw-r--r--src/main/java/com/seaofnodes/simple/Var.java57
-rw-r--r--src/main/java/com/seaofnodes/simple/node/AddNode.java13
-rw-r--r--src/main/java/com/seaofnodes/simple/node/AndNode.java17
-rw-r--r--src/main/java/com/seaofnodes/simple/node/BoolNode.java15
-rw-r--r--src/main/java/com/seaofnodes/simple/node/BulkMemPhiNode.java3
-rw-r--r--src/main/java/com/seaofnodes/simple/node/CFGNode.java51
-rw-r--r--src/main/java/com/seaofnodes/simple/node/CProjNode.java6
-rw-r--r--src/main/java/com/seaofnodes/simple/node/CallEndNode.java95
-rw-r--r--src/main/java/com/seaofnodes/simple/node/CallNode.java142
-rw-r--r--src/main/java/com/seaofnodes/simple/node/CastNode.java22
-rw-r--r--src/main/java/com/seaofnodes/simple/node/ConstantNode.java16
-rw-r--r--src/main/java/com/seaofnodes/simple/node/CtrlNode.java15
-rw-r--r--src/main/java/com/seaofnodes/simple/node/DivFNode.java2
-rw-r--r--src/main/java/com/seaofnodes/simple/node/DivNode.java1
-rw-r--r--src/main/java/com/seaofnodes/simple/node/FRefNode.java35
-rw-r--r--src/main/java/com/seaofnodes/simple/node/FunNode.java134
-rw-r--r--src/main/java/com/seaofnodes/simple/node/IfNode.java17
-rw-r--r--src/main/java/com/seaofnodes/simple/node/LoadNode.java33
-rw-r--r--src/main/java/com/seaofnodes/simple/node/LogicalNode.java27
-rw-r--r--src/main/java/com/seaofnodes/simple/node/LoopNode.java57
-rw-r--r--src/main/java/com/seaofnodes/simple/node/MemMergeNode.java5
-rw-r--r--src/main/java/com/seaofnodes/simple/node/MemOpNode.java18
-rw-r--r--src/main/java/com/seaofnodes/simple/node/MinusFNode.java2
-rw-r--r--src/main/java/com/seaofnodes/simple/node/MinusNode.java12
-rw-r--r--src/main/java/com/seaofnodes/simple/node/MulNode.java9
-rw-r--r--src/main/java/com/seaofnodes/simple/node/MultiNode.java11
-rw-r--r--src/main/java/com/seaofnodes/simple/node/MultiUse.java5
-rw-r--r--src/main/java/com/seaofnodes/simple/node/NewNode.java3
-rw-r--r--src/main/java/com/seaofnodes/simple/node/Node.java55
-rw-r--r--src/main/java/com/seaofnodes/simple/node/NotNode.java25
-rw-r--r--src/main/java/com/seaofnodes/simple/node/OrNode.java17
-rw-r--r--src/main/java/com/seaofnodes/simple/node/OutNode.java7
-rw-r--r--src/main/java/com/seaofnodes/simple/node/ParmNode.java40
-rw-r--r--src/main/java/com/seaofnodes/simple/node/PhiNode.java50
-rw-r--r--src/main/java/com/seaofnodes/simple/node/ProjNode.java16
-rw-r--r--src/main/java/com/seaofnodes/simple/node/RegionNode.java29
-rw-r--r--src/main/java/com/seaofnodes/simple/node/ReturnNode.java97
-rw-r--r--src/main/java/com/seaofnodes/simple/node/RoundF32Node.java2
-rw-r--r--src/main/java/com/seaofnodes/simple/node/SarNode.java18
-rw-r--r--src/main/java/com/seaofnodes/simple/node/ScopeNode.java187
-rw-r--r--src/main/java/com/seaofnodes/simple/node/ShlNode.java20
-rw-r--r--src/main/java/com/seaofnodes/simple/node/ShrNode.java18
-rw-r--r--src/main/java/com/seaofnodes/simple/node/StartNode.java16
-rw-r--r--src/main/java/com/seaofnodes/simple/node/StopNode.java43
-rw-r--r--src/main/java/com/seaofnodes/simple/node/StoreNode.java35
-rw-r--r--src/main/java/com/seaofnodes/simple/node/StructNode.java3
-rw-r--r--src/main/java/com/seaofnodes/simple/node/SubNode.java7
-rw-r--r--src/main/java/com/seaofnodes/simple/node/ToFloatNode.java10
-rw-r--r--src/main/java/com/seaofnodes/simple/node/XCtrlNode.java4
-rw-r--r--src/main/java/com/seaofnodes/simple/node/XorNode.java18
-rw-r--r--src/main/java/com/seaofnodes/simple/print/SimpleGraphAdapter.java21
-rw-r--r--src/main/java/com/seaofnodes/simple/print/SimpleGraphObserver.java41
-rw-r--r--src/main/java/com/seaofnodes/simple/type/Field.java17
-rw-r--r--src/main/java/com/seaofnodes/simple/type/Type.java105
-rw-r--r--src/main/java/com/seaofnodes/simple/type/TypeFloat.java99
-rw-r--r--src/main/java/com/seaofnodes/simple/type/TypeFunPtr.java143
-rw-r--r--src/main/java/com/seaofnodes/simple/type/TypeInteger.java89
-rw-r--r--src/main/java/com/seaofnodes/simple/type/TypeMem.java47
-rw-r--r--src/main/java/com/seaofnodes/simple/type/TypeMemPtr.java104
-rw-r--r--src/main/java/com/seaofnodes/simple/type/TypeNil.java62
-rw-r--r--src/main/java/com/seaofnodes/simple/type/TypePtr.java53
-rw-r--r--src/main/java/com/seaofnodes/simple/type/TypeRPC.java100
-rw-r--r--src/main/java/com/seaofnodes/simple/type/TypeStruct.java44
-rw-r--r--src/main/java/com/seaofnodes/simple/type/TypeTuple.java72
-rw-r--r--src/test/java/com/seaofnodes/simple/BrainFuckTest.java21
-rw-r--r--src/test/java/com/seaofnodes/simple/Chapter01Test.java34
-rw-r--r--src/test/java/com/seaofnodes/simple/Chapter02Test.java42
-rw-r--r--src/test/java/com/seaofnodes/simple/Chapter03Test.java29
-rw-r--r--src/test/java/com/seaofnodes/simple/Chapter04Test.java124
-rw-r--r--src/test/java/com/seaofnodes/simple/Chapter05Test.java79
-rw-r--r--src/test/java/com/seaofnodes/simple/Chapter06Test.java116
-rw-r--r--src/test/java/com/seaofnodes/simple/Chapter07Test.java100
-rw-r--r--src/test/java/com/seaofnodes/simple/Chapter08Test.java87
-rw-r--r--src/test/java/com/seaofnodes/simple/Chapter09Test.java135
-rw-r--r--src/test/java/com/seaofnodes/simple/Chapter10Test.java207
-rw-r--r--src/test/java/com/seaofnodes/simple/Chapter11Test.java23
-rw-r--r--src/test/java/com/seaofnodes/simple/Chapter12Test.java147
-rw-r--r--src/test/java/com/seaofnodes/simple/Chapter13Test.java103
-rw-r--r--src/test/java/com/seaofnodes/simple/Chapter14FloatTest.java50
-rw-r--r--src/test/java/com/seaofnodes/simple/Chapter14Test.java121
-rw-r--r--src/test/java/com/seaofnodes/simple/Chapter15Test.java164
-rw-r--r--src/test/java/com/seaofnodes/simple/Chapter16Test.java80
-rw-r--r--src/test/java/com/seaofnodes/simple/Chapter17aTest.java48
-rw-r--r--src/test/java/com/seaofnodes/simple/Chapter17bTest.java431
-rw-r--r--src/test/java/com/seaofnodes/simple/Chapter18Test.java551
-rw-r--r--src/test/java/com/seaofnodes/simple/CompoundAssignmentTest.java25
-rw-r--r--src/test/java/com/seaofnodes/simple/Eval2.java454
-rw-r--r--src/test/java/com/seaofnodes/simple/FuzzerWrap.java9
-rw-r--r--src/test/java/com/seaofnodes/simple/MergeSortTest.java65
-rw-r--r--src/test/java/com/seaofnodes/simple/MutabilityTest.java17
-rw-r--r--src/test/java/com/seaofnodes/simple/SchedulerTest.java18
-rw-r--r--src/test/java/com/seaofnodes/simple/TypeTest.java45
-rw-r--r--src/test/java/com/seaofnodes/simple/evaluator/Evaluator.java64
-rw-r--r--src/test/java/com/seaofnodes/simple/evaluator/Scheduler.java96
-rw-r--r--src/test/java/com/seaofnodes/simple/fuzzer/Fuzzer.java50
-rw-r--r--src/test/java/com/seaofnodes/simple/fuzzer/FuzzerUtils.java11
-rw-r--r--src/test/java/com/seaofnodes/simple/fuzzer/ScriptGenerator.java3
124 files changed, 7861 insertions, 2168 deletions
diff --git a/Makefile b/Makefile
index 3f1e53ff..11a698a8 100644
--- a/Makefile
+++ b/Makefile
@@ -2,6 +2,7 @@ SHELL := /bin/bash
# Shared packaging target; included after chapter source variables below.
.DELETE_ON_ERROR:
+
# for printing variable values
# usage: make print-VARIABLE
# > VARIABLE = value_of_variable
@@ -70,13 +71,15 @@ JVM=nice java -ea -cp "build/classes/main${SEP}${jars}${SEP}$(CLZDIR)/test"
tests: $(default_targets)
@echo "testing " $(test_cp)
- @$(JVM) org.junit.runner.JUnitCore $(test_cp) com.seaofnodes.simple.FuzzerWrap
+ @$(JVM) org.junit.runner.JUnitCore $(test_cp)
+ @$(JVM) org.junit.runner.JUnitCore com.seaofnodes.simple.FuzzerWrap
fuzzer: $(default_targets)
@echo "fuzzing " $(test_cp)
@$(JVM) org.junit.runner.JUnitCore com.seaofnodes.simple.FuzzerWrap
+
.PHONY: clean
clean:
rm -rf build
diff --git a/README.ja.md b/README.ja.md
index c003c793..2ce5ce95 100644
--- a/README.ja.md
+++ b/README.ja.md
@@ -55,7 +55,7 @@ Simple 言語のスタイルは、C または Java のサブセットに倣っã�
* [第16章](docs/chapter16/README.ja.md):コンストラクタ。
* [第17a章](docs/chapter17a/README.ja.md):束縛の可変性、参照の権限、深い読み取り専用ビュー。
* [第17b章](docs/chapter17b/README.ja.md):糖衣構文。`var`、`val`、`x+=y`、`for(init; test; next) body`。
-* 第18章:関数と呼び出し。
+* [第18章](docs/chapter18/README.ja.md):関数と呼び出し。
* 第19章:命令選択と移植可能なコンパイル。
* 第20章:グラフ彩色によるレジスタ割り当て。
* 第21章:命令エンコーディングと ELF。
diff --git a/README.md b/README.md
index 81fb3c2f..88cfd152 100644
--- a/README.md
+++ b/README.md
@@ -64,7 +64,7 @@ The Simple language is styled after a subset of C or Java.
* [Chapter 16](docs/chapter16/README.md): Constructors
* [Chapter 17a](docs/chapter17a/README.md): Binding mutability, reference permissions, and deep read-only views.
* [Chapter 17b](docs/chapter17b/README.md): Syntax sugar: `var`, `val`, `x+=y`, `for(init; test; next) body`
-* Chapter 18: Functions and calls.
+* [Chapter 18](docs/chapter18/README.md): Functions and calls.
* Chapter 19: Instruction selection and portable compilation
* Chapter 20: Graph Coloring Register Allocation
* Chapter 21: Instruction Encodings & ELF
diff --git a/chapter17b.iml b/chapter17b.iml
deleted file mode 100644
index 3075ff71..00000000
--- a/chapter17b.iml
+++ /dev/null
@@ -1,28 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<module type="JAVA_MODULE" version="4">
- <component name="NewModuleRootManager" inherit-compiler-output="false">
- <output url="file://$MODULE_DIR$/../build/idea/production/chapter17b" />
- <output-test url="file://$MODULE_DIR$/../build/idea/test/chapter17b" />
- <exclude-output />
- <content url="file://$MODULE_DIR$">
- <sourceFolder url="file://$MODULE_DIR$/src/main/java" isTestSource="false" />
- <sourceFolder url="file://$MODULE_DIR$/src/test/java" isTestSource="true" />
- <excludeFolder url="file://$MODULE_DIR$/build" />
- <excludeFolder url="file://$MODULE_DIR$/target" />
- </content>
- <orderEntry type="inheritedJdk" />
- <orderEntry type="sourceFolder" forTests="false" />
- <orderEntry type="module" module-name="graph" />
- <orderEntry type="module" module-name="print" />
- <orderEntry type="module-library" scope="TEST">
- <library name="JUnit4">
- <CLASSES>
- <root url="jar://$MODULE_DIR$/lib/junit-4.12.jar!/" />
- <root url="jar://$MODULE_DIR$/lib/hamcrest-core-1.3.jar!/" />
- </CLASSES>
- <JAVADOC />
- <SOURCES />
- </library>
- </orderEntry>
- </component>
-</module>
diff --git a/docs/chapter18/18-grammar.ja.md b/docs/chapter18/18-grammar.ja.md
new file mode 100644
index 00000000..4c90e442
--- /dev/null
+++ b/docs/chapter18/18-grammar.ja.md
@@ -0,0 +1,141 @@
+# 第18章の文法
+
+[English](18-grammar.md) | 日本語
+
+```antlrv4
+grammar SimpleLanguage;
+
+// Name lookup, assignable operands, type compatibility, and access permissions
+// are checked by the compiler in addition to these syntax rules.
+program : statement* EOF ;
+
+block : '{' statement* '}' ;
+
+statement
+ : block
+ | returnStatement
+ | ifStatement
+ | whileStatement
+ | forStatement
+ | breakStatement
+ | continueStatement
+ | structDeclaration
+ | declaration ';'
+ | assignment ';'
+ | ';'
+ ;
+
+returnStatement : 'return' assignment ';' ;
+ifStatement : 'if' '(' assignment ')' statement ('else' statement)? ;
+whileStatement : 'while' '(' assignment ')' statement ;
+breakStatement : 'break' ';' ;
+continueStatement : 'continue' ';' ;
+
+forStatement
+ : 'for' '(' (declaration | assignment)? ';' assignment? ';' assignment? ')' statement
+ ;
+
+structDeclaration : 'struct' IDENTIFIER block ';' ;
+
+declaration : declarationType binding (',' binding)* ;
+declarationType : type | 'var' | 'val' ;
+binding : bindingModifier? IDENTIFIER ('=' initializer)? ;
+bindingModifier : '!' | '~' ;
+initializer : assignment ;
+
+// The prefix qualifies the named struct reference, not an enclosing array.
+// Each [] / [~] suffix qualifies its own array layer. ? requires a reference.
+type
+ : functionType
+ | primitiveType typeSuffix*
+ | accessModifier? typeName typeSuffix*
+ ;
+accessModifier : '!' | '~' ;
+typeSuffix : '?' | '[]' | '[~]' ;
+typeName : IDENTIFIER ;
+
+primitiveType
+ : 'int' | 'i8' | 'i16' | 'i32' | 'i64'
+ | 'u1' | 'u8' | 'u16' | 'u32' | 'byte' | 'bool'
+ | 'flt' | 'f32' | 'f64'
+ ;
+
+assignment : expression (assignmentOperator assignment)? ;
+assignmentOperator
+ : '=' | '+=' | '-=' | '*=' | '/=' | '&=' | '|=' | '^='
+ | '<<=' | '>>=' | '>>>='
+ ;
+
+expression : bitwiseExpression ('?' assignment (':' assignment)?)? ;
+
+bitwiseExpression
+ : comparisonExpression (('&' | '|' | '^') comparisonExpression)*
+ ;
+
+comparisonExpression
+ : shiftExpression (('==' | '!=' | '<' | '<=' | '>' | '>=') shiftExpression)*
+ ;
+
+shiftExpression
+ : additiveExpression (('<<' | '>>' | '>>>') additiveExpression)*
+ ;
+
+additiveExpression
+ : multiplicativeExpression (('+' | '-') multiplicativeExpression)*
+ ;
+
+multiplicativeExpression
+ : unaryExpression (('*' | '/') unaryExpression)*
+ ;
+
+unaryExpression
+ : ('-' | '!') unaryExpression
+ | updateOperator IDENTIFIER
+ | postfixExpression
+ ;
+
+// Prefix updates require a local name; postfix updates also allow fields
+// and array elements. All updates require an assignable operand.
+updateOperator : '++' | '--' ;
+postfixExpression : primaryExpression postfixSuffix* updateOperator? ;
+postfixSuffix : '.' IDENTIFIER | '[' assignment ']' | '#' | callSuffix ;
+
+primaryExpression
+ : INTEGER_LITERAL
+ | FLOAT_LITERAL
+ | 'true'
+ | 'false'
+ | 'null'
+ | IDENTIFIER
+ | '(' assignment ')'
+ | newExpression
+ | functionExpression
+ ;
+
+// A function is an expression bound with an ordinary declaration.
+// Its last statement supplies the implicit result; return can exit earlier.
+functionExpression : '{' parameterList? '->' statement* '}' ;
+parameterList : (parameter ','?)+ ;
+parameter : type bindingModifier? IDENTIFIER ;
+
+// Function types have unnamed, space-separated argument types.
+// {int} is the zero-argument type; its function expression still uses ->.
+functionType
+ : '{' type+ '->' type '}' '?'?
+ | '{' type '}' '?'?
+ ;
+
+callSuffix : '(' argumentList? ')' ;
+argumentList : assignment (',' assignment)* ','? ;
+
+// Struct initialization uses a block; array allocation supplies a length.
+newExpression : 'new' type ('[' assignment ']' | block)? ;
+
+INTEGER_LITERAL : '0' | [1-9] DIGIT* ;
+FLOAT_LITERAL : DIGIT+ ('.' DIGIT* ('e' DIGIT+)? | 'e' DIGIT+) ;
+IDENTIFIER : NON_DIGIT (NON_DIGIT | DIGIT)* ;
+fragment NON_DIGIT : [a-zA-Z_] ;
+fragment DIGIT : [0-9] ;
+WHITESPACE : [ \t\r\n]+ -> skip ;
+LINE_COMMENT : '//' ~[\r\n]* -> skip ;
+```
diff --git a/docs/chapter18/18-grammar.md b/docs/chapter18/18-grammar.md
new file mode 100644
index 00000000..656bd63a
--- /dev/null
+++ b/docs/chapter18/18-grammar.md
@@ -0,0 +1,141 @@
+# Grammar for Chapter 18
+
+English | [日本語](18-grammar.ja.md)
+
+```antlrv4
+grammar SimpleLanguage;
+
+// Name lookup, assignable operands, type compatibility, and access permissions
+// are checked by the compiler in addition to these syntax rules.
+program : statement* EOF ;
+
+block : '{' statement* '}' ;
+
+statement
+ : block
+ | returnStatement
+ | ifStatement
+ | whileStatement
+ | forStatement
+ | breakStatement
+ | continueStatement
+ | structDeclaration
+ | declaration ';'
+ | assignment ';'
+ | ';'
+ ;
+
+returnStatement : 'return' assignment ';' ;
+ifStatement : 'if' '(' assignment ')' statement ('else' statement)? ;
+whileStatement : 'while' '(' assignment ')' statement ;
+breakStatement : 'break' ';' ;
+continueStatement : 'continue' ';' ;
+
+forStatement
+ : 'for' '(' (declaration | assignment)? ';' assignment? ';' assignment? ')' statement
+ ;
+
+structDeclaration : 'struct' IDENTIFIER block ';' ;
+
+declaration : declarationType binding (',' binding)* ;
+declarationType : type | 'var' | 'val' ;
+binding : bindingModifier? IDENTIFIER ('=' initializer)? ;
+bindingModifier : '!' | '~' ;
+initializer : assignment ;
+
+// The prefix qualifies the named struct reference, not an enclosing array.
+// Each [] / [~] suffix qualifies its own array layer. ? requires a reference.
+type
+ : functionType
+ | primitiveType typeSuffix*
+ | accessModifier? typeName typeSuffix*
+ ;
+accessModifier : '!' | '~' ;
+typeSuffix : '?' | '[]' | '[~]' ;
+typeName : IDENTIFIER ;
+
+primitiveType
+ : 'int' | 'i8' | 'i16' | 'i32' | 'i64'
+ | 'u1' | 'u8' | 'u16' | 'u32' | 'byte' | 'bool'
+ | 'flt' | 'f32' | 'f64'
+ ;
+
+assignment : expression (assignmentOperator assignment)? ;
+assignmentOperator
+ : '=' | '+=' | '-=' | '*=' | '/=' | '&=' | '|=' | '^='
+ | '<<=' | '>>=' | '>>>='
+ ;
+
+expression : bitwiseExpression ('?' assignment (':' assignment)?)? ;
+
+bitwiseExpression
+ : comparisonExpression (('&' | '|' | '^') comparisonExpression)*
+ ;
+
+comparisonExpression
+ : shiftExpression (('==' | '!=' | '<' | '<=' | '>' | '>=') shiftExpression)*
+ ;
+
+shiftExpression
+ : additiveExpression (('<<' | '>>' | '>>>') additiveExpression)*
+ ;
+
+additiveExpression
+ : multiplicativeExpression (('+' | '-') multiplicativeExpression)*
+ ;
+
+multiplicativeExpression
+ : unaryExpression (('*' | '/') unaryExpression)*
+ ;
+
+unaryExpression
+ : ('-' | '!') unaryExpression
+ | updateOperator IDENTIFIER
+ | postfixExpression
+ ;
+
+// Prefix updates require a local name; postfix updates also allow fields
+// and array elements. All updates require an assignable operand.
+updateOperator : '++' | '--' ;
+postfixExpression : primaryExpression postfixSuffix* updateOperator? ;
+postfixSuffix : '.' IDENTIFIER | '[' assignment ']' | '#' | callSuffix ;
+
+primaryExpression
+ : INTEGER_LITERAL
+ | FLOAT_LITERAL
+ | 'true'
+ | 'false'
+ | 'null'
+ | IDENTIFIER
+ | '(' assignment ')'
+ | newExpression
+ | functionExpression
+ ;
+
+// A function is an expression bound with an ordinary declaration.
+// Its last statement supplies the implicit result; return can exit earlier.
+functionExpression : '{' parameterList? '->' statement* '}' ;
+parameterList : (parameter ','?)+ ;
+parameter : type bindingModifier? IDENTIFIER ;
+
+// Function types have unnamed, space-separated argument types.
+// {int} is the zero-argument type; its function expression still uses ->.
+functionType
+ : '{' type+ '->' type '}' '?'?
+ | '{' type '}' '?'?
+ ;
+
+callSuffix : '(' argumentList? ')' ;
+argumentList : assignment (',' assignment)* ','? ;
+
+// Struct initialization uses a block; array allocation supplies a length.
+newExpression : 'new' type ('[' assignment ']' | block)? ;
+
+INTEGER_LITERAL : '0' | [1-9] DIGIT* ;
+FLOAT_LITERAL : DIGIT+ ('.' DIGIT* ('e' DIGIT+)? | 'e' DIGIT+) ;
+IDENTIFIER : NON_DIGIT (NON_DIGIT | DIGIT)* ;
+fragment NON_DIGIT : [a-zA-Z_] ;
+fragment DIGIT : [0-9] ;
+WHITESPACE : [ \t\r\n]+ -> skip ;
+LINE_COMMENT : '//' ~[\r\n]* -> skip ;
+```
diff --git a/docs/chapter18/Makefile b/docs/chapter18/Makefile
new file mode 100644
index 00000000..6fa0f057
--- /dev/null
+++ b/docs/chapter18/Makefile
@@ -0,0 +1 @@
+include ../../graph/docs.mk
diff --git a/docs/chapter18/README.ja.md b/docs/chapter18/README.ja.md
new file mode 100644
index 00000000..9f3157d4
--- /dev/null
+++ b/docs/chapter18/README.ja.md
@@ -0,0 +1,226 @@
+# 第18章: 関数と呼び出し
+
+[English](README.md) | 日本語
+
+[前: 第17b章](../chapter17b/README.ja.md) |
+[次: 第19章](../chapter19/README.ja.md)
+
+この文書は [原文](README.md) の日本語訳です。
+
+第17b章までは、プログラムは入力 `arg` と結果を持つ1つの本体からなっていました。分岐、ループ、オブジェクトの割り当て、メモリの更新はできますが、まだ関数に分割できません。この章では、再帰呼び出しも含めた関数値と呼び出しを追加します。
+
+グラフ表現には、なじみのある部品を使います。関数の入口は Region、パラメータは Phi で、出口は1つの Return に合流します。呼び出しは関数境界を越えてこれらを結びます。関数の呼び出し元が1つだけなら、境界を取り除くことで通常のピープホール最適化が結合されたグラフを簡略化できます。これが最初の形のインライン化です。
+
+この章の[完全な言語文法](18-grammar.ja.md)はこちらです。
+
+## 目次
+
+1. [関数を書く](#関数を書く)
+2. [グラフ内の関数](#グラフ内の関数)
+3. [呼び出しをまたぐメモリ](#呼び出しをまたぐメモリ)
+4. [関数型と呼び出し先](#関数型と呼び出し先)
+5. [インライン化](#インライン化)
+6. [スケジューリングと実行](#スケジューリングと実行)
+
+[linear](https://github.com/SeaOfNodes/Simple/tree/linear) ブランチの線形の Git リビジョン履歴で[この章](https://github.com/SeaOfNodes/Simple/tree/linear-chapter18)を読むことや、前章との[差分](https://github.com/SeaOfNodes/Simple/compare/linear-chapter17b...linear-chapter18)を見ることもできます。
+
+## 関数を書く
+
+関数式は型付きのパラメータを列挙し、`->` と本体を続けます。
+
+```simple
+val sq = { int x -> x*x; };
+return sq(arg);
+```
+
+初期化子は関数値を作り、宣言がそれを `sq` に束縛します。呼び出し `sq(arg)` は引数を評価し、その値を `x` に束縛して本体を実行し、結果を返します。実行が本体の末尾に到達すると、最後の式が結果を供給します。明示的な `return` なら途中で終了できます。
+
+関数型は、パラメータ名を含めず、パラメータ型と結果型を列挙します。同じ平方関数を明示的な型で宣言できます。
+
+```simple
+{int -> int} sq = { int x -> x*x; };
+return sq(4); // 16
+```
+
+関数は匿名の値です。変数に代入すれば診断用の名前を付けられますが、束縛はほかの変数と同じ規則に従います。`val` は固定の束縛、`var` は再代入可能な束縛を推論します。関数を引数として渡したり、結果として返したり、式で選んだりできます。
+
+パラメータは[第17a章](../chapter17a/README.ja.md)の明示的な宣言構文を使います。`!Point p` は固定されたパラメータ束縛を通じた書き込みを許し、`Point !p` は読み取り専用参照の再代入を許し、`int ~limit` はプリミティブのパラメータを固定します。パラメータ型は必須です。`var` と `val` は、関数を保持する変数に適用するもので、パラメータには適用しません。
+
+### 戻り値とスコープ
+
+本体には周囲の言語と同じ文が使えます。ここでは早期 return で、最初の一致する配列要素を探します。
+
+```simple
+val find = { int[] es, int e ->
+ for( int i=0; i<es#; i++ )
+ if( es[i] == e )
+ return i;
+ return -1;
+};
+val es = new int[3];
+es[0] = 7;
+es[1] = 9;
+return find(es,9); // 1
+```
+
+1つの関数の、到達可能なすべての結果には共通の型が必要です。これは最適化後にチェックするので、到達不能な return は型エラーを起こしません。`void` 型はありませんが、関数は構文を何も書かずに `null` を返せ、呼び出し元は呼び出しを文として使って結果を無視できます。
+
+関数は、囲んでいる関数の局所変数を捕捉しません。外側の束縛にアクセスできるのは、それが固定され、値がコンパイル時定数の場合だけです。たとえば次のようになります。
+
+```simple
+val offset = 2;
+val addOffset = { int x -> x+offset; };
+return addOffset(arg);
+```
+
+`val offset` を `int offset` に変えると束縛が可変になり、関数定義は拒否されます。同様に `val offset = arg` は固定ですが定数ではないので、入れ子の関数から使えません。固定された関数定数はこの規則を満たすため、フレームを捕捉せずに、ある関数から別の関数を参照できます。
+
+### 再帰
+
+関数は自身の束縛を参照できます。
+
+```simple
+val fact = { int n ->
+ n <= 1 ? 1 : n*fact(n-1);
+};
+return fact(arg);
+```
+
+パーサーは、本体をパースする前に関数の入口を登録します。`fact` への前方参照は、宣言がその関数値を受け取ると解決されます。それによって再帰呼び出しも、外からの呼び出しと同じ入口を見つけられます。この章では戻り値の型推論はまだ悲観的です。相互再帰する定義には、[第24章](../chapter24/README.ja.md)の SCCP で導入する、より強力な解析が必要なことがあります。
+
+## グラフ内の関数
+
+これまでは `Start` が1つのプログラム本体への入力を供給していました。今度はその本体を、整数パラメータ `arg` を持つ暗黙の `main` としてパースします。評価器は `Start` から `main` に入り、結果を外の世界に渡します。そのため既存のプログラムは、ソース構文を維持したまま、明示的に宣言された関数と同じ関数表現を得ます。
+
+### 入口、パラメータ、出口
+
+[FunNode](../../src/main/java/com/seaofnodes/simple/node/FunNode.java) は `RegionNode` を継承します。Region が異なる分岐からの制御を合流するのに対し、Fun は異なる呼び出し元からの制御を合流します。リンクされた呼び出しが、1本の流入制御エッジを供給します。
+
+[ParmNode](../../src/main/java/com/seaofnodes/simple/node/ParmNode.java) は `PhiNode` を継承します。Phi が流入分岐に属する値を選ぶのと同じように、各パラメータは流入呼び出しに属する引数を選びます。パラメータの添字が、呼び出し元の供給するものを識別します。
+
+| パラメータの添字 | 値 |
+|---|---|
+| 0 | 復帰地点: 呼び出し元の実行再開位置 |
+| 1 | メモリ全体 |
+| 2 以降 | ソース言語の引数 |
+
+各関数は、`Start` で表される暗黙の未知の呼び出し元も持ちます。これは宣言されたパラメータ型と未知のメモリを供給します。呼び出しをまだ発見している間、これによって入口を保守的に保ちます。
+
+ソース上のすべての `return` は、1つの出口 Region に寄与します。値の Phi が結果を合流し、BulkMemPhi がそのメモリ状態を合流します。結果の [ReturnNode](../../src/main/java/com/seaofnodes/simple/node/ReturnNode.java) の入力は `{control, memory, value, return point}` です。出口が1つなら、Region と Phi はしばしば畳み込まれて消えます。`Stop` は、`main` のものも含め、関数の Return を保持します。
+
+これにより、本体に分岐、ループ、複数の return 文があっても、各関数は1つの入口と1つの合流した出口を持ちます。
+
+### 呼び出しと復帰地点
+
+[CallNode](../../src/main/java/com/seaofnodes/simple/node/CallNode.java) の入力は `{control, memory, arguments..., function pointer}` です。最後の入力が呼び出し先を決めます。定数の関数でも、関数値を持つ式の結果でもかまいません。引数式は、Call が制御とメモリの入力を取る前に評価します。
+
+各 Call には [CallEndNode](../../src/main/java/com/seaofnodes/simple/node/CallEndNode.java) があり、呼び出し元が継続する地点となります。CallEnd は Call と、リンクされた呼び出し先の Return を入力に取ります。その射影は、それぞれスロット 0、1、2 に制御、メモリ、結果を供給します。
+
+呼び出される側は、どの CallEnd に戻るかを知る必要があります。隠れたパラメータ 0 が、本体を通じて Return までその復帰地点を運びます。*return program counter*(復帰プログラムカウンタ)の略である `TypeRPC` は、関数ポインタ型が取り得る入口の集合を記述するのと同じように、取り得る復帰地点の集合を記述します。これらは内部値であり、ソースプログラムは RPC 変数を宣言しません。
+
+呼び出しグラフのエッジは、呼び出しがどの関数に到達し得るかを記述します。これは1つの関数内の制御フローとは別です。通常グラフをたどるときには、呼び出しと関数の付近で注意が必要です。多くの探索は、単一の関数内でだけ有効だからです。
+
+## 呼び出しをまたぐメモリ
+
+前の章では、フィールドのエイリアスごとにメモリを遅延的に分割しました。関数内では今もそうしますが、関数入口のメモリは未知です。引数が、呼び出し元で割り当てて変更したオブジェクトを参照するかもしれません。流入するヒープが空だとは、もう仮定できません。
+
+Call は、MemMerge に包まれたスライスも含め、完全なメモリ状態を受け取ります。その CallEnd は新しいメモリ全体の値を生成します。この章では、すべての呼び出しがすべてのエイリアスを変更し得ると扱います。呼び出される関数がわかっていても、どのフィールドに書くかという要約はまだ得られません。
+
+```simple
+struct Counter { int n; };
+val bump = { !Counter p -> p.n++; return null; };
+val p = new Counter;
+int before = p.n;
+bump(p);
+bump(p);
+return before*10+p.n; // 2
+```
+
+最初の `p.n` の読み出しは、初期化された値を観測します。最後の読み出しは両方の呼び出し後のメモリを使う必要があり、最初の読み出しを再利用できません。2つの呼び出しも、メモリの入出力によって順序が維持されます。書き込み可能なパラメータ権限が更新を許し、メモリエッジがその時点を記録します。
+
+関数内では、MemMerge、MemPhi、BulkMemPhi が引き続き精密なスライスを露出し、分岐やループの状態を合流します。境界では、メモリ Parm 1 と CallEnd のメモリ結果は不透明なままです。大域的コード移動は、Load を配置するときに呼び出しを潜在的な書き込みとして扱います。呼び出しはブロックを終了するため、Call より前である必要がある Load は、その終端命令より前にスケジュールします。
+
+インライン化は呼び出しの境界を取り除き、実際の Load と Store を既存のエイリアス最適化に露出します。グラフに残る呼び出しの作用をより精密に扱うには、後のエスケープ解析が必要です。
+
+## 関数型と呼び出し先
+
+[TypeFunPtr](../../src/main/java/com/seaofnodes/simple/type/TypeFunPtr.java) は、引数タプル、結果型、null 許容性、関数添字の集合(`fidxs`)を記録します。ある引数シグネチャ内で、各関数は小さな整数の添字を得ます。ビット集合は、そのシグネチャを持つ1つの既知の関数や、複数の可能な関数を記述できます。`CodeGen` は具体的な関数の識別情報を FunNode に対応付けます。この章の IR の実行に、機械語コードのアドレスは不要です。
+
+たとえば、以下の両分岐は型 `{int -> int}` を持ちますが、関数添字は異なります。
+
+```simple
+val f = arg ? { int x -> x+x; } : { int x -> x*x; };
+return f(3); // 6 when arg is nonzero, otherwise 9
+```
+
+`f` の Phi は、2つの関数ポインタ型を組み合わせます。呼び出し先の集合は両方の関数を含みます。関数を選ぶことは、その本体の実行ではありません。
+
+関数ポインタも、なじみのある接尾辞 `?` で null を許容できます。
+
+```simple
+{int -> int}? f = arg ? { int x -> x*x; } : null;
+if( f ) return f(3);
+return 0;
+```
+
+ガードは、呼び出し時にポインタが null でないことを証明します。呼び出しは、引数の個数、型、アクセス権限もチェックします。構造体ポインタと関数ポインタは、`Type.NIL` で表される特別な `null` 値を共有します。`TypeNil` が、共通の null 許容性の仕組みを供給します。
+
+### 既知の呼び出し先のリンク
+
+ここで*リンク*とは、呼び出しと関数の間に IR エッジを追加することです。オブジェクトファイルのリンクではありません。既知の各呼び出し先について、コンパイラは Call を Fun の入力として追加し、引数をその Parm に追加し、その Return を CallEnd の入力として追加します。対応する入力位置が、呼び出し元と引数の関係を保ちます。
+
+この章ではすでに、上の条件式の例にある両方の関数も含め、既知の呼び出し先の有限集合をリンクします。未知の関数をまだ含む無限集合は列挙できません。この不確実性を、すべての呼び出しからすべての関数へのエッジで表すのは避けます。二次的に増大するためです。
+
+代わりに Fun は*未知の呼び出し元*の入力を保持します。これまでに見つかった呼び出しが定数を渡していても、パラメータは宣言型を受け入れる必要があります。呼び出し元が1つ見つかっても、ほかにないという証明にはなりません。同様に、CallEnd は関数ポインタ型から結果型を得て、メモリ結果を未知のままにします。リンクされた Return エッジだけでは、これらの保守的な仮定を取り除きません。
+
+インライン化は、関数の呼び出し元が1つだけであるという局所的な証明に依存します。後の SCCP の章では、どの関数や呼び出しに到達可能かについて、より強力な解析を構築し、残る境界を越えてより多くの情報を流せるようにします。
+
+## インライン化
+
+関数値をちょうど1つの呼び出しが使う関数を考えます。
+
+```simple
+val inc = { int x -> x+1; };
+return inc(arg);
+```
+
+この呼び出しが `inc` にリンクすると、CallEnd は、呼び出し先が1つで、その関数ポインタにほかの使用がないことを証明できます。引数が有効で自己再帰呼び出しがなければ、関数本体を呼び出し元の一部にできます。
+
+| インライン化前 | インライン化後 |
+|---|---|
+| ![呼び出しは inc のパラメータに arg を供給し、その和を受け取る。](inline-before.svg) | ![同じ Add が arg を直接使い、main の return に供給する。](inline-after.svg) |
+
+これらはグラフの模式的な断片で、書き換え前後でノード ID は変わりません。引数、結果、リンクのエッジを示し、周囲の制御フロー、メモリ、RPC の配線は省略しています。`Parm_x` への `int` 入力は、インライン化前の未知の呼び出し元の引数を表します。
+
+書き換えは未知の呼び出し元の経路を取り除き、関数入口を呼び出しの流入制御につなぎます。その後、通常の Region と Phi の簡略化がパラメータを実引数に置き換えます。CallEnd の射影は、呼び出された関数の返す制御、メモリ、値になります。Call、関数境界、復帰地点の仕組みは、使用が消えるにつれて消えます。
+
+Add は残りますが、今度は `arg` を直接消費します。引数が `3` なら、第2章から使っている同じ定数畳み込み規則によって `4` を生成します。インライン化で露出した Load と Store も、既存のメモリ規則で同じように簡略化できます。
+
+この形のインライン化は、呼び出し元が1つの本体をその呼び出し元へ移動します。複数の呼び出し箇所のために本体を複製するわけではありません。`fact` のような再帰関数は呼び出しを保持し、評価器が処理します。
+
+## スケジューリングと実行
+
+この章で新しく導入する [CodeGen](../../src/main/java/com/seaofnodes/simple/CodeGen.java) は、コンパイル処理と関数の検索テーブルを所有します。次のフェーズ順序を強制します。
+
+| フェーズ | 目的 |
+|---|---|
+| Parse | 関数と呼び出しを直接 IR に構築する。 |
+| Opto | 呼び出しのリンクと自明なインライン化を含め、ピープホール最適化を反復する。 |
+| TypeCheck | 型と死んだ制御が落ち着いた後で、生き残ったグラフをチェックする。 |
+| Schedule | 大域的コード移動で演算を基本ブロックに配置する。 |
+| LocalSched | 実行のために各ブロック内の演算を順序付ける。 |
+
+例:
+
+```java
+CodeGen code = new CodeGen("val sq = { int x -> x*x; }; return sq(arg);");
+code.parse().opto().typeCheck().GCM().localSched();
+```
+
+大域的コード移動は、[第13章](../chapter13/README.ja.md)の処理を複数の関数に拡張します。関数本体を別々に保ち、共有される定数式には、それを使う各関数内に局所的なコピーを与え、呼び出しをまたぐメモリへの作用を尊重します。
+
+その後 [ListScheduler](../../src/main/java/com/seaofnodes/simple/ListScheduler.java) が各ブロックを順序付けます。未スケジュールの局所依存を数え、準備のできた演算を選び、依存が満たされるにつれてそのユーザーを準備済みにします。Phi は入口に、制御移動は出口に属します。ここには機械のタイミングモデルがなく、さまざまな改善の余地がありますが、この章の範囲外です。目標は、引き続き合法な実行順序です。
+
+[Eval2](../../src/test/java/com/seaofnodes/simple/Eval2.java) はそのスケジュールを実行し、IR の演算を、無制限の値スロットを持つ命令として扱います。各呼び出しには独自のフレームがあるため、同じノードの再帰的な呼び出しも異なる値を保持します。呼び出し時には、呼び出し元のフレームと復帰地点を保存し、呼び出される側のフレームを作り、選ばれた関数に移ります。return 時には呼び出し元を復元し、その CallEnd に値を渡します。Region では、結果を代入する前に、選ばれたすべての Phi 入力を読みます。そのため並列代入は正しさを保ちます。
+
+これでスケジュールされた関数からなる実行可能なプログラムができましたが、演算はまだ機械に依存しません。[第19章](../chapter19/README.ja.md)では、スケジューリング前に命令選択を挿入します。これらの理想的な演算は、選んだ CPU のレジスタ制約と呼び出し規約を持つ命令になります。
diff --git a/docs/chapter18/README.md b/docs/chapter18/README.md
new file mode 100644
index 00000000..1306efb5
--- /dev/null
+++ b/docs/chapter18/README.md
@@ -0,0 +1,363 @@
+# Chapter 18: Functions and Calls
+
+English | [日本語](README.ja.md)
+
+[Previous: Chapter 17b](../chapter17b/README.md) |
+[Next: Chapter 19](../chapter19/README.md)
+
+Through Chapter 17b, a program has one body, with an input `arg` and a result.
+We can branch, loop, allocate objects, and update memory, but cannot yet break
+up the program into functions. This chapter adds function values and calls,
+including recursive calls.
+
+The graph representation builds on familiar pieces. A function entry is a
+Region, its parameters are Phis, and its exits merge into one Return. Calls
+connect these pieces across function boundaries. When a function has just one
+caller, removing that boundary lets ordinary peepholes simplify the combined
+graph: this is our first form of inlining.
+
+Here is the [complete language grammar](18-grammar.md) for this chapter.
+
+## Table of Contents
+
+1. [Writing functions](#writing-functions)
+2. [Functions in the graph](#functions-in-the-graph)
+3. [Memory across calls](#memory-across-calls)
+4. [Function types and call targets](#function-types-and-call-targets)
+5. [Inlining](#inlining)
+6. [Scheduling and execution](#scheduling-and-execution)
+
+You can also read [this chapter](https://github.com/SeaOfNodes/Simple/tree/linear-chapter18) in a linear Git revision history on the [linear](https://github.com/SeaOfNodes/Simple/tree/linear) branch and [compare](https://github.com/SeaOfNodes/Simple/compare/linear-chapter17b...linear-chapter18) it to the previous chapter.
+
+## Writing functions
+
+A function expression lists typed parameters, followed by `->` and a body:
+
+```simple
+val sq = { int x -> x*x; };
+return sq(arg);
+```
+
+The initializer creates a function value; the declaration binds it to `sq`.
+The call `sq(arg)` evaluates its argument, executes the body with that value
+bound to `x`, and yields the result. The final expression supplies the result
+when execution reaches the end of the body. An explicit `return` can exit
+earlier.
+
+A function type lists the parameter types and result type, without parameter
+names. The same square function can be declared with an explicit type:
+
+```simple
+{int -> int} sq = { int x -> x*x; };
+return sq(4); // 16
+```
+
+Functions are anonymous values. Assigning one to a variable can give it a name
+for diagnostics, but the binding follows the same rules as other variables.
+`val` infers a fixed binding; `var` infers a reassignable one. Functions can
+be passed as arguments, returned as results, and selected by expressions.
+
+Parameters use the explicit declaration syntax from
+[Chapter 17a](../chapter17a/README.md): `!Point p` allows writes through a fixed
+parameter binding, `Point !p` allows reassignment of a read-only reference,
+and `int ~limit` fixes a primitive parameter. Parameter types are required;
+`var` and `val` apply to the variable holding a function, not its parameters.
+
+### Returns and scope
+
+The body has the same statements as the surrounding language. Here an early
+return finds the first matching array element:
+
+```simple
+val find = { int[] es, int e ->
+ for( int i=0; i<es#; i++ )
+ if( es[i] == e )
+ return i;
+ return -1;
+};
+val es = new int[3];
+es[0] = 7;
+es[1] = 9;
+return find(es,9); // 1
+```
+
+All reachable results of one function must have a common type. This is checked
+after optimization, so an unreachable return does not cause a type error.
+There is no `void` type although a function can return `null` with no syntax,
+and callers can ignore a result by using the call as a statement.
+
+Functions do not capture an enclosing function's local variables. An outer
+binding is accessible only when it is fixed and its value is a compile-time
+constant. For example:
+
+```simple
+val offset = 2;
+val addOffset = { int x -> x+offset; };
+return addOffset(arg);
+```
+
+Changing `val offset` to `int offset` makes the binding mutable and the function
+definition is rejected. Likewise, `val offset = arg` is fixed but not constant,
+so it cannot be used from the nested function. Fixed function constants satisfy
+this rule, allowing one function to refer to another without capturing a frame.
+
+### Recursion
+
+A function can refer to its own binding:
+
+```simple
+val fact = { int n ->
+ n <= 1 ? 1 : n*fact(n-1);
+};
+return fact(arg);
+```
+
+The parser registers the function entry before parsing its body. A forward
+reference to `fact` is resolved when the declaration receives its function
+value. Recursive calls can then find the same entry as calls from outside.
+Return-type inference is still pessimistic in this chapter; mutually recursive
+definitions can require the stronger analysis introduced with SCCP in
+[Chapter 24](../chapter24/README.md).
+
+## Functions in the graph
+
+Until now, `Start` supplied the input to one program body. We now parse that
+body as an implicit `main` with an integer parameter `arg`. The evaluator
+enters `main` from `Start` and delivers its result to the outside world.
+Existing programs therefore keep their source syntax while acquiring the same
+function representation as explicitly declared functions.
+
+### Entries, parameters, and exits
+
+[FunNode](../../src/main/java/com/seaofnodes/simple/node/FunNode.java) extends
+`RegionNode`. Where a Region merges control from different branches, a Fun
+merges control from different callers. A linked call supplies one incoming
+control edge.
+
+[ParmNode](../../src/main/java/com/seaofnodes/simple/node/ParmNode.java) extends
+`PhiNode`. Each parameter selects the argument belonging to the incoming call,
+just as a Phi selects the value belonging to an incoming branch. The parameter
+index identifies what the caller supplies:
+
+| Parameter index | Value |
+|---|---|
+| 0 | Return point: where execution resumes in the caller |
+| 1 | Whole memory |
+| 2 onward | Source-language arguments |
+
+Each function also has an implicit unknown caller, represented by `Start`.
+It supplies the declared parameter types and unknown memory. This keeps the
+entry conservative while calls are still being discovered.
+
+Every source-level `return` contributes to one exit Region. A value Phi merges
+the results, and a BulkMemPhi merges their memory states. The resulting
+[ReturnNode](../../src/main/java/com/seaofnodes/simple/node/ReturnNode.java) has inputs
+`{control, memory, value, return point}`. A single exit often folds away the
+Region and Phis. `Stop` retains the functions' Returns, including `main`'s.
+
+This gives each function a single entry and a single merged exit even when its
+body contains branches, loops, and several return statements.
+
+### Calls and return points
+
+[CallNode](../../src/main/java/com/seaofnodes/simple/node/CallNode.java) takes inputs
+`{control, memory, arguments..., function pointer}`. The final input determines
+the target; it can be a constant function or the result of a function-valued
+expression. Argument expressions are evaluated before the Call takes its
+control and memory inputs.
+
+Each Call has a [CallEndNode](../../src/main/java/com/seaofnodes/simple/node/CallEndNode.java),
+the point where its caller continues. CallEnd takes the Call and the Returns
+of linked targets as inputs. Its projections provide control, memory, and the
+result, in slots 0, 1, and 2 respectively.
+
+The callee needs to know which CallEnd to return to. Its hidden parameter 0
+carries that return point through the body to the Return. `TypeRPC`, short for
+*return program counter*, describes sets of possible return points, much as
+function-pointer types describe sets of possible entries. These are internal
+values; a source program does not declare RPC variables.
+
+Call-graph edges describe which functions a call may reach. They are distinct
+from the control flow within one function: walking the graph typically requires
+taking care around calls and functions, as most walks are only valid from within
+a single function.
+
+## Memory across calls
+
+Earlier chapters split memory lazily by field alias. That still happens within
+a function, but a function's entry memory is unknown: an argument may refer to
+an object allocated and modified by its caller. We can no longer assume that
+the incoming heap is empty.
+
+A Call receives the complete memory state, including any slices packaged in a
+MemMerge. Its CallEnd produces a new whole-memory value. This chapter treats
+every call as potentially modifying every alias; knowing which function is
+called does not yet provide a summary of which fields it writes.
+
+```simple
+struct Counter { int n; };
+val bump = { !Counter p -> p.n++; return null; };
+val p = new Counter;
+int before = p.n;
+bump(p);
+bump(p);
+return before*10+p.n; // 2
+```
+
+The first read of `p.n` observes its initialized value. The final read must use
+memory after both calls; it cannot reuse the first read. The two calls also
+remain ordered by their memory inputs and outputs. The writable parameter
+permission allows the updates, while the memory edges record when they occur.
+
+Inside a function, MemMerge, MemPhi, and BulkMemPhi continue to expose precise
+slices and merge branch or loop states. At the boundary, memory Parm 1 and the
+CallEnd memory result stay opaque. Global code motion respects a call as a
+possible writer when placing Loads. Calls end their blocks, so a Load that
+must precede a Call is scheduled before that terminator.
+
+Inlining removes the call boundary and exposes its actual Loads and Stores
+to the existing alias optimizations. More precise effects for calls that remain
+in the graph require later escape analysis.
+
+## Function types and call targets
+
+[TypeFunPtr](../../src/main/java/com/seaofnodes/simple/type/TypeFunPtr.java) records
+an argument tuple, a result type, nullability, and a set of function indices
+(`fidxs`). Within an argument signature, each function gets a small integer
+index. A bit set can then describe one known function or several possible
+functions with that signature. `CodeGen` maps a concrete function identity to
+its FunNode; no machine code address is needed to execute this chapter's IR.
+
+For example, both arms below have type `{int -> int}`, but different function
+indices:
+
+```simple
+val f = arg ? { int x -> x+x; } : { int x -> x*x; };
+return f(3); // 6 when arg is nonzero, otherwise 9
+```
+
+The Phi for `f` combines the two function-pointer types. Its set of targets
+contains both functions; choosing a function does not execute its body.
+
+Function pointers can also be nullable, using the familiar `?` suffix:
+
+```simple
+{int -> int}? f = arg ? { int x -> x*x; } : null;
+if( f ) return f(3);
+return 0;
+```
+
+The guard proves the pointer non-null at the call. A call also checks its
+argument count, types, and access permissions. Struct pointers and function
+pointers share the distinguished `null` value, represented by `Type.NIL`;
+`TypeNil` supplies their common nullability machinery.
+
+### Linking known targets
+
+Here *linking* means adding IR edges between a call and a function. It is not
+object-file linking. For each known target, the compiler adds the Call as an
+input to the Fun, adds arguments to its Parms, and adds its Return as an input
+to the CallEnd. Corresponding input positions preserve the relationship
+between a caller and its arguments.
+
+This chapter already links finite sets of known targets, including both
+functions in the conditional example above. The infinite set that still
+includes unknown functions cannot be enumerated. We avoid representing that
+uncertainty with edges from every call to every function, which would grow
+quadratically.
+
+Instead, a Fun retains its *unknown-caller* input. Its parameters must accept
+their declared types even when the calls found so far pass constants. Finding
+one caller is not proof that no other callers exist! Similarly, CallEnd obtains
+its result type from the function-pointer type and keeps its memory result
+unknown. Linked Return edges alone do not remove these conservative assumptions.
+
+Inlining relies on a local proof that a function has only one caller. The later
+SCCP chapter develops stronger analysis of which functions and calls are
+reachable, allowing more information to flow across boundaries that remain.
+
+## Inlining
+
+Consider a function whose value is used by exactly one call:
+
+```simple
+val inc = { int x -> x+1; };
+return inc(arg);
+```
+
+Once this call links to `inc`, CallEnd can prove that it has one target and
+that the target has no other uses of its function pointer. With valid
+arguments and no self-recursive call, the function body can become part of
+the caller.
+
+| Before inlining | After inlining |
+|---|---|
+| ![The call supplies arg to inc's parameter and receives its sum.](inline-before.svg) | ![The same Add uses arg directly and supplies main's return.](inline-after.svg) |
+
+These are schematic slices of the graph, with stable node IDs across the
+rewrite. They show the argument, result, and linking edges; the surrounding
+control flow, memory, and RPC plumbing are omitted. The `int` input to `Parm_x`
+represents the unknown caller's argument before inlining.
+
+The rewrite removes the unknown-caller path and connects the function entry to
+the call's incoming control. Ordinary Region and Phi simplifications then
+replace the parameter with the actual argument. CallEnd's projections become
+the callee's returned control, memory, and value. The Call, function boundary,
+and return-point machinery disappear as their uses disappear.
+
+The Add remains, but now consumes `arg` directly. If the argument had instead
+been `3`, the same constant-folding rules used since Chapter 2 would produce
+`4`. Loads and Stores exposed by inlining can similarly simplify using the
+existing memory rules.
+
+This form of inlining moves a body with one caller into that caller; it does
+not clone the body for several call sites. A recursive function such as
+`fact` retains its calls and is handled by the evaluator.
+
+## Scheduling and execution
+
+New in this chapter is
+[CodeGen](../../src/main/java/com/seaofnodes/simple/CodeGen.java) which owns the
+compilation process and its function lookup table. It enforces the phase order:
+
+| Phase | Purpose |
+|---|---|
+| Parse | Build the functions and calls directly in the IR. |
+| Opto | Iterate peepholes, including call linking and trivial inlining. |
+| TypeCheck | Check the surviving graph after types and dead control have settled. |
+| Schedule | Use global code motion to place operations in basic blocks. |
+| LocalSched | Order operations within each block for execution. |
+
+For example:
+
+```java
+CodeGen code = new CodeGen("val sq = { int x -> x*x; }; return sq(arg);");
+code.parse().opto().typeCheck().GCM().localSched();
+```
+
+Global code motion extends the work of [Chapter 13](../chapter13/README.md) to
+multiple functions. It keeps their bodies separate, gives shared constant
+expressions a local copy in each function that uses them, and respects memory
+effects across calls.
+
+[ListScheduler](../../src/main/java/com/seaofnodes/simple/ListScheduler.java) then
+orders each block. It counts unscheduled local dependencies, chooses a ready
+operation, and makes its users ready as their dependencies are satisfied. Phis
+belong at entry and control transfers at exit. There is room for all sorts of
+improvements - there is no machine timing model here, but this is out of scope
+for this chapter. The goal remains a legal execution order.
+
+[Eval2](../../src/test/java/com/seaofnodes/simple/Eval2.java) executes that schedule,
+treating IR operations as instructions with an unlimited supply of value
+slots. Each invocation has its own frame, so recursive invocations of the same
+nodes keep distinct values. At a call it saves the caller's frame and return
+point, creates a callee frame, and transfers to the selected function. At a
+return it restores the caller and delivers the value to its CallEnd. At a
+Region, it reads all selected Phi inputs before assigning any results, so
+parallel assignments remain correct.
+
+We now have an executable program made of scheduled functions, still expressed
+in machine-independent operations. [Chapter 19](../chapter19/README.md) inserts
+instruction selection before scheduling: those ideal operations become
+instructions for a chosen CPU, with its register constraints and calling
+convention.
diff --git a/docs/chapter18/font-awesome-4.7.0.zip b/docs/chapter18/font-awesome-4.7.0.zip
new file mode 100644
index 00000000..b6bdb4bd
--- /dev/null
+++ b/docs/chapter18/font-awesome-4.7.0.zip
Binary files differ
diff --git a/docs/chapter18/inline-after.json b/docs/chapter18/inline-after.json
new file mode 100644
index 00000000..64e36e97
--- /dev/null
+++ b/docs/chapter18/inline-after.json
@@ -0,0 +1,101 @@
+{
+ "ver": 1,
+ "comp": "inline",
+ "step": 2,
+ "roots": [
+ 12
+ ],
+ "scope": 0,
+ "nodes": [
+ {
+ "id": 1,
+ "label": "Parm_arg",
+ "type": "int",
+ "kind": "PHI",
+ "edges": [
+ {
+ "idx": 0,
+ "def": 0,
+ "role": "ASSOC",
+ "label": null
+ },
+ {
+ "idx": 1,
+ "def": 0,
+ "role": "DATA",
+ "label": null
+ }
+ ],
+ "proj": null
+ },
+ {
+ "id": 2,
+ "label": "Con",
+ "type": "1",
+ "kind": "DATA",
+ "edges": [],
+ "proj": null
+ },
+ {
+ "id": 8,
+ "label": "Add",
+ "type": "int",
+ "kind": "DATA",
+ "edges": [
+ {
+ "idx": 0,
+ "def": 0,
+ "role": "CTRL",
+ "label": null
+ },
+ {
+ "idx": 1,
+ "def": 1,
+ "role": "DATA",
+ "label": null
+ },
+ {
+ "idx": 2,
+ "def": 2,
+ "role": "DATA",
+ "label": null
+ }
+ ],
+ "proj": null
+ },
+ {
+ "id": 12,
+ "label": "Return main",
+ "type": null,
+ "kind": "CTRL",
+ "edges": [
+ {
+ "idx": 0,
+ "def": 0,
+ "role": "CTRL",
+ "label": null
+ },
+ {
+ "idx": 1,
+ "def": 0,
+ "role": "MEM",
+ "label": null
+ },
+ {
+ "idx": 2,
+ "def": 8,
+ "role": "DATA",
+ "label": null
+ },
+ {
+ "idx": 3,
+ "def": 0,
+ "role": "DATA",
+ "label": null
+ }
+ ],
+ "proj": null
+ }
+ ],
+ "groups": []
+}
diff --git a/docs/chapter18/inline-after.svg b/docs/chapter18/inline-after.svg
new file mode 100644
index 00000000..f376ce7f
--- /dev/null
+++ b/docs/chapter18/inline-after.svg
@@ -0,0 +1,81 @@
+<svg aria-label="Compiler graph" width="332" height="312" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 332 312" style="font-family: sans-serif;"><style>
+ html, body { height:100%; margin:0; font-family:sans-serif; }
+ .viewer { height:100%; display:grid; grid-template-rows:auto minmax(0,1fr) auto; }
+ .source { padding:8px; border-bottom:1px solid #ccc; }
+ #program { width:min(600px,80vw); vertical-align:middle; }
+ #status { margin-top:4px; }
+ #graph { min-height:0; overflow:hidden; position:relative; background:#fafbfc; }
+ #elk { width:100%; height:100%; }
+ #graph svg { display:block; }
+ .tools { display:flex; flex-wrap:wrap; align-items:center; gap:14px; margin-top:8px; font-size:12px; }
+ .hint { color:#616c78; }
+ .ctrl { color:#b63838; } .mem { color:#2867b2; } .data { color:#536477; }
+ .edge { fill:none; stroke-width:1.5; }
+ .edge.CTRL { stroke-width:2; }
+ .edge.ASSOC { stroke-dasharray:4 4; }
+ .edge.PARSER { stroke-dasharray:5 4; }
+ .parser rect { fill:#f6f0ff; stroke:#7956a5; stroke-width:1.5; stroke-dasharray:5 4; }
+ .edge.selected { stroke-width:3.5; }
+ .edge.bundle { stroke-width:4; }
+ .edge.bundle.selected { stroke-width:6; }
+ .edge-hit { fill:none; stroke:transparent; stroke-width:12; vector-effect:non-scaling-stroke; pointer-events:stroke; cursor:pointer; }
+ .edge-jump { fill:transparent; pointer-events:all; cursor:pointer; }
+ .node { cursor:pointer; }
+ .box { stroke:#758191; stroke-width:1; }
+ .node.held .box { stroke-dasharray:5 3; }
+ .node.near .box { stroke:#c18221; stroke-width:2; }
+ .node.focus .box { stroke:#9c4900; stroke-width:3; }
+ .node.selected .box { stroke:#1569b9; stroke-width:3; }
+ .node.folded .box { stroke-width:4; }
+ .node.folding .box { fill:#f4ccd7; }
+ .fold-tag { font-size:9px; font-weight:700; fill:#963751; }
+ .peep-area { fill:#fff3d9; fill-opacity:.8; stroke:#c18221; stroke-width:2; pointer-events:none; }
+ .node.peep-edit .box { stroke:#9c4900; stroke-width:3; }
+ .node.error .box { stroke:#b42318; stroke-width:4; }
+ #event.error { color:#b42318; font-weight:600; white-space:pre-wrap; overflow-wrap:anywhere; }
+ .peep-ghosts { pointer-events:none; }
+ .region-box { stroke:#9da9b8; stroke-width:1.5; }
+ .fold-btn { cursor:pointer; }
+ .fold-btn rect { fill:white; stroke:#596674; }
+ .fold-btn text { font-size:14px; fill:#152330; }
+ .fold-btn:focus rect { stroke:#1569b9; stroke-width:2; }
+ .shortcut { cursor:pointer; }
+ .shortcut path { fill:none; stroke-width:1.5; }
+ .shortcut rect { fill:#fff8ec; stroke:#b63838; stroke-dasharray:3 2; }
+ .shortcut text { font-size:11px; fill:#783030; }
+ .shortcut.selected rect, .shortcut:focus rect { stroke-width:2.5; }
+ .label { font-size:12px; fill:#152330; font-weight:600; }
+ .node-id { font-size:10px; fill:#596674; font-weight:400; }
+ .type { font-size:11px; fill:#455768; }
+ .port { stroke:#536477; stroke-width:1; }
+ .row { stroke:#b6afcf; stroke-width:1; }
+ .bind { font-size:12px; fill:#152330; }
+ .slot { font-size:10px; fill:#364352; paint-order:stroke; stroke:#fafbfc; stroke-width:3; }
+ #detail { position:absolute; top:8px; right:8px; margin:0; padding:12px; max-width:320px;
+ max-height:45%; overflow:auto; white-space:pre-wrap; overflow-wrap:anywhere;
+ background:#fffffff2; border:1px solid #bac5d0; border-radius:4px; font-size:12px; }
+ .controls { display:flex; flex-wrap:wrap; justify-content:center; align-items:center; gap:6px; padding:6px; }
+ .button { color:white; background:black; font-size:20px; min-width:30px; }
+ .button:disabled { background:grey; }
+ .count { font-size:20px; min-width:35px; text-align:center; }
+ #N { width:6ch; }
+ #scrub { width:clamp(120px,35vw,600px); }
+ </style><defs><marker id="arrow-CTRL" viewBox="0 -4 8 8" refX="8" refY="0" markerWidth="7" markerHeight="7" orient="auto-start-reverse"><path d="M0,-4L8,0L0,4Z" fill="#b63838"/></marker><marker id="arrow-DATA" viewBox="0 -4 8 8" refX="8" refY="0" markerWidth="7" markerHeight="7" orient="auto-start-reverse"><path d="M0,-4L8,0L0,4Z" fill="#536477"/></marker><marker id="arrow-MEM" viewBox="0 -4 8 8" refX="8" refY="0" markerWidth="7" markerHeight="7" orient="auto-start-reverse"><path d="M0,-4L8,0L0,4Z" fill="#2867b2"/></marker><marker id="arrow-ASSOC" viewBox="0 -4 8 8" refX="8" refY="0" markerWidth="7" markerHeight="7" orient="auto-start-reverse"><path d="M0,-4L8,0L0,4Z" fill="#9396a3"/></marker><marker id="arrow-PARSER" viewBox="0 -4 8 8" refX="8" refY="0" markerWidth="7" markerHeight="7" orient="auto-start-reverse"><path d="M0,-4L8,0L0,4Z" fill="#7956a5"/></marker></defs><rect width="100%" height="100%" fill="rgb(250, 251, 252)"/><g><g class="regions" style="opacity: 1;"/><rect class="peep-area" rx="36" style="opacity: 0;"/><g class="edges"><path class="edge DATA" id="e8i1" d="M96,80 L96,128" stroke="#536477" marker-start="url(#arrow-DATA)" style="opacity: 1;"><title>#8[1] → #1 · DATA</title></path><path class="edge DATA" id="e8i2" d="M248,80 L248,85 Q248,90 243,90 L134,90 Q126,90 126,98 L126,128" stroke="#536477" marker-start="url(#arrow-DATA)" style="opacity: 1;"><title>#8[2] → #2 · DATA</title></path><path class="edge DATA" id="e12i2" d="M96,184 L96,232" stroke="#536477" marker-start="url(#arrow-DATA)" style="opacity: 1;"><title>#12[2] → #8 · DATA</title></path></g><g class="edge-hits"/><g class="parser" style="opacity: 1;"/><g class="nodes"><g class="node" id="n1" data-id="1" transform="translate(36,30)" style="opacity: 1;"><path class="box" d="M12,0H108L120,22L108,44H12L0,22Z" fill="#f5e4fa"/><text class="label" text-anchor="middle" x="60" y="18"><tspan>Parm_arg</tspan><tspan class="node-id">  #1</tspan></text><text class="type" text-anchor="middle" y="35" x="60">int</text><title>#1 Parm_arg
+int
+
+[0] → — ASSOC
+[1] → — DATA</title><circle class="port" cx="0" cy="-3" r="3" fill="white"/><circle class="port" cx="60" cy="-3" r="3" fill="white"/><text class="slot" x="0" y="-10" text-anchor="middle">0</text><text class="slot" x="60" y="-10" text-anchor="middle">1</text></g><g class="node" id="n2" data-id="2" transform="translate(188,30)" style="opacity: 1;"><path class="box" d="M14,0H106Q120,0 120,14V30Q120,44 106,44H14Q0,44 0,30V14Q0,0 14,0Z" fill="#edf3f7"/><text class="label" text-anchor="middle" x="60" y="18"><tspan>Con</tspan><tspan class="node-id">  #2</tspan></text><text class="type" text-anchor="middle" y="35" x="60">1</text><title>#2 Con
+1
+
+</title></g><g class="node" id="n8" data-id="8" transform="translate(36,134)" style="opacity: 1;"><path class="box" d="M14,0H106Q120,0 120,14V30Q120,44 106,44H14Q0,44 0,30V14Q0,0 14,0Z" fill="#edf3f7"/><text class="label" text-anchor="middle" x="60" y="18"><tspan>Add</tspan><tspan class="node-id">  #8</tspan></text><text class="type" text-anchor="middle" y="35" x="60">int</text><title>#8 Add
+int
+
+[0] → — CTRL
+[1] → #1 DATA
+[2] → #2 DATA</title><circle class="port" cx="30" cy="-3" r="3" fill="white"/><circle class="port" cx="60" cy="-3" r="3" fill="#536477"/><circle class="port" cx="90" cy="-3" r="3" fill="#536477"/><text class="slot" x="30" y="-10" text-anchor="middle">0</text><text class="slot" x="60" y="-10" text-anchor="middle">1</text><text class="slot" x="90" y="-10" text-anchor="middle">2</text></g><g class="node" id="n12" data-id="12" transform="translate(24,238)" style="opacity: 1;"><path class="box" d="M0,0H120V44H0Z" fill="#fff1c4"/><text class="label" text-anchor="middle" x="60" y="18"><tspan>Return main</tspan><tspan class="node-id">  #12</tspan></text><text class="type" text-anchor="middle" y="35" x="60"/><title>#12 Return main
+Type not computed
+
+[0] → — CTRL
+[1] → — MEM
+[2] → #8 DATA
+[3] → — DATA</title><circle class="port" cx="24" cy="-3" r="3" fill="white"/><circle class="port" cx="48" cy="-3" r="3" fill="white"/><circle class="port" cx="72" cy="-3" r="3" fill="#536477"/><circle class="port" cx="96" cy="-3" r="3" fill="white"/><text class="slot" x="24" y="-10" text-anchor="middle">0</text><text class="slot" x="48" y="-10" text-anchor="middle">1</text><text class="slot" x="72" y="-10" text-anchor="middle">2</text><text class="slot" x="96" y="-10" text-anchor="middle">3</text></g></g><g class="region-heads" style="opacity: 1;"/><g class="shortcuts" style="opacity: 1;"/><g class="peep-ghosts" pointer-events="none"/></g></svg>
diff --git a/docs/chapter18/inline-before.json b/docs/chapter18/inline-before.json
new file mode 100644
index 00000000..243aff79
--- /dev/null
+++ b/docs/chapter18/inline-before.json
@@ -0,0 +1,276 @@
+{
+ "ver": 1,
+ "comp": "inline",
+ "step": 1,
+ "roots": [
+ 12
+ ],
+ "scope": 0,
+ "nodes": [
+ {
+ "id": 1,
+ "label": "Parm_arg",
+ "type": "int",
+ "kind": "PHI",
+ "edges": [
+ {
+ "idx": 0,
+ "def": 0,
+ "role": "ASSOC",
+ "label": null
+ },
+ {
+ "idx": 1,
+ "def": 0,
+ "role": "DATA",
+ "label": null
+ }
+ ],
+ "proj": null
+ },
+ {
+ "id": 2,
+ "label": "Con",
+ "type": "1",
+ "kind": "DATA",
+ "edges": [],
+ "proj": null
+ },
+ {
+ "id": 3,
+ "label": "Con inc",
+ "type": "{int -> int}",
+ "kind": "DATA",
+ "edges": [],
+ "proj": null
+ },
+ {
+ "id": 4,
+ "label": "Call",
+ "type": null,
+ "kind": "CTRL",
+ "edges": [
+ {
+ "idx": 0,
+ "def": 0,
+ "role": "CTRL",
+ "label": null
+ },
+ {
+ "idx": 1,
+ "def": 0,
+ "role": "MEM",
+ "label": null
+ },
+ {
+ "idx": 2,
+ "def": 1,
+ "role": "DATA",
+ "label": null
+ },
+ {
+ "idx": 3,
+ "def": 3,
+ "role": "DATA",
+ "label": null
+ }
+ ],
+ "proj": null
+ },
+ {
+ "id": 5,
+ "label": "inc",
+ "type": null,
+ "kind": "FUN",
+ "edges": [
+ {
+ "idx": 0,
+ "def": 0,
+ "role": "ASSOC",
+ "label": null
+ },
+ {
+ "idx": 1,
+ "def": 0,
+ "role": "CTRL",
+ "label": null
+ },
+ {
+ "idx": 2,
+ "def": 4,
+ "role": "CTRL",
+ "label": null
+ }
+ ],
+ "proj": null
+ },
+ {
+ "id": 6,
+ "label": "Con",
+ "type": "int",
+ "kind": "DATA",
+ "edges": [],
+ "proj": null
+ },
+ {
+ "id": 7,
+ "label": "Parm_x",
+ "type": "int",
+ "kind": "PHI",
+ "edges": [
+ {
+ "idx": 0,
+ "def": 5,
+ "role": "ASSOC",
+ "label": null
+ },
+ {
+ "idx": 1,
+ "def": 6,
+ "role": "DATA",
+ "label": null
+ },
+ {
+ "idx": 2,
+ "def": 1,
+ "role": "DATA",
+ "label": null
+ }
+ ],
+ "proj": null
+ },
+ {
+ "id": 8,
+ "label": "Add",
+ "type": "int",
+ "kind": "DATA",
+ "edges": [
+ {
+ "idx": 0,
+ "def": 0,
+ "role": "CTRL",
+ "label": null
+ },
+ {
+ "idx": 1,
+ "def": 7,
+ "role": "DATA",
+ "label": null
+ },
+ {
+ "idx": 2,
+ "def": 2,
+ "role": "DATA",
+ "label": null
+ }
+ ],
+ "proj": null
+ },
+ {
+ "id": 9,
+ "label": "Return inc",
+ "type": null,
+ "kind": "CTRL",
+ "edges": [
+ {
+ "idx": 0,
+ "def": 0,
+ "role": "CTRL",
+ "label": null
+ },
+ {
+ "idx": 1,
+ "def": 0,
+ "role": "MEM",
+ "label": null
+ },
+ {
+ "idx": 2,
+ "def": 8,
+ "role": "DATA",
+ "label": null
+ },
+ {
+ "idx": 3,
+ "def": 0,
+ "role": "DATA",
+ "label": null
+ }
+ ],
+ "proj": null
+ },
+ {
+ "id": 10,
+ "label": "CallEnd",
+ "type": null,
+ "kind": "CTRL",
+ "edges": [
+ {
+ "idx": 0,
+ "def": 4,
+ "role": "CTRL",
+ "label": null
+ },
+ {
+ "idx": 1,
+ "def": 9,
+ "role": "DATA",
+ "label": null
+ }
+ ],
+ "proj": null
+ },
+ {
+ "id": 11,
+ "label": "result",
+ "type": "int",
+ "kind": "DATA",
+ "edges": [
+ {
+ "idx": 0,
+ "def": 10,
+ "role": "DATA",
+ "label": null
+ }
+ ],
+ "proj": {
+ "par": 10,
+ "idx": 2
+ }
+ },
+ {
+ "id": 12,
+ "label": "Return main",
+ "type": null,
+ "kind": "CTRL",
+ "edges": [
+ {
+ "idx": 0,
+ "def": 0,
+ "role": "CTRL",
+ "label": null
+ },
+ {
+ "idx": 1,
+ "def": 0,
+ "role": "MEM",
+ "label": null
+ },
+ {
+ "idx": 2,
+ "def": 11,
+ "role": "DATA",
+ "label": null
+ },
+ {
+ "idx": 3,
+ "def": 0,
+ "role": "DATA",
+ "label": null
+ }
+ ],
+ "proj": null
+ }
+ ],
+ "groups": []
+}
diff --git a/docs/chapter18/inline-before.svg b/docs/chapter18/inline-before.svg
new file mode 100644
index 00000000..8e15f6ea
--- /dev/null
+++ b/docs/chapter18/inline-before.svg
@@ -0,0 +1,117 @@
+<svg aria-label="Compiler graph" width="543" height="772" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 543 772" style="font-family: sans-serif;"><style>
+ html, body { height:100%; margin:0; font-family:sans-serif; }
+ .viewer { height:100%; display:grid; grid-template-rows:auto minmax(0,1fr) auto; }
+ .source { padding:8px; border-bottom:1px solid #ccc; }
+ #program { width:min(600px,80vw); vertical-align:middle; }
+ #status { margin-top:4px; }
+ #graph { min-height:0; overflow:hidden; position:relative; background:#fafbfc; }
+ #elk { width:100%; height:100%; }
+ #graph svg { display:block; }
+ .tools { display:flex; flex-wrap:wrap; align-items:center; gap:14px; margin-top:8px; font-size:12px; }
+ .hint { color:#616c78; }
+ .ctrl { color:#b63838; } .mem { color:#2867b2; } .data { color:#536477; }
+ .edge { fill:none; stroke-width:1.5; }
+ .edge.CTRL { stroke-width:2; }
+ .edge.ASSOC { stroke-dasharray:4 4; }
+ .edge.PARSER { stroke-dasharray:5 4; }
+ .parser rect { fill:#f6f0ff; stroke:#7956a5; stroke-width:1.5; stroke-dasharray:5 4; }
+ .edge.selected { stroke-width:3.5; }
+ .edge.bundle { stroke-width:4; }
+ .edge.bundle.selected { stroke-width:6; }
+ .edge-hit { fill:none; stroke:transparent; stroke-width:12; vector-effect:non-scaling-stroke; pointer-events:stroke; cursor:pointer; }
+ .edge-jump { fill:transparent; pointer-events:all; cursor:pointer; }
+ .node { cursor:pointer; }
+ .box { stroke:#758191; stroke-width:1; }
+ .node.held .box { stroke-dasharray:5 3; }
+ .node.near .box { stroke:#c18221; stroke-width:2; }
+ .node.focus .box { stroke:#9c4900; stroke-width:3; }
+ .node.selected .box { stroke:#1569b9; stroke-width:3; }
+ .node.folded .box { stroke-width:4; }
+ .node.folding .box { fill:#f4ccd7; }
+ .fold-tag { font-size:9px; font-weight:700; fill:#963751; }
+ .peep-area { fill:#fff3d9; fill-opacity:.8; stroke:#c18221; stroke-width:2; pointer-events:none; }
+ .node.peep-edit .box { stroke:#9c4900; stroke-width:3; }
+ .node.error .box { stroke:#b42318; stroke-width:4; }
+ #event.error { color:#b42318; font-weight:600; white-space:pre-wrap; overflow-wrap:anywhere; }
+ .peep-ghosts { pointer-events:none; }
+ .region-box { stroke:#9da9b8; stroke-width:1.5; }
+ .fold-btn { cursor:pointer; }
+ .fold-btn rect { fill:white; stroke:#596674; }
+ .fold-btn text { font-size:14px; fill:#152330; }
+ .fold-btn:focus rect { stroke:#1569b9; stroke-width:2; }
+ .shortcut { cursor:pointer; }
+ .shortcut path { fill:none; stroke-width:1.5; }
+ .shortcut rect { fill:#fff8ec; stroke:#b63838; stroke-dasharray:3 2; }
+ .shortcut text { font-size:11px; fill:#783030; }
+ .shortcut.selected rect, .shortcut:focus rect { stroke-width:2.5; }
+ .label { font-size:12px; fill:#152330; font-weight:600; }
+ .node-id { font-size:10px; fill:#596674; font-weight:400; }
+ .type { font-size:11px; fill:#455768; }
+ .port { stroke:#536477; stroke-width:1; }
+ .row { stroke:#b6afcf; stroke-width:1; }
+ .bind { font-size:12px; fill:#152330; }
+ .slot { font-size:10px; fill:#364352; paint-order:stroke; stroke:#fafbfc; stroke-width:3; }
+ #detail { position:absolute; top:8px; right:8px; margin:0; padding:12px; max-width:320px;
+ max-height:45%; overflow:auto; white-space:pre-wrap; overflow-wrap:anywhere;
+ background:#fffffff2; border:1px solid #bac5d0; border-radius:4px; font-size:12px; }
+ .controls { display:flex; flex-wrap:wrap; justify-content:center; align-items:center; gap:6px; padding:6px; }
+ .button { color:white; background:black; font-size:20px; min-width:30px; }
+ .button:disabled { background:grey; }
+ .count { font-size:20px; min-width:35px; text-align:center; }
+ #N { width:6ch; }
+ #scrub { width:clamp(120px,35vw,600px); }
+ </style><defs><marker id="arrow-CTRL" viewBox="0 -4 8 8" refX="8" refY="0" markerWidth="7" markerHeight="7" orient="auto-start-reverse"><path d="M0,-4L8,0L0,4Z" fill="#b63838"/></marker><marker id="arrow-DATA" viewBox="0 -4 8 8" refX="8" refY="0" markerWidth="7" markerHeight="7" orient="auto-start-reverse"><path d="M0,-4L8,0L0,4Z" fill="#536477"/></marker><marker id="arrow-MEM" viewBox="0 -4 8 8" refX="8" refY="0" markerWidth="7" markerHeight="7" orient="auto-start-reverse"><path d="M0,-4L8,0L0,4Z" fill="#2867b2"/></marker><marker id="arrow-ASSOC" viewBox="0 -4 8 8" refX="8" refY="0" markerWidth="7" markerHeight="7" orient="auto-start-reverse"><path d="M0,-4L8,0L0,4Z" fill="#9396a3"/></marker><marker id="arrow-PARSER" viewBox="0 -4 8 8" refX="8" refY="0" markerWidth="7" markerHeight="7" orient="auto-start-reverse"><path d="M0,-4L8,0L0,4Z" fill="#7956a5"/></marker></defs><rect width="100%" height="100%" fill="rgb(250, 251, 252)"/><g><g class="regions" style="opacity: 1;"/><rect class="peep-area" rx="36" style="opacity: 0;"/><g class="edges"><path class="edge DATA" id="e4i2" d="M96,80 L96,128" stroke="#536477" marker-start="url(#arrow-DATA)" style="opacity: 1;"><title>#4[2] → #1 · DATA</title></path><path class="edge DATA" id="e4i3" d="M248,80 L248,85 Q248,90 243,90 L128,90 Q120,90 120,98 L120,128" stroke="#536477" marker-start="url(#arrow-DATA)" style="opacity: 1;"><title>#4[3] → #3 · DATA</title></path><path class="edge CTRL" id="e5i2" d="M84,184 L84,189 Q84,194 89,194 L177,194 Q185,194 185,202 L185,232" stroke="#b63838" marker-start="url(#arrow-CTRL)" style="opacity: 1;"><title>#5[2] → #4 · CTRL</title></path><path class="edge DATA" id="e7i1" d="M257,184 L257,189 Q257,194 262,194 L279,194 Q287,194 287,202 L287,232" stroke="#536477" marker-start="url(#arrow-DATA)" style="opacity: 1;"><title>#7[1] → #6 · DATA</title></path><path class="edge DATA" id="e7i2" d="M96,80 L96,92 Q96,100 104,100 L319,100 Q327,100 327,108 L327,232" stroke="#536477" marker-start="url(#arrow-DATA)" style="opacity: 1;"><title>#7[2] → #1 · DATA</title></path><path class="edge DATA" id="e8i1" d="M307,288 L307,336" stroke="#536477" marker-start="url(#arrow-DATA)" style="opacity: 1;"><title>#8[1] → #7 · DATA</title></path><path class="edge DATA" id="e8i2" d="M459,288 L459,293 Q459,298 454,298 L345,298 Q337,298 337,306 L337,336" stroke="#536477" marker-start="url(#arrow-DATA)" style="opacity: 1;"><title>#8[2] → #2 · DATA</title></path><path class="edge DATA" id="e9i2" d="M307,392 L307,440" stroke="#536477" marker-start="url(#arrow-DATA)" style="opacity: 1;"><title>#9[2] → #8 · DATA</title></path><path class="edge CTRL" id="e10i0" d="M84,184 L84,544" stroke="#b63838" marker-start="url(#arrow-CTRL)" style="opacity: 1;"><title>#10[0] → #4 · CTRL</title></path><path class="edge DATA" id="e10i1" d="M295,496 L295,501 Q295,506 290,506 L132,506 Q124,506 124,514 L124,544" stroke="#536477" marker-start="url(#arrow-DATA)" style="opacity: 1;"><title>#10[1] → #9 · DATA</title></path><path class="edge DATA" id="e12i2" d="M104,644 L104,692" stroke="#536477" marker-start="url(#arrow-DATA)" style="opacity: 1;"><title>#12[2] → #11 · DATA</title></path></g><g class="edge-hits"/><g class="parser" style="opacity: 1;"/><g class="nodes"><g class="node" id="n1" data-id="1" transform="translate(36,30)" style="opacity: 1;"><path class="box" d="M12,0H108L120,22L108,44H12L0,22Z" fill="#f5e4fa"/><text class="label" text-anchor="middle" x="60" y="18"><tspan>Parm_arg</tspan><tspan class="node-id">  #1</tspan></text><text class="type" text-anchor="middle" y="35" x="60">int</text><title>#1 Parm_arg
+int
+
+[0] → — ASSOC
+[1] → — DATA</title><circle class="port" cx="0" cy="-3" r="3" fill="white"/><circle class="port" cx="60" cy="-3" r="3" fill="white"/><text class="slot" x="0" y="-10" text-anchor="middle">0</text><text class="slot" x="60" y="-10" text-anchor="middle">1</text></g><g class="node" id="n2" data-id="2" transform="translate(399,238)" style="opacity: 1;"><path class="box" d="M14,0H106Q120,0 120,14V30Q120,44 106,44H14Q0,44 0,30V14Q0,0 14,0Z" fill="#edf3f7"/><text class="label" text-anchor="middle" x="60" y="18"><tspan>Con</tspan><tspan class="node-id">  #2</tspan></text><text class="type" text-anchor="middle" y="35" x="60">1</text><title>#2 Con
+1
+
+</title></g><g class="node" id="n3" data-id="3" transform="translate(188,30)" style="opacity: 1;"><path class="box" d="M14,0H106Q120,0 120,14V30Q120,44 106,44H14Q0,44 0,30V14Q0,0 14,0Z" fill="#edf3f7"/><text class="label" text-anchor="middle" x="60" y="18"><tspan>Con inc</tspan><tspan class="node-id">  #3</tspan></text><text class="type" text-anchor="middle" y="35" x="60">{int -&gt; int}</text><title>#3 Con inc
+{int -&gt; int}
+
+</title></g><g class="node" id="n4" data-id="4" transform="translate(24,134)" style="opacity: 1;"><path class="box" d="M0,0H120V44H0Z" fill="#fff1c4"/><text class="label" text-anchor="middle" x="60" y="18"><tspan>Call</tspan><tspan class="node-id">  #4</tspan></text><text class="type" text-anchor="middle" y="35" x="60"/><title>#4 Call
+Type not computed
+
+[0] → — CTRL
+[1] → — MEM
+[2] → #1 DATA
+[3] → #3 DATA</title><circle class="port" cx="24" cy="-3" r="3" fill="white"/><circle class="port" cx="48" cy="-3" r="3" fill="white"/><circle class="port" cx="72" cy="-3" r="3" fill="#536477"/><circle class="port" cx="96" cy="-3" r="3" fill="#536477"/><text class="slot" x="24" y="-10" text-anchor="middle">0</text><text class="slot" x="48" y="-10" text-anchor="middle">1</text><text class="slot" x="72" y="-10" text-anchor="middle">2</text><text class="slot" x="96" y="-10" text-anchor="middle">3</text></g><g class="node" id="n5" data-id="5" transform="translate(95,238)" style="opacity: 1;"><path class="box" d="M10,0H110L120,10V34L110,44H10L0,34V10Z" fill="#ffe0ab"/><text class="label" text-anchor="middle" x="60" y="18"><tspan>inc</tspan><tspan class="node-id">  #5</tspan></text><text class="type" text-anchor="middle" y="35" x="60"/><title>#5 inc
+Type not computed
+
+[0] → — ASSOC
+[1] → — CTRL
+[2] → #4 CTRL</title><circle class="port" cx="30" cy="-3" r="3" fill="white"/><circle class="port" cx="60" cy="-3" r="3" fill="white"/><circle class="port" cx="90" cy="-3" r="3" fill="#536477"/><text class="slot" x="30" y="-10" text-anchor="middle">0</text><text class="slot" x="60" y="-10" text-anchor="middle">1</text><text class="slot" x="90" y="-10" text-anchor="middle">2</text></g><g class="node" id="n6" data-id="6" transform="translate(197,134)" style="opacity: 1;"><path class="box" d="M14,0H106Q120,0 120,14V30Q120,44 106,44H14Q0,44 0,30V14Q0,0 14,0Z" fill="#edf3f7"/><text class="label" text-anchor="middle" x="60" y="18"><tspan>Con</tspan><tspan class="node-id">  #6</tspan></text><text class="type" text-anchor="middle" y="35" x="60">int</text><title>#6 Con
+int
+
+</title></g><g class="node" id="n7" data-id="7" transform="translate(247,238)" style="opacity: 1;"><path class="box" d="M12,0H108L120,22L108,44H12L0,22Z" fill="#f5e4fa"/><text class="label" text-anchor="middle" x="60" y="18"><tspan>Parm_x</tspan><tspan class="node-id">  #7</tspan></text><text class="type" text-anchor="middle" y="35" x="60">int</text><title>#7 Parm_x
+int
+
+[0] → #5 ASSOC
+[1] → #6 DATA
+[2] → #1 DATA</title><circle class="port" cx="-3" cy="22" r="3" fill="#536477"/><circle class="port" cx="40" cy="-3" r="3" fill="#536477"/><circle class="port" cx="80" cy="-3" r="3" fill="#536477"/><path class="reg" fill="none" stroke="#b63838" d="M-3,22H-18m4,-3l-4,3l4,3"><title>[0] → #5</title></path><text class="slot" x="-10" y="15" text-anchor="middle">0</text><text class="slot" x="40" y="-10" text-anchor="middle">1</text><text class="slot" x="80" y="-10" text-anchor="middle">2</text></g><g class="node" id="n8" data-id="8" transform="translate(247,342)" style="opacity: 1;"><path class="box" d="M14,0H106Q120,0 120,14V30Q120,44 106,44H14Q0,44 0,30V14Q0,0 14,0Z" fill="#edf3f7"/><text class="label" text-anchor="middle" x="60" y="18"><tspan>Add</tspan><tspan class="node-id">  #8</tspan></text><text class="type" text-anchor="middle" y="35" x="60">int</text><title>#8 Add
+int
+
+[0] → — CTRL
+[1] → #7 DATA
+[2] → #2 DATA</title><circle class="port" cx="30" cy="-3" r="3" fill="white"/><circle class="port" cx="60" cy="-3" r="3" fill="#536477"/><circle class="port" cx="90" cy="-3" r="3" fill="#536477"/><text class="slot" x="30" y="-10" text-anchor="middle">0</text><text class="slot" x="60" y="-10" text-anchor="middle">1</text><text class="slot" x="90" y="-10" text-anchor="middle">2</text></g><g class="node" id="n9" data-id="9" transform="translate(235,446)" style="opacity: 1;"><path class="box" d="M0,0H120V44H0Z" fill="#fff1c4"/><text class="label" text-anchor="middle" x="60" y="18"><tspan>Return inc</tspan><tspan class="node-id">  #9</tspan></text><text class="type" text-anchor="middle" y="35" x="60"/><title>#9 Return inc
+Type not computed
+
+[0] → — CTRL
+[1] → — MEM
+[2] → #8 DATA
+[3] → — DATA</title><circle class="port" cx="24" cy="-3" r="3" fill="white"/><circle class="port" cx="48" cy="-3" r="3" fill="white"/><circle class="port" cx="72" cy="-3" r="3" fill="#536477"/><circle class="port" cx="96" cy="-3" r="3" fill="white"/><text class="slot" x="24" y="-10" text-anchor="middle">0</text><text class="slot" x="48" y="-10" text-anchor="middle">1</text><text class="slot" x="72" y="-10" text-anchor="middle">2</text><text class="slot" x="96" y="-10" text-anchor="middle">3</text></g><g class="node" id="n10" data-id="10" transform="translate(44,550)" style="opacity: 1;"><path class="box" d="M0,0H120V44H0Z" fill="#fff1c4"/><text class="label" text-anchor="middle" x="60" y="18"><tspan>CallEnd</tspan><tspan class="node-id">  #10</tspan></text><text class="type" text-anchor="middle" y="35" x="60"/><title>#10 CallEnd
+Type not computed
+
+[0] → #4 CTRL
+[1] → #9 DATA</title><circle class="port" cx="40" cy="-3" r="3" fill="#536477"/><circle class="port" cx="80" cy="-3" r="3" fill="#536477"/><text class="slot" x="40" y="-10" text-anchor="middle">0</text><text class="slot" x="80" y="-10" text-anchor="middle">1</text></g><g class="node" id="n11" data-id="11" transform="translate(44,594)" style="opacity: 1;"><path class="box" d="M0,0H120V44H0Z" fill="#edf3f7"/><text class="label" text-anchor="middle" x="60" y="18"><tspan>result</tspan><tspan class="node-id">  #11/2</tspan></text><text class="type" text-anchor="middle" y="35" x="60">int</text><title>#11 result
+Projection 2 of #10
+int
+
+[0] → #10 DATA</title></g><g class="node" id="n12" data-id="12" transform="translate(32,698)" style="opacity: 1;"><path class="box" d="M0,0H120V44H0Z" fill="#fff1c4"/><text class="label" text-anchor="middle" x="60" y="18"><tspan>Return main</tspan><tspan class="node-id">  #12</tspan></text><text class="type" text-anchor="middle" y="35" x="60"/><title>#12 Return main
+Type not computed
+
+[0] → — CTRL
+[1] → — MEM
+[2] → #11 DATA
+[3] → — DATA</title><circle class="port" cx="24" cy="-3" r="3" fill="white"/><circle class="port" cx="48" cy="-3" r="3" fill="white"/><circle class="port" cx="72" cy="-3" r="3" fill="#536477"/><circle class="port" cx="96" cy="-3" r="3" fill="white"/><text class="slot" x="24" y="-10" text-anchor="middle">0</text><text class="slot" x="48" y="-10" text-anchor="middle">1</text><text class="slot" x="72" y="-10" text-anchor="middle">2</text><text class="slot" x="96" y="-10" text-anchor="middle">3</text></g></g><g class="region-heads" style="opacity: 1;"/><g class="shortcuts" style="opacity: 1;"/><g class="peep-ghosts" pointer-events="none"/></g></svg>
diff --git a/docs/chapter18/lattice.gv b/docs/chapter18/lattice.gv
new file mode 100644
index 00000000..8661082d
--- /dev/null
+++ b/docs/chapter18/lattice.gv
@@ -0,0 +1,203 @@
+digraph Lattice {
+ compound = true;
+ // Define nodes
+ splines=false;
+ node [shape=circle, style=filled];
+ nodesep=0.2;
+ ranksep=0.2;
+
+ TOP [label=<<B>⊤</B >>, fillcolor=black, fontcolor=white];
+ BOT [label=<<B>⊥</B>>, fillcolor=black, fontcolor=white];
+
+ // ----------------------
+ // Control
+ XCTRL [label=<<B>⊤</B >:ctrl>, fillcolor=yellow, shape=oval];
+ CTRL [label=<<B>⊥</B>:ctrl>, fillcolor=yellow, shape=oval];
+
+ TOP -> XCTRL;
+ XCTRL -> CTRL;
+ CTRL -> BOT;
+
+ // ----------------------
+ // Integers
+ INT_TOP [label=<<B>⊤</B >:int>, fillcolor=lightblue, shape=oval];
+ INT_BOT [label=<<B>⊥</B>:int>, fillcolor=lightblue, shape=oval];
+
+ INT_HI [label="[min>max]" , fillcolor=lightblue, shape=oval];
+ INT_XBOOL [label="[1...0]", fillcolor=lightblue, shape=oval];
+ INT_CON [label="constants", fillcolor=lightblue, shape=oval];
+ INT_CON0 [label="0", fillcolor=lightblue];
+ INT_CON1 [label="1", fillcolor=lightblue];
+ INT_BOOL [label="[0...1]", fillcolor=lightblue,shape=oval];
+ INT_LO [label="[min<max]" , fillcolor=lightblue, shape=oval];
+
+ TOP -> INT_TOP;
+ INT_TOP -> INT_HI;
+ INT_HI -> INT_XBOOL;
+ INT_XBOOL -> INT_CON0;
+ INT_XBOOL -> INT_CON1;
+ INT_HI -> INT_CON;
+ INT_CON0 -> INT_BOOL;
+ INT_CON1 -> INT_BOOL;
+ INT_BOOL -> INT_LO;
+ INT_CON -> INT_LO;
+ INT_LO -> INT_BOT;
+ INT_BOT -> BOT;
+
+ INT_CON0 -> INT_CON1 -> INT_CON [style=invis];
+
+ // ----------------------
+ // Floats
+ FLT_TOP [label=<<B>⊤</B >:flt>, fillcolor=aqua, shape=oval];
+ FLT_BOT [label=<<B>⊥</B>:flt>, fillcolor=aqua, shape=oval];
+
+ FLT_CON64 [label="64b consts\n[excludes\n32b consts]" , fillcolor=aqua, shape=oval];
+ FLT_CON32 [label="32b consts", fillcolor=aqua, shape=oval];
+ FLT_CONPI [label="3.14159...", fillcolor=aqua, shape=oval];
+ FLT_X32 [label="~f32", fillcolor=aqua];
+ FLT_CON0 [label="0." , fillcolor=aqua];
+ FLT_32 [label="f32" , fillcolor=aqua];
+
+ TOP -> FLT_TOP;
+ FLT_TOP -> FLT_CON64
+ FLT_TOP -> FLT_CONPI
+ FLT_CON64 -> FLT_BOT
+ FLT_CONPI -> FLT_BOT
+
+ FLT_TOP -> FLT_X32;
+ FLT_X32 -> FLT_CON0;
+ FLT_X32 -> FLT_CON32;
+ FLT_CON0 -> FLT_32;
+ FLT_CON32 -> FLT_32;
+ FLT_32 -> FLT_BOT
+
+ FLT_BOT -> BOT;
+
+ FLT_CON0 -> FLT_CON32 -> FLT_CONPI -> FLT_CON64 [style=invis];
+
+
+ // ----------------------
+ // Pointers, just a boolean nil/not and a struct
+ PTR [shape=none, fillcolor=none, label=<
+ <TABLE BORDER="0" CELLBORDER="1" CELLSPACING="0">
+ <TR><TD BGCOLOR="green"><FONT color="white">*ptr</FONT></TD></TR>
+ <TR><TD BGCOLOR="lightgreen">struct</TD></TR>
+ </TABLE>
+ >];
+ PTR0 [shape=none, fillcolor=none, label=<
+ <TABLE BORDER="0" CELLBORDER="1" CELLSPACING="0">
+ <TR><TD BGCOLOR="green"><FONT color="white">*ptr?</FONT></TD></TR>
+ <TR><TD BGCOLOR="lightgreen">struct</TD></TR>
+ </TABLE>
+ >];
+
+ TOP -> PTR;
+ PTR -> PTR0;
+ PTR0 -> BOT;
+
+ // ----------------------
+ // Structs
+ STRUCT_TOP [label=<<B>⊤</B >:struct>, fillcolor=lightgreen, shape=oval];
+ STRUCT_BOT [label=<<B>⊥</B>:struct>, fillcolor=lightgreen, shape=oval];
+
+ STRUCT_S1 [shape=none, fillcolor=none, label=<
+ <TABLE BORDER="0" CELLBORDER="1" CELLSPACING="0">
+ <TR><TD BGCOLOR="lightgreen">field</TD><TD BGCOLOR="lightblue:green" gradientangle="315">int/ptr</TD></TR>
+ </TABLE>
+ >];
+ STRUCT_S2 [shape=none, fillcolor=none, label=<
+ <TABLE BORDER="0" CELLBORDER="1" CELLSPACING="0">
+ <TR><TD BGCOLOR="lightgreen">field</TD><TD BGCOLOR="lightblue:green" gradientangle="315">int/ptr</TD></TR>
+ <TR><TD BGCOLOR="lightgreen">field</TD><TD BGCOLOR="lightblue:green" gradientangle="315">int/ptr</TD></TR>
+ </TABLE>
+ >];
+ STRUCT_SN [shape=none, fillcolor=none, label=<
+ <TABLE BORDER="0" CELLBORDER="1" CELLSPACING="0">
+ <TR><TD BGCOLOR="lightgreen">field</TD><TD BGCOLOR="lightblue:green" gradientangle="315">int/ptr</TD></TR>
+ <TR><TD BGCOLOR="lightgreen">... </TD><TD BGCOLOR="lightblue:green" gradientangle="315">int/ptr</TD></TR>
+ <TR><TD BGCOLOR="lightgreen">field</TD><TD BGCOLOR="lightblue:green" gradientangle="315">int/ptr</TD></TR>
+ </TABLE>
+ >];
+
+
+ TOP -> STRUCT_TOP;
+ STRUCT_TOP -> STRUCT_S1;
+ STRUCT_TOP -> STRUCT_S2;
+ STRUCT_TOP -> STRUCT_SN;
+ STRUCT_S1 -> STRUCT_BOT;
+ STRUCT_S2 -> STRUCT_BOT;
+ STRUCT_SN -> STRUCT_BOT;
+ STRUCT_BOT -> BOT;
+
+ STRUCT_S1 -> STRUCT_S2 -> STRUCT_SN [style=invis];
+
+ // ----------------------
+ // Memory
+ MEM_TOP [label=<<B>⊤</B >:mem>, fillcolor=blue, fontcolor=white, shape=oval];
+ MEM_BOT [label=<<B>⊥</B>:mem>, fillcolor=blue, fontcolor=white, shape=oval];
+ MEM_ALIAS1 [label="#1" , fillcolor=blue, fontcolor=white];
+ MEM_ALIASDOTS [label="..." , fillcolor=blue, fontcolor=white, shape=oval];
+ MEM_ALIASN [label="#n" , fillcolor=blue, fontcolor=white];
+
+ TOP -> MEM_TOP;
+ MEM_TOP -> MEM_ALIAS1;
+ MEM_TOP -> MEM_ALIASDOTS;
+ MEM_TOP -> MEM_ALIASN;
+ MEM_ALIAS1 -> MEM_BOT;
+ MEM_ALIASDOTS -> MEM_BOT;
+ MEM_ALIASN -> MEM_BOT;
+ MEM_BOT -> BOT;
+
+ MEM_ALIAS1 -> MEM_ALIASDOTS -> MEM_ALIASN [style=invis];
+
+ // ----------------------
+ // Tuples
+
+ TUPLE_TOP [label=<<B>⊤</B >:tuple>, fillcolor=pink, shape=oval];
+ TUPLE_BOT [label=<<B>⊥</B>:tuple>, fillcolor=pink, shape=oval];
+
+ TUPLE1 [shape=none, fillcolor=none, label=<
+ <TABLE BORDER="0" CELLBORDER="1" CELLSPACING="0">
+ <TH><TD BGCOLOR="pink">Tuple</TD></TH>
+ <TR><TD BGCOLOR="black" ><FONT color="white">type</FONT></TD></TR>
+ </TABLE>
+ >];
+ TUPLE2 [shape=none, fillcolor=none, label=<
+ <TABLE BORDER="0" CELLBORDER="1" CELLSPACING="0">
+ <TH><TD BGCOLOR="pink">Tuple</TD></TH>
+ <TR><TD BGCOLOR="black" ><FONT color="white">type</FONT></TD></TR>
+ <TR><TD BGCOLOR="black" ><FONT color="white">type</FONT></TD></TR>
+ </TABLE>
+ >];
+ TUPLEN [shape=none, fillcolor=none, label=<
+ <TABLE BORDER="0" CELLBORDER="1" CELLSPACING="0">
+ <TH><TD BGCOLOR="pink">Tuple</TD></TH>
+ <TR><TD BGCOLOR="black" ><FONT color="white">type</FONT></TD></TR>
+ <TR><TD BGCOLOR="black" ><FONT color="white">...</FONT></TD></TR>
+ <TR><TD BGCOLOR="black" ><FONT color="white">type</FONT></TD></TR>
+ </TABLE>
+ >];
+
+
+ TOP -> TUPLE_TOP;
+ TUPLE_TOP -> TUPLE1;
+ TUPLE_TOP -> TUPLE2;
+ TUPLE_TOP -> TUPLEN;
+ TUPLE1 -> TUPLE_BOT;
+ TUPLE2 -> TUPLE_BOT;
+ TUPLEN -> TUPLE_BOT;
+ TUPLE_BOT -> BOT;
+
+ // ----------------------
+ // Additional customization
+ {rank=same; TOP;}
+ {rank=same; INT_TOP; FLT_TOP; XCTRL; PTR; STRUCT_TOP; MEM_TOP; TUPLE_TOP}
+ {rank=same; INT_CON; INT_CON0; INT_CON1;
+ FLT_CON32; FLT_CON64; FLT_CON0; FLT_CONPI;
+ STRUCT_S1; STRUCT_S2; STRUCT_SN;
+ MEM_ALIAS1; MEM_ALIASDOTS; MEM_ALIASN;
+ TUPLE1; TUPLE2; TUPLEN;
+ }
+ {rank=same; INT_BOT; FLT_BOT; CTRL; PTR0; STRUCT_BOT; MEM_BOT; TUPLE_BOT}
+ {rank=same; BOT;}
+}
diff --git a/docs/chapter18/lattice.svg b/docs/chapter18/lattice.svg
new file mode 100644
index 00000000..030f4826
--- /dev/null
+++ b/docs/chapter18/lattice.svg
@@ -0,0 +1,691 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN"
+ "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
+<!-- Generated by graphviz version 12.2.0 (20241103.1931)
+ -->
+<!-- Title: Lattice Pages: 1 -->
+<svg width="1330pt" height="584pt"
+ viewBox="0.00 0.00 1329.51 583.54" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
+<g id="graph0" class="graph" transform="scale(1 1) rotate(0) translate(4 579.54)">
+<title>Lattice</title>
+<polygon fill="white" stroke="none" points="-4,4 -4,-579.54 1325.51,-579.54 1325.51,4 -4,4"/>
+<!-- TOP -->
+<g id="node1" class="node">
+<title>TOP</title>
+<ellipse fill="black" stroke="black" cx="641.51" cy="-554.42" rx="21.12" ry="21.12"/>
+<text text-anchor="start" x="633.63" y="-549.99" font-family="Times New Roman,serif" font-weight="bold" font-size="14.00" fill="white">⊤</text>
+</g>
+<!-- XCTRL -->
+<g id="node3" class="node">
+<title>XCTRL</title>
+<ellipse fill="yellow" stroke="black" cx="36.51" cy="-492.79" rx="36.51" ry="18"/>
+<text text-anchor="start" x="17.76" y="-488.74" font-family="Times New Roman,serif" font-weight="bold" font-size="14.00">⊤</text>
+<text text-anchor="start" x="33.51" y="-488.74" font-family="Times New Roman,serif" font-size="14.00">:ctrl</text>
+</g>
+<!-- TOP&#45;&gt;XCTRL -->
+<g id="edge1" class="edge">
+<title>TOP&#45;&gt;XCTRL</title>
+<path fill="none" stroke="black" d="M620.33,-551.33C533.82,-542.8 206.01,-510.5 83.28,-498.4"/>
+<polygon fill="black" stroke="black" points="83.86,-494.94 73.56,-497.44 83.17,-501.91 83.86,-494.94"/>
+</g>
+<!-- INT_TOP -->
+<g id="node5" class="node">
+<title>INT_TOP</title>
+<ellipse fill="lightblue" stroke="black" cx="316.51" cy="-492.79" rx="33.95" ry="18"/>
+<text text-anchor="start" x="299.63" y="-488.74" font-family="Times New Roman,serif" font-weight="bold" font-size="14.00">⊤</text>
+<text text-anchor="start" x="315.38" y="-488.74" font-family="Times New Roman,serif" font-size="14.00">:int</text>
+</g>
+<!-- TOP&#45;&gt;INT_TOP -->
+<g id="edge4" class="edge">
+<title>TOP&#45;&gt;INT_TOP</title>
+<path fill="none" stroke="black" d="M620.68,-549.6C568.33,-539.99 430.36,-514.68 359.64,-501.71"/>
+<polygon fill="black" stroke="black" points="360.44,-498.29 349.97,-499.93 359.18,-505.18 360.44,-498.29"/>
+</g>
+<!-- FLT_TOP -->
+<g id="node14" class="node">
+<title>FLT_TOP</title>
+<ellipse fill="aqua" stroke="black" cx="494.51" cy="-492.79" rx="32.41" ry="18"/>
+<text text-anchor="start" x="478.76" y="-488.74" font-family="Times New Roman,serif" font-weight="bold" font-size="14.00">⊤</text>
+<text text-anchor="start" x="494.51" y="-488.74" font-family="Times New Roman,serif" font-size="14.00">:flt</text>
+</g>
+<!-- TOP&#45;&gt;FLT_TOP -->
+<g id="edge18" class="edge">
+<title>TOP&#45;&gt;FLT_TOP</title>
+<path fill="none" stroke="black" d="M621.99,-545.5C598.79,-536.09 559.6,-520.19 530.78,-508.5"/>
+<polygon fill="black" stroke="black" points="532.29,-505.34 521.7,-504.82 529.65,-511.82 532.29,-505.34"/>
+</g>
+<!-- PTR -->
+<g id="node22" class="node">
+<title>PTR</title>
+<polygon fill="none" stroke="none" points="668.51,-519.29 614.51,-519.29 614.51,-466.29 668.51,-466.29 668.51,-519.29"/>
+<polygon fill="green" stroke="none" points="623.51,-492.79 623.51,-515.29 659.51,-515.29 659.51,-492.79 623.51,-492.79"/>
+<polygon fill="none" stroke="black" points="623.51,-492.79 623.51,-515.29 659.51,-515.29 659.51,-492.79 623.51,-492.79"/>
+<text text-anchor="start" x="630.63" y="-498.99" font-family="Times New Roman,serif" font-size="14.00" fill="white">*ptr</text>
+<polygon fill="lightgreen" stroke="none" points="623.51,-470.29 623.51,-492.79 659.51,-492.79 659.51,-470.29 623.51,-470.29"/>
+<polygon fill="none" stroke="black" points="623.51,-470.29 623.51,-492.79 659.51,-492.79 659.51,-470.29 623.51,-470.29"/>
+<text text-anchor="start" x="626.51" y="-476.49" font-family="Times New Roman,serif" font-size="14.00">struct</text>
+</g>
+<!-- TOP&#45;&gt;PTR -->
+<g id="edge33" class="edge">
+<title>TOP&#45;&gt;PTR</title>
+<path fill="none" stroke="black" d="M641.51,-532.9C641.51,-532.06 641.51,-531.22 641.51,-530.37"/>
+<polygon fill="black" stroke="black" points="645.01,-530.61 641.51,-520.61 638.01,-530.61 645.01,-530.61"/>
+</g>
+<!-- STRUCT_TOP -->
+<g id="node24" class="node">
+<title>STRUCT_TOP</title>
+<ellipse fill="lightgreen" stroke="black" cx="746.51" cy="-492.79" rx="44.7" ry="18"/>
+<text text-anchor="start" x="721.76" y="-488.74" font-family="Times New Roman,serif" font-weight="bold" font-size="14.00">⊤</text>
+<text text-anchor="start" x="737.51" y="-488.74" font-family="Times New Roman,serif" font-size="14.00">:struct</text>
+</g>
+<!-- TOP&#45;&gt;STRUCT_TOP -->
+<g id="edge36" class="edge">
+<title>TOP&#45;&gt;STRUCT_TOP</title>
+<path fill="none" stroke="black" d="M659.8,-543.03C674.04,-534.94 694.24,-523.47 711.55,-513.64"/>
+<polygon fill="black" stroke="black" points="713.07,-516.81 720.03,-508.83 709.61,-510.72 713.07,-516.81"/>
+</g>
+<!-- MEM_TOP -->
+<g id="node29" class="node">
+<title>MEM_TOP</title>
+<ellipse fill="blue" stroke="black" cx="998.51" cy="-492.79" rx="43.67" ry="18"/>
+<text text-anchor="start" x="974.51" y="-488.74" font-family="Times New Roman,serif" font-weight="bold" font-size="14.00" fill="white">⊤</text>
+<text text-anchor="start" x="990.26" y="-488.74" font-family="Times New Roman,serif" font-size="14.00" fill="white">:mem</text>
+</g>
+<!-- TOP&#45;&gt;MEM_TOP -->
+<g id="edge46" class="edge">
+<title>TOP&#45;&gt;MEM_TOP</title>
+<path fill="none" stroke="black" d="M662.51,-549.91C717.64,-540.7 867.72,-515.64 947.33,-502.34"/>
+<polygon fill="black" stroke="black" points="947.77,-505.82 957.06,-500.72 946.62,-498.91 947.77,-505.82"/>
+</g>
+<!-- TUPLE_TOP -->
+<g id="node34" class="node">
+<title>TUPLE_TOP</title>
+<ellipse fill="pink" stroke="black" cx="1182.51" cy="-492.79" rx="42.65" ry="18"/>
+<text text-anchor="start" x="1159.26" y="-488.74" font-family="Times New Roman,serif" font-weight="bold" font-size="14.00">⊤</text>
+<text text-anchor="start" x="1175.01" y="-488.74" font-family="Times New Roman,serif" font-size="14.00">:tuple</text>
+</g>
+<!-- TOP&#45;&gt;TUPLE_TOP -->
+<g id="edge56" class="edge">
+<title>TOP&#45;&gt;TUPLE_TOP</title>
+<path fill="none" stroke="black" d="M662.72,-551.08C740.91,-542.46 1014.51,-512.31 1130.21,-499.56"/>
+<polygon fill="black" stroke="black" points="1130.5,-503.05 1140.05,-498.47 1129.73,-496.09 1130.5,-503.05"/>
+</g>
+<!-- BOT -->
+<g id="node2" class="node">
+<title>BOT</title>
+<ellipse fill="black" stroke="black" cx="641.51" cy="-21.12" rx="21.12" ry="21.12"/>
+<text text-anchor="start" x="633.63" y="-16.7" font-family="Times New Roman,serif" font-weight="bold" font-size="14.00" fill="white">⊥</text>
+</g>
+<!-- CTRL -->
+<g id="node4" class="node">
+<title>CTRL</title>
+<ellipse fill="yellow" stroke="black" cx="49.51" cy="-82.75" rx="36.51" ry="18"/>
+<text text-anchor="start" x="30.76" y="-78.7" font-family="Times New Roman,serif" font-weight="bold" font-size="14.00">⊥</text>
+<text text-anchor="start" x="46.51" y="-78.7" font-family="Times New Roman,serif" font-size="14.00">:ctrl</text>
+</g>
+<!-- XCTRL&#45;&gt;CTRL -->
+<g id="edge2" class="edge">
+<title>XCTRL&#45;&gt;CTRL</title>
+<path fill="none" stroke="black" d="M37.09,-474.38C39.15,-409.6 46.05,-191.88 48.57,-112.25"/>
+<polygon fill="black" stroke="black" points="52.06,-112.73 48.88,-102.63 45.06,-112.51 52.06,-112.73"/>
+</g>
+<!-- CTRL&#45;&gt;BOT -->
+<g id="edge3" class="edge">
+<title>CTRL&#45;&gt;BOT</title>
+<path fill="none" stroke="black" d="M85.21,-78.15C191.74,-67.42 506.36,-35.74 608.84,-25.41"/>
+<polygon fill="black" stroke="black" points="609.15,-28.9 618.75,-24.42 608.45,-21.94 609.15,-28.9"/>
+</g>
+<!-- INT_HI -->
+<g id="node7" class="node">
+<title>INT_HI</title>
+<ellipse fill="lightblue" stroke="black" cx="174.51" cy="-434.29" rx="53.91" ry="18"/>
+<text text-anchor="middle" x="174.51" y="-429.24" font-family="Times New Roman,serif" font-size="14.00">[min&gt;max]</text>
+</g>
+<!-- INT_TOP&#45;&gt;INT_HI -->
+<g id="edge5" class="edge">
+<title>INT_TOP&#45;&gt;INT_HI</title>
+<path fill="none" stroke="black" d="M289.8,-481.17C269.89,-473.25 242.26,-462.25 219.03,-453.01"/>
+<polygon fill="black" stroke="black" points="220.37,-449.77 209.78,-449.33 217.78,-456.28 220.37,-449.77"/>
+</g>
+<!-- INT_BOT -->
+<g id="node6" class="node">
+<title>INT_BOT</title>
+<ellipse fill="lightblue" stroke="black" cx="329.51" cy="-82.75" rx="33.95" ry="18"/>
+<text text-anchor="start" x="312.63" y="-78.7" font-family="Times New Roman,serif" font-weight="bold" font-size="14.00">⊥</text>
+<text text-anchor="start" x="328.38" y="-78.7" font-family="Times New Roman,serif" font-size="14.00">:int</text>
+</g>
+<!-- INT_BOT&#45;&gt;BOT -->
+<g id="edge15" class="edge">
+<title>INT_BOT&#45;&gt;BOT</title>
+<path fill="none" stroke="black" d="M361.14,-75.7C420.84,-64.3 549.47,-39.71 609.47,-28.25"/>
+<polygon fill="black" stroke="black" points="609.86,-31.73 619.03,-26.42 608.55,-24.86 609.86,-31.73"/>
+</g>
+<!-- INT_XBOOL -->
+<g id="node8" class="node">
+<title>INT_XBOOL</title>
+<ellipse fill="lightblue" stroke="black" cx="97.51" cy="-373.97" rx="33.95" ry="18"/>
+<text text-anchor="middle" x="97.51" y="-368.92" font-family="Times New Roman,serif" font-size="14.00">[1...0]</text>
+</g>
+<!-- INT_HI&#45;&gt;INT_XBOOL -->
+<g id="edge6" class="edge">
+<title>INT_HI&#45;&gt;INT_XBOOL</title>
+<path fill="none" stroke="black" d="M153.47,-417.36C144.79,-410.78 134.6,-403.06 125.31,-396.03"/>
+<polygon fill="black" stroke="black" points="127.71,-393.46 117.63,-390.21 123.48,-399.04 127.71,-393.46"/>
+</g>
+<!-- INT_CON -->
+<g id="node9" class="node">
+<title>INT_CON</title>
+<ellipse fill="lightblue" stroke="black" cx="174.51" cy="-282.65" rx="45.21" ry="18"/>
+<text text-anchor="middle" x="174.51" y="-277.6" font-family="Times New Roman,serif" font-size="14.00">constants</text>
+</g>
+<!-- INT_HI&#45;&gt;INT_CON -->
+<g id="edge9" class="edge">
+<title>INT_HI&#45;&gt;INT_CON</title>
+<path fill="none" stroke="black" d="M174.51,-416C174.51,-390.27 174.51,-343.1 174.51,-312.31"/>
+<polygon fill="black" stroke="black" points="178.01,-312.52 174.51,-302.52 171.01,-312.52 178.01,-312.52"/>
+</g>
+<!-- INT_CON0 -->
+<g id="node10" class="node">
+<title>INT_CON0</title>
+<ellipse fill="lightblue" stroke="black" cx="47.51" cy="-282.65" rx="18" ry="18"/>
+<text text-anchor="middle" x="47.51" y="-277.6" font-family="Times New Roman,serif" font-size="14.00">0</text>
+</g>
+<!-- INT_XBOOL&#45;&gt;INT_CON0 -->
+<g id="edge7" class="edge">
+<title>INT_XBOOL&#45;&gt;INT_CON0</title>
+<path fill="none" stroke="black" d="M88.34,-356.59C80.82,-343.17 70.07,-323.96 61.49,-308.62"/>
+<polygon fill="black" stroke="black" points="64.63,-307.08 56.69,-300.06 58.53,-310.5 64.63,-307.08"/>
+</g>
+<!-- INT_CON1 -->
+<g id="node11" class="node">
+<title>INT_CON1</title>
+<ellipse fill="lightblue" stroke="black" cx="97.51" cy="-282.65" rx="18" ry="18"/>
+<text text-anchor="middle" x="97.51" y="-277.6" font-family="Times New Roman,serif" font-size="14.00">1</text>
+</g>
+<!-- INT_XBOOL&#45;&gt;INT_CON1 -->
+<g id="edge8" class="edge">
+<title>INT_XBOOL&#45;&gt;INT_CON1</title>
+<path fill="none" stroke="black" d="M97.51,-355.75C97.51,-343.47 97.51,-326.68 97.51,-312.39"/>
+<polygon fill="black" stroke="black" points="101.01,-312.64 97.51,-302.64 94.01,-312.64 101.01,-312.64"/>
+</g>
+<!-- INT_LO -->
+<g id="node13" class="node">
+<title>INT_LO</title>
+<ellipse fill="lightblue" stroke="black" cx="174.51" cy="-141.25" rx="53.91" ry="18"/>
+<text text-anchor="middle" x="174.51" y="-136.2" font-family="Times New Roman,serif" font-size="14.00">[min&lt;max]</text>
+</g>
+<!-- INT_CON&#45;&gt;INT_LO -->
+<g id="edge13" class="edge">
+<title>INT_CON&#45;&gt;INT_LO</title>
+<path fill="none" stroke="black" d="M174.51,-264.17C174.51,-240.45 174.51,-199.04 174.51,-170.9"/>
+<polygon fill="black" stroke="black" points="178.01,-171.25 174.51,-161.25 171.01,-171.25 178.01,-171.25"/>
+</g>
+<!-- INT_CON0&#45;&gt;INT_CON1 -->
+<!-- INT_BOOL -->
+<g id="node12" class="node">
+<title>INT_BOOL</title>
+<ellipse fill="lightblue" stroke="black" cx="97.51" cy="-196.45" rx="33.95" ry="18"/>
+<text text-anchor="middle" x="97.51" y="-191.4" font-family="Times New Roman,serif" font-size="14.00">[0...1]</text>
+</g>
+<!-- INT_CON0&#45;&gt;INT_BOOL -->
+<g id="edge10" class="edge">
+<title>INT_CON0&#45;&gt;INT_BOOL</title>
+<path fill="none" stroke="black" d="M56.45,-266.6C63.5,-254.72 73.51,-237.87 81.88,-223.77"/>
+<polygon fill="black" stroke="black" points="84.75,-225.79 86.85,-215.41 78.73,-222.22 84.75,-225.79"/>
+</g>
+<!-- INT_CON1&#45;&gt;INT_CON -->
+<!-- INT_CON1&#45;&gt;INT_BOOL -->
+<g id="edge11" class="edge">
+<title>INT_CON1&#45;&gt;INT_BOOL</title>
+<path fill="none" stroke="black" d="M97.51,-264.21C97.51,-253.25 97.51,-238.87 97.51,-226.25"/>
+<polygon fill="black" stroke="black" points="101.01,-226.39 97.51,-216.39 94.01,-226.39 101.01,-226.39"/>
+</g>
+<!-- INT_BOOL&#45;&gt;INT_LO -->
+<g id="edge12" class="edge">
+<title>INT_BOOL&#45;&gt;INT_LO</title>
+<path fill="none" stroke="black" d="M117.34,-181.75C124.98,-176.47 133.91,-170.3 142.42,-164.42"/>
+<polygon fill="black" stroke="black" points="144.27,-167.4 150.5,-158.83 140.29,-161.64 144.27,-167.4"/>
+</g>
+<!-- INT_LO&#45;&gt;INT_BOT -->
+<g id="edge14" class="edge">
+<title>INT_LO&#45;&gt;INT_BOT</title>
+<path fill="none" stroke="black" d="M210.07,-127.29C234.52,-118.37 266.93,-106.56 291.82,-97.49"/>
+<polygon fill="black" stroke="black" points="292.71,-100.89 300.91,-94.17 290.31,-94.31 292.71,-100.89"/>
+</g>
+<!-- FLT_CON64 -->
+<g id="node16" class="node">
+<title>FLT_CON64</title>
+<ellipse fill="aqua" stroke="black" cx="564.51" cy="-282.65" rx="55.33" ry="40.66"/>
+<text text-anchor="middle" x="564.51" y="-294.1" font-family="Times New Roman,serif" font-size="14.00">64b consts</text>
+<text text-anchor="middle" x="564.51" y="-277.6" font-family="Times New Roman,serif" font-size="14.00">[excludes</text>
+<text text-anchor="middle" x="564.51" y="-261.1" font-family="Times New Roman,serif" font-size="14.00">32b consts]</text>
+</g>
+<!-- FLT_TOP&#45;&gt;FLT_CON64 -->
+<g id="edge19" class="edge">
+<title>FLT_TOP&#45;&gt;FLT_CON64</title>
+<path fill="none" stroke="black" d="M500.48,-474.88C510.8,-443.88 532.35,-379.2 547.59,-333.44"/>
+<polygon fill="black" stroke="black" points="550.9,-334.57 550.74,-323.98 544.26,-332.36 550.9,-334.57"/>
+</g>
+<!-- FLT_CONPI -->
+<g id="node18" class="node">
+<title>FLT_CONPI</title>
+<ellipse fill="aqua" stroke="black" cx="446.51" cy="-282.65" rx="48.79" ry="18"/>
+<text text-anchor="middle" x="446.51" y="-277.6" font-family="Times New Roman,serif" font-size="14.00">3.14159...</text>
+</g>
+<!-- FLT_TOP&#45;&gt;FLT_CONPI -->
+<g id="edge20" class="edge">
+<title>FLT_TOP&#45;&gt;FLT_CONPI</title>
+<path fill="none" stroke="black" d="M490.33,-474.51C482.02,-438.11 463.32,-356.27 453.25,-312.16"/>
+<polygon fill="black" stroke="black" points="456.69,-311.49 451.05,-302.52 449.86,-313.04 456.69,-311.49"/>
+</g>
+<!-- FLT_X32 -->
+<g id="node19" class="node">
+<title>FLT_X32</title>
+<ellipse fill="aqua" stroke="black" cx="333.51" cy="-373.97" rx="28.32" ry="28.32"/>
+<text text-anchor="middle" x="333.51" y="-368.92" font-family="Times New Roman,serif" font-size="14.00">~f32</text>
+</g>
+<!-- FLT_TOP&#45;&gt;FLT_X32 -->
+<g id="edge23" class="edge">
+<title>FLT_TOP&#45;&gt;FLT_X32</title>
+<path fill="none" stroke="black" d="M474.77,-478.22C447.56,-458.14 398.22,-421.73 365.65,-397.69"/>
+<polygon fill="black" stroke="black" points="367.88,-394.99 357.75,-391.86 363.72,-400.62 367.88,-394.99"/>
+</g>
+<!-- FLT_BOT -->
+<g id="node15" class="node">
+<title>FLT_BOT</title>
+<ellipse fill="aqua" stroke="black" cx="507.51" cy="-82.75" rx="32.41" ry="18"/>
+<text text-anchor="start" x="491.76" y="-78.7" font-family="Times New Roman,serif" font-weight="bold" font-size="14.00">⊥</text>
+<text text-anchor="start" x="507.51" y="-78.7" font-family="Times New Roman,serif" font-size="14.00">:flt</text>
+</g>
+<!-- FLT_BOT&#45;&gt;BOT -->
+<g id="edge29" class="edge">
+<title>FLT_BOT&#45;&gt;BOT</title>
+<path fill="none" stroke="black" d="M532.4,-70.67C554.98,-60.63 588.29,-45.81 612.16,-35.19"/>
+<polygon fill="black" stroke="black" points="613.29,-38.51 621,-31.25 610.44,-32.12 613.29,-38.51"/>
+</g>
+<!-- FLT_CON64&#45;&gt;FLT_BOT -->
+<g id="edge21" class="edge">
+<title>FLT_CON64&#45;&gt;FLT_BOT</title>
+<path fill="none" stroke="black" d="M553.11,-242.68C542.05,-203.88 525.53,-145.95 515.71,-111.5"/>
+<polygon fill="black" stroke="black" points="519.17,-110.89 513.06,-102.23 512.44,-112.81 519.17,-110.89"/>
+</g>
+<!-- FLT_CON32 -->
+<g id="node17" class="node">
+<title>FLT_CON32</title>
+<ellipse fill="aqua" stroke="black" cx="333.51" cy="-282.65" rx="50.33" ry="18"/>
+<text text-anchor="middle" x="333.51" y="-277.6" font-family="Times New Roman,serif" font-size="14.00">32b consts</text>
+</g>
+<!-- FLT_CON32&#45;&gt;FLT_CONPI -->
+<!-- FLT_32 -->
+<g id="node21" class="node">
+<title>FLT_32</title>
+<ellipse fill="aqua" stroke="black" cx="333.51" cy="-196.45" rx="23.2" ry="23.2"/>
+<text text-anchor="middle" x="333.51" y="-191.4" font-family="Times New Roman,serif" font-size="14.00">f32</text>
+</g>
+<!-- FLT_CON32&#45;&gt;FLT_32 -->
+<g id="edge27" class="edge">
+<title>FLT_CON32&#45;&gt;FLT_32</title>
+<path fill="none" stroke="black" d="M333.51,-264.21C333.51,-254.7 333.51,-242.59 333.51,-231.31"/>
+<polygon fill="black" stroke="black" points="337.01,-231.51 333.51,-221.51 330.01,-231.51 337.01,-231.51"/>
+</g>
+<!-- FLT_CONPI&#45;&gt;FLT_BOT -->
+<g id="edge22" class="edge">
+<title>FLT_CONPI&#45;&gt;FLT_BOT</title>
+<path fill="none" stroke="black" d="M452.03,-264.56C462.62,-229.86 485.86,-153.69 498.65,-111.79"/>
+<polygon fill="black" stroke="black" points="501.94,-112.98 501.51,-102.39 495.25,-110.93 501.94,-112.98"/>
+</g>
+<!-- FLT_CONPI&#45;&gt;FLT_CON64 -->
+<!-- FLT_X32&#45;&gt;FLT_CON32 -->
+<g id="edge25" class="edge">
+<title>FLT_X32&#45;&gt;FLT_CON32</title>
+<path fill="none" stroke="black" d="M333.51,-345.2C333.51,-334.71 333.51,-322.76 333.51,-312.19"/>
+<polygon fill="black" stroke="black" points="337.01,-312.52 333.51,-302.52 330.01,-312.53 337.01,-312.52"/>
+</g>
+<!-- FLT_CON0 -->
+<g id="node20" class="node">
+<title>FLT_CON0</title>
+<ellipse fill="aqua" stroke="black" cx="251.51" cy="-282.65" rx="18.08" ry="18.08"/>
+<text text-anchor="middle" x="251.51" y="-277.6" font-family="Times New Roman,serif" font-size="14.00">0.</text>
+</g>
+<!-- FLT_X32&#45;&gt;FLT_CON0 -->
+<g id="edge24" class="edge">
+<title>FLT_X32&#45;&gt;FLT_CON0</title>
+<path fill="none" stroke="black" d="M314.9,-352.7C301.83,-338.47 284.38,-319.46 271.1,-304.99"/>
+<polygon fill="black" stroke="black" points="273.81,-302.77 264.47,-297.77 268.65,-307.5 273.81,-302.77"/>
+</g>
+<!-- FLT_CON0&#45;&gt;FLT_CON32 -->
+<!-- FLT_CON0&#45;&gt;FLT_32 -->
+<g id="edge26" class="edge">
+<title>FLT_CON0&#45;&gt;FLT_32</title>
+<path fill="none" stroke="black" d="M263.96,-268.86C276.06,-256.44 294.74,-237.26 309.69,-221.91"/>
+<polygon fill="black" stroke="black" points="312.03,-224.53 316.5,-214.92 307.01,-219.64 312.03,-224.53"/>
+</g>
+<!-- FLT_32&#45;&gt;FLT_BOT -->
+<g id="edge28" class="edge">
+<title>FLT_32&#45;&gt;FLT_BOT</title>
+<path fill="none" stroke="black" d="M353.13,-183.63C383.19,-163.99 440.9,-126.28 476.61,-102.94"/>
+<polygon fill="black" stroke="black" points="478.34,-105.99 484.79,-97.59 474.51,-100.13 478.34,-105.99"/>
+</g>
+<!-- PTR0 -->
+<g id="node23" class="node">
+<title>PTR0</title>
+<polygon fill="none" stroke="none" points="668.51,-109.25 614.51,-109.25 614.51,-56.25 668.51,-56.25 668.51,-109.25"/>
+<polygon fill="green" stroke="none" points="623.51,-82.75 623.51,-105.25 659.51,-105.25 659.51,-82.75 623.51,-82.75"/>
+<polygon fill="none" stroke="black" points="623.51,-82.75 623.51,-105.25 659.51,-105.25 659.51,-82.75 623.51,-82.75"/>
+<text text-anchor="start" x="627.63" y="-88.95" font-family="Times New Roman,serif" font-size="14.00" fill="white">*ptr?</text>
+<polygon fill="lightgreen" stroke="none" points="623.51,-60.25 623.51,-82.75 659.51,-82.75 659.51,-60.25 623.51,-60.25"/>
+<polygon fill="none" stroke="black" points="623.51,-60.25 623.51,-82.75 659.51,-82.75 659.51,-60.25 623.51,-60.25"/>
+<text text-anchor="start" x="626.51" y="-66.45" font-family="Times New Roman,serif" font-size="14.00">struct</text>
+</g>
+<!-- PTR&#45;&gt;PTR0 -->
+<g id="edge34" class="edge">
+<title>PTR&#45;&gt;PTR0</title>
+<path fill="none" stroke="black" d="M641.51,-466.52C641.51,-396.01 641.51,-202.44 641.51,-120.34"/>
+<polygon fill="black" stroke="black" points="645.01,-120.58 641.51,-110.58 638.01,-120.58 645.01,-120.58"/>
+</g>
+<!-- PTR0&#45;&gt;BOT -->
+<g id="edge35" class="edge">
+<title>PTR0&#45;&gt;BOT</title>
+<path fill="none" stroke="black" d="M641.51,-56.46C641.51,-55.58 641.51,-54.7 641.51,-53.81"/>
+<polygon fill="black" stroke="black" points="645.01,-53.9 641.51,-43.9 638.01,-53.9 645.01,-53.9"/>
+</g>
+<!-- STRUCT_S1 -->
+<g id="node26" class="node">
+<title>STRUCT_S1</title>
+<polygon fill="none" stroke="none" points="741.38,-300.65 663.63,-300.65 663.63,-264.65 741.38,-264.65 741.38,-300.65"/>
+<polygon fill="lightgreen" stroke="none" points="671.63,-273.4 671.63,-291.9 698.38,-291.9 698.38,-273.4 671.63,-273.4"/>
+<polygon fill="none" stroke="black" points="671.63,-273.4 671.63,-291.9 698.38,-291.9 698.38,-273.4 671.63,-273.4"/>
+<text text-anchor="start" x="672.63" y="-277.6" font-family="Times New Roman,serif" font-size="14.00">field</text>
+<defs>
+<linearGradient id="l_0" gradientUnits="userSpaceOnUse" x1="703.51" y1="-289.19" x2="728.26" y2="-276.11" >
+<stop offset="0" style="stop-color:lightblue;stop-opacity:1.;"/>
+<stop offset="1" style="stop-color:green;stop-opacity:1.;"/>
+</linearGradient>
+</defs>
+<polygon fill="url(#l_0)" stroke="none" points="698.38,-273.4 698.38,-291.9 733.38,-291.9 733.38,-273.4 698.38,-273.4"/>
+<polygon fill="none" stroke="black" points="698.38,-273.4 698.38,-291.9 733.38,-291.9 733.38,-273.4 698.38,-273.4"/>
+<text text-anchor="start" x="699.38" y="-277.6" font-family="Times New Roman,serif" font-size="14.00">int/ptr</text>
+</g>
+<!-- STRUCT_TOP&#45;&gt;STRUCT_S1 -->
+<g id="edge37" class="edge">
+<title>STRUCT_TOP&#45;&gt;STRUCT_S1</title>
+<path fill="none" stroke="black" d="M742.68,-474.51C735.02,-437.92 717.75,-355.45 708.55,-311.5"/>
+<polygon fill="black" stroke="black" points="712.02,-311 706.54,-301.93 705.17,-312.43 712.02,-311"/>
+</g>
+<!-- STRUCT_S2 -->
+<g id="node27" class="node">
+<title>STRUCT_S2</title>
+<polygon fill="none" stroke="none" points="841.38,-309.15 755.63,-309.15 755.63,-256.15 841.38,-256.15 841.38,-309.15"/>
+<polygon fill="lightgreen" stroke="none" points="763.63,-282.65 763.63,-305.15 794.38,-305.15 794.38,-282.65 763.63,-282.65"/>
+<polygon fill="none" stroke="black" points="763.63,-282.65 763.63,-305.15 794.38,-305.15 794.38,-282.65 763.63,-282.65"/>
+<text text-anchor="start" x="766.63" y="-288.85" font-family="Times New Roman,serif" font-size="14.00">field</text>
+<defs>
+<linearGradient id="l_1" gradientUnits="userSpaceOnUse" x1="800.1" y1="-301.86" x2="827.67" y2="-285.95" >
+<stop offset="0" style="stop-color:lightblue;stop-opacity:1.;"/>
+<stop offset="1" style="stop-color:green;stop-opacity:1.;"/>
+</linearGradient>
+</defs>
+<polygon fill="url(#l_1)" stroke="none" points="794.38,-282.65 794.38,-305.15 833.38,-305.15 833.38,-282.65 794.38,-282.65"/>
+<polygon fill="none" stroke="black" points="794.38,-282.65 794.38,-305.15 833.38,-305.15 833.38,-282.65 794.38,-282.65"/>
+<text text-anchor="start" x="797.38" y="-288.85" font-family="Times New Roman,serif" font-size="14.00">int/ptr</text>
+<polygon fill="lightgreen" stroke="none" points="763.63,-260.15 763.63,-282.65 794.38,-282.65 794.38,-260.15 763.63,-260.15"/>
+<polygon fill="none" stroke="black" points="763.63,-260.15 763.63,-282.65 794.38,-282.65 794.38,-260.15 763.63,-260.15"/>
+<text text-anchor="start" x="766.63" y="-266.35" font-family="Times New Roman,serif" font-size="14.00">field</text>
+<defs>
+<linearGradient id="l_2" gradientUnits="userSpaceOnUse" x1="800.1" y1="-279.36" x2="827.67" y2="-263.45" >
+<stop offset="0" style="stop-color:lightblue;stop-opacity:1.;"/>
+<stop offset="1" style="stop-color:green;stop-opacity:1.;"/>
+</linearGradient>
+</defs>
+<polygon fill="url(#l_2)" stroke="none" points="794.38,-260.15 794.38,-282.65 833.38,-282.65 833.38,-260.15 794.38,-260.15"/>
+<polygon fill="none" stroke="black" points="794.38,-260.15 794.38,-282.65 833.38,-282.65 833.38,-260.15 794.38,-260.15"/>
+<text text-anchor="start" x="797.38" y="-266.35" font-family="Times New Roman,serif" font-size="14.00">int/ptr</text>
+</g>
+<!-- STRUCT_TOP&#45;&gt;STRUCT_S2 -->
+<g id="edge38" class="edge">
+<title>STRUCT_TOP&#45;&gt;STRUCT_S2</title>
+<path fill="none" stroke="black" d="M751.03,-474.51C759.53,-440.16 778.05,-365.34 789.28,-319.95"/>
+<polygon fill="black" stroke="black" points="792.67,-320.83 791.67,-310.28 785.87,-319.15 792.67,-320.83"/>
+</g>
+<!-- STRUCT_SN -->
+<g id="node28" class="node">
+<title>STRUCT_SN</title>
+<polygon fill="none" stroke="none" points="941.38,-320.4 855.63,-320.4 855.63,-244.9 941.38,-244.9 941.38,-320.4"/>
+<polygon fill="lightgreen" stroke="none" points="863.63,-293.9 863.63,-316.4 894.38,-316.4 894.38,-293.9 863.63,-293.9"/>
+<polygon fill="none" stroke="black" points="863.63,-293.9 863.63,-316.4 894.38,-316.4 894.38,-293.9 863.63,-293.9"/>
+<text text-anchor="start" x="866.63" y="-300.1" font-family="Times New Roman,serif" font-size="14.00">field</text>
+<defs>
+<linearGradient id="l_3" gradientUnits="userSpaceOnUse" x1="900.1" y1="-313.11" x2="927.67" y2="-297.2" >
+<stop offset="0" style="stop-color:lightblue;stop-opacity:1.;"/>
+<stop offset="1" style="stop-color:green;stop-opacity:1.;"/>
+</linearGradient>
+</defs>
+<polygon fill="url(#l_3)" stroke="none" points="894.38,-293.9 894.38,-316.4 933.38,-316.4 933.38,-293.9 894.38,-293.9"/>
+<polygon fill="none" stroke="black" points="894.38,-293.9 894.38,-316.4 933.38,-316.4 933.38,-293.9 894.38,-293.9"/>
+<text text-anchor="start" x="897.38" y="-300.1" font-family="Times New Roman,serif" font-size="14.00">int/ptr</text>
+<polygon fill="lightgreen" stroke="none" points="863.63,-271.4 863.63,-293.9 894.38,-293.9 894.38,-271.4 863.63,-271.4"/>
+<polygon fill="none" stroke="black" points="863.63,-271.4 863.63,-293.9 894.38,-293.9 894.38,-271.4 863.63,-271.4"/>
+<text text-anchor="start" x="869.63" y="-277.6" font-family="Times New Roman,serif" font-size="14.00">... &#160;</text>
+<defs>
+<linearGradient id="l_4" gradientUnits="userSpaceOnUse" x1="900.1" y1="-290.61" x2="927.67" y2="-274.7" >
+<stop offset="0" style="stop-color:lightblue;stop-opacity:1.;"/>
+<stop offset="1" style="stop-color:green;stop-opacity:1.;"/>
+</linearGradient>
+</defs>
+<polygon fill="url(#l_4)" stroke="none" points="894.38,-271.4 894.38,-293.9 933.38,-293.9 933.38,-271.4 894.38,-271.4"/>
+<polygon fill="none" stroke="black" points="894.38,-271.4 894.38,-293.9 933.38,-293.9 933.38,-271.4 894.38,-271.4"/>
+<text text-anchor="start" x="897.38" y="-277.6" font-family="Times New Roman,serif" font-size="14.00">int/ptr</text>
+<polygon fill="lightgreen" stroke="none" points="863.63,-248.9 863.63,-271.4 894.38,-271.4 894.38,-248.9 863.63,-248.9"/>
+<polygon fill="none" stroke="black" points="863.63,-248.9 863.63,-271.4 894.38,-271.4 894.38,-248.9 863.63,-248.9"/>
+<text text-anchor="start" x="866.63" y="-255.1" font-family="Times New Roman,serif" font-size="14.00">field</text>
+<defs>
+<linearGradient id="l_5" gradientUnits="userSpaceOnUse" x1="900.1" y1="-268.11" x2="927.67" y2="-252.2" >
+<stop offset="0" style="stop-color:lightblue;stop-opacity:1.;"/>
+<stop offset="1" style="stop-color:green;stop-opacity:1.;"/>
+</linearGradient>
+</defs>
+<polygon fill="url(#l_5)" stroke="none" points="894.38,-248.9 894.38,-271.4 933.38,-271.4 933.38,-248.9 894.38,-248.9"/>
+<polygon fill="none" stroke="black" points="894.38,-248.9 894.38,-271.4 933.38,-271.4 933.38,-248.9 894.38,-248.9"/>
+<text text-anchor="start" x="897.38" y="-255.1" font-family="Times New Roman,serif" font-size="14.00">int/ptr</text>
+</g>
+<!-- STRUCT_TOP&#45;&gt;STRUCT_SN -->
+<g id="edge39" class="edge">
+<title>STRUCT_TOP&#45;&gt;STRUCT_SN</title>
+<path fill="none" stroke="black" d="M759.21,-475.24C782.17,-443.49 831.3,-375.56 864.63,-329.48"/>
+<polygon fill="black" stroke="black" points="867.37,-331.67 870.4,-321.52 861.7,-327.57 867.37,-331.67"/>
+</g>
+<!-- STRUCT_BOT -->
+<g id="node25" class="node">
+<title>STRUCT_BOT</title>
+<ellipse fill="lightgreen" stroke="black" cx="751.51" cy="-82.75" rx="44.7" ry="18"/>
+<text text-anchor="start" x="726.76" y="-78.7" font-family="Times New Roman,serif" font-weight="bold" font-size="14.00">⊥</text>
+<text text-anchor="start" x="742.51" y="-78.7" font-family="Times New Roman,serif" font-size="14.00">:struct</text>
+</g>
+<!-- STRUCT_BOT&#45;&gt;BOT -->
+<g id="edge43" class="edge">
+<title>STRUCT_BOT&#45;&gt;BOT</title>
+<path fill="none" stroke="black" d="M725.72,-67.77C709,-58.7 687.2,-46.89 669.97,-37.55"/>
+<polygon fill="black" stroke="black" points="671.71,-34.51 661.25,-32.82 668.37,-40.67 671.71,-34.51"/>
+</g>
+<!-- STRUCT_S1&#45;&gt;STRUCT_BOT -->
+<g id="edge40" class="edge">
+<title>STRUCT_S1&#45;&gt;STRUCT_BOT</title>
+<path fill="none" stroke="black" d="M706.86,-264.91C715.3,-230.49 733.97,-154.31 744.29,-112.19"/>
+<polygon fill="black" stroke="black" points="747.69,-113.04 746.67,-102.5 740.89,-111.37 747.69,-113.04"/>
+</g>
+<!-- STRUCT_S1&#45;&gt;STRUCT_S2 -->
+<!-- STRUCT_S2&#45;&gt;STRUCT_BOT -->
+<g id="edge41" class="edge">
+<title>STRUCT_S2&#45;&gt;STRUCT_BOT</title>
+<path fill="none" stroke="black" d="M792.36,-256.52C783.62,-219.3 767.61,-151.25 758.45,-112.26"/>
+<polygon fill="black" stroke="black" points="761.88,-111.57 756.18,-102.64 755.07,-113.17 761.88,-111.57"/>
+</g>
+<!-- STRUCT_S2&#45;&gt;STRUCT_SN -->
+<!-- STRUCT_SN&#45;&gt;STRUCT_BOT -->
+<g id="edge42" class="edge">
+<title>STRUCT_SN&#45;&gt;STRUCT_BOT</title>
+<path fill="none" stroke="black" d="M870.86,-245.05C841.74,-205.46 796.64,-144.13 771.03,-109.3"/>
+<polygon fill="black" stroke="black" points="773.99,-107.42 765.25,-101.44 768.36,-111.57 773.99,-107.42"/>
+</g>
+<!-- MEM_ALIAS1 -->
+<g id="node31" class="node">
+<title>MEM_ALIAS1</title>
+<ellipse fill="blue" stroke="black" cx="975.51" cy="-282.65" rx="20.13" ry="20.13"/>
+<text text-anchor="middle" x="975.51" y="-277.6" font-family="Times New Roman,serif" font-size="14.00" fill="white">#1</text>
+</g>
+<!-- MEM_TOP&#45;&gt;MEM_ALIAS1 -->
+<g id="edge47" class="edge">
+<title>MEM_TOP&#45;&gt;MEM_ALIAS1</title>
+<path fill="none" stroke="black" d="M996.51,-474.51C992.58,-438.66 983.84,-358.73 978.96,-314.18"/>
+<polygon fill="black" stroke="black" points="982.45,-313.94 977.89,-304.38 975.5,-314.7 982.45,-313.94"/>
+</g>
+<!-- MEM_ALIASDOTS -->
+<g id="node32" class="node">
+<title>MEM_ALIASDOTS</title>
+<ellipse fill="blue" stroke="black" cx="1036.51" cy="-282.65" rx="27" ry="18"/>
+<text text-anchor="middle" x="1036.51" y="-277.6" font-family="Times New Roman,serif" font-size="14.00" fill="white">...</text>
+</g>
+<!-- MEM_TOP&#45;&gt;MEM_ALIASDOTS -->
+<g id="edge48" class="edge">
+<title>MEM_TOP&#45;&gt;MEM_ALIASDOTS</title>
+<path fill="none" stroke="black" d="M1001.81,-474.51C1008.41,-438.02 1023.27,-355.86 1031.23,-311.83"/>
+<polygon fill="black" stroke="black" points="1034.63,-312.69 1032.97,-302.23 1027.74,-311.45 1034.63,-312.69"/>
+</g>
+<!-- MEM_ALIASN -->
+<g id="node33" class="node">
+<title>MEM_ALIASN</title>
+<ellipse fill="blue" stroke="black" cx="1097.51" cy="-282.65" rx="20.13" ry="20.13"/>
+<text text-anchor="middle" x="1097.51" y="-277.6" font-family="Times New Roman,serif" font-size="14.00" fill="white">#n</text>
+</g>
+<!-- MEM_TOP&#45;&gt;MEM_ALIASN -->
+<g id="edge49" class="edge">
+<title>MEM_TOP&#45;&gt;MEM_ALIASN</title>
+<path fill="none" stroke="black" d="M1006.95,-474.88C1024.11,-438.46 1063.18,-355.52 1083.95,-311.44"/>
+<polygon fill="black" stroke="black" points="1087.07,-313.03 1088.16,-302.49 1080.73,-310.05 1087.07,-313.03"/>
+</g>
+<!-- MEM_BOT -->
+<g id="node30" class="node">
+<title>MEM_BOT</title>
+<ellipse fill="blue" stroke="black" cx="998.51" cy="-82.75" rx="43.67" ry="18"/>
+<text text-anchor="start" x="974.51" y="-78.7" font-family="Times New Roman,serif" font-weight="bold" font-size="14.00" fill="white">⊥</text>
+<text text-anchor="start" x="990.26" y="-78.7" font-family="Times New Roman,serif" font-size="14.00" fill="white">:mem</text>
+</g>
+<!-- MEM_BOT&#45;&gt;BOT -->
+<g id="edge53" class="edge">
+<title>MEM_BOT&#45;&gt;BOT</title>
+<path fill="none" stroke="black" d="M958.6,-75.08C887.17,-63.15 738.86,-38.38 673.56,-27.48"/>
+<polygon fill="black" stroke="black" points="674.3,-24.05 663.86,-25.86 673.15,-30.96 674.3,-24.05"/>
+</g>
+<!-- MEM_ALIAS1&#45;&gt;MEM_BOT -->
+<g id="edge50" class="edge">
+<title>MEM_ALIAS1&#45;&gt;MEM_BOT</title>
+<path fill="none" stroke="black" d="M977.84,-262.38C981.92,-226.96 990.35,-153.62 995.09,-112.45"/>
+<polygon fill="black" stroke="black" points="998.57,-112.87 996.23,-102.53 991.61,-112.07 998.57,-112.87"/>
+</g>
+<!-- MEM_ALIAS1&#45;&gt;MEM_ALIASDOTS -->
+<!-- MEM_ALIASDOTS&#45;&gt;MEM_BOT -->
+<g id="edge51" class="edge">
+<title>MEM_ALIASDOTS&#45;&gt;MEM_BOT</title>
+<path fill="none" stroke="black" d="M1033.07,-264.56C1026.49,-229.93 1012.06,-154.01 1004.08,-112.06"/>
+<polygon fill="black" stroke="black" points="1007.56,-111.6 1002.25,-102.43 1000.68,-112.91 1007.56,-111.6"/>
+</g>
+<!-- MEM_ALIASDOTS&#45;&gt;MEM_ALIASN -->
+<!-- MEM_ALIASN&#45;&gt;MEM_BOT -->
+<g id="edge52" class="edge">
+<title>MEM_ALIASN&#45;&gt;MEM_BOT</title>
+<path fill="none" stroke="black" d="M1088.37,-264.2C1070.97,-229.07 1032.98,-152.35 1012.41,-110.82"/>
+<polygon fill="black" stroke="black" points="1015.58,-109.34 1008.01,-101.93 1009.31,-112.45 1015.58,-109.34"/>
+</g>
+<!-- TUPLE1 -->
+<g id="node36" class="node">
+<title>TUPLE1</title>
+<polygon fill="none" stroke="none" points="1185.51,-309.15 1131.51,-309.15 1131.51,-256.15 1185.51,-256.15 1185.51,-309.15"/>
+<polygon fill="pink" stroke="none" points="1139.76,-282.65 1139.76,-305.15 1177.26,-305.15 1177.26,-282.65 1139.76,-282.65"/>
+<polygon fill="none" stroke="black" points="1139.76,-282.65 1139.76,-305.15 1177.26,-305.15 1177.26,-282.65 1139.76,-282.65"/>
+<text text-anchor="start" x="1142.76" y="-288.85" font-family="Times New Roman,serif" font-size="14.00">Tuple</text>
+<polygon fill="black" stroke="none" points="1139.76,-260.15 1139.76,-282.65 1177.26,-282.65 1177.26,-260.15 1139.76,-260.15"/>
+<polygon fill="none" stroke="black" points="1139.76,-260.15 1139.76,-282.65 1177.26,-282.65 1177.26,-260.15 1139.76,-260.15"/>
+<text text-anchor="start" x="1146.88" y="-266.35" font-family="Times New Roman,serif" font-size="14.00" fill="white">type</text>
+</g>
+<!-- TUPLE_TOP&#45;&gt;TUPLE1 -->
+<g id="edge57" class="edge">
+<title>TUPLE_TOP&#45;&gt;TUPLE1</title>
+<path fill="none" stroke="black" d="M1180.42,-474.51C1176.51,-440.23 1167.99,-365.66 1162.8,-320.24"/>
+<polygon fill="black" stroke="black" points="1166.28,-319.86 1161.67,-310.32 1159.33,-320.65 1166.28,-319.86"/>
+</g>
+<!-- TUPLE2 -->
+<g id="node37" class="node">
+<title>TUPLE2</title>
+<polygon fill="none" stroke="none" points="1253.51,-320.4 1199.51,-320.4 1199.51,-244.9 1253.51,-244.9 1253.51,-320.4"/>
+<polygon fill="pink" stroke="none" points="1207.76,-293.9 1207.76,-316.4 1245.26,-316.4 1245.26,-293.9 1207.76,-293.9"/>
+<polygon fill="none" stroke="black" points="1207.76,-293.9 1207.76,-316.4 1245.26,-316.4 1245.26,-293.9 1207.76,-293.9"/>
+<text text-anchor="start" x="1210.76" y="-300.1" font-family="Times New Roman,serif" font-size="14.00">Tuple</text>
+<polygon fill="black" stroke="none" points="1207.76,-271.4 1207.76,-293.9 1245.26,-293.9 1245.26,-271.4 1207.76,-271.4"/>
+<polygon fill="none" stroke="black" points="1207.76,-271.4 1207.76,-293.9 1245.26,-293.9 1245.26,-271.4 1207.76,-271.4"/>
+<text text-anchor="start" x="1214.88" y="-277.6" font-family="Times New Roman,serif" font-size="14.00" fill="white">type</text>
+<polygon fill="black" stroke="none" points="1207.76,-248.9 1207.76,-271.4 1245.26,-271.4 1245.26,-248.9 1207.76,-248.9"/>
+<polygon fill="none" stroke="black" points="1207.76,-248.9 1207.76,-271.4 1245.26,-271.4 1245.26,-248.9 1207.76,-248.9"/>
+<text text-anchor="start" x="1214.88" y="-255.1" font-family="Times New Roman,serif" font-size="14.00" fill="white">type</text>
+</g>
+<!-- TUPLE_TOP&#45;&gt;TUPLE2 -->
+<g id="edge58" class="edge">
+<title>TUPLE_TOP&#45;&gt;TUPLE2</title>
+<path fill="none" stroke="black" d="M1186.34,-474.51C1192.95,-442.94 1206.72,-377.19 1216.28,-331.51"/>
+<polygon fill="black" stroke="black" points="1219.68,-332.35 1218.3,-321.85 1212.83,-330.92 1219.68,-332.35"/>
+</g>
+<!-- TUPLEN -->
+<g id="node38" class="node">
+<title>TUPLEN</title>
+<polygon fill="none" stroke="none" points="1321.51,-331.65 1267.51,-331.65 1267.51,-233.65 1321.51,-233.65 1321.51,-331.65"/>
+<polygon fill="pink" stroke="none" points="1275.76,-305.15 1275.76,-327.65 1313.26,-327.65 1313.26,-305.15 1275.76,-305.15"/>
+<polygon fill="none" stroke="black" points="1275.76,-305.15 1275.76,-327.65 1313.26,-327.65 1313.26,-305.15 1275.76,-305.15"/>
+<text text-anchor="start" x="1278.76" y="-311.35" font-family="Times New Roman,serif" font-size="14.00">Tuple</text>
+<polygon fill="black" stroke="none" points="1275.76,-282.65 1275.76,-305.15 1313.26,-305.15 1313.26,-282.65 1275.76,-282.65"/>
+<polygon fill="none" stroke="black" points="1275.76,-282.65 1275.76,-305.15 1313.26,-305.15 1313.26,-282.65 1275.76,-282.65"/>
+<text text-anchor="start" x="1282.88" y="-288.85" font-family="Times New Roman,serif" font-size="14.00" fill="white">type</text>
+<polygon fill="black" stroke="none" points="1275.76,-260.15 1275.76,-282.65 1313.26,-282.65 1313.26,-260.15 1275.76,-260.15"/>
+<polygon fill="none" stroke="black" points="1275.76,-260.15 1275.76,-282.65 1313.26,-282.65 1313.26,-260.15 1275.76,-260.15"/>
+<text text-anchor="start" x="1288.88" y="-266.35" font-family="Times New Roman,serif" font-size="14.00" fill="white">...</text>
+<polygon fill="black" stroke="none" points="1275.76,-237.65 1275.76,-260.15 1313.26,-260.15 1313.26,-237.65 1275.76,-237.65"/>
+<polygon fill="none" stroke="black" points="1275.76,-237.65 1275.76,-260.15 1313.26,-260.15 1313.26,-237.65 1275.76,-237.65"/>
+<text text-anchor="start" x="1282.88" y="-243.85" font-family="Times New Roman,serif" font-size="14.00" fill="white">type</text>
+</g>
+<!-- TUPLE_TOP&#45;&gt;TUPLEN -->
+<g id="edge59" class="edge">
+<title>TUPLE_TOP&#45;&gt;TUPLEN</title>
+<path fill="none" stroke="black" d="M1192.06,-474.88C1207.65,-445.62 1239.24,-386.36 1263.24,-341.32"/>
+<polygon fill="black" stroke="black" points="1266.22,-343.18 1267.83,-332.71 1260.04,-339.88 1266.22,-343.18"/>
+</g>
+<!-- TUPLE_BOT -->
+<g id="node35" class="node">
+<title>TUPLE_BOT</title>
+<ellipse fill="pink" stroke="black" cx="1192.51" cy="-82.75" rx="42.65" ry="18"/>
+<text text-anchor="start" x="1169.26" y="-78.7" font-family="Times New Roman,serif" font-weight="bold" font-size="14.00">⊥</text>
+<text text-anchor="start" x="1185.01" y="-78.7" font-family="Times New Roman,serif" font-size="14.00">:tuple</text>
+</g>
+<!-- TUPLE_BOT&#45;&gt;BOT -->
+<g id="edge63" class="edge">
+<title>TUPLE_BOT&#45;&gt;BOT</title>
+<path fill="none" stroke="black" d="M1151.54,-77.32C1046.53,-65.95 769.32,-35.95 674.14,-25.65"/>
+<polygon fill="black" stroke="black" points="674.52,-22.18 664.2,-24.58 673.77,-29.14 674.52,-22.18"/>
+</g>
+<!-- TUPLE1&#45;&gt;TUPLE_BOT -->
+<g id="edge60" class="edge">
+<title>TUPLE1&#45;&gt;TUPLE_BOT</title>
+<path fill="none" stroke="black" d="M1162.95,-256.52C1169.28,-219.3 1180.86,-151.25 1187.49,-112.26"/>
+<polygon fill="black" stroke="black" points="1190.9,-113.1 1189.12,-102.66 1184,-111.93 1190.9,-113.1"/>
+</g>
+<!-- TUPLE2&#45;&gt;TUPLE_BOT -->
+<g id="edge61" class="edge">
+<title>TUPLE2&#45;&gt;TUPLE_BOT</title>
+<path fill="none" stroke="black" d="M1220.11,-245.05C1213.55,-206.44 1203.46,-147.16 1197.47,-111.94"/>
+<polygon fill="black" stroke="black" points="1200.99,-111.74 1195.86,-102.47 1194.09,-112.92 1200.99,-111.74"/>
+</g>
+<!-- TUPLEN&#45;&gt;TUPLE_BOT -->
+<g id="edge62" class="edge">
+<title>TUPLEN&#45;&gt;TUPLE_BOT</title>
+<path fill="none" stroke="black" d="M1269.56,-233.75C1249.85,-195.12 1223.04,-142.58 1206.8,-110.75"/>
+<polygon fill="black" stroke="black" points="1210.07,-109.46 1202.41,-102.15 1203.83,-112.65 1210.07,-109.46"/>
+</g>
+</g>
+</svg>
diff --git a/docs/chapter18/lattice2.gv b/docs/chapter18/lattice2.gv
new file mode 100644
index 00000000..6aa37fa0
--- /dev/null
+++ b/docs/chapter18/lattice2.gv
@@ -0,0 +1,85 @@
+digraph Lattice {
+ compound = true;
+ // Define nodes
+ splines=false;
+ node [shape=oval, style=filled];
+ nodesep=0.2;
+ ranksep=0.4;
+
+ TOP [label="~scalar\n+int+tmp+0", fillcolor=black, fontcolor=white, group=center];
+
+ // ------------------------
+ PTRHQ [label="~tmp\n+tmp+0", fillcolor=green, fontcolor=white, group=left];
+ TOP -> PTRHQ
+
+ VALH_ [label="~nscalar\n+int+tmp", fillcolor=white, group=center];
+ TOP -> VALH_
+
+ INTHQ [label="~int\n+int+0", fillcolor=lightblue, group=right];
+ TOP -> INTHQ
+
+ LEFTHI [label="junk", style=invis, group=junkleft]
+
+
+ PTRHQ -> LEFTHI-> VALH_ -> INTHQ [style=invis];
+ { rank=same; PTRHQ; LEFTHI; VALH_; INTHQ }
+
+ // ------------------------
+ PTRH_ [label="~ntmp\n+tmp", fillcolor=green, fontcolor=white, group=left];
+ VALH_ -> PTRH_
+ PTRHQ -> PTRH_
+
+ INTH_ [label="~nint\n+int", fillcolor=lightblue, group=right];
+ VALH_ -> INTH_
+ INTHQ -> INTH_
+ { rank=same; PTRH_; INTH_ }
+
+ // ------------------------
+ NILX_ [label="~nil\n[int,tmp]+0", fillcolor=aqua, group=junkleft];
+ INTHQ -> NILX_
+ PTRHQ -> NILX_
+
+ NIL__ [label="nil\n[+int+tmp],0", fillcolor=pink];
+ VALH_ -> NIL__;
+
+ NILX_ -> NIL__ [style=invis];
+ { rank=same; NIL__; NILX_ }
+
+ // ------------------------
+ PTRL_ [label="ntmp\ntmp", fillcolor=green, fontcolor=white, group=left];
+ PTRH_ -> PTRL_
+
+ INTL_ [label="nint\nint", fillcolor=lightblue, group=right];
+ INTH_ -> INTL_
+ { rank=same; PTRL_; INTL_ }
+
+ // ------------------------
+ PTRL0 [label="tmp\ntmp,0", fillcolor=green, fontcolor=white, group=left];
+ PTRL_ -> PTRL0
+ NIL__ -> PTRL0
+
+ VALL_ [label="nscalar\nint,tmp", fillcolor=white, group=center];
+ PTRL_ -> VALL_
+ INTL_ -> VALL_
+ NILX_ -> VALL_
+
+ INTL0 [label="int\nint,0", fillcolor=lightblue, group=right];
+ INTL_ -> INTL0
+ NIL__ -> INTL0
+
+ PTRL0 -> VALL_ -> INTL0 [style=invis];
+ { rank=same; PTRL0; VALL_; INTL0 }
+
+ // ------------------------
+ BOT [label="scalar\nint,tmp,0", fillcolor=black, fontcolor=white, group=center];
+ PTRL0 -> BOT
+ INTL0 -> BOT
+ VALL_ -> BOT
+
+ // ------------------------
+ // Verticle alignment
+ TOP -> VALH_ -> VALL_ -> BOT [style=invis];
+ PTRHQ -> PTRH_ -> PTRL_ -> PTRL0 [style=invis];
+ INTHQ -> INTH_ -> INTL_ -> INTL0 [style=invis];
+ LEFTHI -> NILX_ [style=invis]
+}
diff --git a/docs/chapter18/lattice2.svg b/docs/chapter18/lattice2.svg
new file mode 100644
index 00000000..857bca2d
--- /dev/null
+++ b/docs/chapter18/lattice2.svg
@@ -0,0 +1,260 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN"
+ "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
+<!-- Generated by graphviz version 12.2.0 (20241103.1931)
+ -->
+<!-- Title: Lattice Pages: 1 -->
+<svg width="478pt" height="501pt"
+ viewBox="0.00 0.00 477.96 500.90" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
+<g id="graph0" class="graph" transform="scale(1 1) rotate(0) translate(4 496.9)">
+<title>Lattice</title>
+<polygon fill="white" stroke="none" points="-4,4 -4,-496.9 473.96,-496.9 473.96,4 -4,4"/>
+<!-- TOP -->
+<g id="node1" class="node">
+<title>TOP</title>
+<ellipse fill="black" stroke="black" cx="240.13" cy="-463.91" rx="59.04" ry="28.99"/>
+<text text-anchor="middle" x="240.13" y="-467.11" font-family="Times New Roman,serif" font-size="14.00" fill="white">~scalar</text>
+<text text-anchor="middle" x="240.13" y="-450.61" font-family="Times New Roman,serif" font-size="14.00" fill="white">+int+tmp+0</text>
+</g>
+<!-- PTRHQ -->
+<g id="node2" class="node">
+<title>PTRHQ</title>
+<ellipse fill="green" stroke="black" cx="43.13" cy="-376.92" rx="43.13" ry="28.99"/>
+<text text-anchor="middle" x="43.13" y="-380.12" font-family="Times New Roman,serif" font-size="14.00" fill="white">~tmp</text>
+<text text-anchor="middle" x="43.13" y="-363.62" font-family="Times New Roman,serif" font-size="14.00" fill="white">+tmp+0</text>
+</g>
+<!-- TOP&#45;&gt;PTRHQ -->
+<g id="edge1" class="edge">
+<title>TOP&#45;&gt;PTRHQ</title>
+<path fill="none" stroke="black" d="M196.41,-444.04C164.74,-430.38 121.99,-411.94 89.68,-398"/>
+<polygon fill="black" stroke="black" points="91.11,-394.81 80.55,-394.06 88.34,-401.24 91.11,-394.81"/>
+</g>
+<!-- VALH_ -->
+<g id="node3" class="node">
+<title>VALH_</title>
+<ellipse fill="white" stroke="black" cx="240.13" cy="-376.92" rx="48.44" ry="28.99"/>
+<text text-anchor="middle" x="240.13" y="-380.12" font-family="Times New Roman,serif" font-size="14.00">~nscalar</text>
+<text text-anchor="middle" x="240.13" y="-363.62" font-family="Times New Roman,serif" font-size="14.00">+int+tmp</text>
+</g>
+<!-- TOP&#45;&gt;VALH_ -->
+<g id="edge2" class="edge">
+<title>TOP&#45;&gt;VALH_</title>
+<path fill="none" stroke="black" d="M235.15,-434.61C234.93,-429.02 234.85,-423.06 234.9,-417.18"/>
+<polygon fill="black" stroke="black" points="238.39,-417.69 235.12,-407.61 231.39,-417.52 238.39,-417.69"/>
+</g>
+<!-- TOP&#45;&gt;VALH_ -->
+<!-- INTHQ -->
+<g id="node4" class="node">
+<title>INTHQ</title>
+<ellipse fill="lightblue" stroke="black" cx="432.13" cy="-376.92" rx="37.83" ry="28.99"/>
+<text text-anchor="middle" x="432.13" y="-380.12" font-family="Times New Roman,serif" font-size="14.00">~int</text>
+<text text-anchor="middle" x="432.13" y="-363.62" font-family="Times New Roman,serif" font-size="14.00">+int+0</text>
+</g>
+<!-- TOP&#45;&gt;INTHQ -->
+<g id="edge3" class="edge">
+<title>TOP&#45;&gt;INTHQ</title>
+<path fill="none" stroke="black" d="M283.22,-443.83C314.91,-429.81 357.78,-410.83 389.39,-396.84"/>
+<polygon fill="black" stroke="black" points="390.53,-400.16 398.26,-392.92 387.7,-393.76 390.53,-400.16"/>
+</g>
+<!-- LEFTHI -->
+<!-- PTRHQ&#45;&gt;LEFTHI -->
+<!-- PTRH_ -->
+<g id="node6" class="node">
+<title>PTRH_</title>
+<ellipse fill="green" stroke="black" cx="43.13" cy="-289.94" rx="36.77" ry="28.99"/>
+<text text-anchor="middle" x="43.13" y="-293.14" font-family="Times New Roman,serif" font-size="14.00" fill="white">~ntmp</text>
+<text text-anchor="middle" x="43.13" y="-276.64" font-family="Times New Roman,serif" font-size="14.00" fill="white">+tmp</text>
+</g>
+<!-- PTRHQ&#45;&gt;PTRH_ -->
+<g id="edge8" class="edge">
+<title>PTRHQ&#45;&gt;PTRH_</title>
+<path fill="none" stroke="black" d="M38.15,-347.62C37.93,-342.03 37.85,-336.07 37.9,-330.2"/>
+<polygon fill="black" stroke="black" points="41.39,-330.71 38.12,-320.63 34.39,-330.54 41.39,-330.71"/>
+</g>
+<!-- PTRHQ&#45;&gt;PTRH_ -->
+<!-- NILX_ -->
+<g id="node8" class="node">
+<title>NILX_</title>
+<ellipse fill="aqua" stroke="black" cx="150.13" cy="-289.94" rx="56.39" ry="28.99"/>
+<text text-anchor="middle" x="150.13" y="-293.14" font-family="Times New Roman,serif" font-size="14.00">~nil</text>
+<text text-anchor="middle" x="150.13" y="-276.64" font-family="Times New Roman,serif" font-size="14.00">[int,tmp]+0</text>
+</g>
+<!-- PTRHQ&#45;&gt;NILX_ -->
+<g id="edge12" class="edge">
+<title>PTRHQ&#45;&gt;NILX_</title>
+<path fill="none" stroke="black" d="M70.41,-354.26C82.91,-344.33 97.94,-332.4 111.56,-321.58"/>
+<polygon fill="black" stroke="black" points="113.43,-324.56 119.09,-315.6 109.08,-319.08 113.43,-324.56"/>
+</g>
+<!-- VALH_&#45;&gt;INTHQ -->
+<!-- VALH_&#45;&gt;PTRH_ -->
+<g id="edge7" class="edge">
+<title>VALH_&#45;&gt;PTRH_</title>
+<path fill="none" stroke="black" d="M201.21,-359.13C167.78,-344.71 119.68,-323.96 85.33,-309.14"/>
+<polygon fill="black" stroke="black" points="87.1,-306.09 76.53,-305.35 84.33,-312.52 87.1,-306.09"/>
+</g>
+<!-- INTH_ -->
+<g id="node7" class="node">
+<title>INTH_</title>
+<ellipse fill="lightblue" stroke="black" cx="432.13" cy="-289.94" rx="31.47" ry="28.99"/>
+<text text-anchor="middle" x="432.13" y="-293.14" font-family="Times New Roman,serif" font-size="14.00">~nint</text>
+<text text-anchor="middle" x="432.13" y="-276.64" font-family="Times New Roman,serif" font-size="14.00">+int</text>
+</g>
+<!-- VALH_&#45;&gt;INTH_ -->
+<g id="edge9" class="edge">
+<title>VALH_&#45;&gt;INTH_</title>
+<path fill="none" stroke="black" d="M278.53,-358.93C311.9,-344.16 360.02,-322.86 393.48,-308.05"/>
+<polygon fill="black" stroke="black" points="394.67,-311.35 402.4,-304.1 391.84,-304.95 394.67,-311.35"/>
+</g>
+<!-- NIL__ -->
+<g id="node9" class="node">
+<title>NIL__</title>
+<ellipse fill="pink" stroke="black" cx="324.13" cy="-289.94" rx="62.23" ry="28.99"/>
+<text text-anchor="middle" x="324.13" y="-293.14" font-family="Times New Roman,serif" font-size="14.00">nil</text>
+<text text-anchor="middle" x="324.13" y="-276.64" font-family="Times New Roman,serif" font-size="14.00">[+int+tmp],0</text>
+</g>
+<!-- VALH_&#45;&gt;NIL__ -->
+<g id="edge13" class="edge">
+<title>VALH_&#45;&gt;NIL__</title>
+<path fill="none" stroke="black" d="M264.43,-351.34C272.67,-343.01 282.01,-333.55 290.83,-324.64"/>
+<polygon fill="black" stroke="black" points="293.12,-327.3 297.66,-317.72 288.14,-322.38 293.12,-327.3"/>
+</g>
+<!-- VALL_ -->
+<g id="node13" class="node">
+<title>VALL_</title>
+<ellipse fill="white" stroke="black" cx="240.13" cy="-115.97" rx="39.42" ry="28.99"/>
+<text text-anchor="middle" x="240.13" y="-119.17" font-family="Times New Roman,serif" font-size="14.00">nscalar</text>
+<text text-anchor="middle" x="240.13" y="-102.67" font-family="Times New Roman,serif" font-size="14.00">int,tmp</text>
+</g>
+<!-- VALH_&#45;&gt;VALL_ -->
+<!-- INTHQ&#45;&gt;INTH_ -->
+<g id="edge10" class="edge">
+<title>INTHQ&#45;&gt;INTH_</title>
+<path fill="none" stroke="black" d="M427.17,-348.1C426.94,-342.37 426.85,-336.25 426.9,-330.21"/>
+<polygon fill="black" stroke="black" points="430.39,-330.42 427.13,-320.34 423.39,-330.26 430.39,-330.42"/>
+</g>
+<!-- INTHQ&#45;&gt;INTH_ -->
+<!-- INTHQ&#45;&gt;NILX_ -->
+<g id="edge11" class="edge">
+<title>INTHQ&#45;&gt;NILX_</title>
+<path fill="none" stroke="black" d="M396.99,-365.33C350,-351.17 266.03,-325.87 209.23,-308.75"/>
+<polygon fill="black" stroke="black" points="210.28,-305.41 199.69,-305.88 208.26,-312.11 210.28,-305.41"/>
+</g>
+<!-- LEFTHI&#45;&gt;VALH_ -->
+<!-- LEFTHI&#45;&gt;NILX_ -->
+<!-- PTRL_ -->
+<g id="node10" class="node">
+<title>PTRL_</title>
+<ellipse fill="green" stroke="black" cx="43.13" cy="-202.96" rx="31.47" ry="28.99"/>
+<text text-anchor="middle" x="43.13" y="-206.16" font-family="Times New Roman,serif" font-size="14.00" fill="white">ntmp</text>
+<text text-anchor="middle" x="43.13" y="-189.66" font-family="Times New Roman,serif" font-size="14.00" fill="white">tmp</text>
+</g>
+<!-- PTRH_&#45;&gt;PTRL_ -->
+<g id="edge15" class="edge">
+<title>PTRH_&#45;&gt;PTRL_</title>
+<path fill="none" stroke="black" d="M38.17,-261.11C37.94,-255.39 37.85,-249.26 37.9,-243.22"/>
+<polygon fill="black" stroke="black" points="41.39,-243.44 38.13,-233.36 34.39,-243.27 41.39,-243.44"/>
+</g>
+<!-- PTRH_&#45;&gt;PTRL_ -->
+<!-- INTL_ -->
+<g id="node11" class="node">
+<title>INTL_</title>
+<ellipse fill="lightblue" stroke="black" cx="432.13" cy="-202.96" rx="27" ry="28.99"/>
+<text text-anchor="middle" x="432.13" y="-206.16" font-family="Times New Roman,serif" font-size="14.00">nint</text>
+<text text-anchor="middle" x="432.13" y="-189.66" font-family="Times New Roman,serif" font-size="14.00">int</text>
+</g>
+<!-- INTH_&#45;&gt;INTL_ -->
+<g id="edge16" class="edge">
+<title>INTH_&#45;&gt;INTL_</title>
+<path fill="none" stroke="black" d="M427.17,-261.11C426.94,-255.39 426.85,-249.26 426.9,-243.22"/>
+<polygon fill="black" stroke="black" points="430.39,-243.44 427.13,-233.36 423.39,-243.27 430.39,-243.44"/>
+</g>
+<!-- INTH_&#45;&gt;INTL_ -->
+<!-- NILX_&#45;&gt;NIL__ -->
+<!-- NILX_&#45;&gt;VALL_ -->
+<g id="edge21" class="edge">
+<title>NILX_&#45;&gt;VALL_</title>
+<path fill="none" stroke="black" d="M164.79,-261.6C180.03,-232.15 203.95,-185.91 220.74,-153.45"/>
+<polygon fill="black" stroke="black" points="223.74,-155.27 225.23,-144.78 217.53,-152.06 223.74,-155.27"/>
+</g>
+<!-- PTRL0 -->
+<g id="node12" class="node">
+<title>PTRL0</title>
+<ellipse fill="green" stroke="black" cx="43.13" cy="-115.97" rx="34.12" ry="28.99"/>
+<text text-anchor="middle" x="43.13" y="-119.17" font-family="Times New Roman,serif" font-size="14.00" fill="white">tmp</text>
+<text text-anchor="middle" x="43.13" y="-102.67" font-family="Times New Roman,serif" font-size="14.00" fill="white">tmp,0</text>
+</g>
+<!-- NIL__&#45;&gt;PTRL0 -->
+<g id="edge18" class="edge">
+<title>NIL__&#45;&gt;PTRL0</title>
+<path fill="none" stroke="black" d="M286.24,-266.48C232.36,-233.13 134.24,-172.38 80.6,-139.17"/>
+<polygon fill="black" stroke="black" points="82.76,-136.39 72.41,-134.1 79.07,-142.34 82.76,-136.39"/>
+</g>
+<!-- INTL0 -->
+<g id="node14" class="node">
+<title>INTL0</title>
+<ellipse fill="lightblue" stroke="black" cx="432.13" cy="-115.97" rx="28.81" ry="28.99"/>
+<text text-anchor="middle" x="432.13" y="-119.17" font-family="Times New Roman,serif" font-size="14.00">int</text>
+<text text-anchor="middle" x="432.13" y="-102.67" font-family="Times New Roman,serif" font-size="14.00">int,0</text>
+</g>
+<!-- NIL__&#45;&gt;INTL0 -->
+<g id="edge23" class="edge">
+<title>NIL__&#45;&gt;INTL0</title>
+<path fill="none" stroke="black" d="M341.49,-261.99C360.34,-231.61 390.49,-183.05 410.79,-150.35"/>
+<polygon fill="black" stroke="black" points="413.65,-152.38 415.95,-142.04 407.7,-148.69 413.65,-152.38"/>
+</g>
+<!-- PTRL_&#45;&gt;PTRL0 -->
+<g id="edge17" class="edge">
+<title>PTRL_&#45;&gt;PTRL0</title>
+<path fill="none" stroke="black" d="M38.17,-174.13C37.94,-168.47 37.85,-162.41 37.9,-156.43"/>
+<polygon fill="black" stroke="black" points="41.39,-156.75 38.12,-146.67 34.39,-156.58 41.39,-156.75"/>
+</g>
+<!-- PTRL_&#45;&gt;PTRL0 -->
+<!-- PTRL_&#45;&gt;VALL_ -->
+<g id="edge19" class="edge">
+<title>PTRL_&#45;&gt;VALL_</title>
+<path fill="none" stroke="black" d="M71.36,-189.78C103.94,-175.73 157.92,-152.44 196.04,-135.99"/>
+<polygon fill="black" stroke="black" points="197.16,-139.32 204.96,-132.15 194.39,-132.9 197.16,-139.32"/>
+</g>
+<!-- INTL_&#45;&gt;VALL_ -->
+<g id="edge20" class="edge">
+<title>INTL_&#45;&gt;VALL_</title>
+<path fill="none" stroke="black" d="M407.43,-191.02C376.23,-177.21 322.01,-153.22 283.77,-136.29"/>
+<polygon fill="black" stroke="black" points="285.39,-133.18 274.83,-132.33 282.55,-139.58 285.39,-133.18"/>
+</g>
+<!-- INTL_&#45;&gt;INTL0 -->
+<g id="edge22" class="edge">
+<title>INTL_&#45;&gt;INTL0</title>
+<path fill="none" stroke="black" d="M427.17,-174.13C426.94,-168.41 426.85,-162.28 426.9,-156.24"/>
+<polygon fill="black" stroke="black" points="430.39,-156.46 427.13,-146.38 423.39,-156.29 430.39,-156.46"/>
+</g>
+<!-- INTL_&#45;&gt;INTL0 -->
+<!-- PTRL0&#45;&gt;VALL_ -->
+<!-- BOT -->
+<g id="node15" class="node">
+<title>BOT</title>
+<ellipse fill="black" stroke="black" cx="240.13" cy="-28.99" rx="46.85" ry="28.99"/>
+<text text-anchor="middle" x="240.13" y="-32.19" font-family="Times New Roman,serif" font-size="14.00" fill="white">scalar</text>
+<text text-anchor="middle" x="240.13" y="-15.69" font-family="Times New Roman,serif" font-size="14.00" fill="white">int,tmp,0</text>
+</g>
+<!-- PTRL0&#45;&gt;BOT -->
+<g id="edge26" class="edge">
+<title>PTRL0&#45;&gt;BOT</title>
+<path fill="none" stroke="black" d="M73.48,-101.88C105.02,-88.28 154.83,-66.79 191.79,-50.85"/>
+<polygon fill="black" stroke="black" points="193.14,-54.08 200.94,-46.9 190.37,-47.65 193.14,-54.08"/>
+</g>
+<!-- VALL_&#45;&gt;INTL0 -->
+<!-- VALL_&#45;&gt;BOT -->
+<g id="edge28" class="edge">
+<title>VALL_&#45;&gt;BOT</title>
+<path fill="none" stroke="black" d="M235.17,-87.15C234.94,-81.48 234.85,-75.42 234.9,-69.44"/>
+<polygon fill="black" stroke="black" points="238.39,-69.76 235.12,-59.68 231.39,-69.6 238.39,-69.76"/>
+</g>
+<!-- VALL_&#45;&gt;BOT -->
+<!-- INTL0&#45;&gt;BOT -->
+<g id="edge27" class="edge">
+<title>INTL0&#45;&gt;BOT</title>
+<path fill="none" stroke="black" d="M405.84,-103.34C375.52,-89.91 325.06,-67.58 287.78,-51.08"/>
+<polygon fill="black" stroke="black" points="289.59,-48.05 279.03,-47.21 286.75,-54.45 289.59,-48.05"/>
+</g>
+</g>
+</svg>
diff --git a/docs/chapter18/webtcp.min.js b/docs/chapter18/webtcp.min.js
new file mode 100644
index 00000000..bf23ee5a
--- /dev/null
+++ b/docs/chapter18/webtcp.min.js
@@ -0,0 +1,65 @@
+function Http(j){this.cID=Math.random().toString(36).substr(2);this.webtcp=j;this.webtcp.httpClients[this.cID]=this;this.createPacket=function(){return{cID:this.cID,type:"http",host:this.remoteAddress,port:this.remotePort,method:null,data:null}};this.ondata=function(){};this.get=function(g,c){this.on("data",c);this.rpc("httpGet",[g])};this.post=function(g,c,j){this.on("data",j);this.rpc("httpPost",[g,c])}}Http.prototype=new WebTCPIO;function Socket(j,g,c,p){this.sID=Math.random().toString(36).substr(2);this.webtcp=j;this.closed=this.ready=!1;this.options=p;this.sockOpts={_updating:!1};this.remoteAddress=g;this.remotePort=c;this.webtcp.sockets[this.sID]=this;this.createPacket=function(){return{id:Math.random().toString(36).substr(2),sID:this.sID,type:"tcp",options:this.options,host:this.remoteAddress,port:this.remotePort,data:null}};this.onconnect=function(){this.webtcp.sockets[sID].ready=!0;this.webtcp.sockets[sID].closed=!1};
+this.ondata=function(){};this.onend=function(){};this.ontimeout=function(){};this.ondrain=function(){};this.onclose=function(){this.webtcp.sockets[sID].ready=!1;this.webtcp.sockets[sID].closed=!0};this.getSockOpts=function(){this.sockOpts._updating=!0;this.rpc("getSockOpts")};this.onSockOptsRcv=function(c){this.sockOpts=c;this.sockOpts._updating=!1}}Socket.prototype=new WebTCPIO;var JSON;JSON||(JSON={});
+(function(){function j(c,p){var q,t,n,x,i=k,e,l=p[c];l&&"object"==typeof l&&"function"==typeof l.toJSON&&(l=l.toJSON(c));"function"==typeof r&&(l=r.call(p,c,l));switch(typeof l){case "string":return g(l);case "number":return isFinite(l)?String(l):"null";case "boolean":case "null":return String(l);case "object":if(!l)return"null";k+=v;e=[];if("[object Array]"===Object.prototype.toString.apply(l)){x=l.length;for(q=0;q<x;q+=1)e[q]=j(q,l)||"null";n=0===e.length?"[]":k?"[\n"+k+e.join(",\n"+k)+"\n"+i+"]":
+"["+e.join(",")+"]";k=i;return n}if(r&&"object"==typeof r){x=r.length;for(q=0;q<x;q+=1)"string"==typeof r[q]&&(t=r[q],n=j(t,l),n&&e.push(g(t)+(k?": ":":")+n))}else for(t in l)Object.prototype.hasOwnProperty.call(l,t)&&(n=j(t,l),n&&e.push(g(t)+(k?": ":":")+n));n=0===e.length?"{}":k?"{\n"+k+e.join(",\n"+k)+"\n"+i+"}":"{"+e.join(",")+"}";k=i;return n}}function g(c){n.lastIndex=0;return n.test(c)?'"'+c.replace(n,function(c){var g=D[c];return"string"==typeof g?g:"\\u"+("0000"+c.charCodeAt(0).toString(16)).slice(-4)})+
+'"':'"'+c+'"'}function c(c){return 10>c?"0"+c:c}"use strict";"function"!=typeof Date.prototype.toJSON&&(Date.prototype.toJSON=function(){return isFinite(this.valueOf())?this.getUTCFullYear()+"-"+c(this.getUTCMonth()+1)+"-"+c(this.getUTCDate())+"T"+c(this.getUTCHours())+":"+c(this.getUTCMinutes())+":"+c(this.getUTCSeconds())+"Z":null},String.prototype.toJSON=Number.prototype.toJSON=Boolean.prototype.toJSON=function(){return this.valueOf()});var p=/[\u0000\u00ad\u0600-\u0604\u070f\u17b4\u17b5\u200c-\u200f\u2028-\u202f\u2060-\u206f\ufeff\ufff0-\uffff]/g,
+n=/[\\\"\x00-\x1f\x7f-\x9f\u00ad\u0600-\u0604\u070f\u17b4\u17b5\u200c-\u200f\u2028-\u202f\u2060-\u206f\ufeff\ufff0-\uffff]/g,k,v,D={"\b":"\\b","\t":"\\t","\n":"\\n","\f":"\\f","\r":"\\r",'"':'\\"',"\\":"\\\\"},r;"function"!=typeof JSON.stringify&&(JSON.stringify=function(c,g,p){var n;v=k="";if("number"==typeof p)for(n=0;n<p;n+=1)v+=" ";else"string"==typeof p&&(v=p);r=g;if(!g||"function"==typeof g||"object"==typeof g&&"number"==typeof g.length)return j("",{"":c});throw Error("JSON.stringify");});"function"!=
+typeof JSON.parse&&(JSON.parse=function(c,g){function j(c,k){var i,e,l=c[k];if(l&&"object"==typeof l)for(i in l)Object.prototype.hasOwnProperty.call(l,i)&&(e=j(l,i),void 0!==e?l[i]=e:delete l[i]);return g.call(c,k,l)}var k,c=String(c);p.lastIndex=0;p.test(c)&&(c=c.replace(p,function(c){return"\\u"+("0000"+c.charCodeAt(0).toString(16)).slice(-4)}));if(/^[\],:{}\s]*$/.test(c.replace(/\\(?:["\\\/bfnrt]|u[0-9a-fA-F]{4})/g,"@").replace(/"[^"\\\n\r]*"|true|false|null|-?\d+(?:\.\d*)?(?:[eE][+\-]?\d+)?/g,
+"]").replace(/(?:^|:|,)(?:\s*\[)+/g,"")))return k=eval("("+c+")"),"function"==typeof g?j({"":k},""):k;throw new SyntaxError("JSON.parse");})})();
+SockJS=function(){var j=document,g=window,c={},p=function(){};p.prototype.addEventListener=function(a,b){this._listeners||(this._listeners={});a in this._listeners||(this._listeners[a]=[]);var f=this._listeners[a];-1===c.arrIndexOf(f,b)&&f.push(b)};p.prototype.removeEventListener=function(a,b){if(this._listeners&&a in this._listeners){var f=this._listeners[a],d=c.arrIndexOf(f,b);-1!==d&&(1<f.length?this._listeners[a]=f.slice(0,d).concat(f.slice(d+1)):delete this._listeners[a])}};p.prototype.dispatchEvent=
+function(a){var b=a.type,c=Array.prototype.slice.call(arguments,0);this["on"+b]&&this["on"+b].apply(this,c);if(this._listeners&&b in this._listeners)for(var d=0;d<this._listeners[b].length;d++)this._listeners[b][d].apply(this,c)};var n=function(a,b){this.type=a;if("undefined"!=typeof b)for(var c in b)b.hasOwnProperty(c)&&(this[c]=b[c])};n.prototype.toString=function(){var a=[],b;for(b in this)if(this.hasOwnProperty(b)){var c=this[b];"function"==typeof c&&(c="[function]");a.push(b+"="+c)}return"SimpleEvent("+
+a.join(", ")+")"};var k=function(a){this.events=a||[]};k.prototype.emit=function(a){var b=Array.prototype.slice.call(arguments,1);!this.nuked&&this["on"+a]&&this["on"+a].apply(this,b);-1===c.arrIndexOf(this.events,a)&&c.log("Event "+JSON.stringify(a)+" not listed "+JSON.stringify(this.events)+" in "+this)};k.prototype.nuke=function(){this.nuked=!0;for(var a=0;a<this.events.length;a++)delete this[this.events[a]]};c.random_string=function(a,b){var b=b||37,c,d=[];for(c=0;c<a;c++)d.push("abcdefghijklmnopqrstuvwxyz0123456789_".substr(Math.floor(Math.random()*
+b),1));return d.join("")};c.random_number=function(a){return Math.floor(Math.random()*a)};c.random_number_string=function(a){var b=(""+(a-1)).length;return(Array(b+1).join("0")+c.random_number(a)).slice(-b)};c.getOrigin=function(a){return(a+"/").split("/").slice(0,3).join("/")};c.isSameOriginUrl=function(a,b){return b||(b=g.location.href),a.split("/").slice(0,3).join("/")===b.split("/").slice(0,3).join("/")};c.getParentDomain=function(a){return/^[0-9.]*$/.test(a)||/^\[/.test(a)||!/[.]/.test(a)?a:
+a.split(".").slice(1).join(".")};c.objectExtend=function(a,b){for(var c in b)b.hasOwnProperty(c)&&(a[c]=b[c]);return a};c.polluteGlobalNamespace=function(){"_jp"in g||(g._jp={})};c.closeFrame=function(a,b){return"c"+JSON.stringify([a,b])};c.userSetCode=function(a){return 1E3===a||3E3<=a&&4999>=a};c.countRTO=function(a){var b;return 100<a?b=3*a:b=a+200,b};c.log=function(){g.console&&console.log&&console.log.apply&&console.log.apply(console,arguments)};c.bind=function(a,b){return a.bind?a.bind(b):function(){return a.apply(b,
+arguments)}};c.flatUrl=function(a){return-1===a.indexOf("?")&&-1===a.indexOf("#")};c.amendUrl=function(a){var b=j.location;if(!a)throw Error("Wrong url for SockJS");if(!c.flatUrl(a))throw Error("Only basic urls are supported in SockJS");return 0===a.indexOf("//")&&(a=b.protocol+a),0===a.indexOf("/")&&(a=b.protocol+"//"+b.host+a),a=a.replace(/[/]+$/,""),a};c.arrIndexOf=function(a,b){for(var c=0;c<a.length;c++)if(a[c]===b)return c;return-1};c.arrSkip=function(a,b){var f=c.arrIndexOf(a,b);return-1===
+f?a.slice():a.slice(0,f).concat(a.slice(f+1))};c.isArray=Array.isArray||function(a){return 0<={}.toString.call(a).indexOf("Array")};c.delay=function(a,b){return"function"==typeof a&&(b=a,a=0),setTimeout(b,a)};var v=/[\\\"\x00-\x1f\x7f-\x9f\u00ad\u0600-\u0604\u070f\u17b4\u17b5\u200c-\u200f\u2028-\u202f\u2060-\u206f\ufeff\ufff0-\uffff]/g,D={"\x00":"\\u0000","\u0001":"\\u0001","\u0002":"\\u0002","\u0003":"\\u0003","\u0004":"\\u0004","\u0005":"\\u0005","\u0006":"\\u0006","\u0007":"\\u0007","\b":"\\b",
+"\t":"\\t","\n":"\\n","\x0B":"\\u000b","\f":"\\f","\r":"\\r","\u000e":"\\u000e","\u000f":"\\u000f","\u0010":"\\u0010","\u0011":"\\u0011","\u0012":"\\u0012","\u0013":"\\u0013","\u0014":"\\u0014","\u0015":"\\u0015","\u0016":"\\u0016","\u0017":"\\u0017","\u0018":"\\u0018","\u0019":"\\u0019","\u001a":"\\u001a","\u001b":"\\u001b","\u001c":"\\u001c","\u001d":"\\u001d","\u001e":"\\u001e","\u001f":"\\u001f",'"':'\\"',"\\":"\\\\","\u007f":"\\u007f","\u0080":"\\u0080","\u0081":"\\u0081","\u0082":"\\u0082",
+"\u0083":"\\u0083","\u0084":"\\u0084","\u0085":"\\u0085","\u0086":"\\u0086","\u0087":"\\u0087","\u0088":"\\u0088","\u0089":"\\u0089","\u008a":"\\u008a","\u008b":"\\u008b","\u008c":"\\u008c","\u008d":"\\u008d","\u008e":"\\u008e","\u008f":"\\u008f","\u0090":"\\u0090","\u0091":"\\u0091","\u0092":"\\u0092","\u0093":"\\u0093","\u0094":"\\u0094","\u0095":"\\u0095","\u0096":"\\u0096","\u0097":"\\u0097","\u0098":"\\u0098","\u0099":"\\u0099","\u009a":"\\u009a","\u009b":"\\u009b","\u009c":"\\u009c","\u009d":"\\u009d",
+"\u009e":"\\u009e","\u009f":"\\u009f","\u00ad":"\\u00ad","\u0600":"\\u0600","\u0601":"\\u0601","\u0602":"\\u0602","\u0603":"\\u0603","\u0604":"\\u0604","\u070f":"\\u070f","\u17b4":"\\u17b4","\u17b5":"\\u17b5","\u200c":"\\u200c","\u200d":"\\u200d","\u200e":"\\u200e","\u200f":"\\u200f","\u2028":"\\u2028","\u2029":"\\u2029","\u202a":"\\u202a","\u202b":"\\u202b","\u202c":"\\u202c","\u202d":"\\u202d","\u202e":"\\u202e","\u202f":"\\u202f","\u2060":"\\u2060","\u2061":"\\u2061","\u2062":"\\u2062","\u2063":"\\u2063",
+"\u2064":"\\u2064","\u2065":"\\u2065","\u2066":"\\u2066","\u2067":"\\u2067","\u2068":"\\u2068","\u2069":"\\u2069","\u206a":"\\u206a","\u206b":"\\u206b","\u206c":"\\u206c","\u206d":"\\u206d","\u206e":"\\u206e","\u206f":"\\u206f","\ufeff":"\\ufeff","\ufff0":"\\ufff0","\ufff1":"\\ufff1","\ufff2":"\\ufff2","\ufff3":"\\ufff3","\ufff4":"\\ufff4","\ufff5":"\\ufff5","\ufff6":"\\ufff6","\ufff7":"\\ufff7","\ufff8":"\\ufff8","\ufff9":"\\ufff9","\ufffa":"\\ufffa","\ufffb":"\\ufffb","\ufffc":"\\ufffc","\ufffd":"\\ufffd",
+"\ufffe":"\\ufffe","\uffff":"\\uffff"},r=/[\x00-\x1f\ud800-\udfff\ufffe\uffff\u0300-\u0333\u033d-\u0346\u034a-\u034c\u0350-\u0352\u0357-\u0358\u035c-\u0362\u0374\u037e\u0387\u0591-\u05af\u05c4\u0610-\u0617\u0653-\u0654\u0657-\u065b\u065d-\u065e\u06df-\u06e2\u06eb-\u06ec\u0730\u0732-\u0733\u0735-\u0736\u073a\u073d\u073f-\u0741\u0743\u0745\u0747\u07eb-\u07f1\u0951\u0958-\u095f\u09dc-\u09dd\u09df\u0a33\u0a36\u0a59-\u0a5b\u0a5e\u0b5c-\u0b5d\u0e38-\u0e39\u0f43\u0f4d\u0f52\u0f57\u0f5c\u0f69\u0f72-\u0f76\u0f78\u0f80-\u0f83\u0f93\u0f9d\u0fa2\u0fa7\u0fac\u0fb9\u1939-\u193a\u1a17\u1b6b\u1cda-\u1cdb\u1dc0-\u1dcf\u1dfc\u1dfe\u1f71\u1f73\u1f75\u1f77\u1f79\u1f7b\u1f7d\u1fbb\u1fbe\u1fc9\u1fcb\u1fd3\u1fdb\u1fe3\u1feb\u1fee-\u1fef\u1ff9\u1ffb\u1ffd\u2000-\u2001\u20d0-\u20d1\u20d4-\u20d7\u20e7-\u20e9\u2126\u212a-\u212b\u2329-\u232a\u2adc\u302b-\u302c\uaab2-\uaab3\uf900-\ufa0d\ufa10\ufa12\ufa15-\ufa1e\ufa20\ufa22\ufa25-\ufa26\ufa2a-\ufa2d\ufa30-\ufa6d\ufa70-\ufad9\ufb1d\ufb1f\ufb2a-\ufb36\ufb38-\ufb3c\ufb3e\ufb40-\ufb41\ufb43-\ufb44\ufb46-\ufb4e\ufff0-\uffff]/g,
+B,M=JSON&&JSON.stringify||function(a){return v.lastIndex=0,v.test(a)&&(a=a.replace(v,function(a){return D[a]})),'"'+a+'"'};c.quote=function(a){a=M(a);r.lastIndex=0;if(r.test(a)){if(!B){var b,c={},d=[];for(b=0;65536>b;b++)d.push(String.fromCharCode(b));B=(r.lastIndex=0,d.join("").replace(r,function(a){return c[a]="\\u"+("0000"+a.charCodeAt(0).toString(16)).slice(-4),""}),r.lastIndex=0,c)}a=a.replace(r,function(a){return B[a]})}return a};var q="websocket xdr-streaming xhr-streaming iframe-eventsource iframe-htmlfile xdr-polling xhr-polling iframe-xhr-polling jsonp-polling".split(" ");
+c.probeProtocols=function(){for(var a={},b=0;b<q.length;b++){var c=q[b];a[c]=e[c]&&e[c].enabled()}return a};c.detectProtocols=function(a,b,c){var d={},h=[];b||(b=q);for(var m=0;m<b.length;m++){var g=b[m];d[g]=a[g]}var e=function(a){var b=a.shift();d[b]?h.push(b):0<a.length&&e(a)};return!1!==c.websocket&&e(["websocket"]),d["xhr-streaming"]&&!c.null_origin?h.push("xhr-streaming"):d["xdr-streaming"]&&!c.cookie_needed&&!c.null_origin?h.push("xdr-streaming"):e(["iframe-eventsource","iframe-htmlfile"]),
+d["xhr-polling"]&&!c.null_origin?h.push("xhr-polling"):d["xdr-polling"]&&!c.cookie_needed&&!c.null_origin?h.push("xdr-polling"):e(["iframe-xhr-polling","jsonp-polling"]),h};c.createHook=function(){var a="a"+c.random_string(8);if(!("_sockjs_global"in g)){var b={};g._sockjs_global=function(a){return a in b||(b[a]={id:a,del:function(){delete b[a]}}),b[a]}}return g._sockjs_global(a)};c.attachMessage=function(a){c.attachEvent("message",a)};c.attachEvent=function(a,b){"undefined"!=typeof g.addEventListener?
+g.addEventListener(a,b,!1):(j.attachEvent("on"+a,b),g.attachEvent("on"+a,b))};c.detachMessage=function(a){c.detachEvent("message",a)};c.detachEvent=function(a,b){"undefined"!=typeof g.addEventListener?g.removeEventListener(a,b,!1):(j.detachEvent("on"+a,b),g.detachEvent("on"+a,b))};var t={},C=!1,x=function(){for(var a in t)t[a](),delete t[a]},i=function(){C||(C=!0,x())};c.attachEvent("beforeunload",i);c.attachEvent("unload",i);c.unload_add=function(a){var b=c.random_string(8);return t[b]=a,C&&c.delay(x),
+b};c.unload_del=function(a){a in t&&delete t[a]};c.createIframe=function(a,b){var f=j.createElement("iframe"),d,h,m=function(){clearTimeout(d);try{f.onload=null}catch(a){}f.onerror=null},g=function(){f&&(m(),setTimeout(function(){f&&f.parentNode.removeChild(f);f=null},0),c.unload_del(h))};return f.src=a,f.style.display="none",f.style.position="absolute",f.onerror=function(){f&&(g(),b("onerror"))},f.onload=function(){clearTimeout(d);d=setTimeout(function(){f&&(g(),b("onload timeout"))},2E3)},j.body.appendChild(f),
+d=setTimeout(function(){f&&(g(),b("timeout"))},15E3),h=c.unload_add(g),{post:function(a,b){try{f&&f.contentWindow&&f.contentWindow.postMessage(a,b)}catch(c){}},cleanup:g,loaded:m}};c.createHtmlfile=function(a,b){var f=new ActiveXObject("htmlfile"),d,h,m,e=function(){clearTimeout(d)},j=function(){f&&(e(),c.unload_del(h),m.parentNode.removeChild(m),m=f=null,CollectGarbage())};f.open();f.write('<html><script>document.domain="'+document.domain+'";<\/script></html>');f.close();f.parentWindow._jp=g._jp;
+var i=f.createElement("div");return f.body.appendChild(i),m=f.createElement("iframe"),i.appendChild(m),m.src=a,d=setTimeout(function(){f&&(j(),b("timeout"))},15E3),h=c.unload_add(j),{post:function(a,b){try{m&&m.contentWindow&&m.contentWindow.postMessage(a,b)}catch(c){}},cleanup:j,loaded:e}};i=function(){};i.prototype=new k(["chunk","finish"]);i.prototype._start=function(a,b,f,d){var h=this;try{h.xhr=new XMLHttpRequest}catch(m){}if(!h.xhr)try{h.xhr=new g.ActiveXObject("Microsoft.XMLHTTP")}catch(e){}if(g.ActiveXObject||
+g.XDomainRequest)b+=(-1===b.indexOf("?")?"?":"&")+"t="+ +new Date;h.unload_ref=c.unload_add(function(){h._cleanup(!0)});try{h.xhr.open(a,b,!0)}catch(j){h.emit("finish",0,"");h._cleanup();return}if(!d||!d.no_credentials)h.xhr.withCredentials="true";if(d&&d.headers)for(var i in d.headers)h.xhr.setRequestHeader(i,d.headers[i]);h.xhr.onreadystatechange=function(){if(h.xhr){var a=h.xhr;switch(a.readyState){case 3:try{var b=a.status,c=a.responseText}catch(d){}c&&0<c.length&&h.emit("chunk",b,c);break;case 4:h.emit("finish",
+a.status,a.responseText),h._cleanup(!1)}}};h.xhr.send(f)};i.prototype._cleanup=function(a){if(this.xhr){c.unload_del(this.unload_ref);this.xhr.onreadystatechange=function(){};if(a)try{this.xhr.abort()}catch(b){}this.unload_ref=this.xhr=null}};i.prototype.close=function(){this.nuke();this._cleanup(!0)};(c.XHRCorsObject=function(){var a=this,b=arguments;c.delay(function(){a._start.apply(a,b)})}).prototype=new i;(c.XHRLocalObject=function(a,b,f){var d=this;c.delay(function(){d._start(a,b,f,{no_credentials:!0})})}).prototype=
+new i;i=c.XDRObject=function(a,b,f){var d=this;c.delay(function(){d._start(a,b,f)})};i.prototype=new k(["chunk","finish"]);i.prototype._start=function(a,b,f){var d=this,h=new XDomainRequest,b=b+((-1===b.indexOf("?")?"?":"&")+"t="+ +new Date),g=h.ontimeout=h.onerror=function(){d.emit("finish",0,"");d._cleanup(!1)};h.onprogress=function(){d.emit("chunk",200,h.responseText)};h.onload=function(){d.emit("finish",200,h.responseText);d._cleanup(!1)};d.xdr=h;d.unload_ref=c.unload_add(function(){d._cleanup(!0)});
+try{d.xdr.open(a,b),d.xdr.send(f)}catch(e){g()}};i.prototype._cleanup=function(a){if(this.xdr){c.unload_del(this.unload_ref);this.xdr.ontimeout=this.xdr.onerror=this.xdr.onprogress=this.xdr.onload=null;if(a)try{this.xdr.abort()}catch(b){}this.unload_ref=this.xdr=null}};i.prototype.close=function(){this.nuke();this._cleanup(!0)};c.isXHRCorsCapable=function(){return g.XMLHttpRequest&&"withCredentials"in new XMLHttpRequest?1:g.XDomainRequest&&j.domain?2:s.enabled()?3:4};var e=function(a,b,f){var d=this,
+h;d._options={devel:!1,debug:!1,protocols_whitelist:[],info:void 0,rtt:void 0};f&&c.objectExtend(d._options,f);d._base_url=c.amendUrl(a);d._server=d._options.server||c.random_number_string(1E3);d._options.protocols_whitelist&&d._options.protocols_whitelist.length?h=d._options.protocols_whitelist:("string"==typeof b&&0<b.length?h=[b]:c.isArray(b)?h=b:h=null,h&&d._debug('Deprecated API: Use "protocols_whitelist" option instead of supplying protocol list as a second parameter to SockJS constructor.'));
+d._protocols=[];d.protocol=null;d.readyState=e.CONNECTING;d._ir=N(d._base_url);d._ir.onfinish=function(a,b){d._ir=null;a?(d._options.info&&(a=c.objectExtend(a,d._options.info)),d._options.rtt&&(b=d._options.rtt),d._applyInfo(a,b,h),d._didClose()):d._didClose(1002,"Can't connect to server",!0)}};e.prototype=new p;e.version="0.3.2";e.CONNECTING=0;e.OPEN=1;e.CLOSING=2;e.CLOSED=3;e.prototype._debug=function(){this._options.debug&&c.log.apply(c,arguments)};e.prototype._dispatchOpen=function(){this.readyState===
+e.CONNECTING?(this._transport_tref&&(clearTimeout(this._transport_tref),this._transport_tref=null),this.readyState=e.OPEN,this.dispatchEvent(new n("open"))):this._didClose(1006,"Server lost session")};e.prototype._dispatchMessage=function(a){this.readyState===e.OPEN&&this.dispatchEvent(new n("message",{data:a}))};e.prototype._dispatchHeartbeat=function(){this.readyState===e.OPEN&&this.dispatchEvent(new n("heartbeat",{}))};e.prototype._didClose=function(a,b,f){var d=this;if(d.readyState!==e.CONNECTING&&
+d.readyState!==e.OPEN&&d.readyState!==e.CLOSING)throw Error("INVALID_STATE_ERR");d._ir&&(d._ir.nuke(),d._ir=null);d._transport&&(d._transport.doCleanup(),d._transport=null);var h=new n("close",{code:a,reason:b,wasClean:c.userSetCode(a)});if(!c.userSetCode(a)&&d.readyState===e.CONNECTING&&!f){if(d._try_next_protocol(h))return;h=new n("close",{code:2E3,reason:"All transports failed",wasClean:!1,last_event:h})}d.readyState=e.CLOSED;c.delay(function(){d.dispatchEvent(h)})};e.prototype._didMessage=function(a){switch(a.slice(0,
+1)){case "o":this._dispatchOpen();break;case "a":for(var a=JSON.parse(a.slice(1)||"[]"),b=0;b<a.length;b++)this._dispatchMessage(a[b]);break;case "m":a=JSON.parse(a.slice(1)||"null");this._dispatchMessage(a);break;case "c":a=JSON.parse(a.slice(1)||"[]");this._didClose(a[0],a[1]);break;case "h":this._dispatchHeartbeat()}};e.prototype._try_next_protocol=function(a){var b=this;b.protocol&&(b._debug("Closed transport:",b.protocol,""+a),b.protocol=null);for(b._transport_tref&&(clearTimeout(b._transport_tref),
+b._transport_tref=null);;){a=b.protocol=b._protocols.shift();if(!a)return!1;if(e[a]&&!0===e[a].need_body&&(!j.body||"undefined"!=typeof j.readyState&&"complete"!==j.readyState))return b._protocols.unshift(a),b.protocol="waiting-for-load",c.attachEvent("load",function(){b._try_next_protocol()}),!0;if(e[a]&&e[a].enabled(b._options)){b._transport_tref=c.delay((b._options.rto||0)*(e[a].roundTrips||1)||5E3,function(){b.readyState===e.CONNECTING&&b._didClose(2007,"Transport timeouted")});var f=c.random_string(8),
+f=b._base_url+"/"+b._server+"/"+f;return b._debug("Opening transport:",a," url:"+f," RTO:"+b._options.rto),b._transport=new e[a](b,f,b._base_url),!0}b._debug("Skipping transport:",a)}};e.prototype.close=function(a,b){if(a&&!c.userSetCode(a))throw Error("INVALID_ACCESS_ERR");return this.readyState!==e.CONNECTING&&this.readyState!==e.OPEN?!1:(this.readyState=e.CLOSING,this._didClose(a||1E3,b||"Normal closure"),!0)};e.prototype.send=function(a){if(this.readyState===e.CONNECTING)throw Error("INVALID_STATE_ERR");
+return this.readyState===e.OPEN&&this._transport.doSend(c.quote(""+a)),!0};e.prototype._applyInfo=function(a,b,f){this._options.info=a;this._options.rtt=b;this._options.rto=c.countRTO(b);this._options.info.null_origin=!j.domain;b=c.probeProtocols();this._protocols=c.detectProtocols(b,f,a)};i=e.websocket=function(a,b){var f=this,d=b+"/websocket";"https"===d.slice(0,5)?d="wss"+d.slice(5):d="ws"+d.slice(4);f.ri=a;f.url=d;f.ws=new (g.WebSocket||g.MozWebSocket)(f.url);f.ws.onmessage=function(a){f.ri._didMessage(a.data)};
+f.unload_ref=c.unload_add(function(){f.ws.close()});f.ws.onclose=function(){f.ri._didMessage(c.closeFrame(1006,"WebSocket connection broken"))}};i.prototype.doSend=function(a){this.ws.send("["+a+"]")};i.prototype.doCleanup=function(){var a=this.ws;a&&(a.onmessage=a.onclose=null,a.close(),c.unload_del(this.unload_ref),this.unload_ref=this.ri=this.ws=null)};i.enabled=function(){return!!g.WebSocket||!!g.MozWebSocket};i.roundTrips=2;var l=function(){};l.prototype.send_constructor=function(a){this.send_buffer=
+[];this.sender=a};l.prototype.doSend=function(a){this.send_buffer.push(a);this.send_stop||this.send_schedule()};l.prototype.send_schedule_wait=function(){var a=this,b;a.send_stop=function(){a.send_stop=null;clearTimeout(b)};b=c.delay(25,function(){a.send_stop=null;a.send_schedule()})};l.prototype.send_schedule=function(){var a=this;if(0<a.send_buffer.length){var b="["+a.send_buffer.join(",")+"]";a.send_stop=a.sender(a.trans_url,b,function(){a.send_stop=null;a.send_schedule_wait()});a.send_buffer=
+[]}};l.prototype.send_destructor=function(){this._send_stop&&this._send_stop();this._send_stop=null};var O=function(a,b,f){if(!("_send_form"in this)){var d=this._send_form=j.createElement("form"),h=this._send_area=j.createElement("textarea");h.name="d";d.style.display="none";d.style.position="absolute";d.method="POST";d.enctype="application/x-www-form-urlencoded";d.acceptCharset="UTF-8";d.appendChild(h);j.body.appendChild(d)}var d=this._send_form,h=this._send_area,g="a"+c.random_string(8);d.target=
+g;d.action=a+"/jsonp_send?i="+g;var e;try{e=j.createElement('<iframe name="'+g+'">')}catch(i){e=j.createElement("iframe"),e.name=g}e.id=g;d.appendChild(e);e.style.display="none";try{h.value=b}catch(k){c.log("Your browser is seriously broken. Go home! "+k.message)}d.submit();var l=function(){e.onerror&&(e.onreadystatechange=e.onerror=e.onload=null,c.delay(500,function(){e.parentNode.removeChild(e);e=null}),h.value="",f())};return e.onerror=e.onload=l,e.onreadystatechange=function(){"complete"==e.readyState&&
+l()},l},P=function(a){return function(b,c,d){return(new a("POST",b+"/xhr_send",c)).onfinish=function(a){d(a)},function(a){d(0,a)}}},i=e["jsonp-polling"]=function(a,b){c.polluteGlobalNamespace();this.ri=a;this.trans_url=b;this.send_constructor(O);this._schedule_recv()};i.prototype=new l;i.prototype._schedule_recv=function(){var a=this,b=a.trans_url+"/jsonp",f="a"+c.random_string(6),b=b+"?c="+escape("_jp."+f),d=function(b){delete g._jp[f];a._recv_stop=null;b&&(a._is_closing||a.ri._didMessage(b));a._is_closing||
+a._schedule_recv()},e,m=j.createElement("script"),i,k=function(a){i&&(i.parentNode.removeChild(i),i=null);m&&(clearTimeout(e),m.parentNode.removeChild(m),m.onreadystatechange=m.onerror=m.onload=m.onclick=null,m=null,d(a),d=null)},l=!1,p=null;m.id="a"+c.random_string(8);m.src=b;m.type="text/javascript";m.charset="UTF-8";m.onerror=function(){p||(p=setTimeout(function(){l||k(c.closeFrame(1006,"JSONP script loaded abnormally (onerror)"))},1E3))};m.onload=function(){k(c.closeFrame(1006,"JSONP script loaded abnormally (onload)"))};
+m.onreadystatechange=function(){if(/loaded|closed/.test(m.readyState)){if(m&&m.htmlFor&&m.onclick){l=!0;try{m.onclick()}catch(a){}}m&&k(c.closeFrame(1006,"JSONP script loaded abnormally (onreadystatechange)"))}};if("undefined"==typeof m.async&&j.attachEvent)if(/opera/i.test(navigator.userAgent))i=j.createElement("script"),i.text="try{var a = document.getElementById('"+m.id+"'); if(a)a.onerror();}catch(x){};",m.async=i.async=!1;else{try{m.htmlFor=m.id,m.event="onclick"}catch(n){}m.async=!0}"undefined"!=
+typeof m.async&&(m.async=!0);e=setTimeout(function(){k(c.closeFrame(1006,"JSONP script loaded abnormally (timeout)"))},35E3);b=j.getElementsByTagName("head")[0];b=(b.insertBefore(m,b.firstChild),i&&b.insertBefore(i,b.firstChild),k);g._jp[f]=b;a._recv_stop=function(){g._jp[f]&&g._jp[f](c.closeFrame(1E3,"JSONP user aborted read"))}};i.enabled=function(){return!0};i.need_body=!0;i.prototype.doCleanup=function(){this._is_closing=!0;this._recv_stop&&this._recv_stop();this.ri=this._recv_stop=null;this.send_destructor()};
+i=function(){};i.prototype=new l;i.prototype.run=function(a,b,c,d,e){this.ri=a;this.trans_url=b;this.send_constructor(P(e));this.poll=new E(a,d,b+c,e)};i.prototype.doCleanup=function(){this.poll&&(this.poll.abort(),this.poll=null)};var w=e["xhr-streaming"]=function(a,b){this.run(a,b,"/xhr_streaming",y,c.XHRCorsObject)};w.prototype=new i;w.enabled=function(){return g.XMLHttpRequest&&"withCredentials"in new XMLHttpRequest&&!/opera/i.test(navigator.userAgent)};w.roundTrips=2;w.need_body=!0;l=e["xdr-streaming"]=
+function(a,b){this.run(a,b,"/xhr_streaming",y,c.XDRObject)};l.prototype=new i;l.enabled=function(){return!!g.XDomainRequest};l.roundTrips=2;var F=e["xhr-polling"]=function(a,b){this.run(a,b,"/xhr",y,c.XHRCorsObject)};F.prototype=new i;F.enabled=w.enabled;F.roundTrips=2;w=e["xdr-polling"]=function(a,b){this.run(a,b,"/xhr",y,c.XDRObject)};w.prototype=new i;w.enabled=l.enabled;w.roundTrips=2;var s=function(){};s.prototype.i_constructor=function(a,b,f){var d=this;d.ri=a;d.origin=c.getOrigin(f);d.base_url=
+f;d.trans_url=b;a=f+"/iframe.html";d.ri._options.devel&&(a+="?t="+ +new Date);d.window_id=c.random_string(8);a+="#"+d.window_id;d.iframeObj=c.createIframe(a,function(a){d.ri._didClose(1006,"Unable to load an iframe ("+a+")")});d.onmessage_cb=c.bind(d.onmessage,d);c.attachMessage(d.onmessage_cb)};s.prototype.doCleanup=function(){if(this.iframeObj){c.detachMessage(this.onmessage_cb);try{this.iframeObj.iframe.contentWindow&&this.postMessage("c")}catch(a){}this.iframeObj.cleanup();this.onmessage_cb=this.iframeObj=
+this.iframeObj=null}};s.prototype.onmessage=function(a){if(a.origin===this.origin){var b=a.data.slice(0,8),c=a.data.slice(8,9),a=a.data.slice(9);if(b===this.window_id)switch(c){case "s":this.iframeObj.loaded();this.postMessage("s",JSON.stringify([e.version,this.protocol,this.trans_url,this.base_url]));break;case "t":this.ri._didMessage(a)}}};s.prototype.postMessage=function(a,b){this.iframeObj.post(this.window_id+a+(b||""),this.origin)};s.prototype.doSend=function(a){this.postMessage("m",a)};s.enabled=
+function(){var a=navigator&&navigator.userAgent&&-1!==navigator.userAgent.indexOf("Konqueror");return("function"==typeof g.postMessage||"object"==typeof g.postMessage)&&!a};var G,H=function(a,b){parent!==g?parent.postMessage(G+a+(b||""),"*"):c.log("Can't postMessage, no parent window.",a,b)},u=function(){};u.prototype._didClose=function(a,b){H("t",c.closeFrame(a,b))};u.prototype._didMessage=function(a){H("t",a)};u.prototype._doSend=function(a){this._transport.doSend(a)};u.prototype._doCleanup=function(){this._transport.doCleanup()};
+c.parent_origin=void 0;e.bootstrap_iframe=function(){var a;G=j.location.hash.slice(1);c.attachMessage(function(b){if(b.source===parent&&("undefined"==typeof c.parent_origin&&(c.parent_origin=b.origin),b.origin===c.parent_origin)){var f=b.data.slice(0,8),d=b.data.slice(8,9),b=b.data.slice(9);if(f===G)switch(d){case "s":var h=JSON.parse(b),f=h[0],d=h[1],b=h[2],h=h[3];f!==e.version&&c.log('Incompatibile SockJS! Main site uses: "'+f+'", the iframe: "'+e.version+'".');if(!c.flatUrl(b)||!c.flatUrl(h)){c.log("Only basic urls are supported in SockJS");
+break}if(!c.isSameOriginUrl(b)||!c.isSameOriginUrl(h)){c.log("Can't connect to different domain from within an iframe. ("+JSON.stringify([g.location.href,b,h])+")");break}a=new u;a._transport=new u[d](a,b,h);break;case "m":a._doSend(b);break;case "c":a&&a._doCleanup(),a=null}}});H("s")};var z=function(a,b){var f=this;c.delay(function(){f.doXhr(a,b)})};z.prototype=new k(["finish"]);z.prototype.doXhr=function(a,b){var f=this,d=(new Date).getTime(),e=new b("GET",a+"/info"),g=c.delay(8E3,function(){e.ontimeout()});
+e.onfinish=function(a,b){clearTimeout(g);g=null;if(200===a){var c=(new Date).getTime()-d,e=JSON.parse(b);"object"!=typeof e&&(e={});f.emit("finish",e,c)}else f.emit("finish")};e.ontimeout=function(){e.close();f.emit("finish")}};var K=function(a){var b=this,f=function(){var c=new s;c.protocol="w-iframe-info-receiver";var f=function(a){"string"==typeof a&&"m"===a.substr(0,1)?(a=JSON.parse(a.substr(1)),b.emit("finish",a[0],a[1])):b.emit("finish");c.doCleanup();c=null};c.i_constructor({_options:{},_didClose:f,
+_didMessage:f},a,a)};j.body?f():c.attachEvent("load",f)};K.prototype=new k(["finish"]);var L=function(){var a=this;c.delay(function(){a.emit("finish",{},2E3)})};L.prototype=new k(["finish"]);var N=function(a){if(c.isSameOriginUrl(a))return new z(a,c.XHRLocalObject);switch(c.isXHRCorsCapable()){case 1:return new z(a,c.XHRLocalObject);case 2:return new z(a,c.XDRObject);case 3:return new K(a);default:return new L}};(u["w-iframe-info-receiver"]=function(a,b,f){(new z(f,c.XHRLocalObject)).onfinish=function(b,
+c){a._didMessage("m"+JSON.stringify([b,c]));a._didClose()}}).prototype.doCleanup=function(){};k=e["iframe-eventsource"]=function(){this.protocol="w-iframe-eventsource";this.i_constructor.apply(this,arguments)};k.prototype=new s;k.enabled=function(){return"EventSource"in g&&s.enabled()};k.need_body=!0;k.roundTrips=3;(u["w-iframe-eventsource"]=function(a,b){this.run(a,b,"/eventsource",I,c.XHRLocalObject)}).prototype=new i;k=e["iframe-xhr-polling"]=function(){this.protocol="w-iframe-xhr-polling";this.i_constructor.apply(this,
+arguments)};k.prototype=new s;k.enabled=function(){return g.XMLHttpRequest&&s.enabled()};k.need_body=!0;k.roundTrips=3;(u["w-iframe-xhr-polling"]=function(a,b){this.run(a,b,"/xhr",y,c.XHRLocalObject)}).prototype=new i;k=e["iframe-htmlfile"]=function(){this.protocol="w-iframe-htmlfile";this.i_constructor.apply(this,arguments)};k.prototype=new s;k.enabled=function(){return s.enabled()};k.need_body=!0;k.roundTrips=3;(u["w-iframe-htmlfile"]=function(a,b){this.run(a,b,"/htmlfile",J,c.XHRLocalObject)}).prototype=
+new i;var E=function(a,b,c,d){this.ri=a;this.Receiver=b;this.recv_url=c;this.AjaxObject=d;this._scheduleRecv()};E.prototype._scheduleRecv=function(){var a=this,b=a.poll=new a.Receiver(a.recv_url,a.AjaxObject);b.onmessage=function(b){a.ri._didMessage(b.data)};b.onclose=function(c){a.poll=b=b.onmessage=b.onclose=null;a.poll_is_closing||("permanent"===c.reason?a.ri._didClose(1006,"Polling error ("+c.reason+")"):a._scheduleRecv())}};E.prototype.abort=function(){this.poll_is_closing=!0;this.poll&&this.poll.abort()};
+var I=function(a){var b=this,f=new EventSource(a);f.onmessage=function(a){b.dispatchEvent(new n("message",{data:unescape(a.data)}))};b.es_close=f.onerror=function(a,e){var g=e?"user":2!==f.readyState?"network":"permanent";b.es_close=f.onmessage=f.onerror=null;f.close();f=null;c.delay(200,function(){b.dispatchEvent(new n("close",{reason:g}))})}};I.prototype=new p;I.prototype.abort=function(){this.es_close&&this.es_close({},!0)};var A,J=function(a){var b=this;c.polluteGlobalNamespace();b.id="a"+c.random_string(6,
+26);a+=(-1===a.indexOf("?")?"?":"&")+"c="+escape("_jp."+b.id);if(void 0===A)if("ActiveXObject"in g)try{A=!!new ActiveXObject("htmlfile")}catch(f){}else A=!1;var d=A?c.createHtmlfile:c.createIframe,e;g._jp[b.id]={start:function(){e.loaded()},message:function(a){b.dispatchEvent(new n("message",{data:a}))},stop:function(){b.iframe_close({},"network")}};b.iframe_close=function(a,c){e.cleanup();b.iframe_close=e=null;delete g._jp[b.id];b.dispatchEvent(new n("close",{reason:c}))};e=d(a,function(){b.iframe_close({},
+"permanent")})};J.prototype=new p;J.prototype.abort=function(){this.iframe_close&&this.iframe_close({},"user")};var y=function(a,b){var c=this,d=0;c.xo=new b("POST",a,null);c.xo.onchunk=function(a,b){if(200===a)for(;;){var e=b.slice(d),g=e.indexOf("\n");if(-1===g)break;d+=g+1;e=e.slice(0,g);c.dispatchEvent(new n("message",{data:e}))}};c.xo.onfinish=function(a,b){c.xo.onchunk(a,b);c.xo=null;c.dispatchEvent(new n("close",{reason:200===a?"network":"permanent"}))}};return y.prototype=new p,y.prototype.abort=
+function(){this.xo&&(this.xo.close(),this.dispatchEvent(new n("close",{reason:"user"})),this.xo=null)},e.getUtils=function(){return c},e.getIframeTransport=function(){return s},e}();"_sockjs_onload"in window&&setTimeout(_sockjs_onload,1);"function"==typeof define&&define.amd&&define("sockjs",[],function(){return SockJS});function WebTCP(j,g){this.sockets={};this.httpClients={};this.sock=new SockJS("http://"+j+":"+g+"/bridge");this.ready=!1;this.outputBuffer=[];var c=this;this.sock.onopen=function(){c.ready=!0;c.processBuffer()};this.processBuffer=function(){if(0<this.outputBuffer.length&&this.ready)for(var c in this.outputBuffer)this.sock.send(this.outputBuffer[c])};this.sock.onmessage=function(g){g.data=JSON.parse(g.data);g.data.sID?(sID=g.data.sID,c.sockets[sID].onEvent(g.data.eventName,g.data.data)):g.data.cID&&
+(cID=g.data.cID,c.httpClients[cID].onEvent(g.data.eventName,g.data.data))};this.sock.onclose=function(){console.log("close")};this.createSocket=function(c,g,j){return new Socket(this,c,g,j)};this.createHTTPClient=function(){return new Http(this)}};function WebTCPIO(){this.onEvent=function(j,g){this["on"+j](g);if(this["on"+j+"Custom"])this["on"+j+"Custom"](g)};this.on=function(j,g){this["on"+j+"Custom"]=g};this.rpc=function(j,g){var c=this.createPacket();c.command=j;c.args=g;this.send(JSON.stringify(c));return c.id};this.write=function(j){var g=this.createPacket();g.data=j;this.send(JSON.stringify(g));return g.id};this.send=function(j){if(this.webtcp.ready)this.webtcp.sock.send(j);else{if(this.webtcp.outputBuffer>this.webtcp.BUFF_SIZE)throw"Output buffer is already full, but sockJS connection is not ready yet";
+this.webtcp.outputBuffer.push(j)}};this.onerror=function(j){throw j;}}; \ No newline at end of file
diff --git a/src/main/java/com/seaofnodes/simple/Ary.java b/src/main/java/com/seaofnodes/simple/Ary.java
index 8654d41e..b5184948 100644
--- a/src/main/java/com/seaofnodes/simple/Ary.java
+++ b/src/main/java/com/seaofnodes/simple/Ary.java
@@ -57,18 +57,6 @@ public class Ary<E> extends AbstractList<E> implements List<E> {
return true;
}
- ///** Slow, linear-time, element insert. Preserves order.
- // * @param i index to insert at, between 0 and _len inclusive.
- // * @param e Element to insert
- // */
- //public void insert( int i, E e ) {
- // if( i < 0 || i>_len )
- // throw new ArrayIndexOutOfBoundsException(""+i+" >= "+_len);
- // if( _len >= _es.length ) _es = Arrays.copyOf(_es,Math.max(1,_es.length<<1));
- // System.arraycopy(_es,i,_es,i+1,(_len++)-i);
- // _es[i] = e;
- //}
-
/** Fast, constant-time, element removal. Does not preserve order
* @param i element to be removed
* @return element removed */
@@ -79,20 +67,6 @@ public class Ary<E> extends AbstractList<E> implements List<E> {
return tmp;
}
- ///** Element removal, using '=='. Does not preserve order.
- // * @param e element to be removed
- // * @return element removed */
- //public E del( E e ) {
- // for( int i=0; i<_len; i++ ) {
- // E tmp = _es[i];
- // if( tmp==e ) {
- // _es[i]=_es[--_len];
- // return tmp;
- // }
- // }
- // return null;
- //}
-
/** Slow, linear-time, element removal. Preserves order.
* @param i element to be removed
* @return element removed */
@@ -129,6 +103,16 @@ public class Ary<E> extends AbstractList<E> implements List<E> {
return this;
}
+ public void swap( int i, int j ) {
+ range_check(i);
+ range_check(j);
+ if( i==j ) return;
+ E tmp = _es[i];
+ _es[i] = _es[j];
+ _es[j] = tmp;
+ }
+
+
/** @param c Collection to be added */
public boolean addAll( Collection<? extends E> c ) {
if( c==null ) return false;
diff --git a/src/main/java/com/seaofnodes/simple/CodeGen.java b/src/main/java/com/seaofnodes/simple/CodeGen.java
new file mode 100644
index 00000000..864b3a1a
--- /dev/null
+++ b/src/main/java/com/seaofnodes/simple/CodeGen.java
@@ -0,0 +1,137 @@
+ package com.seaofnodes.simple;
+
+import com.seaofnodes.graph.GraphObserver;
+
+import com.seaofnodes.simple.node.*;
+import com.seaofnodes.simple.type.*;
+import java.util.HashMap;
+
+public class CodeGen {
+ public GraphObserver<Node> _obs;
+
+ // Inlining can insert CFG edges and invalidate cached depth ordering.
+ private char _iDepthVersion;
+ public char iDepthVersion() { return _iDepthVersion; }
+ public void invalidateIDepthCaches() {
+ assert _iDepthVersion < Character.MAX_VALUE : "Dominator cache version exceeds 65535";
+ ++_iDepthVersion;
+ }
+
+
+
+ public enum Phase {
+ Parse, Opto, TypeCheck, Schedule, LocalSched, RegAlloc;
+ }
+ public Phase _phase;
+
+ public final String _src;
+ // Compile-time known initial argument type
+ public final TypeInteger _arg;
+
+ public Parser P;
+ public StartNode _start;
+ public StopNode _stop ;
+
+
+ // "Linker" mapping from constant TypeFunPtrs to heads of function. These
+ // TFPs all have exact single fidxs and their return is wiped to BOTTOM (so
+ // the return is not part of the match).
+ private final HashMap<TypeFunPtr,FunNode> _linker = new HashMap<>();
+
+
+ // Last created CodeGen as a global, for easier debugging prints
+ public static CodeGen CODE;
+
+ CodeGen( String src, TypeInteger arg ) { _phase = null; _src = src; _arg=arg; CODE=this; }
+ public CodeGen( String src ) { this(src,TypeInteger.BOT); }
+
+ public CodeGen parse() {
+ assert _phase == null;
+ _phase = Phase.Parse;
+ _linker.clear();
+
+ P = new Parser(_src,_arg);
+ _stop = P.parse();
+ _start = Parser.START; // Capture global start
+ if( _obs != null ) _obs.phase("Parse");
+ P = null; // No longer parsing
+ return this;
+ }
+
+ public CodeGen opto() {
+ assert _phase == Phase.Parse;
+ _phase = Phase.Opto;
+
+ // Optimization
+ IterPeeps.iterate(_stop);
+
+ // TODO:
+ // Optimistic
+ if( _obs != null ) _obs.phase("Opto");
+ return this;
+ }
+
+ public CodeGen typeCheck() {
+ // Demand phase Opto for cleaning up dead control flow at least,
+ // required for the following GCM.
+ assert _phase == Phase.Opto;
+ _phase = Phase.TypeCheck;
+
+ // Type check
+ Parser.ParseException err = _stop.walk(n -> {
+ Parser.ParseException msg = n.err();
+ if( msg != null && _obs != null ) _obs.error(n, msg.getMessage());
+ return msg;
+ });
+ if( err != null )
+ throw err;
+ if( _obs != null ) _obs.phase("TypeCheck");
+ return this;
+ }
+
+
+ public CodeGen GCM() {
+ assert _phase == Phase.TypeCheck;
+ _phase = Phase.Schedule;
+
+ // Build the loop tree, fix never-exit loops
+ _start.buildLoopTree(_stop);
+
+
+ // TODO:
+ // loop unroll, peel, RCE, etc
+ GlobalCodeMotion.buildCFG(_start,_stop);
+ return this;
+ }
+
+ // Local (basic block) scheduler phase, a classic list scheduler
+ public CodeGen localSched() {
+ assert _phase == Phase.Schedule;
+ _phase = Phase.LocalSched;
+ ListScheduler.sched(this);
+ return this;
+ }
+
+ // Reverse from a constant function pointer to the IR function being called
+ public FunNode link( TypeFunPtr tfp ) {
+ assert tfp.isConstant();
+ return _linker.get(tfp.makeFrom(Type.BOTTOM));
+ }
+
+ public void link(FunNode fun) {
+ _linker.put(fun.sig().makeFrom(Type.BOTTOM),fun);
+ }
+
+ // Testing shortcuts
+ Node ctrl() { return _stop.ret().ctrl(); }
+ Node expr() { return _stop.ret().expr(); }
+ String print() { return _stop.print(); }
+
+ // Debugging helper
+ @Override public String toString() {
+ return IRPrinter.prettyPrint(this);
+ }
+
+ // Debugging helper
+ public Node f(int idx) { return _stop.find(idx); }
+}
diff --git a/src/main/java/com/seaofnodes/simple/GlobalCodeMotion.java b/src/main/java/com/seaofnodes/simple/GlobalCodeMotion.java
index eba99128..8221ede1 100644
--- a/src/main/java/com/seaofnodes/simple/GlobalCodeMotion.java
+++ b/src/main/java/com/seaofnodes/simple/GlobalCodeMotion.java
@@ -10,10 +10,60 @@ public abstract class GlobalCodeMotion {
// Arrange that the existing isCFG() Nodes form a valid CFG. The
// Node.use(0) is always a block tail (either IfNode or head of the
// following block). There are no unreachable infinite loops.
- public static void buildCFG( StopNode stop ) {
- schedEarly();
- Parser.SCHEDULED = true;
- schedLate( stop);
+ public static void buildCFG( StartNode start, StopNode stop ) {
+ schedEarly(start);
+ breakUpGlobalConstants(start);
+ schedLate(stop);
+ }
+
+
+ // After early scheduling, every global chain member has Start in slot 0.
+ // Give each function one private copy of the entire dependency graph.
+ private static void breakUpGlobalConstants( StartNode start ) {
+ var globals = new IdentityHashMap<Node,Boolean>();
+ var cons = new ArrayList<Node>();
+ for( Node con : start._outputs )
+ if( con!=null && !(con instanceof CFGNode) &&
+ con.isConst() ) {
+ globals.put(con,true);
+ cons.add(con.keep()); // Preserve original inputs while rewiring users.
+ }
+
+ var copies = new IdentityHashMap<FunNode,IdentityHashMap<Node,Node>>();
+ for( Node con : cons )
+ for( Node use : con._outputs.asAry() ) {
+ if( use==null || globals.containsKey(use) ) continue;
+ for( int i=0; i<use.nIns(); i++ ) {
+ if( use.in(i)!=con ) continue;
+ FunNode fun = useFun(use,i);
+ if( fun==null ) continue; // Unknown-caller types stay global.
+ var local = copies.computeIfAbsent(fun,f -> new IdentityHashMap<>());
+ use.setDef(i,cloneGlobal(con,fun,globals,local));
+ }
+ }
+ for( Node con : cons ) con.unkill();
+ }
+
+ private static Node cloneGlobal(Node con, FunNode fun, IdentityHashMap<Node,Boolean> globals,
+ IdentityHashMap<Node,Node> copies) {
+ Node copy = copies.get(con);
+ if( copy!=null ) return copy;
+ copies.put(con,copy=con.copyEmpty());
+ copy.addDef(fun);
+ for( int i=1; i<con.nIns(); i++ ) {
+ Node def = con.in(i);
+ copy.addDef(globals.containsKey(def) ? cloneGlobal(def,fun,globals,copies) : def);
+ }
+ return copy;
+ }
+
+ private static FunNode useFun(Node use, int idx) {
+ if( use instanceof ReturnNode ret ) return ret.fun();
+ // Calls are still linked: a Parm input is evaluated in its caller.
+ CFGNode cfg = use instanceof ParmNode parm ? parm.fun().cfg(idx) : use.cfg0();
+ while( cfg!=null && !(cfg instanceof FunNode) )
+ cfg = cfg.idom();
+ return (FunNode)cfg;
}
@@ -22,10 +72,10 @@ public abstract class GlobalCodeMotion {
// (except at loops). Since defs are visited first - and hoisted as early
// as possible, when we come to a use we place it just after its deepest
// input.
- private static void schedEarly() {
+ private static void schedEarly(StartNode start) {
ArrayList<CFGNode> rpo = new ArrayList<>();
BitSet visit = new BitSet();
- _rpo_cfg(Parser.START, visit, rpo);
+ _rpo_cfg(null, start, visit, rpo);
// Reverse Post-Order on CFG
for( int j=rpo.size()-1; j>=0; j-- ) {
CFGNode cfg = rpo.get(j);
@@ -43,12 +93,14 @@ public abstract class GlobalCodeMotion {
}
// Post-Order of CFG
- private static void _rpo_cfg(Node n, BitSet visit, ArrayList<CFGNode> rpo) {
- if( !(n instanceof CFGNode cfg) || visit.get(cfg._nid) )
+ private static void _rpo_cfg(CFGNode def, Node use, BitSet visit, ArrayList<CFGNode> rpo) {
+ if( !(use instanceof CFGNode cfg) || visit.get(cfg._nid) )
return; // Been there, done that
+ if( def instanceof CallNode && cfg instanceof FunNode )
+ return; // Ignore linked function calls
visit.set(cfg._nid);
- for( Node use : cfg._outputs )
- _rpo_cfg(use,visit,rpo);
+ for( Node useuse : cfg._outputs )
+ _rpo_cfg(cfg,useuse,visit,rpo);
rpo.add(cfg);
}
@@ -166,6 +218,7 @@ public abstract class GlobalCodeMotion {
for( int i=1; i<phi.nIns(); i++ )
if( phi.in(i)==n )
found = phi.region().cfg(i).domLCA(found,null); // Can be more than one matching input.
+
assert found!=null;
return found;
}
@@ -202,7 +255,7 @@ public abstract class GlobalCodeMotion {
assert late[st._nid]!=null;
lca = anti_dep(load,late[st._nid],st.cfg0(),lca,st,anti);
break;
- case NewNode st:
+ case CallNode st:
assert late[st._nid]!=null;
lca = anti_dep(load,late[st._nid],st.cfg0(),lca,st,anti);
break;
@@ -213,6 +266,10 @@ public abstract class GlobalCodeMotion {
if( phi.in(i)==load.mem() )
lca = anti_dep(load,phi.region().cfg(i),load.mem().cfg0(),lca,null,anti);
break;
+ case NewNode st:
+ assert late[st._nid]!=null;
+ lca = anti_dep(load,late[st._nid],st.cfg0(),lca,st,anti);
+ break;
default: throw Utils.TODO();
}
}
@@ -221,14 +278,12 @@ public abstract class GlobalCodeMotion {
//
private static CFGNode anti_dep( LoadNode load, CFGNode stblk, CFGNode defblk, CFGNode lca, Node st, int[] anti ) {
- // Preserve the full store range for the earlier evaluator scheduler.
- // It places nodes independently of GCM and may hoist this store.
for( ; stblk != defblk.idom(); stblk = stblk.idom() ) {
// Store and Load overlap, need anti-dependence
if( anti[stblk._nid]==load._nid ) {
lca = stblk.domLCA(lca,null); // Raise Loads LCA
- if( lca == stblk && st != null && st._inputs.find(load) == -1 ) // And if something moved,
- st.addDef(load); // Add anti-dep as well
+ if( lca == stblk && st != null && !(st instanceof CallNode) && st._inputs.find(load) == -1 ) // And if something moved,
+ st.addDef(load); // Add anti-dep as well; Calls already end their block.
return lca; // Cap this stores' anti-dep to here
}
}
diff --git a/src/main/java/com/seaofnodes/simple/IRPrinter.java b/src/main/java/com/seaofnodes/simple/IRPrinter.java
index 7e93e9da..c7ca8cf4 100644
--- a/src/main/java/com/seaofnodes/simple/IRPrinter.java
+++ b/src/main/java/com/seaofnodes/simple/IRPrinter.java
@@ -2,6 +2,9 @@ package com.seaofnodes.simple;
import com.seaofnodes.print.IRAdapter;
import com.seaofnodes.simple.node.*;
+import java.util.ArrayList;
+import com.seaofnodes.simple.SB;
+import com.seaofnodes.simple.CodeGen;
/** This chapter's read-only IR facts and the familiar debugger entry points. */
public final class IRPrinter extends IRAdapter<Node> {
@@ -12,9 +15,13 @@ public final class IRPrinter extends IRAdapter<Node> {
@Override public Kind kind(Node n) {
if( n instanceof StartNode ) return Kind.START;
if( n instanceof StopNode ) return Kind.STOP;
+ if( n instanceof FunNode ) return Kind.FUN;
if( n instanceof LoopNode ) return Kind.LOOP;
if( n instanceof RegionNode ) return Kind.REGION;
+ if( n instanceof ParmNode ) return Kind.PARM;
if( n instanceof PhiNode ) return Kind.PHI;
+ if( n instanceof CallEndNode ) return Kind.CALL_END;
+ if( n instanceof CallNode ) return Kind.CALL;
if( n instanceof ReturnNode ) return Kind.RETURN;
if( n instanceof ConstantNode ) return Kind.CONSTANT;
if( n instanceof CProjNode ) return Kind.CPROJ;
@@ -28,6 +35,20 @@ public final class IRPrinter extends IRAdapter<Node> {
if( n instanceof CProjNode p ) return p._idx;
return n._nid;
}
+ @Override public String functionName(Node n) { return n.label(); }
+ @Override public String signature(Node n) {
+ FunNode fun=(FunNode)n;
+ return fun.sig().str();
+ }
public static String prettyPrint(Node n, int depth) { return PRINT.prettyPrint(n,depth); }
+ public static SB printLine(Node n, SB sb) { return sb.p(PRINT.line(n)); }
+
+ public static String prettyPrint(CodeGen code) {
+ var units=new ArrayList<com.seaofnodes.print.IRPrinter.Unit<Node>>();
+ var funs=new ArrayList<Node>();
+ for( Node n : code._start._outputs ) if( n instanceof FunNode ) funs.add(n);
+ units.add(new com.seaofnodes.print.IRPrinter.Unit<>(null,null,null,funs));
+ return PRINT.program(code._start,code._stop,units);
+ }
}
diff --git a/src/main/java/com/seaofnodes/simple/IterPeeps.java b/src/main/java/com/seaofnodes/simple/IterPeeps.java
index 5a80698a..1792dada 100644
--- a/src/main/java/com/seaofnodes/simple/IterPeeps.java
+++ b/src/main/java/com/seaofnodes/simple/IterPeeps.java
@@ -57,7 +57,7 @@ public abstract class IterPeeps {
/**
* Iterate peepholes to a fixed point
*/
- public static StopNode iterate(StopNode stop) {
+ public static void iterate( StopNode stop) {
assert progressOnList(stop);
int cnt=0;
@@ -65,7 +65,7 @@ public abstract class IterPeeps {
while( (n=WORK.pop()) != null ) {
if( n.isDead() ) continue;
cnt++; // Useful for debugging, searching which peephole broke things
- var obs = Parser.PARSER == null ? null : Parser.PARSER._obs;
+ var obs = CodeGen.CODE == null ? null : CodeGen.CODE._obs;
if( obs != null ) obs.before(n);
Node x = n.peepholeOpt();
if( x != null ) {
@@ -98,7 +98,6 @@ public abstract class IterPeeps {
if( obs != null ) obs.after(n, x, true);
}
- return stop;
}
// Visit ALL nodes and confirm the invariant:
@@ -120,7 +119,7 @@ public abstract class IterPeeps {
int old_cnt = Node.ITER_CNT, old_nop = Node.ITER_NOP_CNT;
Node changed = stop.walk( n -> {
Node m = n;
- if( n.compute().isa(n._type) && (!n.iskeep() || n._nid<=5) ) { // Types must be forwards, even if on worklist
+ if( n.compute().isa(n._type) && (!n.iskeep() || n._nid<=6) ) { // Types must be forwards, even if on worklist
if( WORK.on(n) ) return null;
m = n.peepholeOpt();
if( m==null ) return null;
@@ -188,6 +187,7 @@ public abstract class IterPeeps {
* True if Node is on the WorkList
*/
boolean on( E x ) { return _on.get(x._nid); }
+ boolean isEmpty() { return _len==0; }
/**
* Removes a random Node from the WorkList; null if WorkList is empty
diff --git a/src/main/java/com/seaofnodes/simple/ListScheduler.java b/src/main/java/com/seaofnodes/simple/ListScheduler.java
new file mode 100644
index 00000000..252a8f8e
--- /dev/null
+++ b/src/main/java/com/seaofnodes/simple/ListScheduler.java
@@ -0,0 +1,110 @@
+ package com.seaofnodes.simple;
+
+import com.seaofnodes.simple.IterPeeps.WorkList;
+import com.seaofnodes.simple.node.*;
+import com.seaofnodes.simple.type.*;
+import java.util.*;
+
+public abstract class ListScheduler {
+
+ private static final BitSet VISIT = new BitSet();
+ private static int[] BCNTS;
+ public static void sched( CodeGen code ) {
+ assert VISIT.isEmpty();
+ BCNTS = new int[Node.UID()];
+ walk(code._start,VISIT);
+ VISIT.clear();
+ }
+
+ // Visit all CFG nodes
+ static void walk( CFGNode cfg, BitSet visit ) {
+ if( visit.get(cfg._nid) ) return;
+ visit.set(cfg._nid);
+ local(cfg);
+ for( Node n : cfg._outputs )
+ if( n instanceof CFGNode c )
+ walk(c,visit);
+ }
+
+ // Local schedule this one CFG
+ static void local( CFGNode bb ) {
+ if( !bb.blockHead() || bb instanceof StopNode ) return;
+ Node[] uses = bb._outputs._es;
+ int ulen = bb._outputs._len;
+
+ // Count block-locals
+ for( int i=0; i<ulen; i++ ) {
+ Node use = uses[i];
+ if( use.in(0)==bb && !(use instanceof PhiNode) ) {
+ // Normal basic block member: in(0)==bb and not a Phi
+ for( Node def : use._inputs )
+ // Has defs from same block? Then block-local inputs
+ if( def != null && def.cfg0()==bb ) // Same block?
+ BCNTS[use._nid]++; // Raise block-local input count
+ }
+ }
+
+ // Nodes are ready if they are not used by other nodes in this block.
+ // Move ready up front. We will never look at remaining nodes, later
+ // nodes are found by looking at users of ready nodes.
+ int ready = 0;
+ for( int i=0; i<ulen; i++ )
+ if( BCNTS[uses[i]._nid]==0 ) // No block-local inputs?
+ uses[ready++] = uses[i]; // Move into ready set
+ assert ready > 0;
+
+ // Classic list scheduler. Behind sched is scheduled. Between sched
+ // and ready have zero counts and are ready to schedule. Ahead of
+ // ready is undefined.
+ //
+ // As nodes are scheduled, the nodes they use decrement their _bcnt. Once
+ // that gets to 0, all the nodes using it are scheduled, so it's ready.
+ int sched = 0;
+ while( sched < ulen ) {
+ assert sched < ready : "Scheduling nodes that are not ready. Probably due to duplicate nodes in the user list.";
+ int pick = best(uses, sched,ready); // Pick best
+ Node best = uses[pick]; // Swap best to head of ready
+ uses[pick] = uses[sched];
+ uses[sched++] = best; // And move it into the scheduled set
+ // Lower ready count of users
+ for( Node use : best._outputs )
+ if( use instanceof ProjNode ) {
+ for( Node useuse : use._outputs )
+ ready = ready(bb,useuse,ready);
+ } else
+ ready = ready(bb, use,ready);
+ }
+ }
+
+ private static int ready(CFGNode bb, Node use, int ready) {
+ if( use != null && use.in(0)==bb && !(use instanceof PhiNode) ) {
+ assert BCNTS[use._nid] >= 1;
+ if( --BCNTS[use._nid] == 0 )
+ bb._outputs._es[ready++] = use; // Became ready, move into ready set
+ }
+ return ready;
+ }
+
+
+ // Pick best between sched and ready.
+ private static int best( Node[] uses, int sched, int ready ) {
+ int pick = sched;
+ int score = score(uses[pick]);
+ for( int i=sched+1; i<ready; i++ ) {
+ int nscore = score(uses[i]);
+ if( nscore > score )
+ { score = nscore; pick = i; }
+ }
+ return pick;
+ }
+
+ // Highest score wins. Max at 1000, min at 10, except specials.
+ private static int score( Node n ) {
+ if( n.isMultiTail() ) return 1001; // Pinned just behind the multi-head
+ if( n instanceof CFGNode ) return n instanceof ReturnNode ? 2 : 1; // Pinned at block exit
+
+ // Nothing special
+ return 500;
+ }
+
+}
diff --git a/src/main/java/com/seaofnodes/simple/Parser.java b/src/main/java/com/seaofnodes/simple/Parser.java
index c02f0305..82ad8d04 100644
--- a/src/main/java/com/seaofnodes/simple/Parser.java
+++ b/src/main/java/com/seaofnodes/simple/Parser.java
@@ -1,10 +1,7 @@
package com.seaofnodes.simple;
-import com.seaofnodes.graph.GraphObserver;
-
import com.seaofnodes.simple.node.*;
import com.seaofnodes.simple.type.*;
-
import java.util.*;
/**
@@ -16,12 +13,6 @@ import java.util.*;
*/
public class Parser {
- // Current compilation context; the observer belongs to the parser.
- public static Parser PARSER;
- public GraphObserver<Node> _obs;
- public int pos() { return _lexer._position; }
-
-
/**
* A Global Static, unique to each compilation. This is a public, so we
* can make constants everywhere without having to thread the StartNode
@@ -32,6 +23,7 @@ public class Parser {
public static StartNode START;
public static ConstantNode ZERO; // Very common node, cached here
+ public static ConstantNode NIL; // Very common node, cached here
public static XCtrlNode XCTRL; // Very common node, cached here
// Next available memory alias number
@@ -39,9 +31,6 @@ public class Parser {
public StopNode STOP;
- // Debugger Printing.
- public static boolean SCHEDULED; // True if debug printer can use schedule info
-
// The Lexer. Thin wrapper over a byte[] buffer with a cursor.
private final Lexer _lexer;
@@ -90,7 +79,6 @@ public class Parser {
add("while");
}};
-
/**
* We clone ScopeNodes when control flows branch; it is useful to have
* a list of all active ScopeNodes for purposes of visualization of the SoN graph
@@ -99,6 +87,7 @@ public class Parser {
ScopeNode _continueScope;
ScopeNode _breakScope; // Merge all the while-breaks here
+ FunNode _fun; // Current function being parsed
// Mapping from a type name to a Type. The string name matches
// `type.str()` call. No TypeMemPtrs are in here, because Simple does not
@@ -109,27 +98,25 @@ public class Parser {
public final HashMap<String, StructNode> INITS;
+ public Parser(String source) { this(source, TypeInteger.BOT); }
+
public Parser(String source, TypeInteger arg) {
- PARSER = this;
Node.reset();
IterPeeps.reset();
- SCHEDULED = false;
+ Type.reset();
_lexer = new Lexer(source);
_scope = new ScopeNode();
_continueScope = _breakScope = null;
START = new StartNode(arg);
STOP = new StopNode(source);
- ZERO = con(0).keep();
+ ZERO = con(TypeInteger.ZERO).keep();
+ NIL = con(Type.NIL).keep();
XCTRL= new XCtrlNode().peephole().keep();
ALIAS = 2; // alias 0 for the control, 1 for memory
TYPES = defaultTypes();
INITS = new HashMap<>();
}
- public Parser(String source) {
- this(source, TypeInteger.BOT);
- }
-
@Override
public String toString() { return _lexer.toString(); }
@@ -137,9 +124,9 @@ public class Parser {
return new HashMap<>() {{
put("bool",TypeInteger.U1 );
put("byte",TypeInteger.U8 );
- put("f32" ,TypeFloat .B32);
- put("f64" ,TypeFloat .BOT);
- put("flt" ,TypeFloat .BOT);
+ put("f32" ,TypeFloat .F32);
+ put("f64" ,TypeFloat .F64);
+ put("flt" ,TypeFloat .F64);
put("i16" ,TypeInteger.I16);
put("i32" ,TypeInteger.I32);
put("i64" ,TypeInteger.BOT);
@@ -162,28 +149,111 @@ public class Parser {
public StopNode parse() {
_xScopes.push(_scope);
- // Enter a new scope for the initial control and arguments
- _scope.push();
- _scope.define(ScopeNode.CTRL, Type.CONTROL , false, new CProjNode(START, 0, ScopeNode.CTRL).peephole());
- _scope.define(ScopeNode.MEM0, TypeMem.BOT , false, new ProjNode(START, 1, ScopeNode.MEM0).peephole());
- _scope.define(ScopeNode.ARG0, TypeInteger.BOT, false, new ProjNode(START, 2, ScopeNode.ARG0).peephole());
+ _scope.define(ScopeNode.CTRL, Type.CONTROL , false, null, _lexer);
+ _scope.define(ScopeNode.MEM0, TypeMem.BOT , false, null, _lexer);
+ _scope.define(ScopeNode.ARG0, TypeInteger.BOT, false, null, _lexer);
- // Parse whole program
- parseBlock(false);
+ ctrl(XCTRL);
+ _scope.mem(con(TypeMem.BOT));
- if( ctrl()._type==Type.CONTROL )
- STOP.addReturn(new ReturnNode(ctrl(), ZERO, _scope).peephole());
- _scope.kill();
+ // Parse whole program, as-if function header "{ int arg -> body }"
+ parseFunctionBody(TypeFunPtr.MAIN,loc(),"arg");
+
+ if( !_lexer.isEOF() ) throw _errorSyntax("unexpected");
+
+ // Clean up and reset
_xScopes.pop();
+ _scope.kill();
for( StructNode init : INITS.values() )
init.unkeep().kill();
INITS.clear();
- if (!_lexer.isEOF()) throw error("Syntax error, unexpected " + _lexer.getAnyNextToken());
STOP.peephole();
return STOP;
}
/**
+ * Parses a function body, assuming the header is parsed.
+ */
+ private ReturnNode parseFunctionBody(TypeFunPtr sig, Lexer loc, String... ids) {
+ return parseFunctionBody(sig, loc, null, ids);
+ }
+
+ private ReturnNode parseFunctionBody(TypeFunPtr sig, Lexer loc, java.util.BitSet finals, String... ids) {
+ // Stack parser state on the local Java stack, and unstack it later
+ Node oldctrl = ctrl().keep();
+ Node oldmem = _scope.mem().keep();
+ FunNode oldfun = _fun;
+ ScopeNode breakScope = _breakScope; _breakScope = null;
+ ScopeNode continueScope = _continueScope; _continueScope = null;
+
+ FunNode fun = _fun = (FunNode)peep(new FunNode(loc(),START,sig));
+ // Once the function header is available, install in linker table -
+ // allowing recursive functions. Linker matches on declared args and
+ // exact fidx, and ignores the return (because the fidx will only match
+ // the exact single function).
+ CodeGen.CODE.link(fun);
+
+ Node rpc = new ParmNode("$rpc",0,TypeRPC.BOT,fun,con(TypeRPC.BOT)).peephole();
+
+ // Build a multi-exit return point for all function returns
+ RegionNode r = new RegionNode((Node)null,null).init();
+ assert r.inProgress();
+ PhiNode rmem = new BulkMemPhiNode(ScopeNode.MEM0,r,null).init();
+ PhiNode rrez = new PhiNode(ScopeNode.ARG0,Type.BOTTOM,r,null).init();
+ ReturnNode ret = new ReturnNode(r, rmem, rrez, rpc, fun).init();
+ fun.setRet(ret);
+ assert ret.inProgress();
+ STOP.addDef(ret);
+
+ // Pre-call the function from Start, with worse-case arguments. This
+ // represents all the future, yet-to-be-parsed functions calls and
+ // external calls.
+ _scope.push(ScopeNode.Kind.Function);
+ ctrl(fun); // Scope control from function
+ // Unknown callers supply whole memory; field aliases are discovered lazily.
+ _scope.mem(new ParmNode(ScopeNode.MEM0,1,TypeMem.BOT,fun,con(TypeMem.BOT)).peephole());
+ // All args, "as-if" called externally
+ for( int i=0; i<ids.length; i++ ) {
+ Type t = sig.arg(i);
+ _scope.define(ids[i], t, finals==null ? t instanceof TypeNil : finals.get(i), new ParmNode(ids[i],i+2,t,fun,con(t)).peephole(), loc);
+ }
+
+ // Parse the body
+ Node last=ZERO;
+ while (!peek('}') && !_lexer.isEOF())
+ last = parseStatement();
+
+ // Last expression is the return
+ if( ctrl()._type==Type.CONTROL )
+ fun.addReturn(ctrl(), _scope.mem(), last);
+
+ // Pop off the inProgress node on the multi-exit Region merge
+ assert r.inProgress();
+ r ._inputs.pop();
+ rmem._inputs.pop();
+ rrez._inputs.pop();
+ r._loc = loc(); // Final position
+ assert !r.inProgress();
+
+ // Force peeps, which have been avoided due to inProgress
+ ret.setDef(1,rmem.peephole());
+ ret.setDef(2,rrez.peephole());
+ ret.setDef(0,r.peephole());
+ ret = (ReturnNode)ret.peephole();
+
+ // Function scope ends
+ _scope.pop();
+ _fun = oldfun;
+ _breakScope = breakScope;
+ _continueScope = continueScope;
+ // Reset control and memory to pre-function parsing days
+ ctrl(oldctrl.unkeep());
+ _scope.mem(oldmem.unkeep());
+
+ return ret;
+ }
+
+ /**
* Parses a block
*
* <pre>
@@ -192,14 +262,16 @@ public class Parser {
* Does not parse the opening or closing '{}'
* @return a {@link Node} or {@code null}
*/
- private Node parseBlock(boolean inCon) {
+ private Node parseBlock(ScopeNode.Kind kind) {
// Enter a new scope
- _scope.push(inCon);
+ _scope.push(kind);
+ Node last = ZERO;
while (!peek('}') && !_lexer.isEOF())
- parseStatement();
+ last = parseStatement();
// Exit scope
+ last.keep();
_scope.pop();
- return null;
+ return last.unkeep();
}
/**
@@ -213,7 +285,6 @@ public class Parser {
private Node parseStatement() {
if( false ) return null;
else if (matchx("return") ) return parseReturn();
- else if (match ("{") ) return require(parseBlock(false),"}");
else if (matchx("if") ) return parseIf();
else if (matchx("while") ) return parseWhile();
else if (matchx("for") ) return parseFor();
@@ -221,6 +292,11 @@ public class Parser {
else if (matchx("continue")) return parseContinue();
else if (matchx("struct") ) return parseStruct();
else if (matchx(";") ) return null; // Empty statement
+ // Break ambiguity around leading function types and starting a block
+ else if (peek('{') && !isTypeFun() ) {
+ match("{");
+ return require(parseBlock(ScopeNode.Kind.Block),"}");
+ }
// Declaration or normal assignment/expression
else return parseDeclarationStatement();
}
@@ -249,13 +325,13 @@ public class Parser {
*/
private Node parseFor() {
// { var x=init,y=init,...;
- // while( pred ) {
+ // while( test ) {
// body;
// next;
// }
// }
require("(");
- _scope.push(); // Scope for the index variables
+ _scope.push(ScopeNode.Kind.Block); // Scope for the index variables
if( !match(";") ) // Can be empty init "for(;test;next) body"
parseDeclarationStatement(); // Non-empty init
Node rez = parseLooping(true);
@@ -275,7 +351,7 @@ public class Parser {
// used as an indicator to switch off peepholes of the region and
// associated phis; see {@code inProgress()}.
- ctrl(new LoopNode(ctrl()).peephole()); // Note we set back edge to null here
+ ctrl(new LoopNode(loc(),ctrl()).peephole()); // Note we set back edge to null here
// At loop head, we clone the current Scope (this includes all
// names in every nesting level within the Scope).
@@ -322,7 +398,7 @@ public class Parser {
// Our current scope is the body Scope
ctrl(ifT.unkeep()); // set ctrl token to ifTrue projection
_scope.addGuards(ifT,pred.unkeep(),false); // Up-cast predicate
- parseStatement(); // Parse loop body
+ Node expr = parseStatement().keep(); // Parse loop body
_scope.removeGuards(ifT);
// Merge the loop bottom into other continue statements
@@ -362,7 +438,7 @@ public class Parser {
_xScopes.pop();
_xScopes.push(exit);
_scope = exit;
- return _scope;
+ return peep(expr.unkeep());
}
private ScopeNode jumpTo(ScopeNode toScope) {
@@ -379,13 +455,13 @@ public class Parser {
return cur;
// toScope is either the break scope, or a scope that was created here
assert toScope._lexSize.size() <= _breakScope._lexSize.size();
- toScope.ctrl(toScope.mergeScopes(cur).peephole());
+ toScope.ctrl(toScope.mergeScopes(cur,loc()).peephole());
return toScope;
}
- private void checkLoopActive() { if (_breakScope == null) throw Parser.error("No active loop for a break or continue"); }
+ private void checkLoopActive() { if (_breakScope == null) throw error("No active loop for a break or continue"); }
- private Node parseContinue() { checkLoopActive(); return (_continueScope = require(jumpTo( _continueScope ),";")); }
+ private Node parseContinue() { checkLoopActive(); _continueScope = require(jumpTo( _continueScope ),";"); return ZERO; }
private Node parseBreak () {
checkLoopActive();
// At the time of the break, and loop-exit conditions are only valid if
@@ -394,11 +470,11 @@ public class Parser {
_breakScope.removeGuards(_breakScope.ctrl());
_breakScope = require(jumpTo(_breakScope ),";");
_breakScope.addGuards(_breakScope.ctrl(), null, false);
- return _breakScope;
+ return ZERO;
}
// Look for an unbalanced `)`, skipping balanced
- private Type skipAsgn() {
+ private void skipAsgn() {
int paren=0;
while( true )
// Next X char handles skipping complex comments
@@ -406,8 +482,10 @@ public class Parser {
case Character.MAX_VALUE:
throw Utils.TODO();
case ')':
- if( --paren<0 )
- return posT(pos()-1); // Leave the `)` behind
+ if( --paren<0 ) {
+ posT( pos() - 1 );
+ return; // Leave the `)` behind
+ }
break;
case '(': paren ++; break;
default: break;
@@ -441,7 +519,6 @@ public class Parser {
Node ifF = new CProjNode(ifNode.unkeep(), 1, "False").peephole().keep();
// In if true branch, the ifT proj node becomes the ctrl
// But first clone the scope and set it as current
- int ndefs = _scope.nIns();
ScopeNode fScope = _scope.dup(); // Duplicate current scope
fScope.ctrl(ifF); // The pending arm already starts at False
_xScopes.push(fScope); // For graph visualization we need all scopes
@@ -449,9 +526,14 @@ public class Parser {
// Parse the true side
ctrl(ifT.unkeep()); // set ctrl token to ifTrue projection
_scope.addGuards(ifT,pred,false); // Up-cast predicate
- Node lhs = stmt ? parseStatement() : parseAsgn().keep(); // Parse true-side
+ Node lhs = (stmt ? parseStatement() : parseAsgn()).keep(); // Parse true-side
_scope.removeGuards(ifT);
+ // See if a one-sided def was made: "if(pred) int x = 1;" and throw.
+ // See if any forward-refs were made, and copy them to the other side:
+ // "pred ? n*fact(n-1) : 1"
+ fScope.balanceIf(_scope);
+
ScopeNode tScope = _scope;
// Parse the false side
@@ -461,31 +543,33 @@ public class Parser {
// remain true if the true clause exits: `if( !ptr ) return 0; return ptr.fld;`
_scope.addGuards(ifF,pred,true);
boolean doRHS = match(fside);
- Node rhs = doRHS
+ Node rhs = (doRHS
? (stmt ? parseStatement() : parseAsgn())
- : (stmt ? null : con(lhs._type.makeZero()));
+ : con(lhs._type.makeZero())).keep();
_scope.removeGuards(ifF);
if( doRHS )
fScope = _scope;
pred.unkeep();
- // Check for `if(pred) int x=17;`
- if( tScope.nIns() != ndefs || fScope.nIns() != ndefs )
- throw error("Cannot define a new name on one arm of an if");
-
// Check the trinary widening int/flt
if( !stmt ) {
- rhs = widenInt( rhs, lhs._type ).keep();
+ rhs = widenInt( rhs.unkeep(), lhs._type ).keep();
lhs = widenInt( lhs.unkeep(), rhs._type ).keep();
- rhs.unkeep();
}
- // Merge results
_scope = tScope;
_xScopes.pop(); // Discard pushed from graph display
+ // See if a one-sided def was made: "if(pred) int x = 1;" and throw.
+ // See if any forward-refs were made, and copy them to the other side:
+ // "pred ? n*fact(n-1) : 1"
+ tScope.balanceIf(fScope);
- RegionNode r = ctrl(tScope.mergeScopes(fScope));
- Node ret = stmt ? r : peep(new PhiNode("",lhs._type.meet(rhs._type),r,lhs.unkeep(),rhs));
+ // Merge results
+ RegionNode r = ctrl(tScope.mergeScopes(fScope,loc()));
+ Node ret = peep(new PhiNode("",lhs._type.meet(rhs._type),r,lhs.unkeep(),rhs.unkeep()));
+ // Immediately fail e.g. `arg ? 7 : ptr`
+ ParseException err;
+ if( !stmt && (err=ret.err()) !=null ) throw err;
r.peephole();
return ret;
}
@@ -501,9 +585,10 @@ public class Parser {
*/
private Node parseReturn() {
var expr = require(parseAsgn(), ";");
- Node ret = STOP.addReturn(new ReturnNode(ctrl(), expr, _scope).peephole());
+ // Force the lazy whole-memory Phi before closing this exit.
+ _fun.addReturn(ctrl(), _scope.mem(), expr);
ctrl(XCTRL); // Kill control
- return ret;
+ return expr;
}
@@ -522,22 +607,24 @@ public class Parser {
Node expr = parseAsgn();
// Final variable to update
- ScopeNode.Var def = _scope.lookup(name);
+ Var def = _scope.lookup(name);
if( def==null )
throw error("Undefined name '" + name + "'");
// TOP fields are for late-initialized fields; these have never
// been written to, and this must be the final write. Other writes
// outside the constructor need to check the final bit.
- if( _scope.in(def._idx)._type!=Type.TOP && def._final && !_scope.canInit(def) )
+ if( _scope.in(def._idx)._type!=Type.TOP && def._final &&
+ // Inside a constructor, final assign is OK, outside nope
+ !_scope.canInit(def) )
throw error("Cannot reassign final '"+name+"'");
// Lift expression, based on type
- Node lift = liftExpr(expr, def.type());
+ Node lift = liftExpr(expr.keep(), def.type());
// Update
_scope.update(name,lift);
// Return un-lifted expr
- return expr;
+ return expr.unkeep();
}
// Apply declared access permissions; widen floats and narrow integers.
@@ -553,13 +640,13 @@ public class Parser {
// Auto-narrow wide ints to narrow ints
expr = zsMask(expr,t);
// Type is sane
- if( !expr._type.isa(t) || !expr._type.accessISA(t) )
+ if( expr._type!=Type.BOTTOM && (!expr._type.shallowISA(t) || !expr._type.accessISA(t)) )
throw error("Type " + expr._type.str() + " is not of declared type " + t.str());
return expr;
}
private Node widenInt( Node expr, Type t ) {
- return expr._type instanceof TypeInteger && t instanceof TypeFloat
+ return (expr._type instanceof TypeInteger || expr._type==Type.NIL) && t instanceof TypeFloat
? peep(new ToFloatNode(expr)) : expr;
}
@@ -581,12 +668,23 @@ public class Parser {
return require(n,";");
}
+ // Widen a reassignable binding without discarding the initializer's
+ // permissions. Lattice glb includes readonly memory and is too broad here.
+ private Type inferredType(Type t) {
+ if( t instanceof TypeMemPtr tmp ) {
+ Type base = TYPES.get(tmp._obj._name);
+ TypeMemPtr ptr = (TypeMemPtr)base;
+ return (tmp._ro ? ptr.makeRO() : ptr).makeNullable();
+ }
+ return t.glb();
+ }
+
// The binding modifier sits immediately before the name. It never
// changes permissions on the referenced object.
private boolean bindingFinal(Type t) {
if( match("!") ) return false;
if( match("~") ) return true;
- return t==Type.TOP || t instanceof TypeMemPtr;
+ return t==Type.TOP || t instanceof TypeNil;
}
/** Parse final: [!|~]var['=' asgn]
@@ -596,6 +694,7 @@ public class Parser {
// Has var/val instead of a user-declared type
boolean inferType = t==Type.TOP || t==Type.BOTTOM;
boolean xfinal = bindingFinal(t);
+ Lexer loc = loc();
String name = requireId();
// Optional initializing expression follows
@@ -603,22 +702,45 @@ public class Parser {
if( match("=") ) {
expr = parseAsgn();
// var/val, then type comes from expression
- if( inferType )
- t = expr._type instanceof TypeMemPtr ptr ? ptr.makeFrom(true) : expr._type.glb();
+ if( inferType ) {
+ if( expr._type==Type.NIL )
+ throw error("a not-null/non-zero expression");
+ t = expr._type;
+ if( !xfinal ) t = inferredType(t); // Widen if not final
+ }
+ if( t instanceof TypeFunPtr && expr._type instanceof TypeFunPtr tfp && tfp.isConstant() )
+ tfp.setName(name);
} else {
- if( inferType && !_scope.inCon() )
+ // Need an expression to infer the type.
+ // Also, if not-null then need an initializing expression.
+ // Allowed in a class def, because type/init will happen in the constructor.
+ if( (inferType || (t instanceof TypeNil tn && !tn.nullable() )) && !_scope.inCon() )
throw errorSyntax("=expression");
- expr = con(xfinal && !(t instanceof TypeMemPtr) ? Type.TOP : t.makeInit());
+ // Initial value for uninitialized struct fields.
+ expr = switch( t ) {
+ // Nullable pointers get a NIL; not-null get a TOP which
+ // signals that they *must* be initialized in the constructor.
+ case TypeNil tn -> tn.nullable() ? NIL : con(Type.TOP);
+ case TypeInteger ti -> xfinal ? con(Type.TOP) : ZERO;
+ case TypeFloat tf -> con(xfinal ? Type.TOP : TypeFloat.FZERO);
+ // Bottom signals type inference: they must be initialized in
+ // the constructor and that's when we'll discover the type.
+ case Type tt -> { assert tt==Type.BOTTOM; yield con(tt); }
+ };
}
// Lift expression, based on type
Node lift = liftExpr(expr, t);
- // Define a new name,
- if( !_scope.define(name,t,xfinal,lift) )
- throw error("Redefining name '" + name + "'");
- return null;
+ // Lift type to the declaration. This will report as an error later if
+ // we cannot lift the type.
+ if( !lift._type.isa(t) )
+ lift = peep(new CastNode(t,null,lift));
+ // Define a new name
+ if( !_scope.define(name,t,xfinal,lift, loc) )
+ throw error("Redefining name '" + name + "'", loc);
+ return lift;
}
@@ -631,15 +753,14 @@ public class Parser {
* @return The statement following the struct
*/
private Node parseStruct() {
- if (_xScopes.size() > 1) throw errorSyntax("struct declarations can only appear in top level scope");
+ if (_xScopes.size() > 1) throw error("struct declarations can only appear in top level scope");
String typeName = requireId();
Type t = TYPES.get(typeName);
if( t!=null && !(t instanceof TypeMemPtr tmp && tmp.isFRef() ) )
- throw errorSyntax("struct '" + typeName + "' cannot be redefined");
+ throw error("struct '" + typeName + "' cannot be redefined");
// A Block scope parse, and inspect the scope afterward for fields.
- _scope.push(true);
- _xScopes.push(_scope);
+ _scope.push(ScopeNode.Kind.Constructor);
require("{");
while (!peek('}') && !_lexer.isEOF())
parseStatement();
@@ -648,21 +769,21 @@ public class Parser {
int lexlen = _scope._lexSize.last();
int varlen = _scope._vars._len;
StructNode s = new StructNode();
- Field[] fs = new Field[varlen-lexlen];
+ Ary<Field> fs = new Ary<>(Field.class);
for( int i=lexlen; i<varlen; i++ ) {
s.addDef(_scope.in(i));
- ScopeNode.Var v = _scope._vars.at(i);
- fs[i-lexlen] = Field.make(v._name,v.type(),ALIAS++,v._final);
+ Var v = _scope._vars.at(i);
+ if( !v.isFRef() ) // Promote to outer scope, not defined here
+ fs.push(Field.make(v._name,v.type(),ALIAS++,v._final));
}
- TypeStruct ts = s._ts = TypeStruct.make(typeName, fs);
+ TypeStruct ts = s._ts = TypeStruct.make(typeName, fs.asAry());
TYPES.put(typeName, TypeMemPtr.make(ts));
INITS.put(typeName,s.peephole().keep());
// Done with struct/block scope
require("}");
require(";");
- _xScopes.pop();
_scope.pop();
- return null;
+ return ZERO;
}
@@ -676,14 +797,20 @@ public class Parser {
int old1 = pos();
boolean writable = match("!");
boolean readonly = !writable && match("~");
+ // Only type with a leading `{` is a function pointer...
+ if( peek('{') ) return typeFunPtr();
+
+ // Otherwise you get a type name
String tname = _lexer.matchId();
if( tname==null ) return posT(old1);
+
// Convert the type name to a type.
Type t0 = TYPES.get(tname);
// No new types as keywords
if( t0 == null && KEYWORDS.contains(tname) )
return posT(old1);
- Type t1 = t0 == null ? TypeMemPtr.make(TypeStruct.makeFRef(tname)) : t0; // Null: assume a forward ref type
+ if( t0 == Type.BOTTOM || t0 == Type.TOP ) return t0; // var/val type inference
+ Type t1 = t0 == null ? TypeMemPtr.make(TypeStruct.makeFRef(tname)) :t0; // Null: assume a forward ref type
// A qualifier before the name applies to the struct reference, not
// to an enclosing array. Arrays have their own [] / [~] qualifier.
if( t1 instanceof TypeMemPtr tmp ) {
@@ -694,12 +821,11 @@ public class Parser {
// Nest arrays and '?' as needed
Type t2 = t1;
while( true ) {
- assert !(t2 instanceof TypeStruct);
if( match("?") ) {
if( !(t2 instanceof TypeMemPtr tmp) )
throw error("Type "+t0+" cannot be null");
- if( tmp._nil ) throw error("Type "+t2+" already allows null");
- t2 = tmp.makeFrom(true);
+ if( tmp.nullable() ) throw error("Type "+t2+" already allows null");
+ t2 = tmp.makeNullable();
} else if( match("[~]") ) {
TypeMemPtr ary = typeAry(t2);
t2 = ary.makeFrom(ary._obj.makeRO()).makeRO();
@@ -716,8 +842,10 @@ public class Parser {
int old2 = pos();
if( !match("!") ) match("~");
String id = _lexer.matchId();
+ if( !(peek(',') || peek(';')) )
+ return posT(old1);
pos(old2); // Reset lexer to reparse
- if( id==null || _scope.lookup(id)!=null )
+ if( id==null )
return posT(old1); // Reset lexer to reparse
// Yes a forward ref, so declare it
TYPES.put(tname,((TypeMemPtr)t1).withAccess(false));
@@ -726,7 +854,7 @@ public class Parser {
// Make an array type of t
private TypeMemPtr typeAry( Type t ) {
- if( t instanceof TypeMemPtr tmp && !tmp._nil )
+ if( t instanceof TypeMemPtr tmp && tmp.notNull() )
throw error("Arrays of reference types must always be nullable");
String tname = "["+t.str()+"]";
Type ta = TYPES.get(tname);
@@ -747,6 +875,37 @@ public class Parser {
return tary;
}
+ // A function type is `{ type... -> type }` or `{ type }`.
+ private Type typeFunPtr() {
+ int old = pos(); // Record lexer position
+ match("{"); // Skip already-peeked '{'
+ Type t0 = type(); // Either return or first arg
+ if( t0==null ) return posT(old); // Not a function
+ if( match("}") ) // No-arg function { -> type }
+ return TypeFunPtr.make(match("?"),TypeTuple.BOT,t0);
+ Ary<Type> ts = new Ary<>(Type.class);
+ ts.push(t0); // First argument
+ while( true ) {
+ if( match("->") ) { // End of arguments, parse return
+ Type ret = type();
+ if( ret==null || !match("}") )
+ return posT(old); // Not a function
+ return TypeFunPtr.make(match("?"),TypeTuple.make(ts.asAry()),ret);
+ }
+ Type t1 = type();
+ if( t1==null ) return posT(old); // Not a function
+ ts.push(t1);
+ }
+ }
+
+ // True if a TypeFunPtr, without advancing parser
+ private boolean isTypeFun() {
+ int old = pos();
+ if( typeFunPtr()==null ) return false;
+ pos(old);
+ return true;
+ }
+
/**
* Parse an expression of the form:
*
@@ -772,9 +931,9 @@ public class Parser {
Node lhs = parseComparison();
while( true ) {
if( false ) ;
- else if( match("&") ) lhs = new AndNode(lhs,null);
- else if( match("|") ) lhs = new OrNode(lhs,null);
- else if( match("^") ) lhs = new XorNode(lhs,null);
+ else if( match("&") ) lhs = new AndNode(loc(),lhs,null);
+ else if( match("|") ) lhs = new OrNode(loc(),lhs,null);
+ else if( match("^") ) lhs = new XorNode(loc(),lhs,null);
else break;
lhs.setDef(2,parseComparison());
lhs = peep(lhs);
@@ -824,11 +983,14 @@ public class Parser {
Node lhs = parseAddition();
while( true ) {
if( false ) ;
- else if( match("<<") ) lhs = new ShlNode(lhs,null);
- else if( match(">>>")) lhs = new ShrNode(lhs,null);
- else if( match(">>") ) lhs = new SarNode(lhs,null);
+ else if( match("<<") ) lhs = new ShlNode(loc(),lhs,null);
+ else if( match(">>>")) lhs = new ShrNode(loc(),lhs,null);
+ else if( match(">>") ) lhs = new SarNode(loc(),lhs,null);
else break;
lhs.setDef(2,parseAddition());
+ ParseException err;
+ if( (err=lhs.err()) != null )
+ throw err;
lhs = peep(lhs.widen());
}
return lhs;
@@ -864,7 +1026,7 @@ public class Parser {
* @return a multiply expression {@link Node}, never {@code null}
*/
private Node parseMultiplication() {
- var lhs = parseUnary(); boolean mul;
+ var lhs = parseUnary();
while( true ) {
if( false ) ;
else if( match("*") ) lhs = new MulNode(lhs,null);
@@ -891,11 +1053,13 @@ public class Parser {
int delta = _lexer.peek(-1)=='+' ? 1 : -1; // Pre vs post
String name = _lexer.matchId();
if( name!=null ) {
- ScopeNode.Var n = _scope.lookup(name);
- if( n != null ) {
+ Var n = _scope.lookup(name);
+ if( n != null && !(n.type() instanceof TypeMemPtr) ) {
if( n._final )
throw error("Cannot reassign final '"+n._name+"'");
- Node expr = zsMask(peep(new AddNode(_scope.in(n),con(delta))),n.type());
+ Node expr = n.type() instanceof TypeFloat
+ ? peep(new AddFNode(_scope.in(n),con(TypeFloat.constant(delta))))
+ : zsMask(peep(new AddNode(_scope.in(n),con(delta))),n.type());
_scope.update(n,expr);
return expr;
}
@@ -920,52 +1084,82 @@ public class Parser {
if( _lexer.isNumber(_lexer.peek()) ) return parseLiteral();
if( matchx("true" ) ) return con(1);
if( matchx("false") ) return ZERO;
- if( matchx("null" ) ) return con(TypeMemPtr.NULLPTR);
- if( match("(") ) return require(parseAsgn(), ")");
+ if( matchx("null" ) ) return NIL;
+ if( match ("(" ) ) return require(parseAsgn(), ")");
if( matchx("new" ) ) return alloc();
+ if( match ("{" ) ) return require(func(),"}");
// Expect an identifier now
- ScopeNode.Var n = requireLookupId("an identifier or expression");
+ Var n = requireLookupId();
Node rvalue = _scope.in(n);
if( rvalue._type == Type.BOTTOM )
- throw error("Cannot read uninitialized field '"+n._name+"'");
+ if( rvalue instanceof FRefNode ) return rvalue;
+ else throw error("Cannot read uninitialized field '"+n._name+"'");
// Check for assign-update, x += e0;
char ch = _lexer.matchOperAssign();
if( ch==0 ) return rvalue;
- if( n._final )
- throw error("Cannot reassign final '"+n._name+"'");
+ Node op = opAssign(ch,rvalue,n._final,n.type(),n._name);
+ _scope.update(n,op);
+ return postfix(ch) ? rvalue.unkeep() : op;
+ }
+
+ // Check for assign-update, "x += e0".
+ // Returns "x + e0"; the caller assigns value.
+ // if ch is postfix, then lhs is kept and caller will unkeep and return it.
+ private Node opAssign(char ch, Node lhs, boolean xfinal, Type t, String name ) {
+ if( xfinal )
+ throw error("Cannot reassign final '"+name+"'");
+ // RHS of the update.
+ lhs.keep(); // Alive across parseAsgn
+ Node rhs =
+ (byte)ch == 1 ? con( 1) : // var++
+ (byte)ch == -1 ? con(-1) : // var--
+ parseAsgn(); // var op= rhs
+ if( !postfix(ch) ) lhs.unkeep(); // Allow to die in next peep
+ // 4 cases:
+ // int + int ==>> narrow int
+ // int + flt ==>> error, caller must fail assigning flt into int
+ // flt + int ==>> use float op, wrap toFloat()
+ // flt + flt ==>> use float op
Node op = switch(ch) {
- case '+' -> new AddNode(rvalue,null);
- case '-' -> new SubNode(rvalue,null);
- case '*' -> new MulNode(rvalue,null);
- case '/' -> new DivNode(rvalue,null);
- case '&' -> new AndNode(rvalue,null);
- case '|' -> new OrNode(rvalue,null);
- case '^' -> new XorNode(rvalue,null);
- case Lexer.SHL -> new ShlNode(rvalue,null);
- case Lexer.SAR -> new SarNode(rvalue,null);
- case Lexer.SHR -> new ShrNode(rvalue,null);
- case 1 -> new AddNode(rvalue,con( 1));
- case (char)-1 -> new AddNode(rvalue,con(-1));
+ case 1, (char)-1,
+ '+' -> new AddNode(lhs,rhs);
+ case '-' -> new SubNode(lhs,rhs);
+ case '*' -> new MulNode(lhs,rhs);
+ case '/' -> new DivNode(lhs,rhs);
+ case '&' -> new AndNode(loc(),lhs,rhs);
+ case '|' -> new OrNode(loc(),lhs,rhs);
+ case '^' -> new XorNode(loc(),lhs,rhs);
+ case Lexer.SHL -> new ShlNode(loc(),lhs,rhs);
+ case Lexer.SAR -> new SarNode(loc(),lhs,rhs);
+ case Lexer.SHR -> new ShrNode(loc(),lhs,rhs);
default -> throw Utils.TODO();
};
- // Return pre-value (x+=1) or post-value (x++)
- boolean pre = op.in(2)==null;
- // Parse RHS argument as needed
- if( pre )
- { op.keep().setDef(2,parseAsgn()); op.unkeep(); }
- else rvalue.keep(); // Keep post-value across peeps
- op = zsMask(peep(op),n.type());
- _scope.update(n,op);
- return pre ? op : rvalue.unkeep();
+ // Convert to float ops, or narrow int types; error if not declared type.
+ // Also, if postfix LHS is still keep()
+ return liftExpr(peep(op.widen()),t);
}
- ScopeNode.Var requireLookupId(String msg) {
+
+ // Expect an ID here. If not found, assume a forward reference function
+ Var requireLookupId() {
String id = _lexer.matchId();
if( id == null || KEYWORDS.contains(id) )
- throw errorSyntax(msg);
- ScopeNode.Var n = _scope.lookup(id);
- if( n==null )
- throw error("Undefined name '" + id + "'");
+ throw errorSyntax("an identifier or expression");
+ Var n = _scope.lookup(id);
+ // If missing, assume a forward reference
+ if( n==null ) {
+ _scope.define(id, FRefNode.FREF_TYPE, true, XCTRL, loc());
+ n = _scope.lookup(id);
+ } else {
+ // Lookup worked on an out-of-function value.
+ if( _scope.outOfFunction(n) ) {
+ // No closures, so this has to be a final constant (which
+ // includes forward refs)
+ Node def = _scope.in(n._idx);
+ if( !(def instanceof FRefNode) && !(n._final && def._type.isConstant()) )
+ throw error("Variable '"+n._name+"' is out of function scope and must be a final constant");
+ }
+ }
return n;
}
@@ -977,6 +1171,8 @@ public class Parser {
if( t==null ) throw error("Expected a type");
// Parse ary[ length_expr ]
if( match("[") ) {
+ if( !t.makeZero().isa(t) )
+ throw error("Cannot allocate a non-nullable, since arrays always zero/null fill");
Node len = parseAsgn();
if( !(len._type instanceof TypeInteger) )
throw error("Cannot allocate an array with length "+len._type);
@@ -1000,12 +1196,12 @@ public class Parser {
if( hasConstructor ) {
idx = _scope.nIns();
// Push a scope, and pre-assign all struct fields.
- _scope.push();
+ _scope.push(ScopeNode.Kind.Block);
+ Lexer loc = loc();
for( int i=0; i<fs.length; i++ )
- _scope.define(fs[i]._fname, fs[i]._type, fs[i]._final, s.in(i)._type==Type.TOP ? con(Type.BOTTOM) : s.in(i));
+ _scope.define(fs[i]._fname, fs[i]._type, fs[i]._final, s.in(i)._type==Type.TOP ? con(Type.BOTTOM) : s.in(i), loc);
// Parse the constructor body
- parseBlock(true);
- require("}");
+ require(parseBlock(ScopeNode.Kind.Constructor),"}");
init = _scope._inputs;
}
// Check that all fields are initialized
@@ -1053,8 +1249,8 @@ public class Parser {
private Node newArray(TypeStruct ary, Node len) {
int base = ary.aryBase ();
int scale= ary.aryScale();
- Node size = peep(new AddNode(con(base),peep(new ShlNode(len.keep(),con(scale)))));
- ALTMP.clear(); ALTMP.add(len.unkeep()); ALTMP.add(con(ary._fields[1]._type.makeInit()));
+ Node size = peep(new AddNode(con(base),peep(new ShlNode(null,len.keep(),con(scale)))));
+ ALTMP.clear(); ALTMP.add(len.unkeep()); ALTMP.add(con(ary._fields[1]._type.makeZero()));
return newStruct(ary,size,0,ALTMP);
}
@@ -1066,7 +1262,7 @@ public class Parser {
if( !init && ptr._type instanceof TypeMemPtr view && view._ro && ctrl()._type!=Type.XCONTROL )
throw error("Cannot modify final field '"+name+"'");
Node prior = mem().keep();
- Node st = new StoreNode(name,alias,glb,prior,ptr,off,val,init);
+ Node st = new StoreNode(loc(),name,alias,glb,prior,ptr,off,val,init);
st.setDef(0,ctrl);
st = st.peephole();
mem(new MemMergeNode(prior,alias,st).peephole());
@@ -1074,33 +1270,32 @@ public class Parser {
}
/**
- * Parse postfix expression. For now this is just a field
- * expression, but in future could be array index too.
+ * Parse postfix expression; this can be a field expression, an array
+ * lookup or a postfix operator like '#'
*
* <pre>
- * expr ('.' IDENTIFIER)* [ = expr ]
- * expr #
- * expr ('[' expr ']')* = [ = expr ]
+ * expr ('.' FIELD)* [ = expr ] // Field reference
+ * expr '#' // Postfix unary read operator
+ * expr ['++' | '--' ] // Postfix unary write operator
+ * expr ('[' expr ']')* = [ = expr ] // Array reference
+ * expr '(' [args,]* ')' // Function call
* </pre>
*/
private Node parsePostfix(Node expr) {
- String name = null;
+ String name;
if( match(".") ) name = requireId();
else if( match("#") ) name = "#";
else if( match("[") ) name = "[]";
+ else if( match("(") ) return parsePostfix(require(functionCall(expr),")"));
else return expr; // No postfix
+ if( expr._type==Type.NIL )
+ throw error("Accessing unknown field '" + name + "' from 'null'");
+
// Sanity check expr for being a reference
if( !(expr._type instanceof TypeMemPtr ptr) )
throw error("Expected reference but got " + expr._type.str());
- // Happens when parsing known dead code, which often has other typing
- // issues. Since the code is dead, possibly due to inlining, lets not
- // spoil the user experience with error messages.
- if( ctrl()._type==Type.XCONTROL )
- // Exit out via parsing the trailing expression
- return matchOpx('=','=') ? parseAsgn() : parsePostfix(con(Type.TOP));
-
// Sanity check field name for existing
TypeMemPtr tmp = (TypeMemPtr)TYPES.get(ptr._obj._name);
if( tmp == null ) throw error("Accessing unknown field '" + name + "' from '" + ptr + "'");
@@ -1118,7 +1313,7 @@ public class Parser {
// Field offset; fixed for structs, computed for arrays
Node off = (name.equals("[]") // If field is an array body
// Array index math
- ? peep(new AddNode(con(base.aryBase()),peep(new ShlNode(require(parseAsgn(),"]"),con(base.aryScale())))))
+ ? peep(new AddNode(con(base.aryBase()),peep(new ShlNode(null,require(parseAsgn(),"]"),con(base.aryScale())))))
// Struct field offsets are hardwired
: con(base.offset(fidx))).keep();
@@ -1131,20 +1326,19 @@ public class Parser {
return val.unkeep(); // "obj.a = expr" returns the expression while updating memory
}
- Node load = new LoadNode(name, f._alias, (tf instanceof TypeMemPtr ? tf : tf.glb()), mem(), expr, off);
+ Node load = new LoadNode(loc(),name, f._alias, tf, mem(), expr, off);
// Arrays include control, as a proxy for a safety range check
// Structs don't need this; they only need a NPE check which is
// done via the type system.
if( base.isAry() ) load.setDef(0,ctrl());
load = peep(load);
- // ary[idx]++ or ptr.fld++
- if( matchx("++") || matchx("--") ) {
- if( f._final && !f._fname.equals("[]") )
- throw error("Cannot reassign final '"+f._fname+"'");
- Node inc = peep(new AddNode(load,con( _lexer.peek(-1)=='+' ? 1 : -1)));
- Node val = zsMask(inc,tf);
- store(name,f._alias,tf,expr.unkeep(),off,val,false,base.isAry() ? ctrl() : null);
+ // Check for assign-update, "ptr.fld += expr" or "ary[idx]++"
+ char ch = _lexer.matchOperAssign();
+ if( ch!=0 ) {
+ Node op = opAssign(ch,load,f._final,tf,name);
+ store(name,f._alias,tf,expr.unkeep(),off,op,false,base.isAry() ? ctrl() : null);
+ load = postfix(ch) ? load.unkeep() : op;
// And use the original loaded value as the result
} else expr.unkill();
off.unkill();
@@ -1165,15 +1359,86 @@ public class Parser {
return peep(new RoundF32Node(val));
}
if( t0._min==0 ) // Unsigned
- return peep(new AndNode(val,con(t0._max)));
+ return peep(new AndNode(null,val,con(t0._max)));
// Signed extension
int shift = Long.numberOfLeadingZeros(t0._max)-1;
Node shf = con(shift);
if( shf._type==TypeInteger.ZERO )
return val;
- return peep(new SarNode(peep(new ShlNode(val,shf.keep())),shf.unkeep()));
+ return peep(new SarNode(null,peep(new ShlNode(null,val,shf.keep())),shf.unkeep()));
}
+ /**
+ * Parse a function body; the caller will parse the surrounding "{}"
+ *
+ * <pre>
+ * { [type arg,]* -> expr }
+ * { expr } // The no-argument function
+ * </pre>
+ */
+ private Node func() {
+ Ary<Type> ts = new Ary<>(Type.class);
+ Ary<String> ids = new Ary<>(String.class);
+ java.util.BitSet finals = new java.util.BitSet();
+ _lexer.skipWhiteSpace();
+ Lexer loc = loc(); // First argument location
+ while( true ) {
+ Type t = type(); // Arg type
+ if( t==null ) break;
+ finals.set(ids.size(),bindingFinal(t));
+ String id = requireId();
+ ts .push(t ); // Push type/arg pairs
+ ids.push(id);
+ match(",");
+ }
+ require("->");
+ // Make a concrete function type, with a fidx
+ TypeFunPtr tfp = TypeFunPtr.makeFun(TypeTuple.make(ts.asAry()),Type.BOTTOM);
+ ReturnNode ret = parseFunctionBody(tfp,loc,finals,ids.asAry());
+ return con(ret._fun.sig());
+ }
+
+ /**
+ * Parse function call arguments; caller will parse the surrounding "()"
+ * <pre>
+ * ( arg* )
+ * </pre>
+ */
+ private Node functionCall(Node expr) {
+ if( expr._type == Type.NIL )
+ throw error("Calling a null function pointer");
+ if( !(expr instanceof FRefNode) && !expr._type.isa(TypeFunPtr.BOT) )
+ throw error("Expected a function but got "+expr._type.glb().str());
+ expr.keep(); // Keep while parsing args
+
+ Ary<Node> args = new Ary<Node>(Node.class);
+ args.push(null); // Space for ctrl,mem
+ args.push(null);
+ while( !peek(')') ) {
+ Node arg = parseAsgn();
+ if( arg==null ) break;
+ args.push(arg.keep());
+ if( !match(",") ) break;
+ }
+ // Control & memory after parsing args
+ args.set(0,ctrl().keep());
+ args.set(1,_scope.mem().keep());
+ args.push(expr); // Function pointer
+ // Unkeep them all
+ for( Node arg : args )
+ arg.unkeep();
+ // Into the call
+ CallNode call = (CallNode)new CallNode(loc(), args.asAry()).peephole();
+
+ // Post-call setup
+ CallEndNode cend = (CallEndNode)new CallEndNode(call).peephole();
+ // Control from CallEnd
+ ctrl(new CProjNode(cend,0,ScopeNode.CTRL).peephole());
+ // A call may update any alias, so its memory result is the new whole state.
+ _scope.mem(new ProjNode(cend,1,ScopeNode.MEM0).peephole());
+ // Call result
+ return new ProjNode(cend,2,null).peephole();
+ }
/**
* Parse integer literal
@@ -1184,7 +1449,7 @@ public class Parser {
* </pre>
*/
private ConstantNode parseLiteral() { return con(_lexer.parseNumber()); }
- public static Node con( long con ) { return con(TypeInteger.constant(con)); }
+ public static Node con( long con ) { return con==0 ? ZERO : con(TypeInteger.constant(con)); }
public static ConstantNode con( Type t ) { return (ConstantNode)new ConstantNode(t).peephole(); }
public Node peep( Node n ) {
// Peephole, then improve with lexically scoped guards
@@ -1203,12 +1468,21 @@ public class Parser {
private boolean peek(char ch) { return _lexer.peek(ch); }
private boolean peekIsId() { return _lexer.peekIsId(); }
+ // ch is +/- 1, means oper++ or oper-- means postfix
+ private static boolean postfix(char ch) {
+ return (byte)ch== 1 || (byte)ch== -1;
+ }
+
+ public int pos() { return _lexer._position; }
private int pos(int pos) {
int old = _lexer._position;
_lexer._position = pos;
return old;
}
private Type posT(int pos) { _lexer._position = pos; return null; }
+ // Source code location
+ Lexer loc() { return new Lexer(_lexer); }
+
// Require and return an identifier
private String requireId() {
@@ -1233,24 +1507,26 @@ public class Parser {
throw errorSyntax(syntax);
}
- RuntimeException errorSyntax(String syntax) {
- return error("Syntax error, expected " + syntax + ": " + _lexer.getAnyNextToken());
- }
-
- public static RuntimeException error( String errorMessage ) {
- return new RuntimeException(errorMessage);
- }
-
////////////////////////////////////
// Lexer components
- private static class Lexer {
+ // Lexer provides low level access to the raw file bytes, peeks and matches
+ // short strings, parses numbers, skips comments and whitespace, tracks
+ // line numbers, allows the parse position to be saved and restored, and
+ // serves as a location indicator for errors.
+
+ public static class Lexer {
// Input buffer; an array of text bytes read from a file or a string
private final byte[] _input;
// Tracks current position in input buffer
private int _position = 0;
+ //
+ private int _line_number = 1;
+ // Start of current line
+ private int _line_start = 0;
+
/**
* Record the source text for lexing
*/
@@ -1265,6 +1541,16 @@ public class Parser {
_input = buf;
}
+ /**
+ * Copy a lexer from a lexer
+ */
+ private Lexer(Lexer l) {
+ _input = l._input;
+ _position = l._position;
+ _line_number = l._line_number;
+ _line_start = l._line_start;
+ }
+
// Very handy in the debugger, shows the unparsed program
@Override
public String toString() {
@@ -1284,9 +1570,16 @@ public class Parser {
// Just crash if misused
public byte peek(int off) { return _input[_position+off]; }
+ private void inc() {
+ if( _position++ < _input.length && _input[_position-1] == '\n' ) {
+ _line_number++;
+ _line_start = _position;
+ }
+ }
+ // Does not honor LF, so caller must roll back position on a LF
private char nextChar() {
char ch = peek();
- _position++;
+ inc();
return ch;
}
@@ -1300,13 +1593,13 @@ public class Parser {
*/
private void skipWhiteSpace() {
while( true ) {
- if( isWhiteSpace() ) _position++;
+ if( isWhiteSpace() ) inc();
// Skip // to end of line
else if( _position+2 < _input.length &&
_input[_position ] == '/' &&
_input[_position+1] == '/') {
- _position += 2;
- while( !isEOF() && _input[_position] != '\n' ) _position++;
+ inc(); inc();
+ while( !isEOF() && _input[_position] != '\n' ) inc();
} else break;
}
}
@@ -1318,6 +1611,7 @@ public class Parser {
// then advance the cursor past syntax.
// Return false otherwise, and do not advance the cursor.
boolean match(String syntax) {
+ assert syntax.indexOf('\n')==-1; // No newlines in match
skipWhiteSpace();
int len = syntax.length();
if (_position + len > _input.length) return false;
@@ -1340,7 +1634,7 @@ public class Parser {
skipWhiteSpace();
if( _position+1 >= _input.length || _input[_position]!=c0 || _input[_position+1]==c1 )
return false;
- _position++;
+ inc();
return true;
}
@@ -1377,8 +1671,9 @@ public class Parser {
int len = isLongOrDouble();
if( len > 0 ) {
if( len > 1 && _input[old]=='0' )
- throw error("Syntax error: integer values cannot start with '0'");
- return TypeInteger.constant(Long.parseLong(new String(_input,old,len)));
+ throw error("Syntax error: integer values cannot start with '0'",this);
+ long i = Long.parseLong(new String(_input,old,len));
+ return TypeInteger.constant(i);
}
return TypeFloat.constant(Double.parseDouble(new String(_input,old,-len)));
}
@@ -1429,7 +1724,6 @@ public class Parser {
// Next oper= character, or 0.
// As a convenience, mark "++" as a char 1 and "--" as char -1 (65535)
- // Disallow e.g. "arg--1" which should parse as "arg - -1"
// Distinct tags for the multi-character compound operators.
static final char SHL = 2, SAR = 3, SHR = 4;
@@ -1449,4 +1743,18 @@ public class Parser {
return 0;
}
}
+
+ ParseException errorSyntax(String syntax) { return _errorSyntax("expected "+syntax); }
+ private ParseException _errorSyntax(String msg) {
+ return error("Syntax error, "+msg+": " + _lexer.getAnyNextToken());
+ }
+ ParseException error(String msg) { return error(msg,_lexer); }
+ public static ParseException error(String msg, Lexer loc) { return new ParseException(msg,loc); }
+
+ public static class ParseException extends RuntimeException {
+ public final Lexer _loc;
+ // file:line:charoff err
+ //String msg = "src:"+_line_number+":"+(_position-_line_start)+" "+errorMessage;
+ ParseException( String msg, Lexer loc ) { super(msg); _loc = loc; }
+ }
}
diff --git a/src/main/java/com/seaofnodes/simple/SB.java b/src/main/java/com/seaofnodes/simple/SB.java
new file mode 100644
index 00000000..6f5a29ee
--- /dev/null
+++ b/src/main/java/com/seaofnodes/simple/SB.java
@@ -0,0 +1,74 @@
+package com.seaofnodes.simple;
+
+/** Tight/tiny StringBuilder wrapper.
+ * Short short names on purpose; so they don't obscure the printing.
+ * Can't believe this wasn't done long, long ago. */
+public final class SB {
+ private final StringBuilder _sb;
+ private int _indent = 0;
+ public SB( ) { _sb = new StringBuilder( ); }
+ public SB(String s) { _sb = new StringBuilder(s); }
+ public SB p( String s ) { _sb.append(s); return this; }
+ public SB p( float s ) {
+ if( Float.isNaN(s) )
+ _sb.append( "Float.NaN");
+ else if( Float.isInfinite(s) ) {
+ _sb.append(s > 0 ? "Float.POSITIVE_INFINITY" : "Float.NEGATIVE_INFINITY");
+ } else _sb.append(s);
+ return this;
+ }
+ public SB p( double s ) {
+ if( Double.isNaN(s) )
+ _sb.append("Double.NaN");
+ else if( Double.isInfinite(s) ) {
+ _sb.append(s > 0 ? "Double.POSITIVE_INFINITY" : "Double.NEGATIVE_INFINITY");
+ } else _sb.append(s);
+ return this;
+ }
+ public SB p( char s ) { _sb.append(s); return this; }
+ public SB p( int s ) { _sb.append(s); return this; }
+ public SB p( long s ) { _sb.append(s); return this; }
+ public SB p( boolean s) { _sb.append(s); return this; }
+ // Not spelled "p" on purpose: too easy to accidentally say "p(1.0)" and
+ // suddenly call the autoboxed version.
+ public SB pobj( Object s ) { _sb.append(s.toString()); return this; }
+ public SB i( int d ) { for( int i=0; i<d+_indent; i++ ) p(" "); return this; }
+ public SB i( ) { return i(0); }
+ public SB ip(String s) { return i().p(s); }
+ public SB s() { _sb.append(' '); return this; }
+
+ // Increase indentation
+ public SB ii( int i) { _indent += i; return this; }
+ public SB ii() { return ii(1); }
+ // Decrease indentation
+ public SB di( int i) { _indent -= i; return this; }
+ public SB di() { return di(1); }
+
+ public SB nl( ) { return p(System.lineSeparator()); }
+ // Last printed a nl
+ public boolean was_nl() {
+ int len = _sb.length();
+ String nl = System.lineSeparator();
+ int nlen = nl.length();
+ if( len < nlen ) return false;
+ for( int i=0; i<nlen; i++ )
+ if( _sb.charAt(len-nlen+i)!=nl.charAt(i) )
+ return false;
+ return true;
+ }
+
+ // Delete last char. Useful when doing string-joins and JSON printing and an
+ // extra separater char needs to be removed:
+ //
+ // sb.p('[');
+ // for( Foo foo : foos )
+ // sb.p(foo).p(',');
+ // sb.unchar().p(']'); // remove extra trailing comma
+ //
+ public SB unchar() { return unchar(1); }
+ public SB unchar(int x) { _sb.setLength(_sb.length()-x); return this; }
+
+ public SB clear() { _sb.setLength(0); return this; }
+ public int len() { return _sb.length(); }
+ @Override public String toString() { return _sb.toString(); }
+}
diff --git a/src/main/java/com/seaofnodes/simple/Var.java b/src/main/java/com/seaofnodes/simple/Var.java
new file mode 100644
index 00000000..6e621875
--- /dev/null
+++ b/src/main/java/com/seaofnodes/simple/Var.java
@@ -0,0 +1,57 @@
+package com.seaofnodes.simple;
+
+import com.seaofnodes.simple.type.*;
+
+
+/**
+ * The tracked fields are now complex enough to deserve a array-of-structs layout
+ */
+public class Var {
+
+ public final String _name; // Declared name
+ public int _idx; // index in containing scope
+ private Type _type; // Declared type
+ public boolean _final; // Final field
+ public Parser.Lexer _loc; // Source location
+ public boolean _fref; // Forward ref
+
+ public Var(int idx, String name, Type type, boolean xfinal, Parser.Lexer loc ) {
+ this(idx,name,type,xfinal,loc,false);
+ }
+ public Var(int idx, String name, Type type, boolean xfinal, Parser.Lexer loc, boolean fref) {
+ _idx = idx;
+ _name = name;
+ _type = type;
+ _final = xfinal;
+ _loc = loc;
+ _fref = fref;
+ }
+ // Raw declared type, without resolving a forward reference while printing.
+ public Type _type() { return _type; }
+ public Type type() {
+ if( !_type.isFRef() ) return _type;
+ // Update self to no longer use the forward ref type
+ Type def = Parser.TYPES.get(((TypeMemPtr)_type)._obj._name);
+ return (_type=_type.meet(def));
+ }
+ public Type lazyGLB() {
+ Type t = type();
+ return t instanceof TypeMemPtr ? t : t.glb();
+ }
+
+ // Forward reference variables (not types) must be BOTTOM and
+ // distinct from inferred variables
+ public boolean isFRef() { return _fref; }
+
+ public void defFRef( Type type, boolean xfinal, Parser.Lexer loc ) {
+ assert isFRef() && xfinal;
+ _type = type;
+ _final = true;
+ _loc = loc;
+ _fref = false;
+ }
+
+ @Override public String toString() {
+ return _type.toString()+(_final ? " ": " !")+_name;
+ }
+}
diff --git a/src/main/java/com/seaofnodes/simple/node/AddNode.java b/src/main/java/com/seaofnodes/simple/node/AddNode.java
index 0f9ecec9..f88c2175 100644
--- a/src/main/java/com/seaofnodes/simple/node/AddNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/AddNode.java
@@ -1,9 +1,9 @@
package com.seaofnodes.simple.node;
+import com.seaofnodes.simple.Parser;
import com.seaofnodes.simple.type.*;
-
public class AddNode extends Node {
public AddNode(Node lhs, Node rhs) { super(null, lhs, rhs); }
@@ -37,12 +37,12 @@ public class AddNode extends Node {
public Node idealize () {
Node lhs = in(1);
Node rhs = in(2);
- if( rhs.err() != null ) return null;
+ if( rhs.err()!=null ) return null;
Type t2 = rhs._type;
// Add of 0. We do not check for (0+x) because this will already
// canonicalize to (x+0)
- if( t2 instanceof TypeInteger i && i.isConstant() && i.value()==0 && lhs._type instanceof TypeInteger )
+ if( t2 == TypeInteger.ZERO && lhs._type instanceof TypeInteger )
return lhs;
// Add of same to a multiply by 2
@@ -178,9 +178,10 @@ public class AddNode extends Node {
@Override Node copy(Node lhs, Node rhs) { return new AddNode(lhs,rhs); }
@Override Node copyF() { return new AddFNode(null,null); }
- @Override public String err() {
- if( !(in(1)._type instanceof TypeInteger) ) return "Cannot '"+label()+"' " + in(1)._type;
- if( !(in(2)._type instanceof TypeInteger) ) return "Cannot '"+label()+"' " + in(2)._type;
+ @Override public Parser.ParseException err() {
+ if( in(1)._type.isHigh() || in(2)._type.isHigh() ) return null;
+ if( !(in(1)._type instanceof TypeInteger) ) return Parser.error("Cannot '"+label()+"' " + in(1)._type,null);
+ if( !(in(2)._type instanceof TypeInteger) ) return Parser.error("Cannot '"+label()+"' " + in(2)._type,null);
return null;
}
}
diff --git a/src/main/java/com/seaofnodes/simple/node/AndNode.java b/src/main/java/com/seaofnodes/simple/node/AndNode.java
index d80e25e7..7cb16c71 100644
--- a/src/main/java/com/seaofnodes/simple/node/AndNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/AndNode.java
@@ -1,16 +1,16 @@
package com.seaofnodes.simple.node;
-
+import com.seaofnodes.simple.Parser;
import com.seaofnodes.simple.type.Type;
import com.seaofnodes.simple.type.TypeInteger;
+import java.util.BitSet;
-public class AndNode extends Node {
- public AndNode(Node lhs, Node rhs) { super(null, lhs, rhs); }
+public class AndNode extends LogicalNode {
+ public AndNode(Parser.Lexer loc, Node lhs, Node rhs) { super(loc, lhs, rhs); }
@Override public String label() { return "And"; }
-
- @Override protected String format() { return "(%1&%2)"; }
+ @Override public String op() { return "&"; }
@Override
public Type compute() {
@@ -52,10 +52,5 @@ public class AndNode extends Node {
return null;
}
- @Override Node copy(Node lhs, Node rhs) { return new AndNode(lhs,rhs); }
- @Override String err() {
- if( !(in(1)._type instanceof TypeInteger) ) return "Cannot '&' " + in(1)._type;
- if( !(in(2)._type instanceof TypeInteger) ) return "Cannot '&' " + in(2)._type;
- return null;
- }
+ @Override Node copy(Node lhs, Node rhs) { return new AndNode(_loc,lhs,rhs); }
}
diff --git a/src/main/java/com/seaofnodes/simple/node/BoolNode.java b/src/main/java/com/seaofnodes/simple/node/BoolNode.java
index 6efde623..aa577f61 100644
--- a/src/main/java/com/seaofnodes/simple/node/BoolNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/BoolNode.java
@@ -4,10 +4,7 @@ import com.seaofnodes.print.ExprPrinter;
import com.seaofnodes.simple.Parser;
import com.seaofnodes.simple.Utils;
-import com.seaofnodes.simple.type.Type;
-import com.seaofnodes.simple.type.TypeInteger;
-import com.seaofnodes.simple.type.TypeFloat;
-import com.seaofnodes.simple.type.TypeMemPtr;
+import com.seaofnodes.simple.type.*;
import static com.seaofnodes.simple.type.TypeInteger.*;
@@ -30,15 +27,19 @@ abstract public class BoolNode extends Node {
public TypeInteger compute() {
Type t1 = in(1)._type;
Type t2 = in(2)._type;
+ // Exactly equals?
if( t1.isHigh() || t2.isHigh() )
return BOOL.dual();
+ if( in(1)==in(2) )
+ // LT fails, both EQ and LE succeed
+ return this instanceof LT ? TypeInteger.FALSE : TypeInteger.TRUE;
if( t1 instanceof TypeInteger i1 &&
t2 instanceof TypeInteger i2 )
return doOp(i1,i2);
if( t1 instanceof TypeFloat f1 &&
t2 instanceof TypeFloat f2 &&
f1.isConstant() && f2.isConstant() )
- return TypeInteger.constant(doOp(f1.value(), f2.value()) ? 1 : 0);
+ return doOp(f1.value(), f2.value()) ? TypeInteger.TRUE : TypeInteger.FALSE;
return BOOL;
}
@@ -49,7 +50,7 @@ abstract public class BoolNode extends Node {
public Node idealize() {
// Compare of same
if( in(1)==in(2) )
- return new ConstantNode(doOp(ZERO,ZERO));
+ return this instanceof LT ? Parser.ZERO : new ConstantNode(TypeInteger.TRUE);
// Equals pushes constant to the right; 5==X becomes X==5.
if( this instanceof EQ ) {
@@ -60,7 +61,7 @@ abstract public class BoolNode extends Node {
return in(1)._type instanceof TypeFloat ? new EQF(in(2),in(1)) : new EQ(in(2),in(1));
}
// Equals X==0 becomes a !X
- if( (in(2)._type == ZERO || in(2)._type == TypeMemPtr.NULLPTR) )
+ if( (in(2)._type == ZERO || in(2)._type == Type.NIL) )
return new NotNode(in(1));
}
diff --git a/src/main/java/com/seaofnodes/simple/node/BulkMemPhiNode.java b/src/main/java/com/seaofnodes/simple/node/BulkMemPhiNode.java
index 84f97189..de5f8b4c 100644
--- a/src/main/java/com/seaofnodes/simple/node/BulkMemPhiNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/BulkMemPhiNode.java
@@ -94,6 +94,7 @@ public class BulkMemPhiNode extends PhiNode {
private int inputAlias(Node n) {
return switch(n) {
case ProjNode proj -> 0;
+ case ParmNode parm -> 0;
case ConstantNode con -> 0;
case MemMergeNode mmm -> missingAlias(mmm);
case MemOpNode mem -> unsplit(mem._alias);
@@ -116,7 +117,7 @@ public class BulkMemPhiNode extends PhiNode {
case MemOpNode mem -> unsplit(mem._alias);
case MemPhiNode phi -> unsplit(phi._alias);
default -> {
- assert use instanceof ReturnNode
+ assert use instanceof ReturnNode || use instanceof CallNode || use instanceof ParmNode
: "Unexpected bulk-memory user "+use;
yield 0;
}
diff --git a/src/main/java/com/seaofnodes/simple/node/CFGNode.java b/src/main/java/com/seaofnodes/simple/node/CFGNode.java
index e85fc6ae..49398838 100644
--- a/src/main/java/com/seaofnodes/simple/node/CFGNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/CFGNode.java
@@ -1,5 +1,6 @@
package com.seaofnodes.simple.node;
+import com.seaofnodes.simple.CodeGen;
import com.seaofnodes.simple.Parser;
import com.seaofnodes.simple.type.*;
import com.seaofnodes.simple.Utils;
@@ -28,6 +29,17 @@ public abstract class CFGNode extends Node {
// Block head is Start, Region, CProj, but not e.g. If, Return, Stop
public boolean blockHead() { return false; }
+ // Get the one control following; error to call with more than one e.g. an
+ // IfNode or other multi-way branch.
+ public CFGNode uctrl() {
+ CFGNode c = null;
+ for( Node n : _outputs )
+ if( n instanceof CFGNode cfg )
+ { assert c==null; c = cfg; }
+ return c;
+ }
+
+
// ------------------------------------------------------------------------
/**
* Immediate dominator tree depth, used to approximate a real IDOM during
@@ -37,13 +49,17 @@ public abstract class CFGNode extends Node {
* See {@link <a href="https://en.wikipedia.org/wiki/Dominator_(graph_theory)">...</a>}
*/
public char _idepth;
- public int idepth() { return _idepth!=0 ? _idepth : cacheIDepth(idom().idepth()+1); }
+ public char _idepthVersion;
+ public int idepth() { return validIDepth() ? _idepth : cacheIDepth(idom().idepth()+1); }
// Zero depth means uncached. Check before narrowing so overflow cannot wrap.
final int cacheIDepth(int depth) {
assert 0 <= depth && depth <= Character.MAX_VALUE : "Dominator depth exceeds 65535";
+ _idepthVersion = CodeGen.CODE.iDepthVersion();
return _idepth = (char)depth;
}
+ final boolean validIDepth() { return _idepth!=0 && _idepthVersion==CodeGen.CODE.iDepthVersion(); }
+
// Return the immediate dominator of this Node and compute dom tree depth.
public CFGNode idom(Node dep) { return cfg(0); }
@@ -83,24 +99,36 @@ public abstract class CFGNode extends Node {
// ------------------------------------------------------------------------
// Tag all CFG Nodes with their containing LoopNode; LoopNodes themselves
// also refer to *their* containing LoopNode, as well as have their depth.
- // Start is a LoopNode which contains all at depth 1.
+ // Start contains the function bodies at depth 0; real loops add depth.
public void buildLoopTree(StopNode stop) {
_ltree = stop._ltree = Parser.XCTRL._ltree = new LoopTree((StartNode)this);
- _bltWalk(2,stop, new BitSet());
+ _bltWalk(2,null,stop, new BitSet());
}
- private int _bltWalk(int pre, StopNode stop, BitSet post) {
+ int _bltWalk( int pre, FunNode fun, StopNode stop, BitSet post ) {
// Pre-walked?
if( _pre!=0 ) return pre;
_pre = pre++;
+ // Seed the function's outer tree before walking its body. Synthetic
+ // exits can be added before the post-order walk reaches the entry.
+ if( this instanceof FunNode ) _ltree = stop._ltree;
+ if( this instanceof ReturnNode ) {
+ _ltree = fun._ltree;
+ post.set(_nid);
+ return pre; // Stop/Start links describe the outside world, not a loop.
+ }
// Pre-walk
for( Node use : _outputs )
- if( use instanceof CFGNode usecfg )
- pre = usecfg._bltWalk(pre,stop,post);
+ if( use instanceof CFGNode usecfg && !skip(usecfg) )
+ pre = usecfg._bltWalk(pre,use instanceof FunNode fuse ? fuse : fun,stop,post);
// Post-order work: find innermost loop
LoopTree inner = null, ltree;
for( Node use : _outputs ) {
if( !(use instanceof CFGNode usecfg) ) continue;
+ if( skip(usecfg) ) continue;
+ if( usecfg._type == Type.XCONTROL || // Do not walk dead control
+ usecfg._type == TypeTuple.IF_NEITHER ) // Nor dead IFs
+ continue;
// Child visited but not post-visited?
if( !post.get(usecfg._nid) ) {
// Must be a backedge to a LoopNode then
@@ -113,7 +141,7 @@ public abstract class CFGNode extends Node {
if( ltree._par == null )
// This loop never had an If test choose to take its
// exit, i.e. it is a no-exit infinite loop.
- ltree._par = ltree._head.forceExit(stop)._ltree;
+ ltree._par = ltree._head.forceExit(fun,stop)._ltree;
ltree = ltree._par;
}
}
@@ -133,4 +161,13 @@ public abstract class CFGNode extends Node {
post.set(_nid);
return pre;
}
+
+ boolean skip(CFGNode usecfg) {
+ // Only walk control users that are alive.
+ // Do not walk from a Call to linked Fun's.
+ return usecfg instanceof XCtrlNode ||
+ (this instanceof CallNode && usecfg instanceof FunNode) ||
+ (this instanceof ReturnNode && usecfg instanceof CallEndNode);
+ }
+
}
diff --git a/src/main/java/com/seaofnodes/simple/node/CProjNode.java b/src/main/java/com/seaofnodes/simple/node/CProjNode.java
index 53348b5a..70238f8c 100644
--- a/src/main/java/com/seaofnodes/simple/node/CProjNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/CProjNode.java
@@ -7,7 +7,7 @@ import com.seaofnodes.simple.type.Type;
import com.seaofnodes.simple.type.TypeMem;
import com.seaofnodes.simple.type.TypeTuple;
-public class CProjNode extends CFGNode {
+public class CProjNode extends CFGNode implements MultiUse {
// Which slice of the incoming multipart value
public final int _idx;
@@ -22,6 +22,7 @@ public class CProjNode extends CFGNode {
}
@Override public String label() { return _label; }
+ @Override public int idx() { return _idx; }
@Override protected ExprPrinter<Node> _print1(ExprPrinter<Node> p) { return p.p(_label); }
@@ -49,7 +50,8 @@ public class CProjNode extends CFGNode {
if( ctrl() instanceof IfNode iff && iff.pred().addDep(this) instanceof NotNode not )
return new CProjNode(new IfNode(iff.ctrl(),not.in(1)).peephole(),1-_idx,_idx==0 ? "False" : "True");
- return null;
+ // Copy of some other input
+ return ((MultiNode)ctrl()).pcopy(_idx);
}
@Override
diff --git a/src/main/java/com/seaofnodes/simple/node/CallEndNode.java b/src/main/java/com/seaofnodes/simple/node/CallEndNode.java
new file mode 100644
index 00000000..2da09cfc
--- /dev/null
+++ b/src/main/java/com/seaofnodes/simple/node/CallEndNode.java
@@ -0,0 +1,95 @@
+package com.seaofnodes.simple.node;
+
+import com.seaofnodes.print.ExprPrinter;
+
+import com.seaofnodes.simple.CodeGen;
+import com.seaofnodes.simple.IterPeeps;
+import com.seaofnodes.simple.Parser;
+import com.seaofnodes.simple.Utils;
+import com.seaofnodes.simple.type.*;
+
+/**
+ * CallEnd
+ */
+public class CallEndNode extends CFGNode implements MultiNode {
+
+ // When set true, this Call/CallEnd/Fun/Return is being trivially inlined
+ private boolean _folding;
+ public boolean folding() { return _folding; }
+
+ public CallEndNode(CallNode call) { super(call); }
+
+ @Override
+ public String label() { return "CallEnd"; }
+ @Override public boolean isMultiHead() { return true; }
+ @Override public boolean blockHead() { return true; }
+
+ CallNode call() { return (CallNode)in(0); }
+
+ @Override
+ protected ExprPrinter<Node> _print1(ExprPrinter<Node> p) {
+ p.p("cend( ");
+ p.p( in(0) instanceof CallNode ? "Call, " : "----, ");
+ for( int i=1; i<nIns()-1; i++ )
+ p.n(in(i)).p(",");
+ return p.unchar(',').unchar(' ').close();
+ }
+
+ @Override
+ public Type compute() {
+ if( !(in(0) instanceof CallNode call) )
+ return TypeTuple.RET.dual();
+ Type ret = call.fptr().addDep(this)._type instanceof TypeFunPtr tfp ? tfp.ret() : Type.BOTTOM;
+ return TypeTuple.make(call._type,TypeMem.BOT,ret);
+ }
+
+ @Override
+ public Node idealize() {
+
+ // Trivial inlining: call site calls a single function; single function
+ // is only called by this call site.
+ if( !_folding && nIns()==2 ) {
+ CallNode call = call();
+ Node fptr = call.fptr();
+ if( fptr.nOuts() == 1 && // Only user is this call
+ fptr instanceof ConstantNode && // We have an immediate call
+ // Function is being called, and its not-null
+ fptr._type instanceof TypeFunPtr tfp && tfp.notNull() &&
+ // Arguments are correct
+ call.err()==null ) {
+ ReturnNode ret = (ReturnNode)in(1);
+ FunNode fun = ret.fun();
+ // Expecting Start, and the Call
+ if( fun.nIns()==3 ) {
+ assert fun.in(1) instanceof StartNode && fun.in(2)==call;
+ // Disallow self-recursive inlining (loop unrolling by another name)
+ CFGNode idom = call;
+ while( !(idom instanceof FunNode fun2) )
+ idom = idom.idom();
+ if( idom != fun ) {
+ // Trivial inline: rewrite
+ _folding = true;
+ // Rewrite Fun so the normal RegionNode ideal collapses
+ fun._folding = true;
+ fun.setDef(1,Parser.XCTRL); // No default/unknown StartNode caller
+ fun.setDef(2,call.ctrl()); // Bypass the Call;
+ fun.ret().setDef(3,null); // Return is folding also
+ IterPeeps.addAll(fun._outputs);
+ CodeGen.CODE.invalidateIDepthCaches();
+ return this;
+ }
+ } else {
+ fun.addDep(this);
+ }
+ } else { // Function ptr has multiple users (so maybe multiple call sites)
+ fptr.addDep(this);
+ }
+ }
+
+ return null;
+ }
+
+ @Override public Node pcopy(int idx) {
+ return _folding ? in(1).in(idx) : null;
+ }
+}
diff --git a/src/main/java/com/seaofnodes/simple/node/CallNode.java b/src/main/java/com/seaofnodes/simple/node/CallNode.java
new file mode 100644
index 00000000..10b04b38
--- /dev/null
+++ b/src/main/java/com/seaofnodes/simple/node/CallNode.java
@@ -0,0 +1,142 @@
+package com.seaofnodes.simple.node;
+
+import com.seaofnodes.print.ExprPrinter;
+
+import com.seaofnodes.simple.CodeGen;
+import com.seaofnodes.simple.IterPeeps;
+import com.seaofnodes.simple.Parser;
+import com.seaofnodes.simple.Utils;
+import com.seaofnodes.simple.type.Type;
+import com.seaofnodes.simple.type.TypeFunPtr;
+
+/**
+ * Call
+ */
+public class CallNode extends CFGNode {
+
+ // Source location for late reported errors
+ public final Parser.Lexer _loc;
+
+ public CallNode(Parser.Lexer loc, Node... nodes) { super(nodes); _loc = loc; }
+
+ @Override
+ public String label() { return "Call"; }
+
+ @Override
+ protected ExprPrinter<Node> _print1(ExprPrinter<Node> p) {
+ String fname = null;
+ Node fptr = fptr();
+ if( fptr._type instanceof TypeFunPtr tfp && tfp.isConstant() )
+ fname = tfp._name;
+ if( fname==null ) p.n(fptr);
+ else p.p(fname);
+ p.p("( ");
+ for( int i=2; i<nIns()-1; i++ )
+ p.n(in(i)).p(",");
+ return p.unchar(',').unchar(' ').close();
+ }
+
+ Node ctrl() { return in(0); }
+ Node mem () { return in(1); }
+ // Args mapped 1-to-1 on inputs, so conceptually start at 2
+ Node arg(int idx) { return in(idx); }
+ // Same arg accounting as TFPs, although the numbering starts at 2
+ int nargs() { return nIns()-3; } // Minus control, memory, fptr
+ // args from input 2 to last; last is function input
+ public Node fptr() { return _inputs.last(); }
+
+ // Find the Call End from the Call
+ public CallEndNode cend() {
+ // Always in use slot 0
+ if( nOuts()>0 && out(0) instanceof CallEndNode cend ) {
+ assert _cend()==cend;
+ return cend;
+ } else {
+ assert _cend()==null;
+ return null;
+ }
+ }
+ private CallEndNode _cend() {
+ CallEndNode cend=null;
+ for( Node n : _outputs )
+ if( n instanceof CallEndNode cend0 )
+ { assert cend == null; cend = cend0; }
+ return cend;
+ }
+
+ // Get the one control following; error to call with more than one e.g. an
+ // IfNode or other multi-way branch.
+ @Override public CFGNode uctrl() { return cend(); }
+
+
+ @Override
+ public Type compute() {
+ return ctrl()._type;
+ }
+
+ @Override
+ public Node idealize() {
+ CallEndNode cend = cend();
+ if( cend==null ) return null; // Still building
+
+ // Link: call calls target function. Linking makes the target FunNode
+ // point to this Call, and all his Parms point to the call arguments;
+ // also the CallEnd points to the Return.
+ if( fptr()._type instanceof TypeFunPtr tfp && tfp.nargs() == nargs() ) {
+ // If fidxs is negative, then infinite unknown functions
+ long fidxs = tfp.fidxs();
+ if( fidxs > 0 ) {
+ // Wipe out the return which matching in the linker table
+ // Walk the (63 max) bits and link
+ for( ; fidxs!=0; fidxs = TypeFunPtr.nextFIDX(fidxs) ) {
+ int fidx = Long.numberOfTrailingZeros(fidxs);
+ TypeFunPtr tfp0 = tfp.makeFrom(fidx);
+ FunNode fun = CodeGen.CODE.link(tfp0);
+ if( fun!=null && !fun._folding && !linked(fun) )
+ link(fun);
+ }
+ }
+ }
+
+ return null;
+ }
+
+ // True if Fun is linked to this Call
+ boolean linked( FunNode fun ) {
+ for( Node n : fun._inputs )
+ if( n == this )
+ return true;
+ return false;
+ }
+
+
+ // Link so this calls fun
+ private void link( FunNode fun ) {
+ assert !linked(fun);
+ fun.addDef(this);
+ for( Node use : fun._outputs )
+ if( use instanceof ParmNode parm )
+ parm.addDef(parm._idx==0 ? cend() : arg(parm._idx));
+ // Call end points to function return
+ IterPeeps.add(cend()).addDef(fun.ret());
+ assert linked(fun);
+ }
+
+ @Override
+ public Parser.ParseException err() {
+ if( !(fptr()._type instanceof TypeFunPtr tfp) )
+ throw Utils.TODO();
+ if( !tfp.notNull() )
+ return Parser.error( "Might be null calling "+tfp, _loc);
+ if( nargs() != tfp.nargs() )
+ return Parser.error( "Expecting "+tfp.nargs()+" arguments, but found "+nargs(), _loc);
+
+ // Check for args
+ for( int i=0; i<tfp.nargs(); i++ )
+ if( !arg(i+2)._type.isa(tfp.arg(i)) || !arg(i+2)._type.accessISA(tfp.arg(i)) )
+ return Parser.error( "Argument #"+i+" isa "+arg(i+2)._type+", but must be a "+tfp.arg(i), _loc);
+
+ return null;
+ }
+
+}
diff --git a/src/main/java/com/seaofnodes/simple/node/CastNode.java b/src/main/java/com/seaofnodes/simple/node/CastNode.java
index 9ade5a50..6bf8ee90 100644
--- a/src/main/java/com/seaofnodes/simple/node/CastNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/CastNode.java
@@ -2,10 +2,10 @@ package com.seaofnodes.simple.node;
import com.seaofnodes.print.ExprPrinter;
+import com.seaofnodes.simple.Parser;
+import com.seaofnodes.simple.Utils;
import com.seaofnodes.simple.type.Type;
import com.seaofnodes.simple.type.TypeInteger;
-import com.seaofnodes.simple.IterPeeps;
-
// Upcast (join) the input to a t. Used after guard test to lift an input.
// Can also be used to make a type-assertion if ctrl is null.
@@ -20,6 +20,7 @@ public class CastNode extends Node {
@Override public String label() { return "("+_t.str()+")"; }
+ @Override public boolean isConst() { return true; }
@Override protected ExprPrinter<Node> _print1(ExprPrinter<Node> p) {
return p.p(label()).n(in(1));
@@ -34,4 +35,21 @@ public class CastNode extends Node {
public Node idealize() {
return in(1)._type.isa(_t) ? in(1) : null;
}
+
+ @Override
+ boolean eq(Node n) {
+ CastNode cast = (CastNode)n; // Contract
+ return _t==cast._t;
+ }
+
+ @Override
+ int hash() { return _t.hashCode(); }
+
+ @Override
+ public Parser.ParseException err() {
+ // Has a condition to test, so OK
+ if( in(0) != null ) return null;
+ // No condition to test, so this must optimize away
+ throw Utils.TODO();
+ }
}
diff --git a/src/main/java/com/seaofnodes/simple/node/ConstantNode.java b/src/main/java/com/seaofnodes/simple/node/ConstantNode.java
index 426736ed..02d0289b 100644
--- a/src/main/java/com/seaofnodes/simple/node/ConstantNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/ConstantNode.java
@@ -3,6 +3,7 @@ package com.seaofnodes.simple.node;
import com.seaofnodes.print.ExprPrinter;
import com.seaofnodes.simple.Parser;
+import com.seaofnodes.simple.SB;
import com.seaofnodes.simple.type.Type;
@@ -19,25 +20,30 @@ import com.seaofnodes.simple.type.Type;
* The Constant's value is the value stored in it.
*/
public class ConstantNode extends Node {
- final Type _con;
+ public final Type _con;
public ConstantNode( Type type ) {
super(Parser.START);
_con = type;
}
+ public static Node make( Type type ) {
+ if( type==Type. CONTROL ) return new CtrlNode();
+ if( type==Type.XCONTROL ) return new XCtrlNode();
+ return new ConstantNode(type);
+ }
+
@Override protected String repeatName() {
return _con==null || _con.toString().length()<=32 ? null : uniqueName();
}
- @Override
- public String label() { return "Con"; }
-
+ @Override public String label() { return "Con"; }
@Override protected ExprPrinter<Node> _print1(ExprPrinter<Node> p) {
- return p.p(_con);
+ return p.p(_con.print(new SB()));
}
@Override public boolean isMultiTail() { return true; }
+ @Override public boolean isConst() { return true; }
@Override
public Type compute() { return _con; }
diff --git a/src/main/java/com/seaofnodes/simple/node/CtrlNode.java b/src/main/java/com/seaofnodes/simple/node/CtrlNode.java
new file mode 100644
index 00000000..9268381a
--- /dev/null
+++ b/src/main/java/com/seaofnodes/simple/node/CtrlNode.java
@@ -0,0 +1,15 @@
+package com.seaofnodes.simple.node;
+
+import com.seaofnodes.print.ExprPrinter;
+
+import com.seaofnodes.simple.Parser;
+import com.seaofnodes.simple.type.Type;
+
+public class CtrlNode extends CFGNode {
+ public CtrlNode() { super(Parser.START); }
+ @Override public String label() { return "Ctrl"; }
+ @Override protected ExprPrinter<Node> _print1(ExprPrinter<Node> p) { return p.p("Cctrl"); }
+ @Override public boolean isConst() { return true; }
+ @Override public Type compute() { return Type.CONTROL; }
+ @Override public Node idealize() { return null; }
+}
diff --git a/src/main/java/com/seaofnodes/simple/node/DivFNode.java b/src/main/java/com/seaofnodes/simple/node/DivFNode.java
index c678ac3e..a3f4318d 100644
--- a/src/main/java/com/seaofnodes/simple/node/DivFNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/DivFNode.java
@@ -29,7 +29,7 @@ public class DivFNode extends Node {
Type t1 = lhs._type;
Type t2 = rhs._type;
- // Div of 1.
+ // Div of 1.
if ( t2.isConstant() && t2 instanceof TypeFloat i && i.value()==1 )
return lhs;
diff --git a/src/main/java/com/seaofnodes/simple/node/DivNode.java b/src/main/java/com/seaofnodes/simple/node/DivNode.java
index 5b31d216..70631c0a 100644
--- a/src/main/java/com/seaofnodes/simple/node/DivNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/DivNode.java
@@ -4,7 +4,6 @@ package com.seaofnodes.simple.node;
import com.seaofnodes.simple.type.Type;
import com.seaofnodes.simple.type.TypeInteger;
-
public class DivNode extends Node {
public DivNode(Node lhs, Node rhs) { super(null, lhs, rhs); }
diff --git a/src/main/java/com/seaofnodes/simple/node/FRefNode.java b/src/main/java/com/seaofnodes/simple/node/FRefNode.java
new file mode 100644
index 00000000..bf1c5a00
--- /dev/null
+++ b/src/main/java/com/seaofnodes/simple/node/FRefNode.java
@@ -0,0 +1,35 @@
+package com.seaofnodes.simple.node;
+
+import com.seaofnodes.print.ExprPrinter;
+
+import com.seaofnodes.simple.Parser;
+import com.seaofnodes.simple.Var;
+import com.seaofnodes.simple.type.Type;
+
+/**
+ * A Forward Reference. Its any final constant, including functions. When
+ * the Def finally appears its plugged into the forward reference, which then
+ * peepholes to the Def.
+ */
+public class FRefNode extends ConstantNode {
+ public static final Type FREF_TYPE = Type.BOTTOM;
+ public final Var _n;
+ public FRefNode( Var n ) { super(FREF_TYPE); _n = n; }
+
+ @Override public String label() { return "FRef"+_n; }
+
+
+ @Override protected ExprPrinter<Node> _print1(ExprPrinter<Node> p) {
+ return p.p("FRef_").p(_n);
+ }
+
+ @Override public Node idealize() {
+ // When FRef finds its definition, idealize to it
+ return nIns()==1 ? null : in(1);
+ }
+
+ public Parser.ParseException err() { return Parser.error("Undefined name '"+_n._name+"'",_n._loc); }
+
+ @Override boolean eq(Node n) { return this==n; }
+ @Override int hash() { return _n._idx; }
+}
diff --git a/src/main/java/com/seaofnodes/simple/node/FunNode.java b/src/main/java/com/seaofnodes/simple/node/FunNode.java
new file mode 100644
index 00000000..ec60f215
--- /dev/null
+++ b/src/main/java/com/seaofnodes/simple/node/FunNode.java
@@ -0,0 +1,134 @@
+package com.seaofnodes.simple.node;
+
+import com.seaofnodes.simple.*;
+import com.seaofnodes.simple.type.Type;
+import com.seaofnodes.simple.type.TypeFunPtr;
+import java.util.BitSet;
+
+public class FunNode extends RegionNode {
+
+ // When set true, this Call/CallEnd/Fun/Return is being trivially inlined
+ boolean _folding;
+ public boolean folding() { return _folding; }
+
+ private TypeFunPtr _sig; // Initial signature
+ private ReturnNode _ret; // Return pointer
+
+ public FunNode( Parser.Lexer loc, StartNode start, TypeFunPtr sig ) { super(loc,null,start); _sig=sig; }
+
+ @Override
+ public String label() { return _sig._name == null ? "$fun" : _sig._name; }
+
+ // Find the one CFG user from Fun. It's not always the Return, but always
+ // the Return *is* a CFG user of Fun.
+ @Override public CFGNode uctrl() {
+ for( Node n : _outputs )
+ if( n instanceof CFGNode cfg &&
+ (cfg instanceof RegionNode || cfg.cfg0()==this) )
+ return cfg;
+ return null;
+ }
+
+ public ParmNode rpc() {
+ ParmNode rpc = null;
+ for( Node n : _outputs )
+ if( n instanceof ParmNode parm && parm._idx==0 )
+ { assert rpc==null; rpc=parm; }
+ return rpc;
+ }
+
+ // Cannot create the Return and Fun at the same time; one has to be first.
+ // So setting the return requires a second step.
+ public void setRet(ReturnNode ret) { _ret=ret; }
+ ReturnNode ret() { assert _ret!=null; return _ret; }
+
+ // Signature can improve over time
+ public TypeFunPtr sig() { return _sig; }
+ void setSig( TypeFunPtr sig ) {
+ assert sig.isa(_sig);
+ if( _sig != sig )
+ IterPeeps.add(this);
+ _sig = sig;
+ }
+
+ @Override
+ public Type compute() {
+ // Only dead if no callers after SCCP
+ return Type.CONTROL;
+ }
+
+ @Override
+ public Node idealize() {
+ // When can we assume no callers? Or no other callers (except main)?
+ // In a partial compilation, we assume Start gets access to any/all
+ // top-level public structures and recursively what they point to.
+ // This in turn is valid arguments to every callable function.
+ //
+ // In a total compilation, we can start from Start and keep things
+ // more contained.
+
+
+ // If no default/unknown caller, use the normal RegionNode ideal rules
+ // to collapse
+ if( unknownCallers() ) return null;
+ Node progress = super.idealize();
+ if( progress!=null ) {
+ IterPeeps.add( CodeGen.CODE._stop);
+ IterPeeps.add( _ret );
+ }
+ return progress;
+ }
+
+ // Unfolded functions are roots; inlining reconnects their depth to the caller.
+ @Override public int idepth() { return _folding ? super.idepth() : 1; }
+ // Bypass Region idom, always assume idom is Start
+ @Override public CFGNode idom(Node dep) { return cfg(1); }
+
+ // Always in-progress until we run out of unknown callers
+ public boolean unknownCallers() { return in(1) instanceof StartNode; }
+
+ @Override public boolean inProgress() { return unknownCallers(); }
+
+ // Add a new function exit point.
+ public void addReturn(Node ctrl, Node mem, Node rez) { _ret.addReturn(ctrl,mem,rez); }
+
+ // Build the function body
+ public BitSet body() {
+
+ // Reverse up (stop to start) CFG only, collect bitmap.
+ BitSet cfgs = new BitSet();
+ cfgs.set(_nid);
+ walkUp(ret(),cfgs );
+
+ // Top down (start to stop) all flavors. CFG limit to bitmap.
+ // If data use bottoms out in wrong CFG, returns false - but tries all outputs.
+ // If any output hits an in-CFG use (e.g. phi), then keep node.
+ BitSet body = new BitSet();
+ walkDown(this, cfgs, body, new BitSet());
+ return body;
+ }
+
+ private static void walkUp(CFGNode n, BitSet cfgs) {
+ if( cfgs.get(n._nid) ) return;
+ cfgs.set(n._nid);
+ if( n instanceof RegionNode r )
+ for( int i=1; i<n.nIns(); i++ )
+ walkUp(n.cfg(i),cfgs);
+ else walkUp(n.cfg0(),cfgs);
+ }
+
+ private static boolean walkDown( Node n, BitSet cfgs, BitSet body, BitSet visit ) {
+ if( visit.get(n._nid) ) return body.get(n._nid);
+ visit.set(n._nid);
+
+ if( n instanceof CFGNode && !cfgs.get(n._nid) )
+ return false;
+ if( n.in(0)!=null && !cfgs.get(n.in(0)._nid) )
+ return false;
+ boolean in = n.in(0)!=null || n instanceof CFGNode;
+ for( Node use : n._outputs )
+ in |= walkDown(use,cfgs,body,visit);
+ if( in ) body.set(n._nid);
+ return in;
+ }
+}
diff --git a/src/main/java/com/seaofnodes/simple/node/IfNode.java b/src/main/java/com/seaofnodes/simple/node/IfNode.java
index 2b53b3a3..a3061b63 100644
--- a/src/main/java/com/seaofnodes/simple/node/IfNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/IfNode.java
@@ -2,9 +2,7 @@ package com.seaofnodes.simple.node;
import com.seaofnodes.simple.IterPeeps;
-import com.seaofnodes.simple.type.Type;
-import com.seaofnodes.simple.type.TypeInteger;
-import com.seaofnodes.simple.type.TypeTuple;
+import com.seaofnodes.simple.type.*;
import java.util.HashSet;
public class IfNode extends CFGNode implements MultiNode {
@@ -24,6 +22,9 @@ public class IfNode extends CFGNode implements MultiNode {
public Node ctrl() { return in(0); }
public Node pred() { return in(1); }
+ // No one unique control follows
+ @Override public CFGNode uctrl() { return null; }
+
@Override
public Type compute() {
// If the If node is not reachable then neither is any following Proj
@@ -33,14 +34,14 @@ public class IfNode extends CFGNode implements MultiNode {
Type t = pred._type;
// High types mean NEITHER side is reachable.
// Wait until the type falls to decide which way to go.
- if( t == Type.TOP || t == TypeInteger.TOP )
+ if( t.isHigh() )
return TypeTuple.IF_NEITHER;
// If constant is 0 then false branch is reachable
// Else true branch is reachable
if( t.isConstant() )
- return t.makeInit()==t ? TypeTuple.IF_FALSE : TypeTuple.IF_TRUE;
- // Integers allow non-zero ranges: "1-65535"
- if( t.makeZero().meet(t) != t )
+ return (t==Type.NIL || t==TypeInteger.ZERO || (t instanceof TypeFunPtr tfp && tfp._fidxs==0) ) ? TypeTuple.IF_FALSE : TypeTuple.IF_TRUE;
+ // If adding a zero makes a difference, the predicate must not have a zero/null
+ if( !t.makeZero().isa(t) )
return TypeTuple.IF_TRUE;
return TypeTuple.IF_BOTH;
@@ -53,7 +54,7 @@ public class IfNode extends CFGNode implements MultiNode {
if( !pred()._type.isHighOrConst() )
for( CFGNode dom = idom(), prior=this; dom!=null; prior = dom, dom = dom.idom() )
if( dom.addDep(this) instanceof IfNode iff && iff.pred().addDep(this)==pred() && prior instanceof CProjNode prj ) {
- setDef(1,new ConstantNode(TypeInteger.make(true,prj._idx==0?1:0)).peephole());
+ setDef(1,new ConstantNode(TypeInteger.constant(prj._idx==0?1:0)).peephole());
return this;
}
return null;
diff --git a/src/main/java/com/seaofnodes/simple/node/LoadNode.java b/src/main/java/com/seaofnodes/simple/node/LoadNode.java
index eaab680c..5190bf08 100644
--- a/src/main/java/com/seaofnodes/simple/node/LoadNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/LoadNode.java
@@ -2,6 +2,7 @@ package com.seaofnodes.simple.node;
import com.seaofnodes.print.ExprPrinter;
+import com.seaofnodes.simple.Parser;
import com.seaofnodes.simple.Utils;
import com.seaofnodes.simple.IterPeeps;
import com.seaofnodes.simple.type.*;
@@ -22,15 +23,15 @@ public class LoadNode extends MemOpNode {
* @param ptr The ptr to the struct base from where we load a field
* @param off The offset inside the struct base
*/
- public LoadNode(String name, int alias, Type glb, Node mem, Node ptr, Node off) {
- super(name, alias, glb, mem, ptr, off);
+ public LoadNode(Parser.Lexer loc, String name, int alias, Type glb, Node mem, Node ptr, Node off) {
+ super(loc, name, alias, glb, mem, ptr, off);
}
@Override boolean canDrop(MemOpNode other, Node dep) {
return super.canDrop(other,dep) && !clobbered(dep);
}
- // Check only immediate memory users. Stores clobber memory; Phis and
+ // Check only immediate memory users. Writers clobber memory; Phis and
// aggregates might lead to a clobber, so stop rather than search further.
private boolean clobbered(Node dep) {
Node mem = mem();
@@ -40,7 +41,7 @@ public class LoadNode extends MemOpNode {
use.addDepForwards(dep);
if( use instanceof StoreNode || use instanceof PhiNode ||
use instanceof MemMergeNode ||
- use instanceof NewNode ) return true;
+ use instanceof NewNode || use instanceof CallNode ) return true;
}
return false;
}
@@ -95,7 +96,7 @@ public class LoadNode extends MemOpNode {
mem = merge.alias(_alias);
break;
case StoreNode st:
- if( _alias==st._alias && ptr == st.ptr() && off() == st.off() )
+ if( _alias==st._alias && ptr == st.ptr().addDep(this) && off() == st.off() )
return castRO(st.val()); // Proved equal
// Can we prove unequal? Offsets do not overlap?
if( _alias==st._alias && !off()._type.join(st.off()._type).isHigh() && // Offsets overlap
@@ -104,17 +105,26 @@ public class LoadNode extends MemOpNode {
// Pointers cannot overlap
mem = st.mem(); // Proved never equal
break;
- case PhiNode phi: break outer; // Assume related
+ case PhiNode phi:
+ // Assume related
+ phi.addDep(this);
+ break outer;
case ConstantNode top: break outer; // Assume shortly dead
- case ProjNode mproj:
- if( mproj.in(0) instanceof NewNode nnn1 ) {
+ case ProjNode mproj: // Memory projection
+ switch( mproj.in(0) ) {
+ case NewNode nnn1:
if( ptr instanceof ProjNode pproj && pproj.in(0) == mproj.in(0) )
return castRO(nnn1.in(nnn1.findAlias(_alias))); // Load from New init
if( !(ptr instanceof ProjNode pproj && pproj.in(0) instanceof NewNode nnn2) )
break outer; // Cannot tell, ptr not related to New
mem = nnn1.mem();// Bypass unrelated New
break;
- } else break outer;
+ case StartNode start: break outer;
+ case CallEndNode cend: break outer; // TODO: Bypass no-alias call
+ default: throw Utils.TODO();
+ }
+ break;
+
default:
break outer;
}
@@ -148,7 +158,7 @@ public class LoadNode extends MemOpNode {
private Node ld( int idx ) {
Node mem = mem(), ptr = ptr();
- LoadNode ld = new LoadNode(_name,_alias,_declaredType,mem.in(idx),ptr instanceof PhiNode && ptr.in(0)==mem.in(0) ? ptr.in(idx) : ptr,off());
+ LoadNode ld = new LoadNode(_loc,_name,_alias,_declaredType,mem.in(idx),ptr instanceof PhiNode && ptr.in(0)==mem.in(0) ? ptr.in(idx) : ptr,off());
ld.setDef(0,in(0));
return ld.peephole();
}
@@ -212,7 +222,8 @@ public class LoadNode extends MemOpNode {
Node slice = _alias<merge.nIns() ? merge.in(_alias) : null;
if( (slice==mem) || (slice==null && merge.in(1)==mem) )
antiDeps(merge,deps,visit);
- } else if( (use instanceof StoreNode st && st._alias==_alias) ||
+ } else if( use instanceof CallNode ||
+ (use instanceof StoreNode st && st._alias==_alias) ||
(use instanceof NewNode nnn && nnn.field(_alias)!=null) ||
(use instanceof MemPhiNode phi && phi._alias==_alias) ||
(use instanceof BulkMemPhiNode phi && !phi.isSplit(_alias)) ) {
diff --git a/src/main/java/com/seaofnodes/simple/node/LogicalNode.java b/src/main/java/com/seaofnodes/simple/node/LogicalNode.java
new file mode 100644
index 00000000..c59bd948
--- /dev/null
+++ b/src/main/java/com/seaofnodes/simple/node/LogicalNode.java
@@ -0,0 +1,27 @@
+package com.seaofnodes.simple.node;
+
+import com.seaofnodes.print.ExprPrinter;
+
+import com.seaofnodes.simple.Parser;
+import com.seaofnodes.simple.type.Type;
+import com.seaofnodes.simple.type.TypeInteger;
+
+public abstract class LogicalNode extends Node {
+ // Source location for late reported errors
+ Parser.Lexer _loc;
+
+ public LogicalNode(Parser.Lexer loc, Node lhs, Node rhs) { super(null, lhs, rhs); _loc = loc; }
+ abstract String op();
+
+ @Override protected ExprPrinter<Node> _print1(ExprPrinter<Node> p) {
+ return p.open().n(in(1)).p(op()).n(in(2)).close();
+ }
+
+
+ @Override public Parser.ParseException err() {
+ if( in(1)._type.isHigh() || in(2)._type.isHigh() ) return null;
+ if( !(in(1)._type instanceof TypeInteger) ) return Parser.error("Cannot '"+op()+"' " + in(1)._type.glb(),_loc);
+ if( !(in(2)._type instanceof TypeInteger) ) return Parser.error("Cannot '"+op()+"' " + in(2)._type.glb(), _loc);
+ return null;
+ }
+}
diff --git a/src/main/java/com/seaofnodes/simple/node/LoopNode.java b/src/main/java/com/seaofnodes/simple/node/LoopNode.java
index 8fb6a4ce..f26df076 100644
--- a/src/main/java/com/seaofnodes/simple/node/LoopNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/LoopNode.java
@@ -3,12 +3,13 @@ package com.seaofnodes.simple.node;
import com.seaofnodes.simple.Parser;
import com.seaofnodes.simple.Utils;
import com.seaofnodes.simple.type.Type;
+import com.seaofnodes.simple.type.TypeMem;
import com.seaofnodes.simple.type.TypeInteger;
import java.util.BitSet;
import java.util.HashSet;
public class LoopNode extends RegionNode {
- public LoopNode( Node entry ) { super(null,entry,null); }
+ public LoopNode( Parser.Lexer loc, Node entry ) { super(loc,null,entry,null); }
public CFGNode entry() { return cfg(1); }
public CFGNode back () { return cfg(2); }
@@ -22,19 +23,14 @@ public class LoopNode extends RegionNode {
return entry()._type;
}
- @Override
- public Node idealize() {
- return inProgress() ? null : super.idealize();
- }
-
// Bypass Region idom, same as the default idom() using use in(1) instead of in(0)
- @Override public int idepth() { return _idepth!=0 ? _idepth : cacheIDepth(entry().idepth()+1); }
+ @Override public int idepth() { return validIDepth() ? _idepth : cacheIDepth(entry().idepth()+1); }
// Bypass Region idom, same as the default idom() using use in(1) instead of in(0)
@Override public CFGNode idom(Node dep) { return entry(); }
// If this is an unreachable loop, it may not have an exit. If it does not
// (i.e., infinite loop), force an exit to make it reachable.
- public StopNode forceExit( StopNode stop ) {
+ public FunNode forceExit( FunNode fun, StopNode stop ) {
// Walk the backedge, then immediate dominator tree util we hit this
// Loop again. If we ever hit a CProj from an If (as opposed to
// directly on the If) we found our exit.
@@ -42,20 +38,51 @@ public class LoopNode extends RegionNode {
while( x != this ) {
if( x instanceof CProjNode exit && exit.in(0) instanceof IfNode iff ) {
CFGNode other = iff.cproj(1-exit._idx);
- if( other.loopDepth() < loopDepth() )
- return stop; // Found an exit, not an infinite loop
+ if( other!=null && other.loopDepth() < loopDepth() )
+ return fun; // Found an exit, not an infinite loop
}
x = x.idom();
}
// Found a no-exit loop. Insert an exit
NeverNode iff = new NeverNode(back());
for( Node use : _outputs )
- if( use instanceof PhiNode phi )
+ if( use instanceof PhiNode )
iff.addDef(use);
- CProjNode t = new CProjNode(iff,0,"True" );
- CProjNode f = new CProjNode(iff,1,"False");
+ CProjNode t = new CProjNode(iff,0,"True" ).init();
+ CProjNode f = new CProjNode(iff,1,"False").init();
setDef(2,f);
- stop.addDef(new ReturnNode(t,Parser.ZERO,null));
- return stop;
+
+ // Now fold control into the exit. Might have 1 valid exit, or an
+ // XCtrl or a bunch of prior NeverNode exits.
+ Node top = new ConstantNode(Type.TOP).peephole();
+ ReturnNode ret = fun.ret();
+ iff._ltree = f._ltree = _ltree;
+ ret._ltree = t._ltree = fun._ltree;
+ Node ctrl = ret.ctrl(), mem = ret.mem(), expr = ret.expr();
+ if( ctrl._type != Type.XCONTROL ) {
+ // Perfect aligned exit?
+ if( !(ctrl instanceof RegionNode r &&
+ mem instanceof PhiNode pmem && pmem.region()==r &&
+ expr instanceof PhiNode prez && prez.region()==r ) ) {
+ // Nope, insert an aligned exit layer
+ ctrl = new RegionNode(_loc,null,ctrl).init();
+ mem = new PhiNode((RegionNode)ctrl,mem ).init();
+ expr = new PhiNode((RegionNode)ctrl,expr).init();
+ }
+ // Append new Never exit
+ ctrl.addDef(t );
+ mem .addDef(top);
+ expr.addDef(top);
+ } else {
+ ctrl = t;
+ mem = top;
+ expr = top;
+ }
+ ((CFGNode)ctrl)._ltree = fun._ltree;
+ ret.setDef(0,ctrl);
+ ret.setDef(1,mem );
+ ret.setDef(2,expr);
+
+ return fun;
}
}
diff --git a/src/main/java/com/seaofnodes/simple/node/MemMergeNode.java b/src/main/java/com/seaofnodes/simple/node/MemMergeNode.java
index faf456de..5cb908bb 100644
--- a/src/main/java/com/seaofnodes/simple/node/MemMergeNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/MemMergeNode.java
@@ -43,9 +43,8 @@ public class MemMergeNode extends Node {
Node init = nnn.in(nnn.findAlias(alias)).addDep(dep);
return contents(nnn.mem(),alias,dep).meet(init._type);
}
- // There are no heap arguments in this chapter. Before the first New,
- // the set of allocated objects (and hence stored values) is empty.
- if( mem instanceof ProjNode proj && proj.in(0) instanceof StartNode ) return Type.TOP;
+ // Function parameters and call results may contain arbitrary heap values.
+ // Their bulk memory types do not imply empty or zero-filled storage.
if( mem._type==Type.TOP || mem._type==TypeMem.TOP ) return Type.TOP;
if( mem._type instanceof TypeMem mt && mt._alias==alias ) return mt._t;
return Type.BOTTOM;
diff --git a/src/main/java/com/seaofnodes/simple/node/MemOpNode.java b/src/main/java/com/seaofnodes/simple/node/MemOpNode.java
index 0bf9b6ac..c09f2725 100644
--- a/src/main/java/com/seaofnodes/simple/node/MemOpNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/MemOpNode.java
@@ -1,5 +1,7 @@
package com.seaofnodes.simple.node;
+import com.seaofnodes.simple.Parser;
+import com.seaofnodes.simple.Utils;
import com.seaofnodes.simple.type.Type;
import com.seaofnodes.simple.type.TypeMemPtr;
@@ -13,15 +15,18 @@ public abstract class MemOpNode extends Node {
// Declared type; not final because it might be a forward-reference
// which will be lazily improved when the reference is declared.
public Type _declaredType;
+ // Source location for late reported errors
+ public final Parser.Lexer _loc;
- public MemOpNode(String name, int alias, Type glb, Node mem, Node ptr, Node off) {
+ public MemOpNode(Parser.Lexer loc, String name, int alias, Type glb, Node mem, Node ptr, Node off) {
super(null, mem, ptr, off);
_name = name;
_alias = alias;
_declaredType = glb;
+ _loc = loc;
}
- public MemOpNode(String name, int alias, Type glb, Node mem, Node ptr, Node off, Node value) {
- this(name, alias, glb, mem, ptr, off);
+ public MemOpNode(Parser.Lexer loc, String name, int alias, Type glb, Node mem, Node ptr, Node off, Node value) {
+ this(loc,name, alias, glb, mem, ptr, off);
addDef(value);
}
@@ -50,13 +55,14 @@ public abstract class MemOpNode extends Node {
int hash() { return _alias; }
@Override
- String err() {
+ public Parser.ParseException err() {
Type ptr = ptr()._type;
// Already an error, but better error messages come from elsewhere
if( ptr == Type.BOTTOM ) return null;
+ if( ptr.isHigh() ) return null; // Assume it will fall to not-null
// Better be a not-nil TMP
- if( ptr instanceof TypeMemPtr tmp && !tmp._nil )
+ if( ptr instanceof TypeMemPtr tmp && tmp.notNull() )
return null;
- return "Might be null accessing '" + _name + "'";
+ return Parser.error( "Might be null accessing '" + _name + "'",_loc);
}
}
diff --git a/src/main/java/com/seaofnodes/simple/node/MinusFNode.java b/src/main/java/com/seaofnodes/simple/node/MinusFNode.java
index 1b45c7c5..852e646d 100644
--- a/src/main/java/com/seaofnodes/simple/node/MinusFNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/MinusFNode.java
@@ -16,7 +16,7 @@ public class MinusFNode extends Node {
public Type compute() {
if (in(1)._type instanceof TypeFloat i0)
return i0.isConstant() ? TypeFloat.constant(-i0.value()) : i0;
- return TypeFloat.BOT;
+ return TypeFloat.F64;
}
@Override
diff --git a/src/main/java/com/seaofnodes/simple/node/MinusNode.java b/src/main/java/com/seaofnodes/simple/node/MinusNode.java
index b85af74e..66e26163 100644
--- a/src/main/java/com/seaofnodes/simple/node/MinusNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/MinusNode.java
@@ -15,19 +15,17 @@ public class MinusNode extends Node {
@Override
public Type compute() {
- if( in(1)._type instanceof TypeInteger i0 ) {
- if( i0.isHigh() ) return TypeInteger.TOP;
- if( i0==TypeInteger.BOT || i0._min == Long.MIN_VALUE || i0._max == Long.MIN_VALUE )
- return TypeInteger.BOT;
+ if( in(1)._type.isHigh() ) return TypeInteger.TOP;
+ if( in(1)._type instanceof TypeInteger i0 &&
+ !(i0==TypeInteger.BOT || i0._min == Long.MIN_VALUE || i0._max == Long.MIN_VALUE) )
return TypeInteger.make(-i0._max,-i0._min);
- }
- return in(1)._type.isHigh() ? TypeInteger.TOP : TypeInteger.BOT;
+ return TypeInteger.BOT;
}
@Override
public Node idealize() {
// -(-x) is x
- if( in(1) instanceof MinusNode minus )
+ if( in(1) instanceof MinusNode minus && addDep(minus.in(1))._type instanceof TypeInteger )
return minus.in(1);
return null;
diff --git a/src/main/java/com/seaofnodes/simple/node/MulNode.java b/src/main/java/com/seaofnodes/simple/node/MulNode.java
index 50404922..2c1ba3de 100644
--- a/src/main/java/com/seaofnodes/simple/node/MulNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/MulNode.java
@@ -1,10 +1,10 @@
package com.seaofnodes.simple.node;
+import com.seaofnodes.simple.Parser;
import com.seaofnodes.simple.type.Type;
import com.seaofnodes.simple.type.TypeInteger;
-
public class MulNode extends Node {
public MulNode(Node lhs, Node rhs) { super(null, lhs, rhs); }
@@ -53,9 +53,10 @@ public class MulNode extends Node {
}
@Override Node copy(Node lhs, Node rhs) { return new MulNode(lhs,rhs); }
@Override Node copyF() { return new MulFNode(null,null); }
- @Override public String err() {
- if( !(in(1)._type instanceof TypeInteger) ) return "Cannot '"+label()+"' " + in(1)._type;
- if( !(in(2)._type instanceof TypeInteger) ) return "Cannot '"+label()+"' " + in(2)._type;
+ @Override public Parser.ParseException err() {
+ if( in(1)._type.isHigh() || in(2)._type.isHigh() ) return null;
+ if( !(in(1)._type instanceof TypeInteger) ) return Parser.error("Cannot '"+label()+"' " + in(1)._type,null);
+ if( !(in(2)._type instanceof TypeInteger) ) return Parser.error("Cannot '"+label()+"' " + in(2)._type,null);
return null;
}
}
diff --git a/src/main/java/com/seaofnodes/simple/node/MultiNode.java b/src/main/java/com/seaofnodes/simple/node/MultiNode.java
index ac9c0045..17d00881 100644
--- a/src/main/java/com/seaofnodes/simple/node/MultiNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/MultiNode.java
@@ -1,6 +1,11 @@
package com.seaofnodes.simple.node;
-public interface MultiNode extends OutNode {
+import com.seaofnodes.simple.Ary;
+
+
+public interface MultiNode {
+
+ abstract Ary<Node> outs();
// Find a projection by index
default ProjNode proj( int idx ) {
@@ -17,4 +22,8 @@ public interface MultiNode extends OutNode {
return prj;
return null;
}
+
+ // Return not-null if this projection index is a ideal copy.
+ // Called by ProjNode ideal and used to collapse Multis.
+ default Node pcopy(int idx) { return null; }
}
diff --git a/src/main/java/com/seaofnodes/simple/node/MultiUse.java b/src/main/java/com/seaofnodes/simple/node/MultiUse.java
new file mode 100644
index 00000000..436d3432
--- /dev/null
+++ b/src/main/java/com/seaofnodes/simple/node/MultiUse.java
@@ -0,0 +1,5 @@
+package com.seaofnodes.simple.node;
+
+public interface MultiUse {
+ abstract int idx();
+}
diff --git a/src/main/java/com/seaofnodes/simple/node/NewNode.java b/src/main/java/com/seaofnodes/simple/node/NewNode.java
index 51341c41..cd639d7e 100644
--- a/src/main/java/com/seaofnodes/simple/node/NewNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/NewNode.java
@@ -14,11 +14,12 @@ public class NewNode extends Node implements MultiNode {
public NewNode(TypeMemPtr ptr, Node... nodes) {
super(nodes);
+ assert !ptr.nullable();
_ptr = ptr;
assert nodes.length==3+ptr._obj._fields.length;
assert nodes[0]._type==Type.CONTROL || nodes[0]._type==Type.XCONTROL;
assert nodes[1]._type instanceof TypeMem;
- assert nodes[2]._type instanceof TypeInteger;
+ assert nodes[2]._type instanceof TypeInteger || nodes[2]._type==Type.NIL;
for( int i=3; i<nodes.length; i++ ) assert nodes[i]._type!=null;
}
diff --git a/src/main/java/com/seaofnodes/simple/node/Node.java b/src/main/java/com/seaofnodes/simple/node/Node.java
index e70fe495..114a652a 100644
--- a/src/main/java/com/seaofnodes/simple/node/Node.java
+++ b/src/main/java/com/seaofnodes/simple/node/Node.java
@@ -2,12 +2,9 @@ package com.seaofnodes.simple.node;
import com.seaofnodes.print.BaseNode;
-import com.seaofnodes.simple.Parser;
+import com.seaofnodes.simple.CodeGen;
-import com.seaofnodes.simple.Ary;
-import com.seaofnodes.simple.IRPrinter;
-import com.seaofnodes.simple.IterPeeps;
-import com.seaofnodes.simple.Utils;
+import com.seaofnodes.simple.*;
import com.seaofnodes.simple.type.Type;
import com.seaofnodes.simple.type.TypeFloat;
import java.util.*;
@@ -18,7 +15,7 @@ import java.util.function.Function;
* The Node class provides common functionality used by all subtypes.
* Subtypes of Node specialize by overriding methods.
*/
-public abstract class Node extends BaseNode<Node> implements OutNode, Cloneable {
+public abstract class Node extends BaseNode<Node> implements Cloneable {
/**
* Inputs to the node. These are use-def references to Nodes.
@@ -71,6 +68,7 @@ public abstract class Node extends BaseNode<Node> implements OutNode, Cloneable
public boolean isMultiHead() { return false; }
public boolean isMultiTail() { return false; }
+ public boolean isConst () { return false; }
// ------------------------------------------------------------------------
// Graph Node & Edge manipulation
@@ -84,7 +82,7 @@ public abstract class Node extends BaseNode<Node> implements OutNode, Cloneable
*/
public Node in(int i) { return _inputs.get(i); }
public Node out(int i) { return _outputs.get(i); }
- @Override public Ary<Node> outs() { return _outputs; }
+ public final Ary<Node> outs() { return _outputs; }
public int nIns() { return _inputs.size(); }
@@ -121,9 +119,11 @@ public abstract class Node extends BaseNode<Node> implements OutNode, Cloneable
new_def.addUse(this);
// Set the new_def over the old (killed) edge
_inputs.set(idx,new_def);
- if( old_def != null && // If the old def exists, remove a def->use edge
- old_def.delUse(this) ) // If we removed the last use, the old def is now dead
- old_def.kill(); // Kill old def
+ if( old_def != null ) { // If the old def exists, remove a def->use edge
+ if( old_def.delUse(this) ) // If we removed the last use, the old def is now dead
+ old_def.kill(); // Kill old def
+ else IterPeeps.add(old_def);// Else old lost a use, so onto worklist
+ }
moveDepsToWorklist();
// Return new_def for easy flow-coding
return new_def;
@@ -249,10 +249,10 @@ public abstract class Node extends BaseNode<Node> implements OutNode, Cloneable
* Always returns some not-null Node (often this).
*/
public final Node peephole() {
- var obs = IterPeeps.midAssert() ? null : Parser.PARSER == null ? null : Parser.PARSER._obs;
+ var obs = CodeGen.CODE == null || IterPeeps.midAssert() || CodeGen.CODE._phase == CodeGen.Phase.Parse && CodeGen.CODE.P == null ? null : CodeGen.CODE._obs;
if( obs != null ) obs.before(this);
Node n = peepholeOpt();
- Node rez = n == null ? this : deadCodeElim(n.peephole());
+ Node rez = n == null ? this : deadCodeElim(n._nid >= _nid ? n.peephole() : n);
if( obs != null ) obs.after(this, n == null ? null : rez, false);
return rez;
}
@@ -280,9 +280,9 @@ public abstract class Node extends BaseNode<Node> implements OutNode, Cloneable
// Compute initial or improved Type
Type old = setType(compute());
- // Replace constant computations from non-constants with a constant node
- if( !(this instanceof ConstantNode) && !(this instanceof XCtrlNode) && _type.isHighOrConst() )
- return (_type==Type.XCONTROL ? new XCtrlNode() : new ConstantNode(_type)).peepholeOpt();
+ // Replace constant computations from non-constants with a constant node.
+ if( _type.isHighOrConst() && !isConst() )
+ return ConstantNode.make(_type).peepholeOpt();
// Global Value Numbering
if( _hash==0 ) {
@@ -305,8 +305,9 @@ public abstract class Node extends BaseNode<Node> implements OutNode, Cloneable
if( n != null ) // Something changed
return n; // Report progress
- if( old==_type ) ITER_NOP_CNT++;
- return old==_type ? null : this; // Report progress
+ if( old!=_type ) return this; // Report progress;
+ ITER_NOP_CNT++;
+ return null; // No progress
}
public static int ITER_CNT, ITER_NOP_CNT;
@@ -357,6 +358,8 @@ public abstract class Node extends BaseNode<Node> implements OutNode, Cloneable
return old;
}
+ public <N extends Node> N init() { _type = compute(); return (N)this; }
+
/**
* This function rewrites the current Node into a more "idealized" form.
* This is the bulk of our peephole rewrite rules, and we use this to
@@ -430,7 +433,7 @@ public abstract class Node extends BaseNode<Node> implements OutNode, Cloneable
// Running peepholes during the big assert cannot have side effects
// like adding dependencies.
if( IterPeeps.midAssert() ) return this;
- var obs = IterPeeps.midAssert() ? null : Parser.PARSER == null ? null : Parser.PARSER._obs;
+ var obs = CodeGen.CODE == null || IterPeeps.midAssert() || CodeGen.CODE._phase == CodeGen.Phase.Parse && CodeGen.CODE.P == null ? null : CodeGen.CODE._obs;
if( obs != null ) obs.dep(this, dep);
if( _deps==null ) _deps = new Ary<>(Node.class);
if( _deps .find(dep) != -1 ) return this; // Already on list
@@ -528,9 +531,7 @@ public abstract class Node extends BaseNode<Node> implements OutNode, Cloneable
// Swap inputs without letting either input go dead during the swap.
Node swap12() {
unlock(); // Hash is order dependent
- Node tmp = in(1);
- _inputs.set(1,in(2));
- _inputs.set(2,tmp);
+ _inputs.swap(1,2);
return this;
}
@@ -555,14 +556,14 @@ public abstract class Node extends BaseNode<Node> implements OutNode, Cloneable
// Does not need to be implemented in isCFG() nodes.
Node copy(Node lhs, Node rhs) { throw Utils.TODO("Binary ops need to implement copy"); }
- // Exact-class copy preserving operation attributes, with fresh identity
- // and no edges, dependencies, or GVN membership.
+ // Exact-class copy with fresh identity and no edges. Unlike machine
+ // rematerialization copies, this never registers or copies input edges.
public final Node copyEmpty() {
Node n;
try { n = (Node)clone(); }
- catch( CloneNotSupportedException e ) { throw new AssertionError(e); }
- n._nid = UNIQUE_ID++;
- n._inputs = new Ary<>(Node.class);
+ catch( Exception e ) { throw new RuntimeException(e); }
+ n._nid = UNIQUE_ID++; // allocate unique dense ID
+ n._inputs = new Ary<>(Node.class);
n._outputs = new Ary<>(Node.class);
n._deps = null;
n._hash = 0;
@@ -570,7 +571,7 @@ public abstract class Node extends BaseNode<Node> implements OutNode, Cloneable
}
// Report any post-optimize errors
- String err() { return null; }
+ public Parser.ParseException err() { return null; }
/**
* Used to allow repeating tests in the same JVM. This just resets the
diff --git a/src/main/java/com/seaofnodes/simple/node/NotNode.java b/src/main/java/com/seaofnodes/simple/node/NotNode.java
index b9cf4904..57fa9301 100644
--- a/src/main/java/com/seaofnodes/simple/node/NotNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/NotNode.java
@@ -12,26 +12,13 @@ public class NotNode extends Node {
@Override protected String format() { return "(!%1)"; }
@Override
- public Type compute() {
+ public TypeInteger compute() {
Type t0 = in(1)._type;
- if( t0.isHigh() ) return TypeInteger.BOOL.dual();
- switch( t0 ) {
- case TypeInteger i0: return i0._max < 0 || i0._min > 0 ? TypeInteger.FALSE : (i0==TypeInteger.ZERO ? TypeInteger.TRUE : TypeInteger.BOOL);
- case TypeFloat i0:
- return i0.isConstant() ? TypeInteger.constant(i0.value()==0 ? 1 : 0) : TypeInteger.BOOL;
- case TypeMemPtr p0:
- // top->top, bot->bot, null->1, *void->0, not-null ptr->0, ptr/nil->bot
- // If input in null then true
- // If input is not null ptr then false
- if( p0 == TypeMemPtr.NULLPTR ) return TypeInteger.TRUE;
- if( !p0._nil ) return TypeInteger.FALSE;
- return TypeInteger.BOOL;
- case Type t:
- if( t0.getClass() != Type.class )
- // Only doing NOT on ints and ptrs
- throw Utils.TODO();
- return TypeInteger.BOOL;
- }
+ if( t0.isHigh() ) return TypeInteger.BOOL.dual();
+ if( t0 == Type.NIL || t0 == TypeInteger.ZERO ) return TypeInteger.TRUE;
+ if( t0 instanceof TypeNil tn && tn.notNull() ) return TypeInteger.FALSE;
+ if( t0 instanceof TypeInteger i && (i._min > 0 || i._max < 0) ) return TypeInteger.FALSE;
+ return TypeInteger.BOOL;
}
@Override
diff --git a/src/main/java/com/seaofnodes/simple/node/OrNode.java b/src/main/java/com/seaofnodes/simple/node/OrNode.java
index ae54a67d..1cd8bafc 100644
--- a/src/main/java/com/seaofnodes/simple/node/OrNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/OrNode.java
@@ -1,16 +1,16 @@
package com.seaofnodes.simple.node;
-
+import com.seaofnodes.simple.Parser;
import com.seaofnodes.simple.type.Type;
import com.seaofnodes.simple.type.TypeInteger;
+import java.util.BitSet;
-public class OrNode extends Node {
- public OrNode(Node lhs, Node rhs) { super(null, lhs, rhs); }
+public class OrNode extends LogicalNode {
+ public OrNode(Parser.Lexer loc, Node lhs, Node rhs) { super(loc, lhs, rhs); }
@Override public String label() { return "Or"; }
-
- @Override protected String format() { return "(%1|%2)"; }
+ @Override public String op() { return "|"; }
@Override
public Type compute() {
@@ -49,10 +49,5 @@ public class OrNode extends Node {
return null;
}
- @Override Node copy(Node lhs, Node rhs) { return new OrNode(lhs,rhs); }
- @Override String err() {
- if( !(in(1)._type instanceof TypeInteger) ) return "Cannot '|' " + in(1)._type;
- if( !(in(2)._type instanceof TypeInteger) ) return "Cannot '|' " + in(2)._type;
- return null;
- }
+ @Override Node copy(Node lhs, Node rhs) { return new OrNode(_loc,lhs,rhs); }
}
diff --git a/src/main/java/com/seaofnodes/simple/node/OutNode.java b/src/main/java/com/seaofnodes/simple/node/OutNode.java
deleted file mode 100644
index dbac136b..00000000
--- a/src/main/java/com/seaofnodes/simple/node/OutNode.java
+++ /dev/null
@@ -1,7 +0,0 @@
-package com.seaofnodes.simple.node;
-
-import com.seaofnodes.simple.Ary;
-
-public interface OutNode {
- Ary<Node> outs();
-}
diff --git a/src/main/java/com/seaofnodes/simple/node/ParmNode.java b/src/main/java/com/seaofnodes/simple/node/ParmNode.java
new file mode 100644
index 00000000..7f5924cc
--- /dev/null
+++ b/src/main/java/com/seaofnodes/simple/node/ParmNode.java
@@ -0,0 +1,40 @@
+package com.seaofnodes.simple.node;
+
+import com.seaofnodes.print.ExprPrinter;
+
+import com.seaofnodes.simple.Utils;
+import com.seaofnodes.simple.type.Type;
+
+public class ParmNode extends PhiNode {
+
+ // Argument indices are mapped one-to-one on CallNode inputs
+ public final int _idx; // Argument index
+
+ public ParmNode(String label, int idx, Type declaredType, Node... inputs) {
+ super(label,declaredType,inputs);
+ _idx = idx;
+ }
+
+ @Override public String label() { return MemOpNode.mlabel(_label); }
+
+ public FunNode fun() { return (FunNode)in(0); }
+
+ @Override
+ protected ExprPrinter<Node> _print1(ExprPrinter<Node> p) {
+ if( "main".equals(fun().sig()._name) && _label.equals("arg") )
+ return p.p("arg");
+ p.p("Parm_").p(_label).open();
+ for( Node in : _inputs ) p.n(in).p(",");
+ return p.unchar(',').close();
+ }
+
+
+ @Override
+ public Node idealize() {
+ if( inProgress() ) return null;
+ return super.idealize();
+ }
+
+ // Always in-progress until we run out of unknown callers
+ @Override public boolean inProgress() { return fun().inProgress(); }
+}
diff --git a/src/main/java/com/seaofnodes/simple/node/PhiNode.java b/src/main/java/com/seaofnodes/simple/node/PhiNode.java
index 942748e7..9b5e1c26 100644
--- a/src/main/java/com/seaofnodes/simple/node/PhiNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/PhiNode.java
@@ -2,14 +2,12 @@ package com.seaofnodes.simple.node;
import com.seaofnodes.print.ExprPrinter;
-import com.seaofnodes.simple.type.Type;
-import com.seaofnodes.simple.type.TypeMem;
-import com.seaofnodes.simple.Utils;
-
+import com.seaofnodes.simple.*;
+import com.seaofnodes.simple.type.*;
public class PhiNode extends Node {
- final String _label;
+ public final String _label;
// The Phi type we compute must stay within the domain of the Phi.
// Example Int stays Int, Ptr stays Ptr, Control stays Control, Mem stays Mem.
@@ -17,6 +15,14 @@ public class PhiNode extends Node {
public PhiNode(String label, Type declaredType, Node... inputs) { super(inputs); _label = label; assert declaredType!=null; _declaredType = declaredType; }
+ public PhiNode(RegionNode r, Node sample) {
+ super(r);
+ _label = "";
+ _declaredType = sample._type;
+ while( nIns() < r.nIns() )
+ addDef(sample);
+ }
+
public static PhiNode make(String label, Type type, Node... inputs) {
return type instanceof TypeMem ? new BulkMemPhiNode(label,inputs) : new PhiNode(label,type,inputs);
}
@@ -43,7 +49,7 @@ public class PhiNode extends Node {
// During parsing Phis have to be computed type pessimistically.
if( r.inProgress() ) return _declaredType;
// Set type to local top of the starting type
- Type t = _declaredType.lub();
+ Type t = _declaredType.glb().dual();//Type.TOP;
for (int i = 1; i < nIns(); i++)
// If the region's control input is live, add this as a dependency
// to the control because we can be peeped should it become dead.
@@ -78,14 +84,16 @@ public class PhiNode extends Node {
// then replace with plain val.
if( nIns()==3 ) {
int nullx = -1;
- if( in(1)._type == in(1)._type.makeInit() ) nullx = 1;
- if( in(2)._type == in(2)._type.makeInit() ) nullx = 2;
+ if( in(1)._type == in(1)._type.makeZero() ) nullx = 1;
+ if( in(2)._type == in(2)._type.makeZero() ) nullx = 2;
if( nullx != -1 ) {
Node val = in(3-nullx);
+ if( val instanceof CastNode cast )
+ val = cast.in(1);
if( r.idom(this).addDep(this) instanceof IfNode iff && iff.pred().addDep(this)==val ) {
// Must walk the idom on the null side to make sure we hit False.
CFGNode idom = (CFGNode)r.in(nullx);
- while( idom.nIns() > 0 && idom.in(0) != iff ) idom = idom.idom();
+ while( idom != null && idom.nIns() > 0 && idom.in(0) != iff ) idom = idom.idom();
if( idom instanceof CProjNode proj && proj._idx==1 )
return val;
}
@@ -190,7 +198,7 @@ public class PhiNode extends Node {
}
// True if last input is null
- public final boolean inProgress() {
+ public boolean inProgress() {
return in(nIns()-1) == null;
}
@@ -198,4 +206,26 @@ public class PhiNode extends Node {
@Override boolean eq( Node n ) {
return !inProgress();
}
+
+ @Override
+ public Parser.ParseException err() {
+ if( _type != Type.BOTTOM ) return null;
+
+ // BOTTOM means we mixed e.g. int and ptr
+ for( int i=1; i<nIns(); i++ )
+ // Already an error, but better error messages come from elsewhere
+ if( in(i)._type == Type.BOTTOM )
+ return null;
+
+ // Gather a minimal set of types that "cover" all the rest
+ boolean ti=false, tf=false, tp=false, tn=false;
+ for( int i=1; i<nIns(); i++ ) {
+ Type t = in(i)._type;
+ ti |= t instanceof TypeInteger x;
+ tf |= t instanceof TypeFloat x;
+ tp |= t instanceof TypeMemPtr x;
+ tn |= t==Type.NIL;
+ }
+ return ReturnNode.mixerr(ti,tf,tp,tn, ((RegionNode)region())._loc);
+ }
}
diff --git a/src/main/java/com/seaofnodes/simple/node/ProjNode.java b/src/main/java/com/seaofnodes/simple/node/ProjNode.java
index 668e20ad..1e192676 100644
--- a/src/main/java/com/seaofnodes/simple/node/ProjNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/ProjNode.java
@@ -7,7 +7,7 @@ import com.seaofnodes.simple.type.TypeMem;
import com.seaofnodes.simple.type.TypeTuple;
-public class ProjNode extends Node {
+public class ProjNode extends Node implements MultiUse {
// Which slice of the incoming multipart value
public final int _idx;
@@ -22,11 +22,19 @@ public class ProjNode extends Node {
}
@Override public String label() { return _label; }
+ @Override public int idx() { return _idx; }
@Override
- protected ExprPrinter<Node> _print1(ExprPrinter<Node> p) { return p.p(_label); }
+ protected ExprPrinter<Node> _print1(ExprPrinter<Node> p) {
+ if( _label != null ) return p.p(_label);
+ if( in(0) instanceof CallEndNode cend && cend.call()!=null )
+ return p.n(cend.call());
+ return p.p("LONELY PROJ");
+ }
- @Override public CFGNode cfg0() { return in(0).cfg0(); }
+ @Override public CFGNode cfg0() {
+ return in(0) instanceof CFGNode cfg ? cfg : in(0).cfg0();
+ }
@Override public boolean isMultiTail() { return in(0).isMultiHead(); }
@Override public boolean isMem() { return _type instanceof TypeMem; }
@@ -37,7 +45,7 @@ public class ProjNode extends Node {
return t instanceof TypeTuple tt ? tt._types[_idx] : Type.BOTTOM;
}
- @Override public Node idealize() { return null; }
+ @Override public Node idealize() { return ((MultiNode)in(0)).pcopy(_idx); }
@Override
boolean eq( Node n ) { return _idx == ((ProjNode)n)._idx; }
diff --git a/src/main/java/com/seaofnodes/simple/node/RegionNode.java b/src/main/java/com/seaofnodes/simple/node/RegionNode.java
index 27866139..945398e9 100644
--- a/src/main/java/com/seaofnodes/simple/node/RegionNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/RegionNode.java
@@ -11,8 +11,11 @@ import java.util.Arrays;
import java.util.HashSet;
public class RegionNode extends CFGNode {
+ // Source location for late discovered errors
+ public Parser.Lexer _loc;
- public RegionNode(Node... nodes) { super(nodes); }
+ public RegionNode(Node... nodes) { this(null,nodes); }
+ public RegionNode(Parser.Lexer loc, Node... nodes) { super(nodes); _loc = loc; }
@Override
public String label() { return "Region"; }
@@ -65,12 +68,17 @@ public class RegionNode extends CFGNode {
return in(1); // Collapse if no Phis; 1-input Phis will collapse on their own
// If a CFG diamond with no merging, delete: "if( pred ) {} else {};"
- if( !hasPhi() && // No Phi users, just a control user
+ if( !hasPhi() && // No Phi users, just a control user
in(1) instanceof CProjNode p1 &&
in(2) instanceof CProjNode p2 &&
p1.addDepForwards(this).in(0)==p2.addDepForwards(this).in(0) &&
- p1.in(0) instanceof IfNode iff )
- return iff.ctrl();
+ p1.in(0) instanceof IfNode iff ) {
+ // Replace with the iff.ctrl directly
+ if( nIns()==3 ) return iff.ctrl();
+ // Just delete the path for fat Regions
+ setDef(1,iff.ctrl());
+ return delDef(2);
+ }
return null;
}
@@ -82,7 +90,7 @@ public class RegionNode extends CFGNode {
return 0; // All inputs alive
}
- private boolean hasPhi() {
+ boolean hasPhi() {
for( Node phi : _outputs )
if( phi instanceof PhiNode )
return true;
@@ -91,7 +99,7 @@ public class RegionNode extends CFGNode {
// Immediate dominator of Region is a little more complicated.
@Override public int idepth() {
- if( _idepth!=0 ) return _idepth;
+ if( validIDepth() ) return _idepth;
int depth=0;
for( Node n : _inputs )
if( n!=null )
@@ -108,12 +116,9 @@ public class RegionNode extends CFGNode {
}
// True if last input is null
- public final boolean inProgress() {
- return nIns()>1 && in(nIns()-1) == null;
- }
+ public boolean inProgress() { return nIns()>1 && in(nIns()-1) == null; }
// Never equal if inProgress
- @Override boolean eq( Node n ) {
- return !inProgress();
- }
+ @Override boolean eq( Node n ) { return !inProgress(); }
+
}
diff --git a/src/main/java/com/seaofnodes/simple/node/ReturnNode.java b/src/main/java/com/seaofnodes/simple/node/ReturnNode.java
index 6c773c42..d4b4094d 100644
--- a/src/main/java/com/seaofnodes/simple/node/ReturnNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/ReturnNode.java
@@ -2,20 +2,26 @@ package com.seaofnodes.simple.node;
import com.seaofnodes.print.ExprPrinter;
+import com.seaofnodes.simple.Parser;
+import com.seaofnodes.simple.SB;
+import com.seaofnodes.simple.Utils;
import com.seaofnodes.simple.type.*;
-
-/** Keeps all preceding memory effects and the return value alive: {ctrl, $mem, value}. */
+/** Keeps all preceding memory effects and the return value alive: {ctrl, $mem, value, rpc}. */
public class ReturnNode extends CFGNode {
- public ReturnNode(Node ctrl, Node data, ScopeNode scope) {
- // A synthetic never-taken loop exit has no source scope.
- super(ctrl, scope == null ? null : scope.mem(), data);
+ public final FunNode _fun;
+
+ public ReturnNode(Node ctrl, Node mem, Node data, Node rpc, FunNode fun ) {
+ super(ctrl, mem, data, rpc);
+ _fun = fun;
}
public Node ctrl() { return in(0); }
public Node mem () { return in(1); }
public Node expr() { return in(2); }
+ public Node rpc () { return in(3); }
+ public FunNode fun() { return _fun; }
@Override
public String label() { return "Return"; }
@@ -27,16 +33,87 @@ public class ReturnNode extends CFGNode {
return p.p(";");
}
+ // No one unique control follows; can be many call end sites
+ @Override public CFGNode uctrl() { return null; }
+
@Override
public Type compute() {
- // Return exposes the complete memory state.
+ if( inProgress () ) return TypeTuple.RET; // In progress
+ if( _fun.isDead() ) return TypeTuple.RET.dual(); // Dead another way
return TypeTuple.make(ctrl()._type,TypeMem.BOT,expr()._type);
}
- @Override
- public Node idealize() {
- if( ctrl()._type==Type.XCONTROL )
- return ctrl();
+ @Override public Node idealize() {
+ if( inProgress () ) return null;
+ if( _fun.isDead() ) return null;
+
+ // Upgrade signature based on return type
+ Type ret = expr()._type;
+ TypeFunPtr fcn = _fun.sig();
+ assert ret.isa(fcn.ret());
+ if( ret != fcn.ret() )
+ _fun.setSig(fcn.makeFrom(ret));
+
+ // If dead (cant be reached; infinite loop), kill the exit values
+ if( ctrl()._type==Type.XCONTROL &&
+ !(mem() instanceof ConstantNode && expr() instanceof ConstantNode) ) {
+ Node top = new ConstantNode(Type.TOP).peephole();
+ setDef(1,top);
+ setDef(2,top);
+ return this;
+ }
+
return null;
}
+
+ public boolean inProgress() {
+ return ctrl().getClass() == RegionNode.class && ((RegionNode)ctrl()).inProgress();
+ }
+
+ // Remember parsed type kinds for diagnostics; the optimized expression decides validity.
+ private boolean ti=false, tf=false, tp=false, tn=false;
+
+ // Add a return exit to the current parsing function
+ void addReturn( Node ctrl, Node rmem, Node expr ) {
+ assert inProgress();
+
+ // Gather parse-time return types for error reporting
+ Type t = expr._type;
+ ti |= t instanceof TypeInteger x;
+ tf |= t instanceof TypeFloat x;
+ tp |= t instanceof TypeMemPtr x;
+ tn |= t==Type.NIL;
+
+ // Merge path into the One True Return
+ RegionNode r = (RegionNode)ctrl();
+ // Assert that the Phis are in particular outputs; not reordered or shuffled
+ PhiNode mem = (PhiNode)r.out(0); assert mem._declaredType == TypeMem.BOT;
+ PhiNode rez = (PhiNode)r.out(1); assert rez._declaredType == Type.BOTTOM;
+ // Pop "inProgress" null off
+ r ._inputs.pop();
+ mem._inputs.pop();
+ rez._inputs.pop();
+ // Add new return point
+ r .addDef(ctrl);
+ mem.addDef(rmem);
+ rez.addDef(expr);
+ // Back to being inProgress
+ r .addDef(null);
+ mem.addDef(null);
+ rez.addDef(null);
+ }
+
+ @Override public Parser.ParseException err() {
+ return expr()._type==Type.BOTTOM ? mixerr(ti,tf,tp,tn,_fun._loc) : null;
+ }
+
+ static Parser.ParseException mixerr( boolean ti, boolean tf, boolean tp, boolean tn, Parser.Lexer loc ) {
+ if( !ti && !tf && !tp && !tn )
+ return Parser.error("No defined return type", loc);
+ SB sb = new SB().p("No common type amongst ");
+ if( ti ) sb.p("int and ");
+ if( tf ) sb.p("f64 and ");
+ if( tp || tn ) sb.p("reference and ");
+ return Parser.error(sb.unchar(5).toString(),loc);
+ }
}
diff --git a/src/main/java/com/seaofnodes/simple/node/RoundF32Node.java b/src/main/java/com/seaofnodes/simple/node/RoundF32Node.java
index 6be071a2..10a0e4aa 100644
--- a/src/main/java/com/seaofnodes/simple/node/RoundF32Node.java
+++ b/src/main/java/com/seaofnodes/simple/node/RoundF32Node.java
@@ -16,7 +16,7 @@ public class RoundF32Node extends Node {
public Type compute() {
if (in(1)._type instanceof TypeFloat i0 && i0.isConstant() )
return TypeFloat.constant((float)i0.value());
- if( in(1)._type==TypeFloat.BOT ) return TypeFloat.B32;
+ if( in(1)._type==TypeFloat.F64 ) return TypeFloat.F32;
return in(1)._type;
}
diff --git a/src/main/java/com/seaofnodes/simple/node/SarNode.java b/src/main/java/com/seaofnodes/simple/node/SarNode.java
index 9f07956c..d321da42 100644
--- a/src/main/java/com/seaofnodes/simple/node/SarNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/SarNode.java
@@ -1,16 +1,15 @@
package com.seaofnodes.simple.node;
-
+import com.seaofnodes.simple.Parser;
import com.seaofnodes.simple.type.Type;
import com.seaofnodes.simple.type.TypeInteger;
+import java.util.BitSet;
-
-public class SarNode extends Node {
- public SarNode(Node lhs, Node rhs) { super(null, lhs, rhs); }
+public class SarNode extends LogicalNode {
+ public SarNode(Parser.Lexer loc, Node lhs, Node rhs) { super(loc, lhs, rhs); }
@Override public String label() { return "Sar"; }
-
- @Override protected String format() { return "(%1>>%2)"; }
+ @Override public String op() { return ">>"; }
@Override
public Type compute() {
@@ -45,10 +44,5 @@ public class SarNode extends Node {
return null;
}
- @Override Node copy(Node lhs, Node rhs) { return new SarNode(lhs,rhs); }
- @Override String err() {
- if( !(in(1)._type instanceof TypeInteger) ) return "Cannot '>>' " + in(1)._type;
- if( !(in(2)._type instanceof TypeInteger) ) return "Cannot '>>' " + in(2)._type;
- return null;
- }
+ @Override Node copy(Node lhs, Node rhs) { return new SarNode(_loc,lhs,rhs); }
}
diff --git a/src/main/java/com/seaofnodes/simple/node/ScopeNode.java b/src/main/java/com/seaofnodes/simple/node/ScopeNode.java
index 753abe90..de199d2d 100644
--- a/src/main/java/com/seaofnodes/simple/node/ScopeNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/ScopeNode.java
@@ -2,9 +2,7 @@ package com.seaofnodes.simple.node;
import com.seaofnodes.print.ExprPrinter;
-import com.seaofnodes.simple.IterPeeps;
-import com.seaofnodes.simple.Parser;
-import com.seaofnodes.simple.Ary;
+import com.seaofnodes.simple.*;
import com.seaofnodes.simple.type.*;
import java.util.*;
@@ -22,34 +20,6 @@ public class ScopeNode extends Node {
public static final String ARG0 = "arg";
public static final String MEM0 = "$mem";
- /** The tracked fields are now complex enough to deserve a array-of-structs layout
- */
- public static class Var {
- public final int _idx; // index in containing scope
- public final String _name; // Declared name
- private Type _type; // Declared type
- public final boolean _final; // Final field
- public Var(int idx, String name, Type type, boolean xfinal) {
- _idx = idx;
- _name = name;
- _type = type;
- _final = xfinal;
- }
- public Type type() {
- if( !_type.isFRef() ) return _type;
- // Update self to no longer use the forward ref type
- Type def = Parser.TYPES.get(((TypeMemPtr)_type)._obj._name);
- return (_type=_type.meet(def));
- }
- public Type lazyGLB() {
- Type t = type();
- return t instanceof TypeMemPtr ? t : t.glb();
- }
- @Override public String toString() {
- return _type.toString()+(_final ? " ": " !")+_name;
- }
- }
-
public Node in(Var v) { return in(v._idx); }
@Override public Type compute() { return Type.BOTTOM; }
@@ -61,8 +31,9 @@ public class ScopeNode extends Node {
// Size of each nested lexical scope
public final Ary<Integer> _lexSize;
- // True if parsing inside of a constructor
- public final Ary<Boolean> _inCons;
+ // Lexical scope is one of normal Block, constructor or function
+ public enum Kind { Block, Constructor, Function };
+ public final Ary<Kind> _kinds;
// Extra guards; tested predicates and casted results
private final Ary<Node> _guards;
@@ -72,7 +43,7 @@ public class ScopeNode extends Node {
_type = Type.BOTTOM;
_vars = new Ary<>(Var .class);
_lexSize= new Ary<>(Integer.class);
- _inCons = new Ary<>(Boolean.class);
+ _kinds = new Ary<>(Kind .class);
_guards = new Ary<>(Node .class);
}
@@ -85,7 +56,7 @@ public class ScopeNode extends Node {
for( int i=0; i<nIns(); i++ ) {
if( j < _lexSize._len && i == _lexSize.at(j) ) { p.p("| "); j++; }
Var v = _vars.get(i);
- p.p(v.type());
+ p.p(v._type().print(new SB()));
p.p(" ");
if( v._final ) p.p("!");
p.p(v._name);
@@ -104,7 +75,6 @@ public class ScopeNode extends Node {
public Node ctrl() { return in(0); }
public Node mem() { return in(lookup(MEM0)); }
- public void mem(Node n) { update(MEM0,n); }
/**
* The ctrl of a ScopeNode is always bound to the currently active
@@ -117,38 +87,69 @@ public class ScopeNode extends Node {
* @return Node that was bound
*/
public <N extends Node> N ctrl(N n) { return setDef(0,n); }
+ public Node mem(Node n) { update(MEM0,n); return n; }
- public void push() { push(false); }
- public void push(boolean inCon) {
- assert _lexSize._len==_inCons._len;
+ public void push(Kind kind) {
+ assert _lexSize._len==_kinds._len;
_lexSize.push(_vars.size());
- _inCons.push(inCon);
+ _kinds .push(kind);
}
+
+ // Pop a lexical scope
public void pop() {
- assert _lexSize._len==_inCons._len;
+ assert _lexSize._len==_kinds._len;
+ promote();
int n = _lexSize.pop();
- _inCons.pop();
+ _kinds.pop();
popUntil(n);
_vars.setLen(n);
}
+
+ // Look for forward references in the last lexical scope and promote to the
+ // next outer lexical scope. At the last scope declare them an error.
+ public void promote() {
+ int n = _lexSize.last();
+ for( int i=n; i<nIns(); i++ ) {
+ Var v = _vars.at(i);
+ if( !v.isFRef() ) continue;
+ if( _lexSize._len==1 )
+ throw Parser.error("Undefined name '" + v._name + "'",v._loc);
+ _vars.swap(n,i);
+ _inputs.swap(n,i);
+ v._idx = n;
+ n++;
+ _lexSize.set(_lexSize._len-1,n);
+ }
+ }
+
+
// Allocation fields live in the scope immediately outside the constructor
// block. Nested blocks retain that permission; surrounding bindings do not.
public boolean canInit(Var v) {
- for( int i=_inCons._len-1; i>0; i-- )
- if( _inCons.at(i) )
+ for( int i=_kinds._len-1; i>0; i-- )
+ if( _kinds.at(i)==Kind.Constructor )
return v._idx >= _lexSize.at(i-1) && v._idx < _lexSize.at(i);
return false;
}
- public boolean inCon() { return _inCons.last(); }
+ public boolean inCon() { return _kinds.last() == Kind.Constructor; }
+
+ // Is v outside any current function scope?
+ public boolean outOfFunction( Var v ) {
+ for( int i=_lexSize._len-1; i>=0 && v._idx<_lexSize.at(i); i-- )
+ if( _kinds.at(i)==Kind.Function )
+ return true;
+ return false;
+ }
+
// Find name in reverse, return an index into _vars or -1. Linear scan
// instead of hashtable, but probably doesn't matter until the scan
// typically hits many dozens of variables.
int find( String name ) {
for( int i=_vars.size()-1; i>=0; i-- )
- if( _vars.get(i)._name.equals(name) )
+ if( _vars.at(i)._name.equals(name) )
return i;
return -1;
}
@@ -156,13 +157,24 @@ public class ScopeNode extends Node {
/**
* Create a new variable name in the current scope
*/
- public boolean define( String name, Type declaredType, boolean xfinal, Node init ) {
- assert name.charAt(0)!='$' || _lexSize.size()==1; // Later scopes do not define memory
- if( _lexSize._len > 1 )
- for( int i=_vars.size()-1; i>=_lexSize.last(); i-- )
- if( _vars.get(i)._name.equals(name) )
- return false; // Double define
- _vars.add(new Var(nIns(),name,declaredType,xfinal));
+ public boolean define( String name, Type declaredType, boolean xfinal, Node init, Parser.Lexer loc ) {
+ assert _lexSize.isEmpty() || name.charAt(0)!='$' ; // Later scopes do not define memory
+ if( _lexSize._len > 0 )
+ for( int i=_vars.size()-1; i>=_lexSize.last(); i-- ) {
+ Var n = _vars.at(i);
+ if( n._name.equals(name) ) {
+ if( !n.isFRef() ) return false; // Double define
+ FRefNode fref = (FRefNode)in(n._idx); // Get forward ref
+ if( !xfinal || !declaredType.isConstant() ) throw fref.err(); // Must be a final constant
+ n.defFRef(declaredType,xfinal,loc); // Declare full correct type, final, source location
+ setDef(n._idx,fref.addDef(init)); // Set FRef to defined; tell parser also
+ }
+ }
+ Var v = new Var(nIns(),name,declaredType,xfinal,loc,init==Parser.XCTRL);
+ _vars.add(v);
+ // Creating a forward reference
+ if( init==Parser.XCTRL )
+ init = new FRefNode(v).init();
addDef(init);
return true;
}
@@ -191,7 +203,7 @@ public class ScopeNode extends Node {
update(_vars.at(idx),n);
}
- public Var update( ScopeNode.Var v, Node st ) {
+ public Var update( Var v, Node st ) {
Node old = in(v._idx);
if( old instanceof ScopeNode loop ) {
// Lazy Phi!
@@ -205,6 +217,7 @@ public class ScopeNode extends Node {
: loop.setDef(v._idx,PhiNode.make(v._name, v.lazyGLB(), loop.ctrl(), loop.in(loop.update(v,null)._idx),null).peephole());
setDef(v._idx,old);
}
+ assert !v._final || st==null || canInit(v);
if( st!=null ) setDef(v._idx,st); // Set new value
return v;
}
@@ -231,7 +244,7 @@ public class ScopeNode extends Node {
// 3) Ensure that the order of defs is the same to allow easy merging
dup._vars .addAll(_vars );
dup._lexSize.addAll(_lexSize);
- dup._inCons .addAll(_inCons );
+ dup._kinds .addAll(_kinds );
dup._guards .addAll(_guards );
// The dup'd guards all need dup'd keepers, to keep proper accounting
// when later removing all guards
@@ -242,7 +255,7 @@ public class ScopeNode extends Node {
// Memory is one binding, with the same lazy loop Phi as scalar names.
for( int i=1; i<nIns(); i++ )
- dup.addDef(loop ? this : in(i));
+ dup.addDef(loop && !_vars.at(i)._final ? this : in(i));
return dup;
}
@@ -254,8 +267,8 @@ public class ScopeNode extends Node {
* @param that The ScopeNode to be merged into this
* @return A new node representing the merge point
*/
- public RegionNode mergeScopes(ScopeNode that) {
- RegionNode r = (RegionNode) ctrl(new RegionNode(null,ctrl(), that.ctrl()).keep());
+ public RegionNode mergeScopes(ScopeNode that, Parser.Lexer loc) {
+ RegionNode r = ctrl(new RegionNode(loc,null,ctrl(), that.ctrl()).keep());
_merge(that,r);
that.kill(); // Kill merged scope
IterPeeps.add(r);
@@ -274,6 +287,20 @@ public class ScopeNode extends Node {
}
}
+ // Balance arms of an IF. Extra lonely defs are thrown: "if(pred) int x;".
+ // Forward refs are copied to the other side, "as if" they were there all along.
+ public void balanceIf( ScopeNode scope ) {
+ for( int i = nIns(); i < scope.nIns(); i++ ) {
+ Var n = scope._vars.at(i);
+ if( n.isFRef() ) { // RHS has forward refs
+ _vars.add(n); // Copy to LHS
+ addDef(scope.in(i));
+ } else
+ throw Parser.error("Cannot define a '"+n._name+"' on one arm of an if",n._loc);
+ }
+ }
+
+
// peephole the backedge scope into this loop head scope
// We set the second input to the phi from the back edge (i.e. loop body)
public void endLoop(ScopeNode back, ScopeNode exit ) {
@@ -290,6 +317,8 @@ public class ScopeNode extends Node {
// Fill in the backedge of any inserted Phis
void _endLoop( ScopeNode scope, Node back, Node exit ) {
for( int i=1; i<nIns(); i++ ) {
+ if( _vars.at(i)._final ) continue; // Final vars did not get modified in the loop
+ if( _vars.at(i).type().isHighOrConst() ) continue; // Cannot lift higher than a constant, so no Phi
if( back.in(i) != scope ) {
PhiNode phi = (PhiNode)in(i);
assert phi.region()==scope.ctrl() && phi.in(2)==null;
@@ -324,7 +353,7 @@ public class ScopeNode extends Node {
assert ctrl instanceof CFGNode;
_guards.add(ctrl); // Marker between guard sets
// add pred & its cast to the normal input list, with special Vars
- if( ctrl._type == Type.XCONTROL || pred==null || pred.isDead() )
+ if( pred==null || pred.isDead() )
return; // Dead, do not add any guards
_addGuards(ctrl,pred,invert);
}
@@ -344,31 +373,31 @@ public class ScopeNode extends Node {
pred = pred instanceof NotNode not ? not.in(1) : IterPeeps.add(new NotNode(pred).peephole());
// This is a zero/null test.
// Compute the positive test type.
- Type tnz = pred._type.nonZero();
- Type tcast = tnz.join(pred._type);
- if( tcast != pred._type ) {
- Node cast = new CastNode(tnz,ctrl,pred.keep()).peephole().keep();
- _guards.add(pred);
- _guards.add(cast);
- replace(pred,cast);
- }
+ Type tnz = pred._type.nonZero();
+ if( tnz!=null )
+ _addGuard(tnz,ctrl,pred);
// Compute the negative test type.
if( pred instanceof NotNode not ) {
Node npred = not.in(1);
Type tzero = npred._type.makeZero();
- Type tzcast= tzero.join(npred._type);
- if( tzcast != npred._type ) {
- Node cast = new CastNode(tzero,ctrl,npred.keep()).peephole().keep();
- _guards.add(npred);
- _guards.add( cast);
- replace(npred,cast);
- }
+ _addGuard(tzero,ctrl,npred);
}
}
+ private void _addGuard(Type guard, Node ctrl, Node pred) {
+ Type tcast = guard.join(pred._type);
+ if( tcast != pred._type && !tcast.isHigh() ) {
+ Node cast = new CastNode(tcast,ctrl,pred.keep()).peephole().keep();
+ _guards.add(pred);
+ _guards.add(cast);
+ replace(pred,cast);
+ }
+ }
+
+
// Remove matching pred/cast pairs from this guarded region.
- public void removeGuards( Node ctrl ) {
+ public ScopeNode removeGuards( Node ctrl ) {
assert ctrl instanceof CFGNode;
// Pop the guards up to this region's marker.
while( true ) {
@@ -378,6 +407,7 @@ public class ScopeNode extends Node {
g .unkill(); // Pop/kill cast
_guards.pop().unkill(); // Pop/kill pred
}
+ return this;
}
// If we find a guarded instance of pred, replace with the upcasted version
@@ -401,16 +431,17 @@ public class ScopeNode extends Node {
if( !(n instanceof CFGNode) )
n.unkill();
_guards.clear();
- super.kill();
+ // Can have lazy uses remaining
+ if( isUnused() )
+ super.kill();
}
- private Node replace( Node old, Node cast ) {
+ private void replace( Node old, Node cast ) {
assert old!=null && old!=cast;
for( int i=0; i<nIns(); i++ )
if( in(i)==old )
setDef(i,cast);
- return cast;
}
}
diff --git a/src/main/java/com/seaofnodes/simple/node/ShlNode.java b/src/main/java/com/seaofnodes/simple/node/ShlNode.java
index 89d205c5..84c19247 100644
--- a/src/main/java/com/seaofnodes/simple/node/ShlNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/ShlNode.java
@@ -1,16 +1,15 @@
package com.seaofnodes.simple.node;
-
import com.seaofnodes.simple.Parser;
import com.seaofnodes.simple.type.Type;
import com.seaofnodes.simple.type.TypeInteger;
+import java.util.BitSet;
-public class ShlNode extends Node {
- public ShlNode(Node lhs, Node rhs) { super(null, lhs, rhs); }
+public class ShlNode extends LogicalNode {
+ public ShlNode(Parser.Lexer loc, Node lhs, Node rhs) { super(loc, lhs, rhs); }
@Override public String label() { return "Shl"; }
-
- @Override protected String format() { return "(%1<<%2)"; }
+ @Override public String op() { return "<<"; }
@Override
public Type compute() {
@@ -37,10 +36,10 @@ public class ShlNode extends Node {
if( (shl.value()&63)==0 && lhs._type instanceof TypeInteger )
return lhs;
// (x + c) << i => (x << i) + (c << i)
- if( lhs instanceof AddNode add && add.addDep(this).in(2)._type instanceof TypeInteger c && c.isConstant() && c!=TypeInteger.ZERO ) {
+ if( lhs instanceof AddNode add && add.addDep(this).in(2)._type instanceof TypeInteger c && c.isConstant() ) {
long sum = c.value() << shl.value();
if( Integer.MIN_VALUE <= sum && sum <= Integer.MAX_VALUE )
- return new AddNode( new ShlNode(add.in(1),rhs).peephole(), Parser.con(sum) );
+ return new AddNode(new ShlNode(_loc,add.in(1),rhs).peephole(), Parser.con(sum) );
}
}
@@ -48,10 +47,5 @@ public class ShlNode extends Node {
return null;
}
- @Override Node copy(Node lhs, Node rhs) { return new ShlNode(lhs,rhs); }
- @Override String err() {
- if( !(in(1)._type instanceof TypeInteger) ) return "Cannot '<<' " + in(1)._type;
- if( !(in(2)._type instanceof TypeInteger) ) return "Cannot '<<' " + in(2)._type;
- return null;
- }
+ @Override Node copy(Node lhs, Node rhs) { return new ShlNode(_loc,lhs,rhs); }
}
diff --git a/src/main/java/com/seaofnodes/simple/node/ShrNode.java b/src/main/java/com/seaofnodes/simple/node/ShrNode.java
index 22b42f3e..587e1631 100644
--- a/src/main/java/com/seaofnodes/simple/node/ShrNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/ShrNode.java
@@ -1,16 +1,15 @@
package com.seaofnodes.simple.node;
-
+import com.seaofnodes.simple.Parser;
import com.seaofnodes.simple.type.Type;
import com.seaofnodes.simple.type.TypeInteger;
+import java.util.BitSet;
-
-public class ShrNode extends Node {
- public ShrNode(Node lhs, Node rhs) { super(null, lhs, rhs); }
+public class ShrNode extends LogicalNode {
+ public ShrNode(Parser.Lexer loc, Node lhs, Node rhs) { super(loc, lhs, rhs); }
@Override public String label() { return "Shr"; }
-
- @Override protected String format() { return "(%1>>>%2)"; }
+ @Override public String op() { return ">>>"; }
@Override
public Type compute() {
@@ -41,10 +40,5 @@ public class ShrNode extends Node {
return null;
}
- @Override Node copy(Node lhs, Node rhs) { return new ShrNode(lhs,rhs); }
- @Override String err() {
- if( !(in(1)._type instanceof TypeInteger) ) return "Cannot '>>>' " + in(1)._type;
- if( !(in(2)._type instanceof TypeInteger) ) return "Cannot '>>>' " + in(2)._type;
- return null;
- }
+ @Override Node copy(Node lhs, Node rhs) { return new ShrNode(_loc,lhs,rhs); }
}
diff --git a/src/main/java/com/seaofnodes/simple/node/StartNode.java b/src/main/java/com/seaofnodes/simple/node/StartNode.java
index cefa2d72..8bdb60cf 100644
--- a/src/main/java/com/seaofnodes/simple/node/StartNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/StartNode.java
@@ -11,7 +11,7 @@ public class StartNode extends LoopNode implements MultiNode {
final Type _arg;
- public StartNode(Type arg) { super(null); _arg = arg; _type = compute(); }
+ public StartNode(Type arg) { super(null,null); _arg = arg; _type = compute(); }
@Override public String label() { return "Start"; }
@@ -21,7 +21,19 @@ public class StartNode extends LoopNode implements MultiNode {
@Override public boolean isMultiHead() { return true; }
@Override public boolean blockHead() { return true; }
- @Override public CFGNode cfg0() { return this; }
+ @Override public CFGNode cfg0() { return null; }
+
+ // Get the one control following; error to call with more than one e.g. an
+ // IfNode or other multi-way branch. For Start, its "main"
+ @Override public CFGNode uctrl() {
+ // Find "main", its the start.
+ CFGNode C = null;
+ for( Node use : _outputs )
+ if( use instanceof FunNode fun && fun.sig().isa(TypeFunPtr.MAIN) )
+ { assert C==null; C = fun; }
+ return C;
+ }
+
@Override public TypeTuple compute() {
return TypeTuple.make(Type.CONTROL,TypeMem.BOT,_arg);
diff --git a/src/main/java/com/seaofnodes/simple/node/StopNode.java b/src/main/java/com/seaofnodes/simple/node/StopNode.java
index d0eb5750..a15125a1 100644
--- a/src/main/java/com/seaofnodes/simple/node/StopNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/StopNode.java
@@ -2,11 +2,8 @@ package com.seaofnodes.simple.node;
import com.seaofnodes.print.ExprPrinter;
+import com.seaofnodes.simple.Utils;
import com.seaofnodes.simple.type.Type;
-import com.seaofnodes.simple.Parser;
-import com.seaofnodes.simple.IterPeeps;
-import com.seaofnodes.simple.GlobalCodeMotion;
-
public class StopNode extends CFGNode {
@@ -15,6 +12,7 @@ public class StopNode extends CFGNode {
public StopNode(String src) {
super();
_src = src;
+ _type = compute();
}
@Override
@@ -24,6 +22,7 @@ public class StopNode extends CFGNode {
@Override
protected ExprPrinter<Node> _print1(ExprPrinter<Node> p) {
+ // For the sake of many old tests, and single value prints as "return val"
if( ret()!=null ) return p.n(ret());
p.p("Stop[ ");
for( Node ret : _inputs )
@@ -33,10 +32,11 @@ public class StopNode extends CFGNode {
@Override public boolean blockHead() { return true; }
+
// If a single Return, return it.
// Otherwise, null because ambiguous.
public ReturnNode ret() {
- return nIns()==1 ? (ReturnNode)in(0) : null;
+ return nIns()==1 && in(0) instanceof ReturnNode ret ? ret : null;
}
@Override
@@ -48,42 +48,17 @@ public class StopNode extends CFGNode {
public Node idealize() {
int len = nIns();
for( int i=0; i<nIns(); i++ )
- if( in(i)._type==Type.XCONTROL )
+ if( ((ReturnNode)in(i)).fun().isDead() )
delDef(i--);
if( len != nIns() ) return this;
return null;
}
@Override public int idepth() {
- if( _idepth!=0 ) return _idepth;
+ if( validIDepth() ) return _idepth;
int d=0;
- for( Node n : _inputs )
- if( n!=null )
- d = Math.max(d,((CFGNode)n).idepth()+1);
+ for( Node ret : _inputs )
+ d = Math.max(d,((ReturnNode)ret).idepth()+1);
return cacheIDepth(d);
}
- @Override public CFGNode idom(Node dep) { return null; }
-
- public Node addReturn(Node node) {
- return addDef(node);
- }
-
- public StopNode iterate() { return IterPeeps.iterate(this).typeCheck().GCM(); }
- public StopNode typeCheck() {
- var obs = Parser.PARSER == null ? null : Parser.PARSER._obs;
- String err = walk(n -> {
- String msg = n.err();
- if( msg != null && obs != null ) obs.error(n, msg);
- return msg;
- });
- if( err != null ) throw new RuntimeException(err);
- if( obs != null ) obs.phase("TypeCheck");
- return this;
- }
- StopNode GCM() {
- Parser.START.buildLoopTree(this);
-
- GlobalCodeMotion.buildCFG(this);
- return this;
- }
}
diff --git a/src/main/java/com/seaofnodes/simple/node/StoreNode.java b/src/main/java/com/seaofnodes/simple/node/StoreNode.java
index 962618ef..de17bbad 100644
--- a/src/main/java/com/seaofnodes/simple/node/StoreNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/StoreNode.java
@@ -2,11 +2,12 @@ package com.seaofnodes.simple.node;
import com.seaofnodes.print.ExprPrinter;
+import com.seaofnodes.simple.IterPeeps;
+import com.seaofnodes.simple.Parser;
import com.seaofnodes.simple.Utils;
import com.seaofnodes.simple.IterPeeps;
import com.seaofnodes.simple.type.*;
-
/**
* Store represents setting a value to a memory based object, in chapter 10
* this means a field inside a struct.
@@ -22,8 +23,8 @@ public class StoreNode extends MemOpNode {
* @param off The offset inside the struct base
* @param value Value to be stored
*/
- public StoreNode(String name, int alias, Type glb, Node mem, Node ptr, Node off, Node value, boolean init) {
- super(name, alias, glb, mem, ptr, off, value);
+ public StoreNode(Parser.Lexer loc, String name, int alias, Type glb, Node mem, Node ptr, Node off, Node value, boolean init) {
+ super(loc, name, alias, glb, mem, ptr, off, value);
_init = init;
}
@@ -73,7 +74,7 @@ public class StoreNode extends MemOpNode {
return this;
}
- // Simple store-after-new on same address. Should pick up the
+ // Simple store-after-new on same address. Should pick up
// an init-store being stomped by a first user store.
if( mem() instanceof ProjNode st && st .in(0) instanceof NewNode nnn &&
ptr() instanceof ProjNode ptr && ptr.in(0) == nnn &&
@@ -81,7 +82,7 @@ public class StoreNode extends MemOpNode {
// Cannot fold a store of a single element over the array body initializer value
!(tmp._obj.isAry() && tmp._obj._fields[1]._alias==_alias) &&
// Very sad strong cutout: val has to be legal to hoist to a New
- // input, which means it cannot depend on the New. Many many
+ // input, which means it cannot depend on the New. Many, many
// things are legal here but difficult to check without doing a
// full dominator check. Example failure:
// "struct C { C? c; }; C self = new C { c=self; }"
@@ -92,10 +93,12 @@ public class StoreNode extends MemOpNode {
// Folding away a broken store
err()==null ) {
nnn.setDef(nnn.findAlias(_alias),val());
- // Must retype the NewNode
- nnn ._type = nnn. compute();
+ // Must *retype* the NewNode, this is not monotonic in isolation
+ // but is monotonic counting from this Store to the New.
+ nnn ._type = nnn .compute();
mem()._type = mem().compute();
- return st;
+ IterPeeps.addAll(nnn._outputs);
+ return mem();
}
return null;
@@ -130,9 +133,9 @@ public class StoreNode extends MemOpNode {
if( ctrl==null ) return null;
Node mem = phi.in(1);
- Node init = new LoadNode(_name,_alias,_declaredType,mem,ptr(),off()).peephole();
+ Node init = new LoadNode(_loc,_name,_alias,_declaredType,mem,ptr(),off()).peephole();
Node value = new PhiNode(_name,_declaredType,loop,init,val()).peephole();
- Node sink = new StoreNode(_name,_alias,_declaredType,mem,ptr(),off(),value,_init);
+ Node sink = new StoreNode(_loc,_name,_alias,_declaredType,mem,ptr(),off(),value,_init);
// Break the memory cycle, killing the old store. Keep the Phi alive
// even if that store was its last use, until our caller replaces it.
phi.keep();
@@ -153,13 +156,15 @@ public class StoreNode extends MemOpNode {
}
@Override
- String err() {
- String err = super.err();
+ public Parser.ParseException err() {
+ Parser.ParseException err = super.err();
if( err != null ) return err;
+ if( ptr()._type == Type.TOP )
+ return null; // Dead store
TypeMemPtr tmp = (TypeMemPtr)ptr()._type;
- if( tmp._ro || tmp._obj.field(_name)._final )
- return "Cannot modify final field '"+_name+"'";
+ if( tmp._ro || (tmp._obj.field(_name)._final && !"[]".equals(_name)) )
+ return Parser.error("Cannot modify final field '"+_name+"'",_loc);
Type t = val()._type;
- return _init || t.isa(_declaredType) ? null : "Cannot store "+t+" into field "+_declaredType+" "+_name;
+ return _init || t.isa(_declaredType) ? null : Parser.error("Cannot store "+t+" into field "+_declaredType+" "+_name,_loc);
}
}
diff --git a/src/main/java/com/seaofnodes/simple/node/StructNode.java b/src/main/java/com/seaofnodes/simple/node/StructNode.java
index 429b49cc..b9801f63 100644
--- a/src/main/java/com/seaofnodes/simple/node/StructNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/StructNode.java
@@ -2,6 +2,7 @@ package com.seaofnodes.simple.node;
import com.seaofnodes.print.ExprPrinter;
+import com.seaofnodes.simple.SB;
import com.seaofnodes.simple.type.*;
/**
@@ -19,7 +20,7 @@ public class StructNode extends Node {
p.p(_ts._name).p(" {");
for( int i=0; i<nIns(); i++ ) {
p.p(_ts._fields[i]._fname).p(":");
- p.p(in(i)==null ? Type.BOTTOM : in(i)._type);
+ p.p((in(i)==null ? Type.BOTTOM : in(i)._type).print(new SB()));
p.p("; ");
}
return p.unchar("; ").p("}");
diff --git a/src/main/java/com/seaofnodes/simple/node/SubNode.java b/src/main/java/com/seaofnodes/simple/node/SubNode.java
index 768cb2bf..9bf6d83e 100644
--- a/src/main/java/com/seaofnodes/simple/node/SubNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/SubNode.java
@@ -5,7 +5,6 @@ import com.seaofnodes.simple.Parser;
import com.seaofnodes.simple.type.Type;
import com.seaofnodes.simple.type.TypeInteger;
-
public class SubNode extends Node {
public SubNode(Node lhs, Node rhs) { super(null, lhs, rhs); }
@@ -18,6 +17,9 @@ public class SubNode extends Node {
Type t1 = in(1)._type, t2 = in(2)._type;
if( t1.isHigh() || t2.isHigh() )
return TypeInteger.TOP;
+ // Sub of same is 0
+ if( in(1)==in(2) )
+ return TypeInteger.ZERO;
if( t1 instanceof TypeInteger i1 &&
t2 instanceof TypeInteger i2 ) {
if (i1.isConstant() && i2.isConstant())
@@ -28,9 +30,6 @@ public class SubNode extends Node {
i2._min != Long.MIN_VALUE )
return TypeInteger.make(i1._min-i2._max,i1._max-i2._min);
}
- // Sub of same is 0
- if( in(1)==in(2) )
- return TypeInteger.ZERO;
return TypeInteger.BOT;
}
diff --git a/src/main/java/com/seaofnodes/simple/node/ToFloatNode.java b/src/main/java/com/seaofnodes/simple/node/ToFloatNode.java
index 26cf50e1..7b0122ce 100644
--- a/src/main/java/com/seaofnodes/simple/node/ToFloatNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/ToFloatNode.java
@@ -15,9 +15,13 @@ public class ToFloatNode extends Node {
@Override
public Type compute() {
- if (in(1)._type instanceof TypeInteger i0 && i0.isConstant() )
- return TypeFloat.constant(i0.value());
- return TypeFloat.BOT;
+ if( in(1)._type == Type.NIL ) return TypeFloat.FZERO;
+ if (in(1)._type instanceof TypeInteger i0 ) {
+ if( i0.isHigh() ) return TypeFloat.F64.dual();
+ if( i0.isConstant() )
+ return TypeFloat.constant(i0.value());
+ }
+ return TypeFloat.F64;
}
@Override public Node idealize() { return null; }
diff --git a/src/main/java/com/seaofnodes/simple/node/XCtrlNode.java b/src/main/java/com/seaofnodes/simple/node/XCtrlNode.java
index 056dfba1..3eae8548 100644
--- a/src/main/java/com/seaofnodes/simple/node/XCtrlNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/XCtrlNode.java
@@ -6,9 +6,11 @@ import com.seaofnodes.simple.Parser;
import com.seaofnodes.simple.type.Type;
public class XCtrlNode extends CFGNode {
- public XCtrlNode( ) { super(Parser.START); }
+ public XCtrlNode() { super(Parser.START); }
@Override public String label() { return "Xctrl"; }
@Override protected ExprPrinter<Node> _print1(ExprPrinter<Node> p) { return p.p("Xctrl"); }
+ @Override public boolean isConst() { return true; }
+ @Override public boolean isMultiTail() { return true; }
@Override public Type compute() { return Type.XCONTROL; }
@Override public Node idealize() { return null; }
}
diff --git a/src/main/java/com/seaofnodes/simple/node/XorNode.java b/src/main/java/com/seaofnodes/simple/node/XorNode.java
index 5efe23e2..034e352a 100644
--- a/src/main/java/com/seaofnodes/simple/node/XorNode.java
+++ b/src/main/java/com/seaofnodes/simple/node/XorNode.java
@@ -1,16 +1,15 @@
package com.seaofnodes.simple.node;
-
+import com.seaofnodes.simple.Parser;
import com.seaofnodes.simple.type.Type;
import com.seaofnodes.simple.type.TypeInteger;
+import java.util.BitSet;
-
-public class XorNode extends Node {
- public XorNode(Node lhs, Node rhs) { super(null, lhs, rhs); }
+public class XorNode extends LogicalNode {
+ public XorNode(Parser.Lexer loc, Node lhs, Node rhs) { super(loc, lhs, rhs); }
@Override public String label() { return "Xor"; }
-
- @Override protected String format() { return "(%1^%2)"; }
+ @Override public String op() { return "^"; }
@Override
public Type compute() {
@@ -49,10 +48,5 @@ public class XorNode extends Node {
return null;
}
- @Override Node copy(Node lhs, Node rhs) { return new XorNode(lhs,rhs); }
- @Override String err() {
- if( !(in(1)._type instanceof TypeInteger) ) return "Cannot '^' " + in(1)._type;
- if( !(in(2)._type instanceof TypeInteger) ) return "Cannot '^' " + in(2)._type;
- return null;
- }
+ @Override Node copy(Node lhs, Node rhs) { return new XorNode(_loc,lhs,rhs); }
}
diff --git a/src/main/java/com/seaofnodes/simple/print/SimpleGraphAdapter.java b/src/main/java/com/seaofnodes/simple/print/SimpleGraphAdapter.java
index 7ba58e6f..3e23968a 100644
--- a/src/main/java/com/seaofnodes/simple/print/SimpleGraphAdapter.java
+++ b/src/main/java/com/seaofnodes/simple/print/SimpleGraphAdapter.java
@@ -6,18 +6,33 @@ import com.seaofnodes.simple.node.*;
import com.seaofnodes.simple.node.Node;
import com.seaofnodes.simple.type.TypeMem;
-/** Chapter 17's view of the IR; browser, transport and layout are shared. */
+/** Chapter 18's view of the IR; browser, transport and layout are shared. */
public class SimpleGraphAdapter extends GraphAdapter<Node> {
@Override protected String edgeName(Node n, int i) {
return n instanceof ScopeNode scope && i < scope._vars.size()
? scope._vars.get(i)._name : null;
}
+ @Override protected int edgeJump(Node n, int i) {
+ return n instanceof CallEndNode && i>0 && n.in(i) instanceof ReturnNode ret
+ ? ref(ret.fun()) : 0;
+ }
@Override protected int projectionIndex(Node n) { return n instanceof ProjNode p ? p._idx : n instanceof CProjNode p ? p._idx : -1; }
+ @Override protected boolean folding(Node n) {
+ if( n instanceof FunNode fun ) return fun.folding();
+ if( n instanceof ReturnNode ret ) return ret.fun().folding();
+ if( n instanceof CallEndNode cend ) return cend.folding();
+ if( n instanceof CallNode )
+ for( int i=0; i<n.nOuts(); i++ )
+ if( n.out(i) instanceof CallEndNode cend && cend.folding() ) return true;
+ return false;
+ }
+
@Override protected Kind kind(Node n) {
if( n instanceof StopNode ) return Kind.STOP;
if( n instanceof ScopeNode ) return Kind.SCOPE;
+ if( n instanceof FunNode ) return Kind.FUN;
if( n instanceof StartNode ) return Kind.CTRL;
if( n instanceof LoopNode ) return Kind.LOOP;
if( n instanceof RegionNode ) return Kind.REGION;
@@ -26,13 +41,13 @@ public class SimpleGraphAdapter extends GraphAdapter<Node> {
}
@Override protected Role role(Node n, int i) {
- if( n instanceof ScopeNode || n instanceof ConstantNode || n instanceof XCtrlNode ) return Role.ASSOC;
+ if( n instanceof ScopeNode || n instanceof ConstantNode || n instanceof CtrlNode || n instanceof XCtrlNode ) return Role.ASSOC;
if( n instanceof PhiNode ) return i == 0 ? Role.ASSOC : isMem(n) ? Role.MEM : Role.DATA;
if( n instanceof ProjNode || n instanceof CProjNode )
return n instanceof CFGNode ? Role.CTRL : isMem(n) ? Role.MEM : Role.DATA;
if( n instanceof RegionNode && i == 0 ) return Role.ASSOC;
if( i == 0 || n instanceof RegionNode || n instanceof StopNode ) return Role.CTRL;
- if( i == 1 && (n instanceof MemOpNode || n instanceof ReturnNode || n instanceof NewNode) ) return Role.MEM;
+ if( n instanceof MemMergeNode || (i == 1 && (n instanceof MemOpNode || n instanceof ReturnNode || n instanceof CallNode || n instanceof NewNode)) ) return Role.MEM;
Node def = n.in(i);
if( def != null && isMem(def) ) return Role.MEM;
return Role.DATA;
diff --git a/src/main/java/com/seaofnodes/simple/print/SimpleGraphObserver.java b/src/main/java/com/seaofnodes/simple/print/SimpleGraphObserver.java
index d774967b..b2dd3107 100644
--- a/src/main/java/com/seaofnodes/simple/print/SimpleGraphObserver.java
+++ b/src/main/java/com/seaofnodes/simple/print/SimpleGraphObserver.java
@@ -2,44 +2,35 @@ package com.seaofnodes.simple.print;
import com.seaofnodes.graph.GraphCapture;
import com.seaofnodes.graph.GraphViewer;
-import com.seaofnodes.simple.Parser;
+import com.seaofnodes.simple.CodeGen;
import com.seaofnodes.simple.node.Node;
import java.util.ArrayList;
import java.io.IOException;
-/** Chapter 17's compilation context; capture and event bookkeeping are shared. */
+/** Chapter 18's compilation context; capture and event bookkeeping are shared. */
public class SimpleGraphObserver extends GraphCapture<Node> {
- private Parser _parser;
- private Node _ret;
- private String _phase;
+ private CodeGen _code;
public SimpleGraphObserver() { super(new SimpleGraphAdapter()); }
public static void main(String[] args) throws IOException {
GraphViewer.run(new SimpleGraphObserver());
}
@Override protected void compile(String src) {
- _parser = new Parser(src);
- _parser._obs = this;
- _phase = "Parse";
- _ret = _parser.parse();
- phase(_phase);
- _phase = "Iter";
- com.seaofnodes.simple.IterPeeps.iterate(_parser.STOP);
- phase(_phase);
- _phase = "TypeCheck";
- _parser.STOP.typeCheck();
+ _code = new CodeGen(src);
+ _code._obs = this;
+ _code.parse().opto().typeCheck();
}
- @Override protected String phase() { return _phase; }
- @Override protected int pos() { return "Parse".equals(_phase) ? _parser.pos() : -1; }
+ @Override protected String phase() { return _code._phase.name(); }
+ @Override protected int pos() { return _code.P != null ? _code.P.pos() : -1; }
@Override protected void detach() {
- if( _parser != null ) _parser._obs = null;
- _parser = null;
- _ret = null;
+ if( _code != null ) _code._obs = null;
+ _code = null;
}
- @Override protected Node scope() { return _parser._scope; }
+ @Override protected Node scope() { return _code.P == null ? null : _code.P._scope; }
@Override protected void roots(ArrayList<Node> roots) {
- roots.add(Parser.START);
- roots.add(_parser.STOP);
- roots.addAll(_parser._xScopes);
- roots.add(_ret);
+ roots.add(_code._stop);
+ if( _code.P != null ) {
+ roots.add(com.seaofnodes.simple.Parser.START);
+ roots.addAll(_code.P._xScopes);
+ }
}
}
diff --git a/src/main/java/com/seaofnodes/simple/type/Field.java b/src/main/java/com/seaofnodes/simple/type/Field.java
index 71c2fded..c93f82e7 100644
--- a/src/main/java/com/seaofnodes/simple/type/Field.java
+++ b/src/main/java/com/seaofnodes/simple/type/Field.java
@@ -1,5 +1,6 @@
package com.seaofnodes.simple.type;
+import com.seaofnodes.simple.SB;
import com.seaofnodes.simple.Utils;
import java.util.ArrayList;
@@ -36,8 +37,9 @@ public class Field extends Type {
@Override public Field makeRO() { return isFinal() ? this : make(_fname,_type.makeRO(),_alias,true); }
@Override public boolean isFinal() { return _final && _type.isFinal(); }
- public static final Field TEST = make("test",TypeInteger.ZERO,-2,false);
- public static void gather(ArrayList<Type> ts) { ts.add(TEST); }
+ public static final Field TEST = make("test",Type.NIL,-2,false);
+ public static final Field TEST2= make("test",Type.NIL,-2,true);
+ public static void gather(ArrayList<Type> ts) { ts.add(TEST); ts.add(TEST2); }
@Override Field xmeet( Type that ) {
Field fld = (Field)that; // Invariant
@@ -51,12 +53,7 @@ public class Field extends Type {
@Override public Field glb() {
Type glb = _type.glb();
- return glb==_type ? this : make(_fname,glb,_alias,_final);
- }
-
- @Override public Field lub() {
- Type lub = _type.lub();
- return lub==_type ? this : make(_fname,lub,_alias,_final);
+ return (glb==_type && _final) ? this : make(_fname,glb,_alias,true);
}
// Override in subclasses
@@ -69,8 +66,8 @@ public class Field extends Type {
@Override
- public StringBuilder print( StringBuilder sb ) {
- return _type.print(sb.append(_final?"":"!").append(_fname).append(":").append(_alias).append(" : "));
+ public SB print( SB sb ) {
+ return _type.print(sb.p(_final?"":"!").p(_fname).p(":").p(_alias).p(" : "));
}
@Override public String str() { return _fname; }
diff --git a/src/main/java/com/seaofnodes/simple/type/Type.java b/src/main/java/com/seaofnodes/simple/type/Type.java
index 60afb668..34f54be8 100644
--- a/src/main/java/com/seaofnodes/simple/type/Type.java
+++ b/src/main/java/com/seaofnodes/simple/type/Type.java
@@ -1,7 +1,7 @@
package com.seaofnodes.simple.type;
+import com.seaofnodes.simple.SB;
import com.seaofnodes.simple.Utils;
-
import java.util.ArrayList;
import java.util.HashMap;
@@ -31,37 +31,50 @@ public class Type {
static final byte TTOP = 1; // Top (ANY)
static final byte TCTRL = 2; // Ctrl flow bottom
static final byte TXCTRL = 3; // Ctrl flow top (mini-lattice: any-xctrl-ctrl-all)
- static final byte TSIMPLE = 4; // End of the Simple Types
- static final byte TINT = 5; // All Integers; see TypeInteger
- static final byte TFLT = 6; // All Integers; see TypeInteger
- static final byte TTUPLE = 7; // Tuples; finite collections of unrelated Types, kept in parallel
- static final byte TMEM = 8; // All memory (alias 0) or A slice of memory - with specific alias
- static final byte TMEMPTR = 9; // Memory pointer type
- static final byte TSTRUCT =10; // Structs; tuples with named fields
- static final byte TFLD =11; // Fields into struct
- static final byte TARRAY =12; // Array
+ static final byte TNIL = 4; // low null of all flavors
+ static final byte TXNIL = 5; // high or choice null
+ static final byte TSIMPLE = 6; // End of the Simple Types
+
+ static final byte TPTR = 7; // All nil-able scalar values
+ static final byte TINT = 8; // All Integers; see TypeInteger
+ static final byte TFLT = 9; // All Floats ; see TypeFloat
+ static final byte TMEMPTR =10; // Memory pointer to a struct type
+ static final byte TFUNPTR =11; // Function pointer; unique signature and code address (just a bit)
+ static final byte TTUPLE =12; // Tuples; finite collections of unrelated Types, kept in parallel
+ static final byte TMEM =13; // All memory (alias 0) or A slice of memory - with specific alias
+ static final byte TSTRUCT =14; // Structs; tuples with named fields
+ static final byte TFLD =15; // Named fields in structs
+ static final byte TRPC =16; // Return Program Control (Return PC or RPC)
public final byte _type;
public boolean is_simple() { return _type < TSIMPLE; }
- private static final String[] STRS = new String[]{"Bot","Top","Ctrl","~Ctrl"};
+ private static final String[] STRS = new String[]{"Bot","Top","Ctrl","~Ctrl","null","~nil"};
protected Type(byte type) { _type = type; }
public static final Type BOTTOM = new Type( TBOT ).intern(); // ALL
public static final Type TOP = new Type( TTOP ).intern(); // ANY
public static final Type CONTROL = new Type( TCTRL ).intern(); // Ctrl
public static final Type XCONTROL = new Type( TXCTRL ).intern(); // ~Ctrl
+ public static final Type NIL = new Type( TNIL ).intern(); // low null of all flavors
+ public static final Type XNIL = new Type( TXNIL ).intern(); // high or choice null
public static Type[] gather() {
ArrayList<Type> ts = new ArrayList<>();
ts.add(BOTTOM);
ts.add(CONTROL);
- Field.gather(ts);
+ ts.add(NIL);
+ ts.add(XNIL);
+ TypeNil.gather(ts);
+ TypePtr.gather(ts);
TypeInteger.gather(ts);
TypeFloat.gather(ts);
- TypeMem.gather(ts);
TypeMemPtr.gather(ts);
+ TypeFunPtr.gather(ts);
+ TypeMem.gather(ts);
+ Field.gather(ts);
TypeStruct.gather(ts);
TypeTuple.gather(ts);
+ TypeRPC.gather(ts);
int sz = ts.size();
for( int i = 0; i < sz; i++ )
ts.add(ts.get(i).dual());
@@ -69,18 +82,12 @@ public class Type {
}
// Is high or on the lattice centerline.
- public boolean isHigh () { return _type==TTOP || _type==TXCTRL; }
- public boolean isHighOrConst() { return _type==TTOP || _type==TXCTRL; }
+ public boolean isHigh () { return _type==TTOP || _type==TXCTRL || _type==TXNIL; }
+ public boolean isHighOrConst() { return isHigh() || isConstant(); }
// Strict constant values, things on the lattice centerline.
// Excludes both high and low values
- public boolean isConstant() { return false; }
-
- /**
- * Display Type name in a format that's good for IR printer
- */
- public StringBuilder typeName( StringBuilder sb) { return print(sb); }
-
+ public boolean isConstant() { return _type==TNIL; }
// ----------------------------------------------------------
@@ -92,7 +99,7 @@ public class Type {
// to be immutable once defined. The rationale for interning is
// *correctness* with cyclic type definitions. Simple structural recursive
// checks go exponential with merely sharing, but with cycles they will
- // stack overflow and crash. Intering means we do not need to have sharing
+ // stack overflow and crash. Interning means we do not need to have sharing
// checks with every type compare, only during interning.
// Factory method which interns "this"
@@ -131,6 +138,9 @@ public class Type {
if( t == this ) return this;
// Same-type is always safe in the subclasses
if( _type==t._type ) return xmeet(t);
+ // TypeNil vs TypeNil meet
+ if( this instanceof TypeNil ptr0 && t instanceof TypeNil ptr1 )
+ return ptr0.nmeet(ptr1);
// Reverse; xmeet 2nd arg is never "is_simple" and never equal to "this".
if( is_simple() ) return this.xmeet(t );
if( t.is_simple() ) return t .xmeet(this);
@@ -145,18 +155,27 @@ public class Type {
// ANY meet anything is thing; thing meet ALL is ALL
if( _type==TBOT || t._type==TTOP ) return this;
if( _type==TTOP || t._type==TBOT ) return t;
- // 'this' is {TCTRL,TXCTRL}
+
+ // RHS TypeNil vs NIL/XNIL
+ if( _type== TNIL ) return t instanceof TypeNil ptr ? ptr.meet0() : (t._type==TXNIL ? TypePtr.PTR : BOTTOM);
+ if( _type== TXNIL ) return t instanceof TypeNil ptr ? ptr.meetX() : (t._type== TNIL ? TypePtr.PTR : BOTTOM);
+ // 'this' is only {TCTRL,TXCTRL}
+ // Other non-simple RHS things bottom out
if( !t.is_simple() ) return BOTTOM;
- // 't' is {TCTRL,TXCTRL}
+ // If RHS is NIL/XNIL
+ if( t._type==TNIL || t._type==TXNIL ) return BOTTOM;
+ // Both are {TCTRL,TXCTRL} and unequal to each other
return _type==TCTRL || t._type==TCTRL ? CONTROL : XCONTROL;
}
public Type dual() {
return switch( _type ) {
- case TBOT -> TOP;
- case TTOP -> BOTTOM;
- case TCTRL -> XCONTROL;
- case TXCTRL -> CONTROL;
+ case TBOT -> TOP;
+ case TTOP -> BOTTOM;
+ case TCTRL ->XCONTROL;
+ case TXCTRL-> CONTROL;
+ case TNIL ->XNIL;
+ case TXNIL -> NIL;
default -> throw Utils.TODO(); // Should not reach here
};
}
@@ -172,19 +191,16 @@ public class Type {
// True if this "isa" t; e.g. 17 isa TypeInteger.BOT
public boolean isa( Type t ) { return meet(t)==t; }
- /** Compute greatest lower bound in the lattice */
- public Type glb() { return _type==TCTRL ? CONTROL : BOTTOM; }
- /** Compute least upper bound in the lattice */
- public Type lub() { return _type==TCTRL ? XCONTROL : TOP; }
+ // True if this "isa" t up to named structures
+ public boolean shallowISA( Type t ) { return isa(t); }
+
+ public Type nonZero() { return TypePtr.NPTR; }
- // Make an initial/default version of this type. Typically, 0 for integers
- // and null for nullable pointers.
- public Type makeInit() { return this; }
// Make a zero version of this type, 0 for integers and null for pointers.
- public Type makeZero() { return null; }
- // Make a non-zero version of this type, if possible. Integers attempt to
- // exclude zero from their range and pointers become not-null.
- public Type nonZero() { return glb(); }
+ public Type makeZero() { return Type.NIL; }
+
+ /** Compute greatest lower bound in the lattice */
+ public Type glb() { return Type.BOTTOM; }
// Writable array slots are invariant in their element access permissions.
// Otherwise an alias could insert a readonly pointer into a writable slot.
@@ -212,11 +228,16 @@ public class Type {
// This is a more verbose dev-friendly print.
@Override
public final String toString() {
- return print(new StringBuilder()).toString();
+ return print(new SB()).toString();
}
- public StringBuilder print(StringBuilder sb) { return is_simple() ? sb.append(STRS[_type]) : sb;}
+ public SB print(SB sb) { return sb.p(str()); }
+ public SB gprint(SB sb) { return print(sb); }
// This is used by error messages, and is a shorted print.
public String str() { return STRS[_type]; }
+
+ public static void reset() {
+ TypeFunPtr.reset();
+ }
}
diff --git a/src/main/java/com/seaofnodes/simple/type/TypeFloat.java b/src/main/java/com/seaofnodes/simple/type/TypeFloat.java
index f85abbed..aa205149 100644
--- a/src/main/java/com/seaofnodes/simple/type/TypeFloat.java
+++ b/src/main/java/com/seaofnodes/simple/type/TypeFloat.java
@@ -1,5 +1,7 @@
package com.seaofnodes.simple.type;
+import com.seaofnodes.simple.SB;
+import com.seaofnodes.simple.Utils;
import java.util.ArrayList;
/**
@@ -7,13 +9,12 @@ import java.util.ArrayList;
*/
public class TypeFloat extends Type {
- public final static TypeFloat TOP = make((byte)-64, 0);
- public final static TypeFloat T32 = make((byte)-32, 0);
- public final static TypeFloat ZERO= make((byte) 0, 0);
- public final static TypeFloat B32 = make((byte) 32, 0);
- public final static TypeFloat BOT = make((byte) 64, 0);
+ public final static TypeFloat ONE = constant(1.0);
+ public final static TypeFloat FZERO = constant(0.0);
+ public final static TypeFloat F32 = make(32, 0);
+ public final static TypeFloat F64 = make(64, 0);
- /** +/-64 for double; +/-32 for float, or 0 for constants */
+ // - high -64, high -32, con 0, low +32, low +64
public final byte _sz;
/**
@@ -23,98 +24,72 @@ public class TypeFloat extends Type {
private TypeFloat(byte sz, double con) {
super(TFLT);
- _sz = sz ;
+ _sz = sz;
_con = con;
}
- private static TypeFloat make(byte sz, double con) {
- return new TypeFloat(sz,con).intern();
+ private static TypeFloat make(int sz, double con) {
+ return new TypeFloat((byte)sz,con).intern();
}
- public static TypeFloat constant(double con) { return make((byte)0, con); }
+ public static TypeFloat constant(double con) { return make(0, con); }
- public static void gather(ArrayList<Type> ts) { ts.add(ZERO); ts.add(BOT); ts.add(B32); ts.add(constant(3.141592653589793)); }
-
- // FIXME this display format is problematic
- // In visualizer '#' gets prepended if its a constant
- @Override
- public StringBuilder print(StringBuilder sb) {
- if( this==TOP ) return sb.append("FltTop");
- if( this==T32 ) return sb.append("F32Top");
- if( this==B32 ) return sb.append("F32Bot");
- if( this==BOT ) return sb.append("FltBot");
- return sb.append(_con);
- }
+ public static void gather(ArrayList<Type> ts) { ts.add(F64); ts.add(F32); ts.add(constant(3.141592653589793)); }
@Override public String str() {
- if( this==TOP ) return "~flt";
- if( this==T32 ) return "~f32";
- if( this==B32 ) return "f32";
- if( this==BOT ) return "flt";
- return ""+_con+(isF32() ? "f" : "");
- }
-
- /**
- * Display Type name in a format that's good for IR printer
- */
- @Override
- public StringBuilder typeName(StringBuilder sb) {
- if( this==TOP ) return sb.append("FltTop");
- if( this==T32 ) return sb.append("F32Top");
- if( this==B32 ) return sb.append("F32Bot");
- if( this==BOT ) return sb.append("FltBot");
- return sb.append(isF32() ? "F32" : "Flt");
+ return switch( _sz ) {
+ case -64 -> "~flt";
+ case -32 -> "~f32";
+ case 0 -> ""+_con+((float)_con==_con ? "f" : "");
+ case 32 -> "f32";
+ case 64 -> "flt";
+ default -> throw Utils.TODO();
+ };
}
+ private boolean isF32() { return ((float)_con)==_con; }
- boolean isF32() { return ((float)_con)==_con; }
- @Override public boolean isHigh() { return _sz< 0; }
- @Override public boolean isHighOrConst() { return _sz<=0; }
- @Override public boolean isConstant() { return _sz==0; }
-
- @Override public int log_size() {
- int sz = _sz==0 ? (isF32() ? 32 : 64) : Math.abs(_sz);
- return _sz==32 ? 2 : 3;
- }
+ @Override public boolean isHigh () { return _sz< 0; }
+ @Override public boolean isConstant() { return _sz==0; }
+ @Override public int log_size() { return _sz==32 || _sz==-32 ? 2 : 3; }
public double value() { return _con; }
@Override
- public Type xmeet(Type other) {
- // Invariant from caller: 'this' != 'other' and same class (TypeFloat)
+ public TypeFloat xmeet(Type other) {
+ TypeFloat f = (TypeFloat)other;
+ // Invariant from caller: 'this' != 'other' and same class (TypeFloat).
TypeFloat i = (TypeFloat)other; // Contract
// Larger size in i1, smaller in i0
TypeFloat i0 = _sz < i._sz ? this : i;
TypeFloat i1 = _sz < i._sz ? i : this;
- if( i1._sz== 64 ) return BOT;
+ if( i1._sz== 64 ) return F64;
if( i0._sz==-64 ) return i1;
if( i1._sz== 32 )
- return i0._sz==0 && !i0.isF32() ? BOT : B32;
+ return i0._sz==0 && !i0.isF32() ? F64 : F32;
if( i1._sz!= 0 ) return i1;
// i1 is a constant
if( i0._sz==-32 )
- return i1.isF32() ? i1 : BOT;
+ return i1.isF32() ? i1 : F64;
// Since both are constants, and are never equals (contract) unequals
// constants fall to bottom
- return i0.isF32() && i1.isF32() ? B32 : BOT;
+ return i0.isF32() && i1.isF32() ? F32 : F64;
}
@Override
public Type dual() {
- if( _sz==0 ) return this; // Constants are a self-dual
- return make((byte)-_sz,0);
+ return isConstant() ? this : make(-_sz,0); // Constants are a self-dual
}
- @Override public Type glb() { return BOT; }
- @Override public Type lub() { return TOP; }
- @Override public TypeFloat makeInit() { return ZERO; }
- @Override public TypeFloat makeZero() { return ZERO; }
+ @Override public Type makeZero() { return FZERO; }
+ @Override public Type glb() { return F64; }
@Override
- int hash() { return (int)(Double.hashCode(_con) ^ _sz); }
+ int hash() { return (int)(Double.hashCode(_con) ^ _sz ^ (1<<17)); }
@Override
public boolean eq( Type t ) {
TypeFloat i = (TypeFloat)t; // Contract
- return _con==i._con && _sz==i._sz;
+ // Allow NaN to check for equality
+ return _sz==i._sz && Double.doubleToLongBits(_con)==Double.doubleToLongBits(i._con);
}
}
diff --git a/src/main/java/com/seaofnodes/simple/type/TypeFunPtr.java b/src/main/java/com/seaofnodes/simple/type/TypeFunPtr.java
new file mode 100644
index 00000000..61fc71cf
--- /dev/null
+++ b/src/main/java/com/seaofnodes/simple/type/TypeFunPtr.java
@@ -0,0 +1,143 @@
+package com.seaofnodes.simple.type;
+
+import com.seaofnodes.simple.SB;
+import com.seaofnodes.simple.Utils;
+import java.util.ArrayList;
+import java.util.HashMap;
+
+/**
+ * Represents a Pointer to a function.
+ * <p></p>
+ * Functions have argument types and a return type, making a function
+ * signature. Within a signature there can be many instances of functions, and
+ * each function is labeled with a small integer constant. A TFP can represent
+ * a single signature and a set of functions; the set might contain only 1
+ * function or the zeroth function (the null ptr).
+ * <p></p>
+ * Functions with different signatures cannot be mixed, and will result in a
+ * bottom function type, which can only be null-checked.
+ */
+public class TypeFunPtr extends TypeNil {
+ // A TypeFunPtr is Signature and a set of functions.
+ public final TypeTuple _sig;
+ public final Type _ret;
+ // Cheesy easy implementation for a small set; 1 bit per unique function
+ // within the TypeTuple. Can be upgraded to a BitSet for larger classes of
+ // functions. Negative means "these 63 concrete bits plus infinite unknown more"
+ public final long _fidxs; // 63 unique functions per signature
+ public String _name; // Optional debug function name; only for named single function
+
+ private TypeFunPtr(byte nil, TypeTuple sig, Type ret, long fidxs) {
+ super(TFUNPTR,nil);
+ assert sig != null;
+ _sig = sig;
+ _ret = ret;
+ _fidxs = fidxs;
+ }
+
+ static TypeFunPtr make( byte nil, TypeTuple sig, Type ret, long fidxs ) { return new TypeFunPtr(nil,sig,ret,fidxs).intern(); }
+ public static TypeFunPtr make( boolean nil, TypeTuple sig, Type ret ) { return make((byte)(nil ? 3 : 2),sig,ret,-1); }
+ @Override TypeFunPtr makeFrom( byte nil ) { return nil ==_nil ? this : make( nil,_sig,_ret, _fidxs).setName(_name); }
+ public TypeFunPtr makeFrom( Type ret ) { return ret ==_ret ? this : make( _nil,_sig, ret, _fidxs).setName(_name); }
+ public TypeFunPtr makeFrom( int fidx ) { return make((byte)2, _sig,_ret,1L<<fidx ).setName(_name); }
+
+ // Compute "function indices": FIDX
+ private static final HashMap<TypeTuple,Integer> FIDXS = new HashMap<>();
+ private static int nextFIDX(TypeTuple sig) {
+ Integer i = FIDXS.get(sig);
+ int fidx = i==null ? 0 : i;
+ FIDXS.put(sig,fidx+1); // Track count per sig
+ assert fidx<64; // TODO: need a larger FIDX space
+ return fidx; // Return
+ }
+ public static TypeFunPtr makeFun( TypeTuple sig, Type ret ) {
+ return make((byte)2,sig,ret,1L<<nextFIDX(sig));
+ }
+
+ public static TypeFunPtr BOT = make((byte)3,TypeTuple.BOT,Type.BOTTOM,-1);
+ public static TypeFunPtr TEST = make((byte)2,TypeTuple.TEST,TypeInteger.BOT,1);
+ public static TypeFunPtr TEST0 = make((byte)3,TypeTuple.TEST,TypeInteger.BOT,3);
+ public static TypeFunPtr MAIN = makeFun(TypeTuple.MAIN,Type.BOTTOM).setName("main");
+ public static void gather(ArrayList<Type> ts) { ts.add(TEST); ts.add(TEST0); ts.add(BOT); ts.add(MAIN); }
+
+ @Override
+ Type xmeet(Type t) {
+ TypeFunPtr that = (TypeFunPtr) t;
+ return TypeFunPtr.make(xmeet0(that),(TypeTuple)_sig.meet(that._sig), _ret.meet(that._ret), _fidxs | that._fidxs);
+ }
+
+ @Override
+ public TypeFunPtr dual() { return TypeFunPtr.make(dual0(), _sig.dual(), _ret.dual(), ~_fidxs); }
+
+ // RHS is NIL; do not deep-dual when crossing the centerline
+ @Override public Type meet0() { return _nil==3 ? this : make((byte)3,_sig,_ret,_fidxs); }
+
+ @Override public TypeFunPtr glb() { return make((byte)3,_sig,_ret,-1L); }
+
+ @Override public boolean isHigh () { return _nil <= 1 || (_nil==2 && _fidxs==0); }
+ @Override public boolean isConstant() { return (_nil==2 && Long.bitCount(_fidxs)==1) || (_nil==3 && _fidxs==0); }
+
+ @Override public int log_size() { return 2; } // (1<<2)==4-byte pointers
+
+ public Type arg(int i) { return _sig._types[i]; }
+ public long fidxs() { return _fidxs; }
+ public Type ret() { return _ret; }
+ public int nargs() { return _sig._types.length; }
+
+ @Override
+ int hash() { return Utils.fold(_sig.hashCode() ^ _ret.hashCode() ^ _fidxs ^ super.hash()); }
+
+ @Override
+ boolean eq(Type t) {
+ TypeFunPtr ptr = (TypeFunPtr)t; // Invariant
+ return _sig == ptr._sig && _ret == ptr._ret && _fidxs == ptr._fidxs && super.eq(ptr);
+ }
+
+ public TypeFunPtr setName(String name) {
+ if( name==null ) return this;
+ assert _fidxs > 0 && Long.bitCount(_fidxs) == 1;
+ // Name can be set to different things, just for debug
+ //assert _name==null || _name.equals(name);
+ _name = name;
+ return this;
+ }
+
+ @Override public String str() { return print(new SB()).toString();
+ }
+ @Override public SB print(SB sb) { return _print(sb,false,true); }
+ public SB print(SB sb, boolean n) { return _print(sb,false,n); }
+ @Override public SB gprint(SB sb) { return _print(sb,true ,true); }
+ private static SB _print(SB sb, boolean g, Type t) { return g ? t.gprint(sb) : t.print(sb); }
+ private SB _print(SB sb, boolean g, boolean n) {
+ if( this==BOT ) return sb.p("FunBot");
+ if( _nil==0 && _sig==TypeTuple.TOP && _ret==Type.TOP && _fidxs==0 ) return sb.p("FunTop");
+ sb.p(x()).p("{ ");
+ if( n && _name!=null ) sb.p(_name);
+ else {
+ if( _sig._types!=null )
+ for( Type t : _sig._types )
+ _print(sb,g,t).p(" ");
+ _print(sb.p(g ? "&rarr; " : "-> "),g,_ret).p(" #");
+ if( isHigh() ) sb.p("~");
+ long fidxs = isHigh() ? ~_fidxs : _fidxs;
+ String fidx = fidxs==0 ? ""
+ : Long.bitCount(fidxs) == 1 ? ""+Long.numberOfTrailingZeros(fidxs)
+ : fidxs == -1 ? "ALL"
+ : "b"+Long.toBinaryString(fidxs); // Just some function bits
+ sb.p(fidx);
+ }
+ return sb.p("}").p(q());
+ }
+
+ // Usage: for( long fidxs=fidxs(); fidxs!=0; fidxs=nextFIDX(fidxs) { int fidxs = Long.numberOfTrailingZeros(fidxs); ... }
+ public static long nextFIDX(long fidxs) { return fidxs & (fidxs-1); }
+
+ public static void reset() {
+ FIDXS.clear();
+ FIDXS.put(MAIN._sig,1);
+ for( Type t : INTERN.keySet() )
+ if( t instanceof TypeFunPtr tfp && tfp!=MAIN)
+ tfp._name = null;
+ }
+
+}
diff --git a/src/main/java/com/seaofnodes/simple/type/TypeInteger.java b/src/main/java/com/seaofnodes/simple/type/TypeInteger.java
index b2979d7b..cccb85a5 100644
--- a/src/main/java/com/seaofnodes/simple/type/TypeInteger.java
+++ b/src/main/java/com/seaofnodes/simple/type/TypeInteger.java
@@ -1,5 +1,6 @@
package com.seaofnodes.simple.type;
+import com.seaofnodes.simple.SB;
import com.seaofnodes.simple.Utils;
import java.util.ArrayList;
@@ -8,17 +9,19 @@ import java.util.ArrayList;
*/
public class TypeInteger extends Type {
- public final static TypeInteger TOP = make(false, 0);
- public final static TypeInteger BOT = make(false, 1);
public final static TypeInteger ZERO= make(0,0);
- public final static TypeInteger U1 = make(0,1);
- public final static TypeInteger BOOL= U1;
public final static TypeInteger FALSE=ZERO;
public final static TypeInteger TRUE= make(1,1);
+
+ public final static TypeInteger I1 = make(-1,0);
public final static TypeInteger I8 = make(-128,127);
public final static TypeInteger I16 = make(-32768,32767);
public final static TypeInteger I32 = make(-1L<<31,(1L<<31)-1);
+ public final static TypeInteger BOT = make(Long.MIN_VALUE,Long.MAX_VALUE);
+ public final static TypeInteger TOP = BOT.dual();
+ public final static TypeInteger U1 = make(0,1);
+ public final static TypeInteger BOOL= U1;
public final static TypeInteger U8 = make(0,255);
public final static TypeInteger U16 = make(0,65535);
public final static TypeInteger U32 = make(0,(1L<<32)-1);
@@ -26,55 +29,50 @@ public class TypeInteger extends Type {
/**
* Describes an integer *range* - everything from min to max; both min and
* max are inclusive. If min==max, this is a constant.
- *
+ * <br>
* If min <= max, this is a below center (towards bottom).
* If min > max, this is an above center (towards top).
*/
public final long _min, _max;
- private TypeInteger(long min, long max) { super(TINT); _min = min; _max = max; }
- public static TypeInteger make(long lo, long hi) { return new TypeInteger(lo,hi).intern(); }
- public static TypeInteger make(boolean is_con, long con) {
- return make(is_con ? con : (con==0 ? Long.MAX_VALUE : Long.MIN_VALUE),
- is_con ? con : (con==0 ? Long.MIN_VALUE : Long.MAX_VALUE));
+ private TypeInteger(long min, long max) {
+ super(TINT);
+ _min = min;
+ _max = max;
}
- public static TypeInteger constant(long con) { return make(true, con); }
+ // Strict non-zero contract
+ public static TypeInteger make(long lo, long hi) { return new TypeInteger(lo,hi).intern(); }
- public static void gather(ArrayList<Type> ts) { ts.add(ZERO); ts.add(BOT); ts.add(U1); ts.add(U8); }
+ public static TypeInteger constant(long con) { return make(con, con); }
- // FIXME this display format is problematic
- // In visualizer '#' gets prepended if its a constant
- @Override
- public StringBuilder print(StringBuilder sb) { return sb.append(str()); }
+ public static void gather(ArrayList<Type> ts) { ts.add(I32); ts.add(BOT); ts.add(U1); ts.add(I1); ts.add(U8); }
@Override public String str() {
- if( this==TOP ) return "~int";
- if( this==BOT ) return "int";
- if( this==BOOL) return ("bool");
- if( this==I8 ) return ("i8");
- if( this==I16 ) return ("i16");
- if( this==I32 ) return ("i32");
- if( this==U8 ) return ("u8");
- if( this==U16 ) return ("u16");
- if( this==U32 ) return ("u32");
if( isConstant() ) return ""+_min;
- return "["+_min+"-"+_max+"]";
+ long lo = _min, hi = _max;
+ String x = "";
+ if( hi < lo ) {
+ lo = _max; hi = _min;
+ x = "~";
+ }
+ return x+_str(lo,hi);
}
-
- /**
- * Display Type name in a format that's good for IR printer
- */
- @Override
- public StringBuilder typeName(StringBuilder sb) {
- if( this==TOP ) return sb.append("IntTop");
- if( this==BOT ) return sb.append("IntBot");
- return sb.append("Int");
+ private static String _str(long lo, long hi) {
+ if( lo==Long.MIN_VALUE && hi==Long.MAX_VALUE ) return "int";
+ if( lo== 0 && hi== 1 ) return "bool";
+ if( lo== -1 && hi== 0 ) return "i1";
+ if( lo== -128 && hi== 127 ) return "i8";
+ if( lo== -32768 && hi== 32767 ) return "i16";
+ if( lo== -1L<<31 && hi==(1L<<31)-1 ) return "i32";
+ if( lo== 0 && hi== 255 ) return "u8";
+ if( lo== 0 && hi== 65535 ) return "u16";
+ if( lo== 0 && hi==(1L<<32)-1 ) return "u32";
+ return "["+lo+"-"+hi+"]";
}
- @Override public boolean isHigh () { return _min > _max; }
- @Override public boolean isHighOrConst() { return _min >= _max; }
- @Override public boolean isConstant () { return _min == _max; }
+ @Override public boolean isHigh () { return _min > _max; }
+ @Override public boolean isConstant() { return _min == _max; }
@Override public int log_size() {
if( this==I8 || this==U8 || this==BOOL ) return 0; // 1<<0 == 1 bytes
@@ -93,8 +91,6 @@ public class TypeInteger extends Type {
public long mask() {
if( isHigh() ) return 0;
if( isConstant() ) return _min;
- //if( _min<0 ) return -1L;
- //if( _max==Long.MAX_VALUE ) return -1L;
// Those bit positions which differ min to max
long x = _min ^ _max;
// Highest '1' bit in the differ set. Since the range is from min to
@@ -114,19 +110,18 @@ public class TypeInteger extends Type {
}
@Override public TypeInteger dual() { return make(_max,_min); }
- @Override public TypeInteger glb() { return BOT; }
- @Override public TypeInteger lub() { return TOP; }
- @Override public TypeInteger makeInit() { return ZERO; }
- @Override public TypeInteger makeZero() { return ZERO; }
+
@Override public TypeInteger nonZero() {
if( isHigh() ) return this;
+ if( this==ZERO ) return null; // No sane answer
if( _min==0 ) return make(1,Math.max(_max,1)); // specifically good on BOOL
if( _max==0 ) return make(_min,-1);
return this;
}
- @Override int hash() { return (int)((_min ^ (_min>>32)) *(_max ^ (_max>>32))); }
- @Override
- public boolean eq( Type t ) {
+ @Override public Type makeZero() { return ZERO; }
+ @Override public TypeInteger glb() { return BOT; }
+ @Override int hash() { return Utils.fold(_min) * Utils.fold(_max); }
+ @Override public boolean eq( Type t ) {
TypeInteger i = (TypeInteger)t; // Contract
return _min==i._min && _max==i._max;
}
diff --git a/src/main/java/com/seaofnodes/simple/type/TypeMem.java b/src/main/java/com/seaofnodes/simple/type/TypeMem.java
index 6dcd401a..fe393a88 100644
--- a/src/main/java/com/seaofnodes/simple/type/TypeMem.java
+++ b/src/main/java/com/seaofnodes/simple/type/TypeMem.java
@@ -1,5 +1,6 @@
package com.seaofnodes.simple.type;
+import com.seaofnodes.simple.SB;
import com.seaofnodes.simple.Utils;
import java.lang.Long;
import java.util.BitSet;
@@ -13,18 +14,23 @@ public class TypeMem extends Type {
// Which slice of memory?
// 0 means TOP, no slice.
- // -1 means BOT, all memory.
+ // 0 means BOT, all memory.
// N means slice#N.
public final int _alias;
public final Type _t; // Memory contents, some scalar type
- private TypeMem(int alias, Type t) { super(TMEM); _alias = alias; _t = t; }
+ private TypeMem(int alias, Type t) {
+ super(TMEM);
+ assert alias!=0 || (t==Type.TOP || t==Type.BOTTOM);
+ _alias = alias;
+ _t = t;
+ }
public static TypeMem make(int alias, Type t) { return new TypeMem(alias,t).intern(); }
- public static final TypeMem TOP = make(-1, Type.TOP );
- public static final TypeMem BOT = make(-1, Type.BOTTOM);
+ public static final TypeMem TOP = make(0, Type.TOP );
+ public static final TypeMem BOT = make(0, Type.BOTTOM);
- public static void gather(ArrayList<Type> ts) { ts.add(make(1,TypeInteger.ZERO)); ts.add(BOT); }
+ public static void gather(ArrayList<Type> ts) { ts.add(make(1,Type.NIL)); ts.add(make(1,TypeInteger.ZERO)); ts.add(BOT); }
@Override
TypeMem xmeet(Type t) {
@@ -33,7 +39,7 @@ public class TypeMem extends Type {
if( that==TOP ) return this;
if( this==BOT ) return BOT;
if( that==BOT ) return BOT;
- int alias = _alias==that._alias ? _alias : -1;
+ int alias = _alias==that._alias ? _alias : 0;
Type mt = _t.meet(that._t);
return make(alias,mt);
}
@@ -43,26 +49,29 @@ public class TypeMem extends Type {
return make(_alias,_t.dual());
}
+ @Override public boolean isHigh() { return _t.isHigh(); }
@Override public Type glb() { return make(_alias,_t.glb()); }
- @Override public Type lub() { return make(_alias,_t.lub()); }
- @Override
- int hash() { return 9876543 + _alias + _t.hashCode(); }
+ @Override int hash() { return 9876543 + _alias + _t.hashCode(); }
- @Override
- boolean eq(Type t) {
+ @Override boolean eq(Type t) {
TypeMem that = (TypeMem) t; // Invariant
return _alias == that._alias && _t == that._t;
}
- @Override
- public StringBuilder print(StringBuilder sb) {
- if( this==BOT ) return sb.append("MemBot");
- if( this==TOP ) return sb.append("MemTop");
- sb.append("MEM#");
- if( _alias== 0 ) return sb.append("TOP");
- if( _alias==-1 ) return sb.append("BOT");
- return _t.print(sb.append(_alias).append(":"));
+ @Override public SB print(SB sb) {
+ if( this==BOT ) return sb.p("MemBot");
+ if( this==TOP ) return sb.p("MemTop");
+ sb.p("#");
+ if( _alias==0 ) return sb.p(_t._type==TTOP ? "TOP" : "BOT");
+ return _t.print(sb.p(_alias).p(":"));
+ }
+ @Override public SB gprint(SB sb) {
+ if( this==BOT ) return sb.p("MemBot");
+ if( this==TOP ) return sb.p("MemTop");
+ sb.p("#");
+ if( _alias==0 ) return sb.p(_t._type==TTOP ? "TOP" : "BOT");
+ return _t.gprint(sb.p(_alias).p(":"));
}
@Override public String str() { return toString(); }
diff --git a/src/main/java/com/seaofnodes/simple/type/TypeMemPtr.java b/src/main/java/com/seaofnodes/simple/type/TypeMemPtr.java
index 8ecc8031..61b020cb 100644
--- a/src/main/java/com/seaofnodes/simple/type/TypeMemPtr.java
+++ b/src/main/java/com/seaofnodes/simple/type/TypeMemPtr.java
@@ -1,5 +1,7 @@
package com.seaofnodes.simple.type;
+import com.seaofnodes.simple.SB;
+import com.seaofnodes.simple.Utils;
import java.util.ArrayList;
/**
@@ -11,9 +13,9 @@ import java.util.ArrayList;
* The distinguished *$BOT ptr represents union of *void and Null.
* The distinguished *$TOP ptr represents the dual of *$BOT.
*/
-public class TypeMemPtr extends Type {
+public class TypeMemPtr extends TypeNil {
// A TypeMemPtr is pair (obj,nil)
- // where obj is a TypeStruct, possibly TypeStruct.BOT
+ // where obj is a TypeStruct, possibly TypeStruct.BOT/TOP
// where nil is an explicit null is allowed or not
// Examples:
@@ -26,25 +28,25 @@ public class TypeMemPtr extends Type {
// Deep read-only access through this pointer; independent of slot finality.
public boolean _ro;
- public final boolean _nil;
- private TypeMemPtr(TypeStruct obj, boolean nil) {
- super(TMEMPTR);
+ private TypeMemPtr(byte nil, TypeStruct obj) {
+ super(TMEMPTR,nil);
assert obj!=null;
_obj = obj;
_ro = obj==TypeStruct.BOT;
- _nil = nil;
}
- public static TypeMemPtr make(TypeStruct obj, boolean nil) { return new TypeMemPtr(obj, nil).intern(); }
- public static TypeMemPtr make(TypeStruct obj) { return make(obj, false); }
- public TypeMemPtr makeFrom(TypeStruct obj) { return obj==_obj ? this : make(obj, _nil).withAccess(_ro); }
- public TypeMemPtr makeFrom(boolean nil) { return nil==_nil ? this : make(_obj, nil).withAccess(_ro); }
+ static TypeMemPtr make(byte nil, TypeStruct obj) { return new TypeMemPtr(nil, obj).intern(); }
+ public static TypeMemPtr makeNullable(TypeStruct obj) { return make((byte)3, obj); }
+ public static TypeMemPtr make(TypeStruct obj) { return new TypeMemPtr((byte)2, obj).intern(); }
+ public TypeMemPtr makeFrom(TypeStruct obj) { return obj==_obj ? this : make(_nil, obj).withAccess(_ro); }
+ public TypeMemPtr makeNullable() { return makeFrom((byte)3); }
+ @Override TypeMemPtr makeFrom(byte nil) { return nil==_nil ? this : make(nil,_obj).withAccess(_ro); }
@Override public TypeMemPtr makeRO() { return withAccess(true); }
@Override public boolean isFinal() { return _ro; }
public TypeMemPtr withAccess(boolean ro) {
- if( _ro==ro || (_obj==TypeStruct.TOP && _nil) ) return this;
- TypeMemPtr ptr = new TypeMemPtr(_obj, _nil);
+ if( _ro==ro ) return this;
+ TypeMemPtr ptr = new TypeMemPtr(_nil, _obj);
ptr._ro = ro;
return ptr.intern();
}
@@ -60,64 +62,68 @@ public class TypeMemPtr extends Type {
}
// An abstract pointer, pointing to either a Struct or an Array.
- // Can also be null or not.
- public static final TypeMemPtr BOT = make(TypeStruct.BOT,true);
+ // Can also be null or not, so 4 choices {TOP,BOT} x {nil,not}
+ public static final TypeMemPtr BOT = make((byte)3, TypeStruct.BOT);
public static final TypeMemPtr TOP = BOT.dual();
- // An abstract null (can be Struct or Array) or not-null C void*
- public static final TypeMemPtr NULLPTR = make(TypeStruct.TOP,true);
- public static final TypeMemPtr VOIDPTR = NULLPTR.dual(); // A bottom mix of not-null ptrs, like C's void* but not null
+ public static final TypeMemPtr NOTBOT = make((byte)2,TypeStruct.BOT);
- public static final TypeMemPtr TEST= make(TypeStruct.TEST,false);
- public static void gather(ArrayList<Type> ts) { ts.add(NULLPTR); ts.add(BOT); ts.add(TEST); ts.add(TEST.makeRO()); }
+ public static final TypeMemPtr TEST= make((byte)2, TypeStruct.TEST);
+ public static void gather(ArrayList<Type> ts) { ts.add(NOTBOT); ts.add(BOT); ts.add(TEST); ts.add(TEST.makeRO()); }
@Override
- Type xmeet(Type t) {
+ public TypeNil xmeet(Type t) {
TypeMemPtr that = (TypeMemPtr) t;
- return TypeMemPtr.make((TypeStruct)_obj.meet(that._obj), _nil | that._nil).withAccess(_ro | that._ro);
+ return TypeMemPtr.make(xmeet0(that), (TypeStruct)_obj.meet(that._obj)).withAccess(_ro | that._ro);
}
@Override
- public TypeMemPtr dual() { return TypeMemPtr.make(_obj.dual(), !_nil).withAccess(!_ro); }
+ public TypeMemPtr dual() { return TypeMemPtr.make( dual0(), _obj.dual()).withAccess(!_ro); }
- @Override public TypeMemPtr glb() { return make(_obj.glb(),true ).withAccess(true); }
- @Override public TypeMemPtr lub() { return make(_obj.lub(),false); }
+ // RHS is NIL; do not deep-dual when crossing the centerline
+ @Override Type meet0() { return _nil==3 ? this : make((byte)3,_obj).withAccess(_ro); }
+
+
+ // True if this "isa" t up to named structures
+ @Override public boolean shallowISA( Type t ) {
+ if( !(t instanceof TypeMemPtr that) ) return false;
+ if( this==that ) return true;
+ if( xmeet0(that)!=that._nil || (_ro && !that._ro) ) return false;
+ if( _obj==that._obj ) return true;
+ if( _obj._name.equals(that._obj._name) )
+ return true; // Shallow, do not follow matching names, just assume ok
+ throw Utils.TODO(); // return _obj.shallowISA(that._obj);
+ }
+
+ @Override public TypeMemPtr glb() { return make((byte)3,_obj.glb()).withAccess(true); }
// Is forward-reference
@Override public boolean isFRef() { return _obj.isFRef(); }
- @Override public Type makeInit() { return _nil ? NULLPTR : Type.TOP; }
- @Override public Type makeZero() { return NULLPTR; }
- @Override public Type nonZero() { return VOIDPTR; }
-
- @Override public boolean isHigh() { return this==TOP; }
- @Override public boolean isConstant() { return this==NULLPTR; }
- @Override public boolean isHighOrConst() { return this==TOP || this==NULLPTR; }
@Override public int log_size() { return 2; } // (1<<2)==4-byte pointers
- @Override
- int hash() { return (_ro ? 8192 : 0) ^ _obj.hashCode() ^ (_nil ? 1024 : 0); }
+ @Override int hash() { return (_ro ? 8192 : 0) ^ _obj.hashCode() ^ super.hash(); }
- @Override
- boolean eq(Type t) {
+ @Override boolean eq(Type t) {
TypeMemPtr ptr = (TypeMemPtr)t; // Invariant
- return _ro==ptr._ro && _obj == ptr._obj && _nil == ptr._nil;
- }
-
- // [void,name,MANY]*[,?]
- @Override
- public StringBuilder print(StringBuilder sb) {
- if( this==BOT ) return sb.append("PtrBot");
- if( this==TOP ) return sb.append("PtrTop");
- if( this== NULLPTR) return sb.append("null");
- if( this== VOIDPTR) return sb.append("*void");
- return _obj.print(sb.append("*")).append(_nil ? "?" : "");
+ return _ro==ptr._ro && _obj == ptr._obj && super.eq(ptr);
}
@Override public String str() {
if( this==BOT ) return "PtrBot";
if( this==TOP ) return "PtrTop";
- if( this== NULLPTR) return "null";
- if( this== VOIDPTR) return "*void";
- return "*"+_obj.str()+(_nil ? "?" : "");
+ if( this== NOTBOT) return "*void";
+ return x()+"*"+_obj.str()+q();
}
+ @Override public SB print(SB sb) {
+ if( this==BOT ) return sb.p("PtrBot");
+ if( this==TOP ) return sb.p("PtrTop");
+ if( this== NOTBOT) return sb.p("*void");
+ return _obj.print(sb.p(x()).p("*")).p(q());
+ }
+ @Override public SB gprint(SB sb) {
+ if( this==BOT ) return sb.p("PtrBot");
+ if( this==TOP ) return sb.p("PtrTop");
+ if( this== NOTBOT) return sb.p("*void");
+ return _obj.gprint(sb.p(x()).p("*")).p(q());
+ }
}
diff --git a/src/main/java/com/seaofnodes/simple/type/TypeNil.java b/src/main/java/com/seaofnodes/simple/type/TypeNil.java
new file mode 100644
index 00000000..aee623ba
--- /dev/null
+++ b/src/main/java/com/seaofnodes/simple/type/TypeNil.java
@@ -0,0 +1,62 @@
+package com.seaofnodes.simple.type;
+
+import com.seaofnodes.simple.SB;
+import com.seaofnodes.simple.Utils;
+import java.util.ArrayList;
+
+/**
+ * Nil-able Scalar types
+ */
+public abstract class TypeNil extends Type {
+ // 0 = high-subclass choice nil
+ // 1 = high-subclass no nil
+ // 2 = low -subclass no nil
+ // 3 = low -subclass also nil
+ final byte _nil;
+
+ TypeNil(byte t, byte nil ) { super(t); _nil = nil; }
+
+ public static void gather(ArrayList<Type> ts) { }
+
+ abstract TypeNil makeFrom(byte nil);
+
+ byte xmeet0(TypeNil that) { return (byte)Math.max(_nil,that._nil); }
+
+ byte dual0() { return (byte)(3-_nil); }
+
+ // RHS is NIL
+ abstract Type meet0();
+
+ // RHS is XNIL
+ Type meetX() {
+ return _nil==0 ? XNIL : (_nil<=2 ? TypePtr.NPTR : TypePtr.PTR);
+ }
+
+ Type nmeet(TypeNil tn) {
+ // Invariants: both are TypeNil subclasses and unequal classes.
+ // If this is TypePtr, we went to TypePtr.nmeet and not here.
+ // If that is TypePtr, this is not (invariant); reverse and go again.
+ if( tn instanceof TypePtr ts ) return ts.nmeet(this);
+
+ // Two mismatched TypeNil, no Scalar.
+ if( _nil==0 && tn._nil==0 ) return XNIL;
+ if( _nil<=2 && tn._nil<=2 ) return TypePtr.NPTR;
+ return TypePtr.PTR;
+ }
+
+ @Override public boolean isHigh () { return _nil <= 1; }
+ @Override public boolean isConstant () { return false; }
+ @Override public boolean isHighOrConst() { return isHigh() || isConstant(); }
+
+ @Override public Type glb() { return Type.NIL; }
+
+ public boolean notNull() { return _nil==1 || _nil==2; }
+ public boolean nullable() { return _nil==3; }
+
+ final String q() { return _nil == 1 || _nil == 2 ? "" : "?"; }
+ final String x() { return isHigh() ? "~" : ""; }
+
+ int hash() { return _nil<<17; }
+
+ boolean eq(TypeNil ptr) { return _nil == ptr._nil; }
+}
diff --git a/src/main/java/com/seaofnodes/simple/type/TypePtr.java b/src/main/java/com/seaofnodes/simple/type/TypePtr.java
new file mode 100644
index 00000000..e9091c25
--- /dev/null
+++ b/src/main/java/com/seaofnodes/simple/type/TypePtr.java
@@ -0,0 +1,53 @@
+package com.seaofnodes.simple.type;
+
+import com.seaofnodes.simple.SB;
+import com.seaofnodes.simple.Utils;
+import java.util.ArrayList;
+
+/**
+ * Represents a Scalar; a single register-sized value.
+ */
+public class TypePtr extends TypeNil {
+
+ private TypePtr(byte nil) { super(TPTR,nil); }
+
+ // An abstract pointer, pointing to either a Struct or an Array.
+ // Can also be null or not, so 4 choices {TOP,BOT} x {nil,not}
+ public static TypePtr XPTR = new TypePtr((byte)0).intern();
+ public static TypePtr XNPTR= new TypePtr((byte)1).intern();
+ public static TypePtr NPTR = new TypePtr((byte)2).intern();
+ public static TypePtr PTR = new TypePtr((byte)3).intern();
+ private static final TypePtr[] PTRS = new TypePtr[]{XPTR,XNPTR,NPTR,PTR};
+
+ public static void gather(ArrayList<Type> ts) { ts.add(PTR); ts.add(NPTR); }
+
+ TypeNil makeFrom(byte nil) { throw Utils.TODO(); }
+
+ @Override public TypeNil xmeet(Type t) {
+ TypePtr that = (TypePtr) t;
+ return PTRS[xmeet0(that)];
+ }
+
+ @Override public TypePtr dual() { return PTRS[dual0()]; }
+
+ // High scalar loses, low scalar wins
+ @Override TypeNil nmeet(TypeNil tn) {
+ if( _nil==0 ) return tn; // High scalar loses
+ if( _nil==1 ) return tn.makeFrom(xmeet0(tn)); // High scalar loses
+ if( _nil==2 ) return tn._nil==3 ? PTR : NPTR; // Low scalar wins
+ return PTR; // this
+ }
+
+
+ // RHS is NIL
+ @Override Type meet0() { return isHigh() ? NIL : PTR; }
+ // RHS is XNIL
+ // 0->xscalar, 1->nscalar, 2->nscalar, 3->scalar
+ @Override Type meetX() { return _nil==0 ? XNIL : (_nil==3 ? PTR : NPTR); }
+
+ @Override public TypePtr glb() { return PTR; }
+
+ private static final String[] STRS = new String[]{"~ptr","~nptr","nptr","ptr"};
+ @Override public String str() { return STRS[_nil]; }
+ @Override public SB print(SB sb) { return sb.p(str()); }
+}
diff --git a/src/main/java/com/seaofnodes/simple/type/TypeRPC.java b/src/main/java/com/seaofnodes/simple/type/TypeRPC.java
new file mode 100644
index 00000000..ec2f5f0a
--- /dev/null
+++ b/src/main/java/com/seaofnodes/simple/type/TypeRPC.java
@@ -0,0 +1,100 @@
+package com.seaofnodes.simple.type;
+
+import com.seaofnodes.simple.SB;
+import com.seaofnodes.simple.Utils;
+import java.util.ArrayList;
+import java.util.BitSet;
+import java.util.HashSet;
+
+/**
+ * Return Program Control or Return PC or RPC
+ */
+public class TypeRPC extends Type {
+
+ // A set of CallEndNode IDs (or StopNode); commonly just one.
+ // Basically a sparse bit set
+ final HashSet<Integer> _rpcs;
+
+ // If true, invert the meaning of the bits
+ final boolean _any;
+
+ private TypeRPC(boolean any, HashSet<Integer> rpcs) {
+ super(TRPC);
+ _any = any;
+ _rpcs = rpcs;
+ }
+ private static TypeRPC make(boolean any, HashSet<Integer> rpcs) {
+ return new TypeRPC(any,rpcs).intern();
+ }
+
+ public static TypeRPC constant(int cend) {
+ HashSet<Integer> rpcs = new HashSet<>();
+ rpcs.add(cend);
+ return make(false,rpcs);
+ }
+
+ public static final TypeRPC BOT = make(true,new HashSet<>());
+ private static final TypeRPC TEST2 = constant(2);
+ private static final TypeRPC TEST3 = constant(2);
+
+ public static void gather(ArrayList<Type> ts) { ts.add(BOT); ts.add(TEST2); ts.add(TEST3); }
+
+ @Override public String str() {
+ if( _rpcs.isEmpty() )
+ return _any ? "$[ALL]" : "$[]";
+ if( _rpcs.size()==1 )
+ for( Integer rpc : _rpcs )
+ return _any ? "$[-"+rpc+"]" : "$["+rpc+"]";
+ return "$["+(_any ? "-" : "")+_rpcs+"]";
+ }
+
+ @Override public boolean isConstant() {
+ return !_any && _rpcs.size()==1;
+ }
+
+ @Override
+ public TypeRPC xmeet(Type other) {
+ TypeRPC rpc = (TypeRPC)other;
+ // If the two sets are equal, the _any must be unequal (invariant),
+ // so they cancel and all bits are set.
+ if( _rpcs.equals(rpc._rpcs) )
+ return BOT;
+ // Classic union of bit sets (which might be infinite).
+ HashSet<Integer> lhs = _rpcs, rhs = rpc._rpcs;
+ // Smaller on left
+ if( lhs.size() > rhs.size() ) { lhs = rpc._rpcs; rhs = _rpcs; }
+
+ HashSet<Integer> rpcs = new HashSet<>();
+ boolean any = true;
+ // If both sets are infinite, intersect.
+ if( _any && rpc._any ) {
+ for( Integer i : lhs ) if( rhs.contains(i) ) rpcs.add(i);
+
+ } else if( !_any && !rpc._any ) {
+ // if neither set is infinite, union.
+ rpcs.addAll( lhs );
+ rpcs.addAll( rhs );
+ any = false;
+ } else {
+ // If one is infinite, subtract the other from it.
+ HashSet<Integer> sub = _any ? rpc._rpcs : _rpcs;
+ HashSet<Integer> inf = _any ? _rpcs : rpc._rpcs;
+ for( Integer i : inf )
+ if( inf.contains(i) && !sub.contains(i) )
+ rpcs.add(i);
+ }
+ return make(any,rpcs);
+ }
+
+ @Override
+ public Type dual() { return make(!_any,_rpcs); }
+
+ @Override
+ int hash() { return _rpcs.hashCode() ^ (_any ? -1 : 0) ; }
+ @Override
+ public boolean eq( Type t ) {
+ TypeRPC rpc = (TypeRPC)t; // Contract
+ return _any==rpc._any && _rpcs.equals(rpc._rpcs);
+ }
+
+}
diff --git a/src/main/java/com/seaofnodes/simple/type/TypeStruct.java b/src/main/java/com/seaofnodes/simple/type/TypeStruct.java
index 97664e3c..fff6a7db 100644
--- a/src/main/java/com/seaofnodes/simple/type/TypeStruct.java
+++ b/src/main/java/com/seaofnodes/simple/type/TypeStruct.java
@@ -1,5 +1,6 @@
package com.seaofnodes.simple.type;
+import com.seaofnodes.simple.SB;
import com.seaofnodes.simple.Utils;
import java.util.ArrayList;
@@ -48,7 +49,7 @@ public class TypeStruct extends Type {
// Array
public static TypeStruct makeAry(TypeInteger len, int lenAlias, Type body, int bodyAlias) {
- assert !(body instanceof TypeMemPtr tmp && !tmp._nil);
+ assert body instanceof TypeInteger || body instanceof TypeFloat || (body instanceof TypeNil tn && tn.nullable());
return make("[" + body.str() + "]",
Field.make("#" ,len , lenAlias,true ),
Field.make("[]",body,bodyAlias,false));
@@ -57,10 +58,10 @@ public class TypeStruct extends Type {
// A pair of self-cyclic types
private static final TypeStruct S1F = makeFRef("S1");
private static final TypeStruct S2F = makeFRef("S2");
- public static final TypeStruct S1 = make("S1", Field.make("a", TypeInteger.BOT, -1, false), Field.make("s2",TypeMemPtr.make(S2F,false),-2, false) );
- private static final TypeStruct S2 = make("S2", Field.make("b", TypeFloat .BOT, -3, false), Field.make("s1",TypeMemPtr.make(S1F,false),-4, false) );
+ public static final TypeStruct S1 = make("S1", Field.make("a", TypeInteger.BOT, -1, false), Field.make("s2",TypeMemPtr.make((byte)2,S2F),-2, false) );
+ private static final TypeStruct S2 = make("S2", Field.make("b", TypeFloat .F64, -3, false), Field.make("s1",TypeMemPtr.make((byte)2,S1F),-4, false) );
- private static final TypeStruct ARY = makeAry(TypeInteger.BOT,-1,TypeFloat.BOT,-2);
+ private static final TypeStruct ARY = makeAry(TypeInteger.BOT,-1,TypeInteger.BOT,-2);
public static void gather(ArrayList<Type> ts) { ts.add(TEST); ts.add(BOT); ts.add(S1); ts.add(S2); ts.add(ARY); }
@@ -142,22 +143,6 @@ public class TypeStruct extends Type {
return false;
return true;
}
- @Override public TypeStruct lub() {
- if( _lub() ) return this;
- // Need to glb each field
- Field[] flds = new Field[_fields.length];
- for( int i=0; i<_fields.length; i++ )
- flds[i] = _fields[i].lub();
- return make(_name,flds);
- }
- private boolean _lub() {
- if( _fields!=null )
- for( Field f : _fields )
- if( f.lub() != f )
- return false;
- return true;
- }
-
// Is forward-reference
@Override public boolean isFRef() { return _fields==null; }
@@ -195,15 +180,20 @@ public class TypeStruct extends Type {
}
@Override
- public StringBuilder print(StringBuilder sb) {
- if( this==BOT ) return sb.append("StructBot");
- if( this==TOP ) return sb.append("StructTop");
- sb.append(_name);
+ public SB print(SB sb) {
+ if( this==BOT ) return sb.p("StructBot");
+ if( this==TOP ) return sb.p("StructTop");
+ sb.p(_name);
if( _fields == null ) return sb; // Forward reference struct, just print the name
- sb.append(" {");
+ sb.p(" {");
for( Field f : _fields )
- f._type.print(sb).append(f._final ? " " : " !").append(f._fname).append("; ");
- return sb.append("}");
+ f._type.print(sb).p(f._final ? " " : " !").p(f._fname).p("; ");
+ return sb.p("}");
+ }
+ @Override public SB gprint( SB sb ) {
+ if( this==BOT ) return sb.p("StructBot");
+ if( this==TOP ) return sb.p("StructTop");
+ return sb.p(_name);
}
@Override public String str() {
diff --git a/src/main/java/com/seaofnodes/simple/type/TypeTuple.java b/src/main/java/com/seaofnodes/simple/type/TypeTuple.java
index a34c64db..6d3a2b69 100644
--- a/src/main/java/com/seaofnodes/simple/type/TypeTuple.java
+++ b/src/main/java/com/seaofnodes/simple/type/TypeTuple.java
@@ -1,5 +1,6 @@
package com.seaofnodes.simple.type;
+import com.seaofnodes.simple.SB;
import java.util.ArrayList;
public class TypeTuple extends Type {
@@ -9,22 +10,37 @@ public class TypeTuple extends Type {
private TypeTuple(Type[] types) { super(TTUPLE); _types = types; }
public static TypeTuple make(Type... types) { return new TypeTuple(types).intern(); }
- private static final TypeTuple TEST = make(TypeInteger.BOT,TypeMemPtr.TEST);
- public static final TypeTuple START = make(Type.CONTROL,TypeMem.TOP,TypeInteger.BOT);
- public static void gather(ArrayList<Type> ts) { ts.add(TEST); ts.add(START); }
+ public static final TypeTuple BOT = new TypeTuple(new Type[0]).intern();
+ public static final TypeTuple TOP = new TypeTuple(null).intern();
+
+ public static final TypeTuple TEST = make(TypeInteger.BOT,TypeMemPtr.TEST);
+ public static final TypeTuple START= make(Type.CONTROL,TypeMem.TOP,TypeInteger.BOT);
+ public static final TypeTuple MAIN = make(TypeInteger.BOT);
+ public static final TypeTuple RET = make(Type.CONTROL,TypeMem.BOT,Type.BOTTOM);
+
+ public static final TypeTuple IF_BOTH = make(new Type[]{Type. CONTROL,Type. CONTROL});
+ public static final TypeTuple IF_NEITHER = make(new Type[]{Type.XCONTROL,Type.XCONTROL});
+ public static final TypeTuple IF_TRUE = make(new Type[]{Type. CONTROL,Type.XCONTROL});
+ public static final TypeTuple IF_FALSE = make(new Type[]{Type.XCONTROL,Type. CONTROL});
+
+ public static void gather(ArrayList<Type> ts) { ts.add(BOT); ts.add(TEST); ts.add(START); ts.add(MAIN); ts.add(IF_TRUE); }
@Override
Type xmeet(Type other) {
TypeTuple tt = (TypeTuple)other; // contract from xmeet
+ if( this==TOP ) return other;
+ if( tt ==TOP ) return this ;
if( _types.length != tt._types.length )
- return BOTTOM;
+ return BOT;
Type[] ts = new Type[_types.length];
for( int i=0; i<_types.length; i++ )
ts[i] = _types[i].meet(tt._types[i]);
return make(ts);
}
- @Override public Type dual() {
+ @Override public TypeTuple dual() {
+ if( this==TOP ) return BOT;
+ if( this==BOT ) return TOP;
Type[] ts = new Type[_types.length];
for( int i=0; i<_types.length; i++ )
ts[i] = _types[i].dual();
@@ -39,51 +55,37 @@ public class TypeTuple extends Type {
return make(ts);
}
- @Override public StringBuilder print(StringBuilder sb) {
- sb.append("[ ");
- for( Type t : _types )
- t.print(sb).append(", ");
- sb.setLength(sb.length()-2);
- sb.append("]");
- return sb;
- }
+ @Override public String str() { return print(new SB()).toString(); }
- @Override public String str() {
- StringBuilder sb = new StringBuilder();
- sb.append("[ ");
+ @Override public SB print(SB sb) {
+ if( this==TOP ) return sb.p("[TOP]");
+ if( this==BOT ) return sb.p("[BOT]");
+ sb.p("[ ");
for( Type t : _types )
- sb.append(t.str()).append(", ");
- sb.setLength(sb.length()-2);
- return sb.append("]").toString();
+ t.print(sb).p(", ");
+ return sb.unchar(2).p("]");
}
-
- /**
- * Display Type name in a format that's good for IR printer
- */
- @Override
- public StringBuilder typeName(StringBuilder sb) {
- sb.append("[");
+ @Override public SB gprint(SB sb) {
+ if( this==TOP ) return sb.p("[TOP]");
+ if( this==BOT ) return sb.p("[BOT]");
+ sb.p("[ ");
for( Type t : _types )
- t.typeName(sb).append(",");
- sb.setLength(sb.length()-1);
- return sb.append("]");
+ t.gprint(sb).p(", ");
+ return sb.unchar(2).p("]");
}
- public static final TypeTuple IF_BOTH = make(new Type[]{Type. CONTROL,Type. CONTROL});
- public static final TypeTuple IF_NEITHER = make(new Type[]{Type.XCONTROL,Type.XCONTROL});
- public static final TypeTuple IF_TRUE = make(new Type[]{Type. CONTROL,Type.XCONTROL});
- public static final TypeTuple IF_FALSE = make(new Type[]{Type.XCONTROL,Type. CONTROL});
-
@Override
int hash() {
int sum = 0;
- for( Type type : _types ) sum ^= type.hashCode();
+ if( _types!=null ) for( Type type : _types ) sum ^= type.hashCode();
return sum;
}
@Override
boolean eq( Type t ) {
TypeTuple tt = (TypeTuple)t; // Contract
+ if( _types==null && tt._types==null ) return true;
+ if( _types==null || tt._types==null ) return false;
if( _types.length != tt._types.length ) return false;
for( int i=0; i<_types.length; i++ )
if( _types[i]!=tt._types[i] )
diff --git a/src/test/java/com/seaofnodes/simple/BrainFuckTest.java b/src/test/java/com/seaofnodes/simple/BrainFuckTest.java
index 154b74a2..37ecde1c 100644
--- a/src/test/java/com/seaofnodes/simple/BrainFuckTest.java
+++ b/src/test/java/com/seaofnodes/simple/BrainFuckTest.java
@@ -1,12 +1,8 @@
package com.seaofnodes.simple;
import com.seaofnodes.simple.evaluator.Evaluator;
-import com.seaofnodes.simple.node.StopNode;
-import org.junit.Test;
-import org.junit.Ignore;
-
import java.nio.charset.StandardCharsets;
-
+import org.junit.Test;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.fail;
@@ -21,9 +17,10 @@ public class BrainFuckTest {
encoded.append("program[").append(i).append("] = ").append(value).append(";");
}
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
encoded + """
-var d = 0;
+
+int d = 0;
u8[] !output = new u8[0];
u8[] !data = new u8[100];
@@ -41,14 +38,14 @@ for( int pc = 0; pc < program#; pc++ ) {
// Output a byte; increase the output array size
var old = output;
output = new u8[output# + 1];
- for( var i = 0; i < old#; i++ )
+ for( int i = 0; i < old#; i++ )
output[i] = old[i];
output[old#] = data[d]; // Add the extra byte on the end
} else if (command == 44) {
data[d] = 42;
} else if (command == 91) {
if (data[d] == 0) {
- for( var d = 1; d > 0; ) {
+ for( int d = 1; d > 0; ) {
command = program[++pc];
if (command == 91) d++;
if (command == 93) d--;
@@ -56,7 +53,7 @@ for( int pc = 0; pc < program#; pc++ ) {
}
} else if (command == 93) {
if (data[d]) {
- for( var d = 1; d > 0; ) {
+ for( int d = 1; d > 0; ) {
command = program[--pc];
if (command == 93) d++;
if (command == 91) d--;
@@ -66,7 +63,7 @@ for( int pc = 0; pc < program#; pc++ ) {
}
return output;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("Hello World!\n", Evaluator.evaluate(stop, 0, 10000).toString());
+ code.parse().opto().typeCheck().GCM();
+ assertEquals("Hello World!\n", Eval2.eval(code, 0, 10000));
}
}
diff --git a/src/test/java/com/seaofnodes/simple/Chapter01Test.java b/src/test/java/com/seaofnodes/simple/Chapter01Test.java
index f7524c17..934eda76 100644
--- a/src/test/java/com/seaofnodes/simple/Chapter01Test.java
+++ b/src/test/java/com/seaofnodes/simple/Chapter01Test.java
@@ -10,15 +10,10 @@ public class Chapter01Test {
@Test
public void testSimpleProgram() {
- Parser parser = new Parser("return 1;");
- StopNode stop = parser.parse();
- StartNode start = Parser.START;
- ReturnNode ret = (ReturnNode)stop.in(0);
-
- assertTrue(ret.ctrl() instanceof CProjNode);
- Node expr = ret.expr();
+ CodeGen code = new CodeGen("return 1;").parse();
+ Node expr = code.expr();
if( expr instanceof ConstantNode con ) {
- assertEquals(start,con.in(0));
+ assertEquals(code._start,con.in(0));
assertEquals(TypeInteger.constant(1), con._type);
} else {
fail();
@@ -27,10 +22,9 @@ public class Chapter01Test {
@Test
public void testZero() {
- Parser parser = new Parser("return 0;");
- parser.parse();
- StartNode start = Parser.START;
- for( Node use : start._outputs )
+ CodeGen code = new CodeGen("return 0;");
+ code.parse();
+ for( Node use : code._start._outputs )
if( use instanceof ConstantNode con && con._type instanceof TypeInteger )
assertEquals(TypeInteger.constant(0),con._type);
}
@@ -38,7 +32,7 @@ public class Chapter01Test {
@Test
public void testBad1() {
try {
- new Parser("ret").parse();
+ new CodeGen("ret;").parse();
fail();
} catch( RuntimeException e ) {
assertEquals("Undefined name 'ret'",e.getMessage());
@@ -48,7 +42,7 @@ public class Chapter01Test {
@Test
public void testBad2() {
try {
- new Parser("return 0123;").parse();
+ new CodeGen("return 0123;").parse();
fail();
} catch( RuntimeException e ) {
assertEquals("Syntax error: integer values cannot start with '0'",e.getMessage());
@@ -58,13 +52,13 @@ public class Chapter01Test {
@Test
public void testNotBad3() {
// this test used to fail in chapter 1
- assertEquals("return 12;", new Parser("return - -12;").parse().print());
+ assertEquals("return 12;", new CodeGen("return - -12;").parse()._stop.print());
}
@Test
public void testBad4() {
try {
- new Parser("return 100").parse();
+ new CodeGen("return 100").parse();
fail();
} catch( RuntimeException e ) {
assertEquals("Syntax error, expected ;: ",e.getMessage());
@@ -74,13 +68,13 @@ public class Chapter01Test {
@Test
public void testNotBad5() {
// this test used to fail in chapter 1
- assertEquals("return -100;", new Parser("return -100;").parse().print());
+ assertEquals("return -100;", new CodeGen("return -100;").parse()._stop.print());
}
@Test
public void testBad6() {
try {
- new Parser("return100").parse();
+ new CodeGen("return100;").parse();
fail();
} catch( RuntimeException e ) {
assertEquals("Undefined name 'return100'",e.getMessage());
@@ -90,10 +84,10 @@ public class Chapter01Test {
@Test
public void testBad7() {
try {
- new Parser("return 1;}").parse();
+ new CodeGen("return 1;}").parse();
fail();
} catch( RuntimeException e ) {
- assertEquals("Syntax error, unexpected }",e.getMessage());
+ assertEquals("Syntax error, unexpected: }",e.getMessage());
}
}
diff --git a/src/test/java/com/seaofnodes/simple/Chapter02Test.java b/src/test/java/com/seaofnodes/simple/Chapter02Test.java
index a6075b75..8b7a2f66 100644
--- a/src/test/java/com/seaofnodes/simple/Chapter02Test.java
+++ b/src/test/java/com/seaofnodes/simple/Chapter02Test.java
@@ -10,51 +10,51 @@ public class Chapter02Test {
@Test
public void testParseGrammar() {
- Parser parser = new Parser("return 1+2*3+-5;");
- StopNode ret = parser.parse();
- assertEquals("return 2;", ret.print());
+ CodeGen code = new CodeGen("return 1+2*3+-5;");
+ code.parse();
+ assertEquals("return 2;", code.print());
}
@Test
public void testAddPeephole() {
- Parser parser = new Parser("return 1+2;");
- StopNode ret = parser.parse();
- assertEquals("return 3;", ret.print());
+ CodeGen code = new CodeGen("return 1+2;");
+ code.parse();
+ assertEquals("return 3;", code.print());
}
@Test
public void testSubPeephole() {
- Parser parser = new Parser("return 1-2;");
- StopNode ret = parser.parse();
- assertEquals("return -1;", ret.print());
+ CodeGen code = new CodeGen("return 1-2;");
+ code.parse();
+ assertEquals("return -1;", code.print());
}
@Test
public void testMulPeephole() {
- Parser parser = new Parser("return 2*3;");
- StopNode ret = parser.parse();
- assertEquals("return 6;", ret.print());
+ CodeGen code = new CodeGen("return 2*3;");
+ code.parse();
+ assertEquals("return 6;", code.print());
}
@Test
public void testDivPeephole() {
- Parser parser = new Parser("return 6/3;");
- StopNode ret = parser.parse();
- assertEquals("return 2;", ret.print());
+ CodeGen code = new CodeGen("return 6/3;");
+ code.parse();
+ assertEquals("return 2;", code.print());
}
@Test
public void testMinusPeephole() {
- Parser parser = new Parser("return 6/-3;");
- StopNode ret = parser.parse();
- assertEquals("return -2;", ret.print());
+ CodeGen code = new CodeGen("return 6/-3;");
+ code.parse();
+ assertEquals("return -2;", code.print());
}
@Test
public void testExample() {
- Parser parser = new Parser("return 1+2*3+-5;");
- StopNode ret = parser.parse();
- assertEquals("return 2;", ret.print());
+ CodeGen code = new CodeGen("return 1+2*3+-5;");
+ code.parse();
+ assertEquals("return 2;", code.print());
}
}
diff --git a/src/test/java/com/seaofnodes/simple/Chapter03Test.java b/src/test/java/com/seaofnodes/simple/Chapter03Test.java
index f06e5dcf..409e23ed 100644
--- a/src/test/java/com/seaofnodes/simple/Chapter03Test.java
+++ b/src/test/java/com/seaofnodes/simple/Chapter03Test.java
@@ -1,7 +1,5 @@
package com.seaofnodes.simple;
-import com.seaofnodes.simple.node.*;
-import com.seaofnodes.simple.type.TypeInteger;
import org.junit.Test;
import static org.junit.Assert.*;
@@ -10,36 +8,35 @@ public class Chapter03Test {
@Test
public void testVarDecl() {
- Parser parser = new Parser("int a=1; return a;");
- StopNode ret = parser.parse();
- assertEquals("return 1;", ret.print());
+ CodeGen code = new CodeGen("int a=1; return a;");
+ code.parse(); assertEquals("return 1;", code.print());
}
@Test
public void testVarAdd() {
- Parser parser = new Parser("int a=1; int b=2; return a+b;");
- StopNode ret = parser.parse();
- assertEquals("return 3;", ret.print());
+ CodeGen code = new CodeGen("int a=1; int b=2; return a+b;");
+ code.parse();
+ assertEquals("return 3;", code.print());
}
@Test
public void testVarScope() {
- Parser parser = new Parser("int a=1; int b=2; int c=0; { int b=3; c=a+b; } return c;");
- StopNode ret = parser.parse();
- assertEquals("return 4;", ret.print());
+ CodeGen code = new CodeGen("int a=1; int b=2; int c=0; { int b=3; c=a+b; } return c;");
+ code.parse();
+ assertEquals("return 4;", code.print());
}
@Test
public void testVarDist() {
- Parser parser = new Parser("int x0=1; int y0=2; int x1=3; int y1=4; return (x0-x1)*(x0-x1) + (y0-y1)*(y0-y1); ");
- StopNode ret = parser.parse();
- assertEquals("return 8;", ret.print());
+ CodeGen code = new CodeGen("int x0=1; int y0=2; int x1=3; int y1=4; return (x0-x1)*(x0-x1) + (y0-y1)*(y0-y1); ");
+ code.parse();
+ assertEquals("return 8;", code.print());
}
@Test
public void testSelfAssign() {
try {
- new Parser("int a=a; return a;").parse();
+ new CodeGen("int a=a; return a;").parse();
fail();
} catch( RuntimeException e ) {
assertEquals("Undefined name 'a'",e.getMessage());
@@ -59,7 +56,7 @@ public class Chapter03Test {
@Test
public void testBad1() {
try {
- new Parser("int a=1; int b=2; int !c=0; { int b=3; c=a+b;").parse();
+ new CodeGen("int a=1; int b=2; int !c=0; { int b=3; c=a+b;").parse();
fail();
} catch( RuntimeException e ) {
assertEquals("Syntax error, expected }: ",e.getMessage());
diff --git a/src/test/java/com/seaofnodes/simple/Chapter04Test.java b/src/test/java/com/seaofnodes/simple/Chapter04Test.java
index 36727a8f..d2260e1f 100644
--- a/src/test/java/com/seaofnodes/simple/Chapter04Test.java
+++ b/src/test/java/com/seaofnodes/simple/Chapter04Test.java
@@ -3,6 +3,7 @@ package com.seaofnodes.simple;
import com.seaofnodes.simple.node.*;
import com.seaofnodes.simple.type.TypeInteger;
import org.junit.Test;
+import org.junit.Ignore;
import static org.junit.Assert.*;
@@ -10,133 +11,130 @@ public class Chapter04Test {
@Test
public void testPeephole() {
- Parser parser = new Parser("return 1+arg+2; ");
- StopNode ret = parser.parse();
- assertEquals("return (arg+3);", ret.print());
+ CodeGen code = new CodeGen("return 1+arg+2; ");
+ code.parse();
+ assertEquals("return (arg+3);", code.print());
}
@Test
public void testPeephole2() {
- Parser parser = new Parser("return (1+arg)+2;");
- StopNode ret = parser.parse();
- assertEquals("return (arg+3);", ret.print());
+ CodeGen code = new CodeGen("return (1+arg)+2;");
+ code.parse();
+ assertEquals("return (arg+3);", code.print());
}
@Test
public void testAdd0() {
- Parser parser = new Parser("return 0+arg;");
- StopNode ret = parser.parse();
- assertEquals("return arg;", ret.print());
+ CodeGen code = new CodeGen("return 0+arg;");
+ code.parse();
+ assertEquals("return arg;", code.print());
}
@Test
public void testAddAddMul() {
- Parser parser = new Parser("return arg+0+arg;");
- StopNode ret = parser.parse();
- assertEquals("return (arg*2);", ret.print());
+ CodeGen code = new CodeGen("return arg+0+arg;");
+ code.parse();
+ assertEquals("return (arg*2);", code.print());
}
@Test
public void testPeephole3() {
- Parser parser = new Parser("return 1+arg+2+arg+3; ");
- StopNode ret = parser.parse();
- assertEquals("return ((arg*2)+6);", ret.print());
+ CodeGen code = new CodeGen("return 1+arg+2+arg+3; ");
+ code.parse();
+ assertEquals("return ((arg*2)+6);", code.print());
}
@Test
public void testMul1() {
- Parser parser = new Parser("return 1*arg;");
- StopNode ret = parser.parse();
- assertEquals("return arg;", ret.print());
+ CodeGen code = new CodeGen("return 1*arg;");
+ code.parse();
+ assertEquals("return arg;", code.print());
}
@Test
public void testSub0() {
- Parser parser = new Parser("return arg-0;");
- StopNode ret = parser.parse();
- assertEquals("return arg;", ret.print());
+ CodeGen code = new CodeGen("return arg-0;");
+ code.parse();
+ assertEquals("return arg;", code.print());
}
@Test
public void test0Sub() {
- Parser parser = new Parser("return 0-arg;");
- StopNode ret = parser.parse();
- assertEquals("return (-arg);", ret.print());
+ CodeGen code = new CodeGen("return 0-arg;");
+ code.parse();
+ assertEquals("return (-arg);", code.print());
}
@Test
public void testSubNeg() {
- Parser parser = new Parser("return 3--arg;");
- StopNode ret = parser.parse();
- assertEquals("return (arg+3);", ret.print());
+ CodeGen code = new CodeGen("return 3--arg;");
+ code.parse();
+ assertEquals("return (arg+3);", code.print());
}
@Test
public void testNegSub() {
- Parser parser = new Parser("return -arg-3;");
- StopNode ret = parser.parse();
- assertEquals("return (-(arg+3));", ret.print());
+ CodeGen code = new CodeGen("return -arg-3;");
+ code.parse();
+ assertEquals("return (-(arg+3));", code.print());
}
@Test
public void testVarArg() {
- Parser parser = new Parser("return arg; ");
- StopNode stop = parser.parse();
- ReturnNode ret = stop.ret();
- assertTrue(ret.in(0) instanceof CProjNode);
- assertTrue(ret.in(1) instanceof ProjNode);
- assertEquals(1, ((ProjNode)ret.in(1))._idx);
- assertTrue(ret.in(2) instanceof ProjNode);
- assertEquals(2, ((ProjNode)ret.in(2))._idx);
+ CodeGen code = new CodeGen("return arg; ");
+ code.parse();
+ assertTrue(code.ctrl() instanceof FunNode);
+ assertTrue(code.expr() instanceof ParmNode);
}
- @Test
+ // Adding functions means `main` does not constant fold the incoming arg value
+ @Ignore @Test
public void testConstantArg() {
- Parser parser = new Parser("return arg; ", TypeInteger.constant(2));
- StopNode ret = parser.parse();
- assertEquals("return 2;", ret.print());
+ CodeGen code = new CodeGen("return arg; ", TypeInteger.constant(2));
+ code.parse();
+ assertEquals("return 2;", code.expr().in(1).toString());
}
@Test
public void testCompEq() {
- Parser parser = new Parser("return 3==3; ");
- StopNode ret = parser.parse();
- assertEquals("return 1;", ret.print());
+ CodeGen code = new CodeGen("return 3==3; ");
+ code.parse();
+ assertEquals("return 1;", code.print());
}
@Test
public void testCompEq2() {
- Parser parser = new Parser("return 3==4; ");
- StopNode ret = parser.parse();
- assertEquals("return 0;", ret.print());
+ CodeGen code = new CodeGen("return 3==4; ");
+ code.parse();
+ assertEquals("return 0;", code.print());
}
@Test
public void testCompNEq() {
- Parser parser = new Parser("return 3!=3; ");
- StopNode ret = parser.parse();
- assertEquals("return 0;", ret.print());
+ CodeGen code = new CodeGen("return 3!=3; ");
+ code.parse();
+ assertEquals("return 0;", code.print());
}
@Test
public void testCompNEq2() {
- Parser parser = new Parser("return 3!=4; ");
- StopNode ret = parser.parse();
- assertEquals("return 1;", ret.print());
+ CodeGen code = new CodeGen("return 3!=4; ");
+ code.parse();
+ assertEquals("return 1;", code.print());
}
@Test
public void testBug1() {
- Parser parser = new Parser("int a=arg+1; int !b=a; b=1; return a+2; ");
- StopNode ret = parser.parse();
- assertEquals("return (arg+3);", ret.print());
+ CodeGen code = new CodeGen("int a=arg+1; int !b=a; b=1; return a+2; ");
+ code.parse();
+ assertEquals("return (arg+3);", code.print());
}
@Test
public void testBug2() {
- Parser parser = new Parser("int !a=arg+1; a=a; return a; ");
- StopNode ret = parser.parse();
- assertEquals("return (arg+1);", ret.print());
+ CodeGen code = new CodeGen("int !a=arg+1; a=a; return a; ");
+ code.parse();
+ assertEquals("return (arg+1);", code.print());
}
@Test
@@ -151,9 +149,9 @@ public class Chapter04Test {
@Test
public void testBug4() {
- Parser parser = new Parser("return -arg;");
- StopNode ret = parser.parse();
- assertEquals("return (-arg);", ret.print());
+ CodeGen code = new CodeGen("return -arg;");
+ code.parse();
+ assertEquals("return (-arg);", code.print());
}
@Test
diff --git a/src/test/java/com/seaofnodes/simple/Chapter05Test.java b/src/test/java/com/seaofnodes/simple/Chapter05Test.java
index 7ea75f49..ff60c695 100644
--- a/src/test/java/com/seaofnodes/simple/Chapter05Test.java
+++ b/src/test/java/com/seaofnodes/simple/Chapter05Test.java
@@ -1,7 +1,6 @@
package com.seaofnodes.simple;
import com.seaofnodes.simple.node.*;
-import com.seaofnodes.simple.type.TypeInteger;
import org.junit.Test;
import static org.junit.Assert.*;
@@ -10,7 +9,7 @@ public class Chapter05Test {
@Test
public void testIfStmt() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int a = 1;
if (arg == 1)
@@ -20,13 +19,13 @@ else {
}
return a;
""");
- StopNode ret = parser.parse().iterate();
- assertEquals("return Phi(Region,(arg+2),(arg-3));", ret.toString());
+ code.parse().opto();
+ assertEquals("return Phi(Region,(arg+2),(arg-3));", code.print());
}
@Test
public void testTest() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int c = 3;
int b = 2;
@@ -34,27 +33,28 @@ if (arg == 1) {
b = 3;
c = 4;
}
-return c;""", TypeInteger.BOT);
- StopNode ret = parser.parse().iterate();
- assertEquals("return Phi(Region,4,3);", ret.toString());
+return c;
+""");
+ code.parse().opto();
+ assertEquals("return Phi(Region,4,3);", code.print());
}
@Test
public void testReturn2() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
if( arg==1 )
return 3;
else
return 4;
-""", TypeInteger.BOT);
- StopNode stop = parser.parse();
- assertEquals("Stop[ return 3; return 4; ]", stop.toString());
+""");
+ code.parse();
+ assertEquals("return Phi(Region,3,4);", code.print());
}
@Test
public void testIfMergeB() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int a=arg+1;
int b=0;
@@ -63,13 +63,13 @@ if( arg==1 )
else
b=a+1;
return a+b;""");
- StopNode ret = parser.parse().iterate();
- assertEquals("return ((arg*2)+Phi(Region,2,3));", ret.toString());
+ code.parse().opto();
+ assertEquals("return ((arg*2)+Phi(Region,2,3));", code.print());
}
@Test
public void testIfMerge2() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int a=arg+1;
int b=arg+2;
@@ -78,13 +78,13 @@ if( arg==1 )
else
a=b+1;
return a+b;""");
- StopNode ret = parser.parse().iterate();
- assertEquals("return ((Phi(Region,(arg*2),arg)+arg)+Phi(Region,4,5));", ret.toString());
+ code.parse().opto();
+ assertEquals("return ((Phi(Region,(arg*2),arg)+arg)+Phi(Region,4,5));", code.print());
}
@Test
public void testMerge3() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int a=1;
if( arg==1 )
@@ -97,14 +97,14 @@ else if( arg==3 )
else
a=5;
return a;
-""", TypeInteger.BOT);
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Region,Phi(Region,2,3),Phi(Region,4,5));", stop.toString());
+""");
+ code.parse().opto();
+ assertEquals("return Phi(Region,Phi(Region,2,3),Phi(Region,4,5));", code.print());
}
@Test
public void testMerge4() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int a=0;
int b=0;
@@ -113,28 +113,29 @@ if( arg )
if( arg==0 )
b=2;
return arg+a+b;
-""", TypeInteger.BOT);
- StopNode stop = parser.parse();
- assertEquals("return ((arg+Phi(Region,1,0))+Phi(Region,2,0));", stop.toString());
+""");
+ code.parse().opto();
+ assertEquals("return ((arg+Phi(Region,1,0))+Phi(Region,2,0));", code.print());
}
@Test
public void testMerge5() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int a=arg==2;
if( arg==1 )
{
a=arg==3;
}
-return a;""");
- StopNode ret = parser.parse().iterate();
- assertEquals("return (arg==Phi(Region,3,2));", ret.toString());
+return a;
+""");
+ code.parse().opto();
+ assertEquals("return (arg==Phi(Region,3,2));", code.print());
}
@Test
public void testMergeSameCon() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int a=arg;
if( arg==1 )
@@ -143,23 +144,23 @@ else
a=3;
return a;
""");
- StopNode ret = parser.parse();
- assertEquals("return 3;", ret.toString());
+ code.parse().opto();
+ assertEquals("return 3;", code.print());
}
@Test
public void testTrue() {
StopNode stop = new Parser("return true;").parse();
- assertEquals("return 1;",stop.toString());
+ assertEquals("return 1;",stop.ret().print());
}
@Test
public void testHalfDef() {
try {
- new Parser("if( arg==1 ) int b=2; return b;").parse();
+ new CodeGen("if( arg==1 ) int b=2; return b;").parse();
fail();
} catch( RuntimeException e ) {
- assertEquals("Cannot define a new name on one arm of an if",e.getMessage());
+ assertEquals("Cannot define a 'b' on one arm of an if",e.getMessage());
}
}
@@ -176,10 +177,10 @@ return a;
@Test
public void testRegress1() {
try {
- new Parser("if(arg==2) int a=1; else int b=2; return a;").parse();
+ new CodeGen("if(arg==2) int a=1; else int b=2; return a;").parse();
fail();
} catch( RuntimeException e ) {
- assertEquals("Cannot define a new name on one arm of an if",e.getMessage());
+ assertEquals("Cannot define a 'a' on one arm of an if",e.getMessage());
}
}
@@ -217,7 +218,7 @@ return a;
@Test
public void testKeyword3() {
try {
- new Parser("int a=1; ififif(arg)inta=2;return a;").parse();
+ new CodeGen("int a=1; ififif(arg);a=2;return a;").parse();
fail();
} catch( RuntimeException e ) {
assertEquals("Undefined name 'ififif'",e.getMessage());
diff --git a/src/test/java/com/seaofnodes/simple/Chapter06Test.java b/src/test/java/com/seaofnodes/simple/Chapter06Test.java
index 50c0580d..2107cdb0 100644
--- a/src/test/java/com/seaofnodes/simple/Chapter06Test.java
+++ b/src/test/java/com/seaofnodes/simple/Chapter06Test.java
@@ -10,32 +10,31 @@ public class Chapter06Test {
@Test
public void testPeepholeReturn() {
- Parser parser = new Parser(
-"""
+ CodeGen code = new CodeGen("""
if( true ) return 2;
return 1;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 2;", stop.toString());
- assertTrue(stop.ret().ctrl() instanceof CProjNode);
+ code.parse().opto();
+ assertEquals("return 2;", code.print());
+ assertTrue(code.ctrl() instanceof FunNode);
}
@Test
public void testPeepholeRotate() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int a = 1;
if (arg)
a = 2;
return (arg < a) < 3; // Because (arg < a) is a bool/uint1/[0-1], its always less than 3
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 1;", stop.toString());
+ code.parse().opto();
+ assertEquals("return 1;", code.print());
}
@Test
public void testPeepholeCFG() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int a=1;
if( true )
@@ -44,14 +43,14 @@ else
a=3;
return a;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 2;", stop.toString());
- assertTrue(stop.ret().ctrl() instanceof CProjNode);
+ code.parse().opto();
+ assertEquals("return 2;", code.print());
+ assertTrue(code.ctrl() instanceof FunNode);
}
@Test
public void testIfIf() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int a=1;
if( arg!=1 )
@@ -63,14 +62,15 @@ if( a==2 )
b=42;
else
b=5;
-return b;""", TypeInteger.BOT);
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Region,42,5);", stop.toString());
+return b;
+""");
+ code.parse().opto();
+ assertEquals("return Phi(Region,42,5);", code.print());
}
@Test
public void testIfArgIf() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int a=1;
if( 1==1 )
@@ -82,15 +82,16 @@ if( arg==2 )
b=a;
else
b=5;
-return b;""", TypeInteger.BOT);
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Region,2,5);", stop.toString());
+return b;""");
+ code.parse().opto();
+ assertEquals("return Phi(Region,2,5);", code.print());
}
@Test
public void testMerge3With2() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
+arg=2;
int a=1;
if( arg==1 )
if( arg==2 )
@@ -103,14 +104,15 @@ else
a=5;
return a;
""", TypeInteger.constant(2));
- StopNode stop = parser.parse();
- assertEquals("return 5;", stop.toString());
+ code.parse().opto();
+ assertEquals("return 5;", code.print());
}
@Test
public void testMerge3With1() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
+arg=1;
int a=1;
if( arg==1 )
if( arg==2 )
@@ -123,13 +125,13 @@ else
a=5;
return a;
""", TypeInteger.constant(1));
- StopNode stop = parser.parse().iterate();
- assertEquals("return 3;", stop.toString());
+ code.parse().opto();
+ assertEquals("return 3;", code.print());
}
@Test
public void testMerge3Peephole() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int a=1;
if( arg==1 )
@@ -142,15 +144,16 @@ else if( arg==3 )
else
a=5;
return a;
-""", TypeInteger.BOT);
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Region,3,Phi(Region,4,5));", stop.toString());
+""");
+ code.parse().opto();
+ assertEquals("return Phi(Region,3,Phi(Region,4,5));", code.print());
}
@Test
public void testMerge3Peephole1() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
+arg=1;
int a=1;
if( arg==1 )
if( 1==2 )
@@ -163,14 +166,15 @@ else
a=5;
return a;
""", TypeInteger.constant(1));
- StopNode stop = parser.parse().iterate();
- assertEquals("return 3;", stop.toString());
+ code.parse().opto();
+ assertEquals("return 3;", code.print());
}
@Test
public void testMerge3Peephole3() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
+arg=3;
int a=1;
if( arg==1 )
if( 1==2 )
@@ -183,13 +187,13 @@ else
a=5;
return a;
""", TypeInteger.constant(3));
- StopNode stop = parser.parse().iterate();
- assertEquals("return 4;", stop.toString());
+ code.parse().opto();
+ assertEquals("return 4;", code.print());
}
@Test
public void testDemo1NonConst() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
int a = 0;
int b = 1;
if( arg ) {
@@ -199,14 +203,15 @@ if( arg ) {
}
return a+b;
""");
- StopNode ret = parser.parse().iterate();
- assertEquals("return Phi(Region,4,1);", ret.toString());
+ code.parse().opto();
+ assertEquals("return Phi(Region,4,1);", code.print());
}
@Test
public void testDemo1True() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
+arg=1;
int a = 0;
int b = 1;
if( arg ) {
@@ -216,13 +221,14 @@ if( arg ) {
}
return a+b;
""", TypeInteger.constant(1));
- StopNode ret = parser.parse().iterate();
- assertEquals("return 4;", ret.toString());
+ code.parse().opto();
+ assertEquals("return 4;", code.print());
}
@Test
public void testDemo1False() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
+arg=0;
int a = 0;
int b = 1;
if( arg ) {
@@ -232,13 +238,13 @@ if( arg ) {
}
return a+b;
""", TypeInteger.constant(0));
- StopNode ret = parser.parse().iterate();
- assertEquals("return 1;", ret.toString());
+ code.parse().opto();
+ assertEquals("return 1;", code.print());
}
@Test
public void testDemo2NonConst() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
int a = 0;
int b = 1;
int c = 0;
@@ -250,14 +256,15 @@ if( arg ) {
}
return a+b+c;
""");
- StopNode ret = parser.parse().iterate();
- assertEquals("return (Phi(Region,Phi(Region,2,3),0)+Phi(Region,3,1));", ret.toString());
+ code.parse().opto();
+ assertEquals("return (Phi(Region,Phi(Region,2,3),0)+Phi(Region,3,1));", code.print());
}
@Test
public void testDemo2True() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
+arg=1;
int a = 0;
int b = 1;
int c = 0;
@@ -269,13 +276,14 @@ if( arg ) {
}
return a+b+c;
""", TypeInteger.constant(1));
- StopNode ret = parser.parse().iterate();
- assertEquals("return 6;", ret.toString());
+ code.parse().opto();
+ assertEquals("return 6;", code.print());
}
@Test
public void testDemo2arg2() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
+arg=2;
int a = 0;
int b = 1;
int c = 0;
@@ -287,8 +295,8 @@ if( arg ) {
}
return a+b+c;
""", TypeInteger.constant(2));
- StopNode ret = parser.parse().iterate();
- assertEquals("return 5;", ret.toString());
+ code.parse().opto();
+ assertEquals("return 5;", code.print());
}
}
diff --git a/src/test/java/com/seaofnodes/simple/Chapter07Test.java b/src/test/java/com/seaofnodes/simple/Chapter07Test.java
index ad3622c9..6d6a3ce7 100644
--- a/src/test/java/com/seaofnodes/simple/Chapter07Test.java
+++ b/src/test/java/com/seaofnodes/simple/Chapter07Test.java
@@ -9,21 +9,21 @@ public class Chapter07Test {
@Test
public void testExample() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
while(arg < 10) {
arg = arg + 1;
}
return arg;
""");
- StopNode stop = parser.parse();
- assertEquals("return Phi(Loop,arg,(Phi_arg+1));", stop.toString());
- assertTrue(stop.ret().ctrl() instanceof CProjNode);
+ code.parse();
+ assertEquals("return Phi(Loop,arg,(Phi_arg+1));", code.print());
+ assertTrue(code.ctrl() instanceof CProjNode);
}
@Test
public void testRegression() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int a = 1;
if(arg){}else{
@@ -33,13 +33,13 @@ if(arg){}else{
}
return a;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Region,1,Phi(Loop,1,(Phi_a+1)));", stop.toString());
+ code.parse().opto();
+ assertEquals("return Phi(Region,1,Phi(Loop,1,(Phi_a+1)));", code.print());
}
@Test
public void testWhileNested() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int sum = 0;
int i = 0;
@@ -53,13 +53,13 @@ while(i < arg) {
}
return sum;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Loop,0,Phi(Loop,Phi_sum,(Phi_sum+Phi(Loop,0,(Phi_j+1)))));", stop.toString());
+ code.parse().opto();
+ assertEquals("return Phi(Loop,0,Phi(Loop,Phi_sum,(Phi_sum+Phi(Loop,0,(Phi_j+1)))));", code.print());
}
@Test
public void testWhileScope() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int a = 1;
int b = 2;
@@ -69,14 +69,14 @@ while(a < 10) {
}
return b;
""");
- StopNode stop = parser.parse();
- assertEquals("return Phi(Loop,2,Phi(Region,Phi_b,4));", stop.toString());
- assertTrue(stop.ret().ctrl() instanceof CProjNode);
+ code.parse();
+ assertEquals("return Phi(Loop,2,Phi(Region,Phi_b,4));", code.print());
+ assertTrue(code.ctrl() instanceof CProjNode);
}
@Test
public void testWhileNestedIfAndInc() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int a = 1;
int b = 2;
@@ -88,15 +88,15 @@ while(a < 10) {
}
return b;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Loop,2,(Phi(Region,Phi_b,4)+1));", stop.toString());
- assertTrue(stop.ret().ctrl() instanceof CProjNode);
+ code.parse().opto();
+ assertEquals("return Phi(Loop,2,(Phi(Region,Phi_b,4)+1));", code.print());
+ assertTrue(code.ctrl() instanceof CProjNode);
}
@Test
public void testWhile() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int a = 1;
while(a < 10) {
@@ -105,14 +105,14 @@ while(a < 10) {
}
return a;
""");
- StopNode stop = parser.parse();
- assertEquals("return Phi(Loop,1,(Phi_a+3));", stop.toString());
- assertTrue(stop.ret().ctrl() instanceof CProjNode);
+ code.parse();
+ assertEquals("return Phi(Loop,1,(Phi_a+3));", code.print());
+ assertTrue(code.ctrl() instanceof CProjNode);
}
@Test
public void testWhilePeep() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int a = 1;
while(a < 10) {
@@ -121,40 +121,40 @@ while(a < 10) {
}
return a;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Loop,1,(Phi_a+3));", stop.toString());
- assertTrue(stop.ret().ctrl() instanceof CProjNode);
+ code.parse().opto();
+ assertEquals("return Phi(Loop,1,(Phi_a+3));", code.print());
+ assertTrue(code.ctrl() instanceof CProjNode);
}
@Test
public void testWhile2() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int a = 1;
while(arg) a = 2;
return a;
""");
- StopNode stop = parser.parse();
- assertEquals("return Phi(Loop,1,2);", stop.toString());
- assertTrue(stop.ret().ctrl() instanceof CProjNode);
+ code.parse();
+ assertEquals("return Phi(Loop,1,2);", code.print());
+ assertTrue(code.ctrl() instanceof CProjNode);
}
@Test
public void testWhile2Peep() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int a = 1;
while(arg) a = 2;
return a;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Loop,1,2);", stop.toString());
- assertTrue(stop.ret().ctrl() instanceof CProjNode);
+ code.parse().opto();
+ assertEquals("return Phi(Loop,1,2);", code.print());
+ assertTrue(code.ctrl() instanceof CProjNode);
}
@Test
public void testWhile3() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int a = 1;
while(a < 10) {
@@ -163,14 +163,14 @@ while(a < 10) {
}
return a;
""");
- StopNode stop = parser.parse();
- assertEquals("return Phi(Loop,1,(Phi_a+3));", stop.toString());
- assertTrue(stop.ret().ctrl() instanceof CProjNode);
+ code.parse();
+ assertEquals("return Phi(Loop,1,(Phi_a+3));", code.print());
+ assertTrue(code.ctrl() instanceof CProjNode);
}
@Test
public void testWhile3Peep() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int a = 1;
while(a < 10) {
@@ -179,14 +179,14 @@ while(a < 10) {
}
return a;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Loop,1,(Phi_a+3));", stop.toString());
- assertTrue(stop.ret().ctrl() instanceof CProjNode);
+ code.parse().opto();
+ assertEquals("return Phi(Loop,1,(Phi_a+3));", code.print());
+ assertTrue(code.ctrl() instanceof CProjNode);
}
@Test
public void testWhile4() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int a = 1;
int b = 2;
@@ -196,14 +196,14 @@ while(a < 10) {
}
return a;
""");
- StopNode stop = parser.parse();
- assertEquals("return Phi(Loop,1,(Phi_a+3));", stop.toString());
- assertTrue(stop.ret().ctrl() instanceof CProjNode);
+ code.parse();
+ assertEquals("return Phi(Loop,1,(Phi_a+3));", code.print());
+ assertTrue(code.ctrl() instanceof CProjNode);
}
@Test
public void testWhile4Peep() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int a = 1;
int b = 2;
@@ -213,9 +213,9 @@ while(a < 10) {
}
return a;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Loop,1,(Phi_a+3));", stop.toString());
- assertTrue(stop.ret().ctrl() instanceof CProjNode);
+ code.parse().opto();
+ assertEquals("return Phi(Loop,1,(Phi_a+3));", code.print());
+ assertTrue(code.ctrl() instanceof CProjNode);
}
}
diff --git a/src/test/java/com/seaofnodes/simple/Chapter08Test.java b/src/test/java/com/seaofnodes/simple/Chapter08Test.java
index bb3bd674..03a2c50a 100644
--- a/src/test/java/com/seaofnodes/simple/Chapter08Test.java
+++ b/src/test/java/com/seaofnodes/simple/Chapter08Test.java
@@ -2,6 +2,7 @@ package com.seaofnodes.simple;
import com.seaofnodes.simple.evaluator.Evaluator;
import com.seaofnodes.simple.node.*;
+import com.seaofnodes.simple.type.TypeInteger;
import org.junit.Assert;
import org.junit.Test;
@@ -11,7 +12,7 @@ public class Chapter08Test {
@Test
public void testEx6() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
while(arg < 10) {
arg = arg + 1;
@@ -22,17 +23,17 @@ while(arg < 10) {
}
return arg;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Region,Phi(Region,Phi(Loop,arg,(Phi_arg+1)),Add),Add);", stop.toString());
- assertTrue(stop.ret().ctrl() instanceof RegionNode);
- Assert.assertEquals(5L, Evaluator.evaluate(stop, 1));
- Assert.assertEquals(10L, Evaluator.evaluate(stop, 6));
+ code.parse().opto();
+ assertEquals("return Phi(Region,Phi(Region,Phi(Loop,arg,(Phi_arg+1)),Add),Add);", code.print());
+ assertTrue(code.ctrl() instanceof RegionNode);
+ Assert.assertEquals( "5", Eval2.eval(code, 1));
+ Assert.assertEquals("10", Eval2.eval(code, 6));
}
@Test
public void testEx5() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int a = 1;
while(arg < 10) {
@@ -45,15 +46,15 @@ while(arg < 10) {
}
return a;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Loop,1,Phi(Region,Phi_a,(Phi_a+1)));", stop.toString());
- assertTrue(stop.ret().ctrl() instanceof CProjNode);
+ code.parse().opto();
+ assertEquals("return Phi(Loop,1,Phi(Region,Phi_a,(Phi_a+1)));", code.print());
+ assertTrue(code.ctrl() instanceof CProjNode);
}
@Test
public void testEx4() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
while(arg < 10) {
arg = arg + 1;
@@ -64,14 +65,14 @@ while(arg < 10) {
}
return arg;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Region,Phi(Loop,arg,(Phi_arg+1)),Add);", stop.toString());
- assertTrue(stop.ret().ctrl() instanceof RegionNode);
+ code.parse().opto();
+ assertEquals("return Phi(Region,Phi(Loop,arg,(Phi_arg+1)),Add);", code.print());
+ assertTrue(code.ctrl() instanceof RegionNode);
}
@Test
public void testEx3() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
while(arg < 10) {
arg = arg + 1;
@@ -80,15 +81,15 @@ while(arg < 10) {
}
return arg;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Region,Phi(Loop,arg,(Phi_arg+1)),Add);", stop.toString());
- assertTrue(stop.ret().ctrl() instanceof RegionNode);
+ code.parse().opto();
+ assertEquals("return Phi(Region,Phi(Loop,arg,(Phi_arg+1)),Add);", code.print());
+ assertTrue(code.ctrl() instanceof RegionNode);
}
@Test
public void testEx2() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
while(arg < 10) {
arg = arg + 1;
@@ -99,15 +100,15 @@ while(arg < 10) {
}
return arg;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Loop,arg,(Phi_arg+1));", stop.toString());
- assertTrue(stop.ret().ctrl() instanceof CProjNode);
+ code.parse().opto();
+ assertEquals("return Phi(Loop,arg,(Phi_arg+1));", code.print());
+ assertTrue(code.ctrl() instanceof CProjNode);
}
@Test
public void testEx1() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
while(arg < 10) {
arg = arg + 1;
@@ -116,14 +117,14 @@ while(arg < 10) {
}
return arg;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Loop,arg,(Phi_arg+1));", stop.toString());
- assertTrue(stop.ret().ctrl() instanceof CProjNode);
+ code.parse().opto();
+ assertEquals("return Phi(Loop,arg,(Phi_arg+1));", code.print());
+ assertTrue(code.ctrl() instanceof CProjNode);
}
@Test
public void testRegress1() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
while( arg < 10 ) {
int a = arg+2;
@@ -132,15 +133,15 @@ while( arg < 10 ) {
}
return arg;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return arg;", stop.toString());
+ code.parse().opto();
+ assertEquals("return arg;", code.print());
}
@Test
public void testRegress2() {
- Parser parser = new Parser("if(1) return 0; else while(arg>- -arg) arg=arg+1; return 0;");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
+ CodeGen code = new CodeGen("if(1) return 0; else while(arg>- -arg) arg=arg+1; return 0;");
+ code.parse().opto();
+ assertEquals("return 0;", code.print());
}
@Test
@@ -161,19 +162,19 @@ return arg;
@Test
public void testRegress3() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
while(arg < 10) {
break;
}
return arg;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return arg;", stop.toString());
+ code.parse().opto();
+ assertEquals("return arg;", code.print());
}
@Test
public void testRegress4() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
int a = 1;
while(arg < 10) {
a = a + 1;
@@ -184,14 +185,14 @@ while(arg < 10) {
}
return a;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Region,Phi(Loop,1,(Phi_a+1)),Add);", stop.toString());
- assertTrue(stop.ret().ctrl() instanceof RegionNode);
+ code.parse().opto();
+ assertEquals("return Phi(Region,Phi(Loop,1,(Phi_a+1)),Add);", code.print());
+ assertTrue(code.ctrl() instanceof RegionNode);
}
@Test
public void testRegress5() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
int a = 1;
while(1) {
a = a + 1;
@@ -200,9 +201,9 @@ while(1) {
}
return a;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return (Phi(Loop,1,Add)+1);", stop.toString());
- assertTrue(stop.ret().ctrl() instanceof CProjNode prj && prj._idx==1 );
+ code.parse().opto();
+ assertEquals("return (Phi(Loop,1,Add)+1);", code.print());
+ assertTrue(code.ctrl() instanceof CProjNode prj && prj._idx==1 );
}
}
diff --git a/src/test/java/com/seaofnodes/simple/Chapter09Test.java b/src/test/java/com/seaofnodes/simple/Chapter09Test.java
index c31afcd6..b210f7e9 100644
--- a/src/test/java/com/seaofnodes/simple/Chapter09Test.java
+++ b/src/test/java/com/seaofnodes/simple/Chapter09Test.java
@@ -1,7 +1,6 @@
package com.seaofnodes.simple;
import com.seaofnodes.simple.evaluator.Evaluator;
-import com.seaofnodes.simple.node.*;
import com.seaofnodes.simple.type.Type;
import com.seaofnodes.simple.type.TypeInteger;
import org.junit.Assert;
@@ -15,7 +14,7 @@ public class Chapter09Test {
@Test
@Ignore
public void testJig() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
int v0=0;
arg=0;
while(v0) {
@@ -25,12 +24,12 @@ while(v0) {
}
return 0;
""");
- StopNode stop = parser.parse().iterate();
+ code.parse().opto();
}
@Test
public void testGVN1() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int x = arg + arg;
if(arg < 10) {
@@ -41,41 +40,37 @@ else {
}
return x;
""");
- StopNode stop = parser.parse();
- assertEquals("Stop[ return (arg*2); return (Mul+1); ]", stop.toString());
- Assert.assertEquals(2L, Evaluator.evaluate(stop, 1));
- Assert.assertEquals(23L, Evaluator.evaluate(stop, 11));
+ code.parse().opto();
+ assertEquals("return Phi(Region,(arg*2),(Mul+1));", code.print());
+ Assert.assertEquals( "2", Eval2.eval(code, 1));
+ Assert.assertEquals("23", Eval2.eval(code, 11));
}
@Test
public void testGVN2() {
- Parser parser = new Parser(
- """
-return arg*arg-arg*arg;
- """);
- StopNode stop = parser.parse();
- assertEquals("return 0;", stop.toString());
- Assert.assertEquals(0L, Evaluator.evaluate(stop, 1));
+ CodeGen code = new CodeGen("return arg*arg-arg*arg;");
+ code.parse().opto();
+ assertEquals("return 0;", code.print());
+ Assert.assertEquals("0", Eval2.eval(code, 1, 1));
}
@Test
public void testWorklist1() {
- Parser parser = new Parser(
- """
+ CodeGen code = new CodeGen("""
int step = 1;
while (arg < 10) {
arg = arg + step + 1;
}
return arg;
- """);
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Loop,arg,(Phi_arg+2));", stop.toString());
- Assert.assertEquals(11L, Evaluator.evaluate(stop, 1));
+""");
+ code.parse().opto();
+ assertEquals("return Phi(Loop,arg,(Phi_arg+2));", code.print());
+ Assert.assertEquals("11", Eval2.eval(code, 1));
}
@Test
public void testWorklist2() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int cond = 0;
int one = 1;
@@ -85,14 +80,14 @@ while (arg < 10) {
}
return arg;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Loop,arg,(Phi_arg+4));", stop.toString());
- Assert.assertEquals(13L, Evaluator.evaluate(stop, 1));
+ code.parse().opto();
+ assertEquals("return Phi(Loop,arg,(Phi_arg+4));", code.print());
+ Assert.assertEquals("13", Eval2.eval(code, 1));
}
@Test
public void testWorklist3() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int v1 = 0;
int v2 = 0;
@@ -114,13 +109,13 @@ while (arg) {
}
return arg;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
+ code.parse().opto();
+ assertEquals("return 0;", code.print());
}
@Test
public void testRegionPeepBug() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int v0=0;
int v1=0;
@@ -132,48 +127,48 @@ while(v1+arg) {
v1=v2;
}
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("Stop[ return 0; return 0; ]", stop.toString());
+ code.parse().opto();
+ assertEquals("return 0;", code.print());
}
@Test
public void testWhile0() {
- Parser parser = new Parser("while(0) continue; if(0) arg=0;");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
+ CodeGen code = new CodeGen("while(0) continue; if(0) arg=0;");
+ code.parse().opto();
+ assertEquals("return 0;", code.print());
}
@Test
public void testWhile1() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
if(0) while(0) {
int arg=arg;
while(0) {}
}
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
+ code.parse().opto();
+ assertEquals("return 0;", code.print());
}
@Test
public void testPrecedence() {
- Parser parser = new Parser("return 3-1+2;");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 4;", stop.toString());
+ CodeGen code = new CodeGen("return 3-1+2;");
+ code.parse().opto();
+ assertEquals("return 4;", code.print());
}
@Test
public void testSwap2() {
- Parser parser = new Parser("return 1+(1+1);");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 3;", stop.toString());
+ CodeGen code = new CodeGen("return 1+(1+1);");
+ code.parse().opto();
+ assertEquals("return 3;", code.print());
}
@Test
public void testFuzz0() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
int one = 1;
int a = 0;
int zero = 0;
@@ -184,13 +179,13 @@ while(arg) {
}
return a;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Loop,0,(-(Phi_a+3)));", stop.toString());
+ code.parse().opto();
+ assertEquals("return Phi(Loop,0,(-(Phi_a+3)));", code.print());
}
@Test
public void testFuzz1() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
while(1) {}
while(arg) break;
while(arg) arg=0;
@@ -198,40 +193,40 @@ arg=0;
int v0=0!=0<-0;
return -0+0+0;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
+ code.parse().opto();
+ assertEquals("return Top;", code.print());
}
@Test
public void testFuzz2() {
- Parser parser = new Parser("return 0+-0;");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
+ CodeGen code = new CodeGen("return 0+-0;");
+ code.parse().opto();
+ assertEquals("return 0;", code.print());
}
@Test
public void testFuzz3() {
- Parser parser = new Parser("int v0=0; while(0==69) while(v0) return 0;");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
+ CodeGen code = new CodeGen("int v0=0; while(0==69) while(v0) return 0;");
+ code.parse().opto();
+ assertEquals("return 0;", code.print());
}
@Test
public void testFuzz4() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
while(1) {
arg=0<=0;
if(1<0) while(arg==-0) arg=arg-arg;
}
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
+ code.parse().opto();
+ assertEquals("return Top;", code.print());
}
@Test
public void testFuzz5() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
{
int v0=0;
while(1)
@@ -247,25 +242,25 @@ while(1) {
}
return 0!=0;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
+ code.parse().opto();
+ assertEquals("return Top;", code.print());
}
@Test
public void testFuzz6() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int v0=0;
while(0==1) while(v0)
v0=1+v0;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
+ code.parse().opto();
+ assertEquals("return ~int;", code.print());
}
@Test
public void testFuzz7() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
while(1) {}
int v0=0;
while(v0)
@@ -275,15 +270,15 @@ while(1)
v1=1;
return v1+v0;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
+ code.parse().opto();
+ assertEquals("return Top;", code.print());
}
@Test
public void testFuzz8() {
- Parser parser = new Parser("while(arg) arg = arg - 1; return arg;");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
+ CodeGen code = new CodeGen("while(arg) arg = arg - 1; return arg;");
+ code.parse().opto();
+ assertEquals("return 0;", code.print());
}
@Test
diff --git a/src/test/java/com/seaofnodes/simple/Chapter10Test.java b/src/test/java/com/seaofnodes/simple/Chapter10Test.java
index f634e421..bcae373b 100644
--- a/src/test/java/com/seaofnodes/simple/Chapter10Test.java
+++ b/src/test/java/com/seaofnodes/simple/Chapter10Test.java
@@ -1,9 +1,8 @@
package com.seaofnodes.simple;
-import com.seaofnodes.simple.evaluator.Evaluator;
+import org.junit.Test;
import com.seaofnodes.simple.node.*;
import java.util.BitSet;
-import org.junit.Test;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.fail;
@@ -14,9 +13,9 @@ public class Chapter10Test {
"if(1) return new S; else return 0;"
} ) {
String src = "struct S { int x; }; " + body;
- var stop = new Parser(src).parse().iterate();
+ var code = new CodeGen(src).parse().opto().typeCheck();
org.junit.Assert.assertTrue(body,
- stop.ret().expr()._type instanceof com.seaofnodes.simple.type.TypeMemPtr);
+ code.expr()._type instanceof com.seaofnodes.simple.type.TypeMemPtr);
}
}
@@ -39,9 +38,9 @@ public class Chapter10Test {
"if (!!!p) return -1; return p.x;",
"int b = !!p; if (b) return p.x + b - 1; return -1;"
} ) {
- StopNode stop = new Parser(NULLABLE_POINT_SOURCE+body).parse().iterate();
- assertEquals(body,-1L,com.seaofnodes.simple.evaluator.Evaluator.evaluate(stop,0));
- assertEquals(body,42L,com.seaofnodes.simple.evaluator.Evaluator.evaluate(stop,1));
+ CodeGen code = new CodeGen(NULLABLE_POINT_SOURCE+body).parse().opto().typeCheck();
+ assertEquals(body,"-1",Eval2.eval(code,0));
+ assertEquals(body,"42",Eval2.eval(code,1));
}
}
@@ -54,7 +53,7 @@ public class Chapter10Test {
"if (!!p) { int x = p.x; } return p.x;"
} ) {
try {
- new Parser(NULLABLE_POINT_SOURCE+body).parse().iterate();
+ new CodeGen(NULLABLE_POINT_SOURCE+body).parse().opto().typeCheck();
fail(body);
} catch( RuntimeException e ) {
// Known null is rejected during parsing in these chapters.
@@ -67,7 +66,7 @@ public class Chapter10Test {
@Test
public void testFuzzer() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int a = arg/3;
int b = arg*5;
@@ -86,13 +85,13 @@ if( (arg/13)==0 ) {
int r = g+h;
return p-r;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
+ code.parse().opto();
+ assertEquals("return 0;", code.print());
}
@Test
public void testStruct() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct Bar {
int a;
int b;
@@ -106,13 +105,13 @@ bar.a = 1;
bar.a = 2;
return bar.a;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 2;", stop.toString());
+ code.parse().opto();
+ assertEquals("return 2;", code.print());
}
@Test
public void testExample() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct Vector2D { int x; int y; };
!Vector2D !v = new Vector2D;
v.x = 1;
@@ -122,36 +121,36 @@ else
v.y = 3;
return v;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Vector2D;", stop.toString());
+ code.parse().opto();
+ assertEquals("return Vector2D;", code.print());
}
@Test
public void testBug() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct s0 {
int v0;
};
s0? v1=null;
int v3=v1.zAicm;
""");
- try { parser.parse(); fail(); }
+ try { code.parse(); fail(); }
catch( Exception e ) { assertEquals("Accessing unknown field 'zAicm' from 'null'",e.getMessage()); }
}
@Test
public void testBug2() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct s0 { int v0; };
arg=0+new s0.0;
""");
- try { parser.parse(); fail(); }
+ try { code.parse(); fail(); }
catch( Exception e ) { assertEquals("Expected an identifier, found 'null'",e.getMessage()); }
}
@Test
public void testLoop() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct Bar { int a; };
!Bar !bar = new Bar;
while (arg) {
@@ -160,65 +159,65 @@ while (arg) {
}
return bar.a;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Loop,0,(Phi_a+2));", stop.toString());
+ code.parse().opto();
+ assertEquals("return Phi(Loop,0,(Phi_a+2));", code.print());
}
@Test
public void testIf() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct Bar { int a; };
!Bar !bar = new Bar;
if (arg) bar = null;
bar.a = 1;
return bar.a;
""");
- try { parser.parse().iterate(); fail(); }
+ try { code.parse().opto(); fail(); }
catch( Exception e ) { assertEquals("Type null is not of declared type *Bar",e.getMessage()); }
}
@Test
public void testIf2() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct Bar { int a; };
!Bar? !bar = null;
if (arg) bar = new Bar;
bar.a = 1;
return bar.a;
""");
- try { parser.parse().iterate(); fail(); }
+ try { code.parse().opto().typeCheck(); fail(); }
catch( Exception e ) { assertEquals("Might be null accessing 'a'",e.getMessage()); }
}
@Test
public void testIf3() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct Bar { int a; };
Bar bar = null;
if (arg) bar = null;
bar.a = 1;
return bar.a;
""");
- try { parser.parse(); fail(); }
+ try { code.parse(); fail(); }
catch( Exception e ) { assertEquals("Type null is not of declared type *Bar", e.getMessage()); }
}
@Test
public void testIfOrNull() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct Bar { int a; };
!Bar? !bar = new Bar;
if (arg) bar = null;
if( bar ) bar.a = 1;
return bar;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Region,(*void)Phi(Region,null,Bar),null);", stop.toString());
+ code.parse().opto();
+ assertEquals("return Phi(Region,null,Bar);", code.print());
}
@Test
public void testIfOrNull2() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct Bar { int a; };
!Bar? !bar = new Bar;
@@ -228,13 +227,13 @@ if( !bar ) rez=4;
else bar.a = 1;
return rez;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Region,4,3);", stop.toString());
+ code.parse().opto();
+ assertEquals("return Phi(Region,4,3);", code.print());
}
@Test
public void testWhileWithNullInside() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct s0 {int v0;};
!s0? !v0 = new s0;
int ret = 0;
@@ -245,14 +244,14 @@ while(arg) {
}
return ret;
""");
- try { parser.parse().iterate(); fail(); }
+ try { code.parse().opto().typeCheck(); fail(); }
catch( Exception e ) {
assertEquals("Might be null accessing 'v0'", e.getMessage()); }
}
@Test
public void testRedeclareStruct() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct s0 {
int v0;
};
@@ -260,14 +259,14 @@ s0? v1=new s0;
!s0? !v1;
v1=new s0;
""");
- try { parser.parse(); fail(); }
+ try { code.parse(); fail(); }
catch( Exception e ) { assertEquals("Redefining name 'v1'", e.getMessage()); }
}
@Test
public void testIter() {
// Build and use an iterator
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct Iter {
int x;
@@ -282,14 +281,14 @@ while( i.x < i.len ) {
}
return sum;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Loop,0,(Phi(Loop,0,(Phi_x+1))+Phi_sum));", stop.toString());
+ code.parse().opto();
+ assertEquals("return Phi(Loop,0,(Phi(Loop,0,(Phi_x+1))+Phi_sum));", code.print());
}
@Test
public void test1() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct s0 {int v0;};
!s0 !ret = new s0;
while(arg) {
@@ -301,13 +300,13 @@ while(arg) {
}
return ret;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Loop,s0,Phi(Region,s0,Phi_ret));", stop.toString());
+ code.parse().opto();
+ assertEquals("return Phi(Loop,s0,Phi(Region,s0,Phi_ret));", code.print());
}
@Test
public void test2() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct s0 {int v0;};
!s0 !ret = new s0;
!s0 !v0 = new s0;
@@ -319,14 +318,14 @@ while(arg) {
}
return ret;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Loop,s0,Phi(Region,s0,Phi_ret));", stop.toString());
+ code.parse().opto();
+ assertEquals("return Phi(Loop,s0,Phi(Region,s0,Phi_ret));", code.print());
}
@Test
public void test3() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct s0 {int v0;};
!s0 !ret = new s0;
while(arg < 10) {
@@ -336,41 +335,40 @@ while(arg < 10) {
}
return ret;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Loop,s0,Phi(Region,s0,Phi_ret));", stop.toString());
+ code.parse().opto();
+ assertEquals("return Phi(Loop,s0,Phi(Region,s0,Phi_ret));", code.print());
}
@Test
public void testBug3() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct s0 { int f0; };
return new s0;
int v0=null.f0;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return s0;", stop.toString());
- assertEquals("Obj<s0>{f0=0}", Evaluator.evaluate(stop, 0).toString());
+ try { code.parse(); fail(); }
+ catch( Exception e ) { assertEquals("Accessing unknown field 'f0' from 'null'",e.getMessage()); }
}
@Test
public void testBug4() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
if(0) {
while(0) if(arg) continue;
int v0=0;
while(1) {
- int arg=-arg;
- v0=arg;
+ int v2=-arg;
+ v0=v2;
}
}
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
+ code.parse().opto();
+ assertEquals("return 0;", code.print());
}
@Test
public void testBug5() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct s0 {
int f0;
};
@@ -378,13 +376,13 @@ if(0) return 0;
else return new s0;
if(new s0.f0) return 0;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return s0;", stop.toString());
+ code.parse().opto();
+ assertEquals("return s0;", code.print());
}
@Test
public void testBug6MissedWorklist() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
while(0) {}
int v4=0;
while(0<arg) {
@@ -394,26 +392,26 @@ while(0<arg) {
}
return 0;
""");
- StopNode stop = parser.parse().iterate();
+ code.parse().opto();
}
@Test
public void testBug7() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct s0 { int f0; };
s0 v0 = new s0;
while(v0.f0) {}
s0 v1 = v0;
return v1;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return (const)s0;", stop.toString());
+ code.parse().opto();
+ assertEquals("return (const)s0;", code.print());
}
@Test
public void testBug8() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
int v2=0;
while(0)
while(0) {}
@@ -438,23 +436,23 @@ while(0) {}
} }
}
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
+ code.parse().opto();
+ assertEquals("return 0;", code.print());
}
@Test
public void testBug9() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
int v0=arg==0;
while(v0) continue;
return 0;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
+ code.parse().opto();
+ assertEquals("return 0;", code.print());
}
@Test public void testReadBeforeStores() {
- var stop = new Parser("""
+ var code = new CodeGen("""
struct S { int x; int y; };
!S !a = new S; !S !b = new S;
a.x = 11; b.x = 22;
@@ -463,9 +461,10 @@ return 0;
a.y = 55; b.y = 66;
a.x = 33; b.x = 44;
return before*100 + p.x;
- """).parse().iterate();
- assertEquals(1133L, com.seaofnodes.simple.evaluator.Evaluator.evaluate(stop,0));
- assertEquals(2244L, com.seaofnodes.simple.evaluator.Evaluator.evaluate(stop,1));
+ """).parse().opto();
+ StopNode stop = code._stop;
+ assertEquals("1133",Eval2.eval(code,0));
+ assertEquals("2244",Eval2.eval(code,1));
}
static final String NESTED_MEMORY = """
@@ -488,34 +487,31 @@ return 0;
""";
@Test public void testMemoryAcrossNestedLoops() {
- var stop = new Parser(NESTED_MEMORY).parse().iterate();
+ var code = new CodeGen(NESTED_MEMORY).parse().opto();
+ StopNode stop = code._stop;
for (int arg=0; arg<7; arg++) {
- var obj = (com.seaofnodes.simple.evaluator.Evaluator.Obj)
- com.seaofnodes.simple.evaluator.Evaluator.evaluate(stop,arg);
- org.junit.Assert.assertArrayEquals(new Object[] {
- 5L+arg, 7L+arg*(arg+1)-(arg>=2 ? 2 : 0), 11L+2*arg-(arg>=2 ? 2 : 0)
- }, obj.fields());
+ assertEquals("S{x="+(5L+arg)+",y="+(7L+arg*(arg+1)-(arg>=2 ? 2 : 0))+
+ ",z="+(11L+2*arg-(arg>=2 ? 2 : 0))+"}",Eval2.eval(code,arg));
}
}
@Test public void testMemoryAtEarlyReturns() {
- var stop = new Parser("""
+ var code = new CodeGen("""
struct S { int x; int y; int z; };
!S !s = new S;
s.x = 3; s.y = 5; s.z = 7;
if (arg) { s.x = 11; s.z = 13; return s; }
s.y = 17;
return s;
- """).parse().iterate();
+ """).parse().opto();
+ StopNode stop = code._stop;
for (int arg=0; arg<2; arg++) {
- var obj = (com.seaofnodes.simple.evaluator.Evaluator.Obj)
- com.seaofnodes.simple.evaluator.Evaluator.evaluate(stop,arg);
- org.junit.Assert.assertArrayEquals(arg==0 ? new Object[]{3L,17L,7L} : new Object[]{11L,5L,13L}, obj.fields());
+ assertEquals(arg==0 ? "S{x=3,y=17,z=7}" : "S{x=11,y=5,z=13}",Eval2.eval(code,arg));
}
}
@Test public void testKeepLoadsAtMerge() {
- StopNode stop = new Parser("""
+ var code = new CodeGen("""
struct S { int x; };
!S !a = new S; !S !b = new S;
a.x = arg; b.x = arg+1;
@@ -524,28 +520,30 @@ return 0;
int v;
if (arg>1) v=p.x; else v=q.x;
return v;
- """).parse().iterate();
+ """).parse().opto();
+ StopNode stop = code._stop;
// The one-step safety check stops at the memory aggregate.
assertEquals(2,countMemoryNodes(stop,LoadNode.class,new BitSet()));
- assertEquals(-1L,Evaluator.evaluate(stop,-1));
- assertEquals(1L,Evaluator.evaluate(stop,0));
- assertEquals(3L,Evaluator.evaluate(stop,3));
+ assertEquals("-1",Eval2.eval(code,-1));
+ assertEquals("1",Eval2.eval(code,0));
+ assertEquals("3",Eval2.eval(code,3));
}
@Test public void testDropStores() {
- StopNode stop = new Parser("""
+ var code = new CodeGen("""
struct S { int x; };
!S !s = new S;
if (arg) s.x=arg+1; else s.x=arg+2;
return s;
- """).parse().iterate();
+ """).parse().opto();
+ StopNode stop = code._stop;
assertEquals(1,countMemoryNodes(stop,StoreNode.class,new BitSet()));
- assertEquals(2L,((Evaluator.Obj)Evaluator.evaluate(stop,0)).fields()[0]);
- assertEquals(4L,((Evaluator.Obj)Evaluator.evaluate(stop,3)).fields()[0]);
+ assertEquals("S{x=2}",Eval2.eval(code,0));
+ assertEquals("S{x=4}",Eval2.eval(code,3));
}
@Test public void testKeepReadsBeforeWrites() {
- StopNode stop = new Parser("""
+ var code = new CodeGen("""
struct S { int x; int y; };
!S !a = new S; !S !b = new S;
a.x=arg; b.x=arg+1;
@@ -555,11 +553,12 @@ return 0;
if (arg>1) { v=p.x; p.x=41; p.y=5; }
else { v=q.x; q.x=42; }
return v;
- """).parse().iterate();
+ """).parse().opto();
+ StopNode stop = code._stop;
assertEquals(2,countMemoryNodes(stop,LoadNode.class,new BitSet()));
- assertEquals(-1L,Evaluator.evaluate(stop,-1));
- assertEquals(1L,Evaluator.evaluate(stop,0));
- assertEquals(3L,Evaluator.evaluate(stop,3));
+ assertEquals("-1",Eval2.eval(code,-1));
+ assertEquals("1",Eval2.eval(code,0));
+ assertEquals("3",Eval2.eval(code,3));
}
private static int countMemoryNodes(Node n, Class<?> kind, BitSet seen) {
diff --git a/src/test/java/com/seaofnodes/simple/Chapter11Test.java b/src/test/java/com/seaofnodes/simple/Chapter11Test.java
index f0caed02..9fd392d2 100644
--- a/src/test/java/com/seaofnodes/simple/Chapter11Test.java
+++ b/src/test/java/com/seaofnodes/simple/Chapter11Test.java
@@ -1,26 +1,26 @@
package com.seaofnodes.simple;
import com.seaofnodes.simple.node.*;
-import com.seaofnodes.simple.evaluator.Evaluator;
import org.junit.Test;
import static org.junit.Assert.*;
public class Chapter11Test {
@Test public void testIndependentField() {
- var stop = new Parser("""
+ var code = new CodeGen("""
struct S { int x; int y; };
!S !s = new S;
s.x = 42;
while (arg > 0) { s.y = s.y + arg; arg = arg - 1; }
return s.x;
- """).parse().iterate();
+ """).parse().opto();
+ var stop = code._stop;
assertEquals("return 42;",stop.toString());
- assertEquals(42L,Evaluator.evaluate(stop,5));
+ assertEquals("42",Eval2.eval(code,5));
assertNull(stop.walk(n -> n instanceof LoadNode ? n : null));
}
@Test public void testParallelMemoryPhis() {
- var stop = new Parser("""
+ var code = new CodeGen("""
struct S { int x; int y; int z; };
!S !a = new S; !S !b = new S;
!S !p = a; if (arg) p = b;
@@ -31,7 +31,8 @@ public class Chapter11Test {
arg = arg - 1;
}
return a;
- """).parse().iterate();
+ """).parse().opto();
+ var stop = code._stop;
int[] phis = {0};
stop.walk(n -> {
// Store sinking can replace field memory Phis with value Phis.
@@ -40,26 +41,26 @@ public class Chapter11Test {
for(int a=b._aliases.nextSetBit(0); a>=0; a=b._aliases.nextSetBit(a+1))
assertTrue(a<m.nIns() && m.in(a)!=null);
assertFalse(n instanceof PhiNode && n.isMem() &&
- !(n instanceof MemPhiNode) && !(n instanceof BulkMemPhiNode));
+ !(n instanceof MemPhiNode) && !(n instanceof BulkMemPhiNode) && !(n instanceof ParmNode));
return null;
});
assertTrue(phis[0]>=4); // Three fields and the loop counter.
- assertArrayEquals(new Object[]{1L,2L,3L},((Evaluator.Obj)Evaluator.evaluate(stop,4)).fields());
+ assertEquals("S{x=1,y=2,z=3}",Eval2.eval(code,4));
}
@Test public void testLateSliceWorklist() throws ReflectiveOperationException {
// Seed 97 exposed a store selecting a bulk predecessor without queuing
// it. Keep both the worklist assertion and the final heap check.
for (int seed : new int[]{0,97,123,456}) {
- var parser = new Parser(Chapter10Test.NESTED_MEMORY);
+ var code = new CodeGen(Chapter10Test.NESTED_MEMORY).parse();
var field = IterPeeps.class.getDeclaredField("WORK");
field.setAccessible(true);
Object work = field.get(null);
field = work.getClass().getDeclaredField("_R");
field.setAccessible(true);
((java.util.Random)field.get(work)).setSeed(seed);
- var stop = parser.parse().iterate();
- assertArrayEquals(new Object[]{9L,25L,17L},((Evaluator.Obj)Evaluator.evaluate(stop,4)).fields());
+ code.opto();
+ assertEquals("S{x=9,y=25,z=17}",Eval2.eval(code,4));
}
}
}
diff --git a/src/test/java/com/seaofnodes/simple/Chapter12Test.java b/src/test/java/com/seaofnodes/simple/Chapter12Test.java
index 628f6211..a15132d4 100644
--- a/src/test/java/com/seaofnodes/simple/Chapter12Test.java
+++ b/src/test/java/com/seaofnodes/simple/Chapter12Test.java
@@ -1,7 +1,5 @@
package com.seaofnodes.simple;
-import com.seaofnodes.simple.evaluator.Evaluator;
-import com.seaofnodes.simple.node.StopNode;
import org.junit.Ignore;
import org.junit.Test;
import static org.junit.Assert.assertEquals;
@@ -11,18 +9,18 @@ public class Chapter12Test {
@Ignore
@Test
public void testJig() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
return 3.14;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 3.14;", stop.toString());
- assertEquals(3.14, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return 3.14;", code.print());
+ assertEquals("3.14", Eval2.eval(code, 0));
}
@Test
public void testLinkedList0() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct LLI { !LLI? !next; int i; };
!LLI? !head = null;
@@ -35,13 +33,13 @@ while( arg ) {
}
return head.next.i;
""");
- try { parser.parse().iterate(); fail(); }
+ try { code.parse().opto().typeCheck(); fail(); }
catch( Exception e ) { assertEquals("Might be null accessing 'i'",e.getMessage()); }
}
@Test
public void testLinkedList1() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct LLI { !LLI? !next; int i; };
!LLI? !head = null;
@@ -57,14 +55,14 @@ LLI? next = head.next;
if( next==null ) return 1;
return next.i;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("Stop[ return 0; return 1; return .i; ]", stop.toString());
- assertEquals(2L, Evaluator.evaluate(stop, 3));
+ code.parse().opto();
+ assertEquals("return Phi(Region,0,1,.i);", code.print());
+ assertEquals("2", Eval2.eval(code, 3));
}
@Test
public void testCoRecur() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct int0 { int i; !flt0? !f; };
struct flt0 { flt f; !int0? !i; };
@@ -76,122 +74,189 @@ i0.f = f0;
f0.i = i0;
return f0.i.f.i.i;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 17;", stop.toString());
+ code.parse().opto();
+ assertEquals("return 17;", code.print());
}
@Test
public void testNullRef0() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct N { !N? !next; int i; };
N n = new N;
return n.next;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return null;", stop.toString());
+ code.parse().opto();
+ assertEquals("return null;", code.print());
}
@Test
public void testNullRef1() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct M { int m; };
struct N { !M !next; int i; };
N n = new N { next = new M; };
return n.next;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return (const)M;", stop.toString());
+ code.parse().opto();
+ assertEquals("return (const)M;", code.print());
}
@Test
public void testNullRef2() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct M { int m; };
struct N { !M !next; int i; };
N n = new N { next = null; }
return n.next;
""");
- try { parser.parse().iterate(); fail(); }
+ try { code.parse().opto(); fail(); }
catch( Exception e ) { assertEquals("Type null is not of declared type *M",e.getMessage()); }
}
@Test
public void testNullRef3() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct N { !N? !next; int i; };
!N !n = new N;
n.i = 3.14;
return n.i;
""");
- assertEquals("3",com.seaofnodes.simple.evaluator.Evaluator.evaluate(parser.parse().iterate(),0).toString());
+ code.parse().opto();
+ assertEquals("3",Eval2.eval(code,0));
}
@Test
public void testNullRef4() {
- Parser parser = new Parser("-null-5/null-5;");
- try { parser.parse().iterate(); fail(); }
+ CodeGen code = new CodeGen("-null-5/null-5;");
+ try { code.parse().opto().typeCheck(); fail(); }
catch( Exception e ) { assertEquals("Cannot 'Add' null",e.getMessage()); }
}
@Test public void testNullRef5() {
- Parser parser = new Parser("return null+42;");
- try { parser.parse().iterate(); fail(); }
+ CodeGen code = new CodeGen("return null+42;");
+ try { code.parse().opto().typeCheck(); fail(); }
catch( Exception e ) { assertEquals("Cannot 'Add' null",e.getMessage()); }
}
@Test
public void testEmpty() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct S{};
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
- assertEquals(0L, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return 0;", code.print());
+ assertEquals("0", Eval2.eval(code, 0));
}
@Test
public void testForwardRef0() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct S1 { !S2? !s; };
return new S2;
""");
- try { parser.parse().iterate(); fail(); }
+ try { code.parse().opto(); fail(); }
catch( Exception e ) { assertEquals("Unknown struct type 'S2'",e.getMessage()); }
}
@Test
public void testForwardRef1() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct S1 { !S2? !s; };
struct S2 { int x; };
return new S1.s=new S2;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return S2;", stop.toString());
+ code.parse().opto();
+ assertEquals("return S2;", code.print());
}
@Test
public void testcheckNull() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct I {int i;};
struct P { !I? !pi; };
!P !p1 = new P;
-!P !p2 = new P;
+!P p2 = new P;
p2.pi = new I;
p2.pi.i = 2;
if (arg) p1 = new P;
return p1.pi.i + 1;
""");
- try { parser.parse().iterate(); fail(); }
+ try { code.parse().opto().typeCheck(); fail(); }
catch( Exception e ) { assertEquals("Might be null accessing 'i'",e.getMessage()); }
}
+ @Test
+ public void testCoRecur2() {
+ CodeGen code = new CodeGen(
+"""
+struct A { !L? !a; !T? !b; !F? !c; }; !A? !a = new A;
+struct B { !M? !a; !U? !b; !G? !c; }; !B? !b = new B;
+struct C { !N? !a; !V? !b; !H? !c; }; !C? !c = new C;
+struct D { !O? !a; !W? !b; !I? !c; }; !D? !d = new D;
+struct E { !P? !a; !X? !b; !J? !c; }; !E? !e = new E;
+struct F { !Q? !a; !Y? !b; !K? !c; }; !F? !f = new F;
+struct G { !R? !a; !Z? !b; !L? !c; }; !G? !g = new G;
+struct H { !S? !a; !A? !b; !M? !c; }; !H? !h = new H;
+struct I { !T? !a; !B? !b; !N? !c; }; !I? !i = new I;
+struct J { !U? !a; !C? !b; !O? !c; }; !J? !j = new J;
+struct K { !V? !a; !D? !b; !P? !c; }; !K? !k = new K;
+struct L { !W? !a; !E? !b; !Q? !c; }; !L? !l = new L;
+struct M { !X? !a; !F? !b; !R? !c; }; !M? !m = new M;
+struct N { !Y? !a; !G? !b; !S? !c; }; !N? !n = new N;
+struct O { !Z? !a; !H? !b; !T? !c; }; !O? !o = new O;
+struct P { !A? !a; !I? !b; !U? !c; }; !P? !p = new P;
+struct Q { !B? !a; !J? !b; !V? !c; }; !Q? !q = new Q;
+struct R { !C? !a; !K? !b; !W? !c; }; !R? !r = new R;
+struct S { !D? !a; !L? !b; !X? !c; }; !S? !s = new S;
+struct T { !E? !a; !M? !b; !Y? !c; }; !T? !t = new T;
+struct U { !F? !a; !N? !b; !Z? !c; }; !U? !u = new U;
+struct V { !G? !a; !O? !b; !A? !c; }; !V? !v = new V;
+struct W { !H? !a; !P? !b; !B? !c; }; !W? !w = new W;
+struct X { !I? !a; !Q? !b; !C? !c; }; !X? !x = new X;
+struct Y { !J? !a; !R? !b; !D? !c; }; !Y? !y = new Y;
+struct Z { !K? !a; !S? !b; !E? !c; }; !Z? !z = new Z;
+
+a.a=l; a.b=t; a.c=f;
+b.a=m; b.b=u; b.c=g;
+c.a=n; c.b=v; c.c=h;
+d.a=o; d.b=w; d.c=i;
+e.a=p; e.b=x; e.c=j;
+f.a=q; f.b=y; f.c=k;
+g.a=r; g.b=z; g.c=l;
+h.a=s; h.b=a; h.c=m;
+i.a=t; i.b=b; i.c=n;
+j.a=u; j.b=c; j.c=o;
+k.a=v; k.b=d; k.c=p;
+l.a=w; l.b=e; l.c=q;
+m.a=x; m.b=f; m.c=r;
+n.a=y; n.b=g; n.c=s;
+o.a=z; o.b=h; o.c=t;
+p.a=a; p.b=i; p.c=u;
+q.a=b; q.b=j; q.c=v;
+r.a=c; r.b=k; r.c=w;
+s.a=d; s.b=l; s.c=x;
+t.a=e; t.b=m; t.c=y;
+u.a=f; u.b=n; u.c=z;
+v.a=g; v.b=o; v.c=a;
+w.a=h; w.b=p; w.c=b;
+x.a=i; x.b=q; x.c=c;
+y.a=j; y.b=r; y.c=d;
+z.a=k; z.b=s; z.c=e;
+
+return a.b.c.a.b.c.a.b.c.a.b.c.a.b.c.a.b.c;
+
+""");
+ code.parse().opto().typeCheck().GCM().localSched();
+ assertEquals("return R;", code._stop.toString());
+ assertEquals("R{a=C{a=N{a=Y{a=J{a=U{a=F{a=Q{a=B{a=M{a=X{a=I{a=T{a=E{a=P{a=A{a=L{a=W{a=H{a=S{a=D{a=O{a=Z{a=K{a=V{a=G{a=$cyclic,b=$cyclic,c=$cyclic},b=$cyclic,c=$cyclic},b=$cyclic,c=$cyclic},b=$cyclic,c=$cyclic},b=$cyclic,c=$cyclic},b=$cyclic,c=$cyclic},b=$cyclic,c=$cyclic},b=$cyclic,c=$cyclic},b=$cyclic,c=$cyclic},b=$cyclic,c=$cyclic},b=$cyclic,c=$cyclic},b=$cyclic,c=$cyclic},b=$cyclic,c=$cyclic},b=$cyclic,c=$cyclic},b=$cyclic,c=$cyclic},b=$cyclic,c=$cyclic},b=$cyclic,c=$cyclic},b=$cyclic,c=$cyclic},b=$cyclic,c=$cyclic},b=$cyclic,c=$cyclic},b=$cyclic,c=$cyclic},b=$cyclic,c=$cyclic},b=$cyclic,c=$cyclic},b=$cyclic,c=$cyclic},b=$cyclic,c=$cyclic},b=$cyclic,c=$cyclic}", Eval2.eval(code, 0));
+ }
+
}
diff --git a/src/test/java/com/seaofnodes/simple/Chapter13Test.java b/src/test/java/com/seaofnodes/simple/Chapter13Test.java
index 8f64701f..584377e4 100644
--- a/src/test/java/com/seaofnodes/simple/Chapter13Test.java
+++ b/src/test/java/com/seaofnodes/simple/Chapter13Test.java
@@ -1,8 +1,6 @@
package com.seaofnodes.simple;
-import com.seaofnodes.simple.evaluator.Evaluator;
-import com.seaofnodes.simple.node.StopNode;
import org.junit.Test;
@@ -13,7 +11,7 @@ public class Chapter13Test {
// A placeholder test used to rapidly rotate through fuzzer produced issues
@Test
public void testFuzzer() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
while(---- -arg) {
while(-arg) {
@@ -292,14 +290,14 @@ else {
}
}
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("Stop[ return 9; return 0; return 0; return 0; return 0; ]", stop.toString());
+ code.parse().opto().typeCheck().GCM();
+ assertEquals("return Phi(Region,9,Top,Top,Top,Top);", code.print());
}
@Test
public void testPrimes() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
if( arg < 2 ) return 0;
int primeCount = 1;
@@ -324,19 +322,19 @@ while( prime <= arg ) {
}
return primeCount;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("Stop[ return 0; return Phi(Loop,1,Phi(Region,Phi_primeCount,Phi(Region,(Phi_primeCount+1),Phi_primeCount))); ]", stop.toString());
- assertEquals(0L, Evaluator.evaluate(stop, 1)); // No primes 1 or below
- assertEquals(1L, Evaluator.evaluate(stop, 2)); // 2
- assertEquals(2L, Evaluator.evaluate(stop, 3)); // 2, 3
- assertEquals(2L, Evaluator.evaluate(stop, 4)); // 2, 3
- assertEquals(3L, Evaluator.evaluate(stop, 5)); // 2, 3, 5
- assertEquals(4L, Evaluator.evaluate(stop, 10)); // 2, 3, 5, 7
+ code.parse().opto();
+ assertEquals("return Phi(Region,0,Phi(Loop,1,Phi(Region,Phi_primeCount,Phi(Region,(Phi_primeCount+1),Phi_primeCount))));", code.print());
+ assertEquals("0", Eval2.eval(code, 1)); // No primes 1 or below
+ assertEquals("1", Eval2.eval(code, 2)); // 2
+ assertEquals("2", Eval2.eval(code, 3)); // 2, 3
+ assertEquals("2", Eval2.eval(code, 4)); // 2, 3
+ assertEquals("3", Eval2.eval(code, 5)); // 2, 3, 5
+ assertEquals("4", Eval2.eval(code, 10)); // 2, 3, 5, 7
}
@Test
public void testAntiDeps1() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct S { int f; };
!S !v=new S;
@@ -346,15 +344,15 @@ i=v.f;
if (arg) v.f=1;
return i;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 2;", stop.toString());
- assertEquals(2L, Evaluator.evaluate(stop, 0));
- assertEquals(2L, Evaluator.evaluate(stop, 1));
+ code.parse().opto();
+ assertEquals("return 2;", code.print());
+ assertEquals("2", Eval2.eval(code, 0));
+ assertEquals("2", Eval2.eval(code, 1));
}
@Test
public void testAntiDeps2() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct S { int f; };
!S !v = new S;
@@ -369,13 +367,13 @@ if (arg) {
}
return i;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Region,.f,0);", stop.toString());
+ code.parse().opto();
+ assertEquals("return Phi(Region,.f,0);", code.print());
}
@Test
public void testAntiDeps3() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct S { int f; };
!S !v0 = new S;
@@ -388,14 +386,14 @@ if (v1) {
}
return v0;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return S;", stop.toString());
+ code.parse().opto();
+ assertEquals("return S;", code.print());
}
@Test
public void testAntiDeps4() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct S { int f; };
!S !v = new S;
@@ -406,13 +404,13 @@ if (arg+1) arg= 0;
while (arg) v.f = 2;
return i;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return arg;", stop.toString());
+ code.parse().opto();
+ assertEquals("return arg;", code.print());
}
@Test
public void testAntiDeps5() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct S { int f; };
!S !v = new S;
@@ -423,13 +421,13 @@ while(1) {
}
return v;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return S;", stop.toString());
+ code.parse().opto();
+ assertEquals("return S;", code.print());
}
@Test
public void testAntiDeps6() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct s { int v; };
!s !ptr=new s;
@@ -438,13 +436,13 @@ while( -arg )
while(1)
arg = arg+ptr.v;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
+ code.parse().opto();
+ assertEquals("return Top;", code.print());
}
@Test
public void testAntiDeps7() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct S { int f; };
!S !v = new S;
@@ -456,13 +454,13 @@ while (arg) {
}
return i;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
+ code.parse().opto();
+ assertEquals("return 0;", code.print());
}
@Test
public void testAntiDeps8() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct S { int f; };
!S !v = new S;
@@ -476,13 +474,13 @@ while(arg) {
}
return arg;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
+ code.parse().opto();
+ assertEquals("return 0;", code.print());
}
@Test
public void testAntiDeps9() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct S { int f; };
!S !v = new S;
@@ -494,13 +492,13 @@ if (arg) {
}
return v;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return S;", stop.toString());
+ code.parse().opto();
+ assertEquals("return S;", code.print());
}
@Test
public void testExample2() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct S { int f; };
!S !v = new S;
@@ -513,13 +511,13 @@ while (arg > 0) {
}
return v;
""");
- StopNode stop = parser.parse().iterate();
- //assertEquals("return new S;", stop.toString());
+ code.parse().opto();
+ //assertEquals("return new S;", code.print());
}
@Test
public void testScheduleUse() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int v0=0;
while(0>=0) {
@@ -530,13 +528,13 @@ while(0>=0) {
}
return 0;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
+ code.parse().opto();
+ assertEquals("return Top;", code.print());
}
@Test
public void testLoopCarriedDep() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
u32 v0=0;
{
@@ -545,10 +543,11 @@ u32 v0=0;
v1=1>>>v0!=0;
v0=v1/0;
}
+ return v1;
}
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
+ code.parse().opto();
+ assertEquals("return 0;", code.print());
}
}
diff --git a/src/test/java/com/seaofnodes/simple/Chapter14FloatTest.java b/src/test/java/com/seaofnodes/simple/Chapter14FloatTest.java
index 3d92c9cf..a40b4f04 100644
--- a/src/test/java/com/seaofnodes/simple/Chapter14FloatTest.java
+++ b/src/test/java/com/seaofnodes/simple/Chapter14FloatTest.java
@@ -20,18 +20,18 @@ public class Chapter14FloatTest {
{"f32 rounded=arg+16777216.0; return rounded;", "1.6777232E7", "1.6777199E7"}
};
for( String[] test : tests ) {
- var stop = new Parser(test[0]).parse().iterate();
- assertEquals(test[0],test[1],Evaluator.evaluate(stop,17).toString());
- assertEquals(test[0],test[2],Evaluator.evaluate(stop,-17).toString());
+ var code = new CodeGen(test[0]).parse().opto().typeCheck();
+ assertEquals(test[0],test[1],Eval2.eval(code,17));
+ assertEquals(test[0],test[2],Eval2.eval(code,-17));
}
}
@Test public void testSubZeroFloat() {
- var stop = new Parser("flt x = arg; return 0-x;").parse().iterate();
+ var code = new CodeGen("flt x = arg; return 0-x;").parse().opto().typeCheck();
// Compare strings so +0.0 and -0.0 remain distinct.
- assertEquals("0.0", Evaluator.evaluate(stop,0).toString());
- assertEquals("-1.0", Evaluator.evaluate(stop,1).toString());
+ assertEquals("0.0", Eval2.eval(code,0));
+ assertEquals("-1.0", Eval2.eval(code,1));
}
@Test public void testDeadNumericReturns() {
@@ -42,8 +42,8 @@ public class Chapter14FloatTest {
{"return 2.5; return 7;", "2.5"}
} ) {
String src = test[0];
- var stop = new Parser(src).parse().iterate();
- assertEquals(src,test[1],com.seaofnodes.simple.evaluator.Evaluator.evaluate(stop,0).toString());
+ var code = new CodeGen(src).parse().opto().typeCheck();
+ assertEquals(src,test[1],Eval2.eval(code,0));
}
}
@@ -51,29 +51,29 @@ public class Chapter14FloatTest {
@Ignore
@Test
public void testJig() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
return 3.14;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 3.14;", stop.toString());
- assertEquals(3.14, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return 3.14;", code.print());
+ assertEquals("3.14", Eval2.eval(code, 0));
}
@Test
public void testFloat() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
return 3.14;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 3.14;", stop.toString());
- assertEquals(3.14, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return 3.14;", code.print());
+ assertEquals("3.14", Eval2.eval(code, 0));
}
@Test
public void testSquareRoot() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
flt guess = arg;
while( 1 ) {
@@ -83,21 +83,21 @@ while( 1 ) {
}
return guess;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Loop,(flt)arg,(((ToFloat/Phi_guess)+Phi_guess)/2.0));", stop.toString());
- assertEquals(3.0, Evaluator.evaluate(stop, 9));
- assertEquals(1.414213562373095, Evaluator.evaluate(stop, 2));
+ code.parse().opto();
+ assertEquals("return Phi(Loop,(flt)arg,(((ToFloat/Phi_guess)+Phi_guess)/2.0f));", code.print());
+ assertEquals("3.0", Eval2.eval(code, 9));
+ assertEquals("1.414213562373095", Eval2.eval(code, 2));
}
@Test
public void testFPOps() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
flt x = arg;
return x+1==x;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return ((flt)arg==(ToFloat+1.0));", stop.toString());
- assertEquals(0L, Evaluator.evaluate(stop, 1));
+ code.parse().opto();
+ assertEquals("return ((flt)arg==(ToFloat+1.0f));", code.print());
+ assertEquals("0", Eval2.eval(code, 1));
}
}
diff --git a/src/test/java/com/seaofnodes/simple/Chapter14Test.java b/src/test/java/com/seaofnodes/simple/Chapter14Test.java
index 27804a5a..789a2113 100644
--- a/src/test/java/com/seaofnodes/simple/Chapter14Test.java
+++ b/src/test/java/com/seaofnodes/simple/Chapter14Test.java
@@ -1,6 +1,5 @@
package com.seaofnodes.simple;
-import com.seaofnodes.simple.evaluator.Evaluator;
import com.seaofnodes.simple.node.StopNode;
import org.junit.Ignore;
import org.junit.Test;
@@ -13,18 +12,18 @@ public class Chapter14Test {
@Ignore
@Test
public void testJig() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
return 3.14;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 3.14;", stop.toString());
- assertEquals(3.14, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return 3.14;", code.print());
+ assertEquals("3.14", Eval2.eval(code, 0));
}
@Test
public void testRange() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int b;
if( arg ) b=1; else b=0;
@@ -33,157 +32,157 @@ if( b < 0 ) c = -1;
if( b > 2 ) c = 1;
return c;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 99;", stop.toString());
- assertEquals(99L, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return 99;", code.print());
+ assertEquals("99", Eval2.eval(code, 0));
}
@Test
public void testU8() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
u8 b = 123;
b = b + 456;// Truncate
return b;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 67;", stop.toString());
- assertEquals(67L, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return 67;", code.print());
+ assertEquals("67", Eval2.eval(code, 0));
}
@Test
public void testU8While() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
u8 b = 123;
while( b ) b = b + 456;// Truncate
return b;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
+ code.parse().opto();
+ assertEquals("return 0;", code.print());
}
@Test
public void testU1() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
bool b = 123;
b = b + 456;// Truncate
u1 c = b; // No more truncate needed
return c;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 1;", stop.toString());
- assertEquals(1L, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return 1;", code.print());
+ assertEquals("1", Eval2.eval(code, 0));
}
@Test
public void testAnd() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int b = 123;
b = b+456 & 31; // Precedence
return b;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 3;", stop.toString());
- assertEquals(3L, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return 3;", code.print());
+ assertEquals("3", Eval2.eval(code, 0));
}
@Test
public void testRefLoad() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct Foo { u1 b; };
!Foo !f = new Foo;
f.b = 123;
return f.b;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 1;", stop.toString());
- assertEquals(1L, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return 1;", code.print());
+ assertEquals("1", Eval2.eval(code, 0));
}
@Test
public void testSigned() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
i8 b = 255; // Chopped
return b; // Sign extend
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return -1;", stop.toString());
- assertEquals(-1L, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return -1;", code.print());
+ assertEquals("-1", Eval2.eval(code, 0));
}
@Test
public void testI8() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
i8 b = arg;
b = b + 1;// Truncate
return b;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return (((((arg<<56)>>56)+1)<<56)>>56);", stop.toString());
- assertEquals(1L, Evaluator.evaluate(stop, 0));
- assertEquals(-128L, Evaluator.evaluate(stop, 127));
+ code.parse().opto();
+ assertEquals("return (((((arg<<56)>>56)+1)<<56)>>56);", code.print());
+ assertEquals("1", Eval2.eval(code, 0));
+ assertEquals("-128", Eval2.eval(code, 127));
}
@Test
public void testMask() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
u16 mask = (1<<16)-1; // AND mask
int c = 123456789 & mask;
return c; //
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 52501;", stop.toString());
- assertEquals(52501L, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return 52501;", code.print());
+ assertEquals("52501", Eval2.eval(code, 0));
}
@Test
public void testOr() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
return (arg | 123 ^ 456) >>> 1;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return (((arg|123)^456)>>>1);", stop.toString());
- assertEquals(217L, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return (((arg|123)^456)>>>1);", code.print());
+ assertEquals("217", Eval2.eval(code, 0));
}
@Test
public void testMaskFloat() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
flt f = arg;
-arg = f & 0;
+arg = f & 1;
return arg;
""");
- try { parser.parse().iterate(); fail(); }
- catch( Exception e ) { assertEquals("Cannot '&' FltBot",e.getMessage()); }
+ try { code.parse().opto().typeCheck(); fail(); }
+ catch( Exception e ) { assertEquals("Cannot '&' flt",e.getMessage()); }
}
@Test
public void testCloneAnd() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
int v0=0;
u32 v1 = 1&(1<<arg)&(1<<arg);
while(arg) v1=-v0;
while(v1) break;
return v1;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Loop,(((1<<arg)&1)&Shl),0);", stop.toString());
- assertEquals(1L, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return (Phi(Loop,((1<<arg)&1),0)&Phi(Loop,Shl,4294967295));", code.print());
+ assertEquals("1", Eval2.eval(code, 0));
}
@Test
public void testAndHigh() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
int v0=0;
if(0&0>>>0) {
while(0) {
@@ -195,14 +194,14 @@ if(0&0>>>0) {
}
return v0;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
- assertEquals(0L, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return 0;", code.print());
+ assertEquals("0", Eval2.eval(code, 0));
}
@Test
public void testTypes() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
i8 xi8 = 123456789; if( xi8 != 21 ) return -8;
i16 xi16 = 123456789; if( xi16 != -13035 ) return -16;
@@ -221,9 +220,9 @@ f32 ff32 = 3.141592653589793; if( ff32 != 3.1415927410125732) return 5;
return 0;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
- assertEquals(0L, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return 0;", code.print());
+ assertEquals("0", Eval2.eval(code, 0));
}
}
diff --git a/src/test/java/com/seaofnodes/simple/Chapter15Test.java b/src/test/java/com/seaofnodes/simple/Chapter15Test.java
index 452a1051..97f695bf 100644
--- a/src/test/java/com/seaofnodes/simple/Chapter15Test.java
+++ b/src/test/java/com/seaofnodes/simple/Chapter15Test.java
@@ -1,43 +1,40 @@
package com.seaofnodes.simple;
-import com.seaofnodes.simple.evaluator.Evaluator;
-import com.seaofnodes.simple.node.StopNode;
-import org.junit.Test;
import org.junit.Ignore;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.fail;
+import org.junit.Test;
+import static org.junit.Assert.*;
public class Chapter15Test {
@Ignore
@Test
public void testJig() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
return 3.14;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 3.14;", stop.toString());
- assertEquals(3.14, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return 3.14;", code.print());
+ assertEquals("3.14", Eval2.eval(code, 0));
}
@Test
public void testCyclic() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct C { !C? !l; };
!C !c = new C;
c.l = c;
return c;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return C;", stop.toString());
- assertEquals("Obj<C>@1{l=obj@1}", Evaluator.evaluate(stop, 0).toString());
+ code.parse().opto();
+ assertEquals("return C;", code.print());
+ assertEquals("C{l=$cyclic}", Eval2.eval(code, 0));
}
@Test
public void testSafetyCheck() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
u8[] old = new u8[0];
u8[] !output = new u8[1];
@@ -49,66 +46,66 @@ while (i < old#) {
output[i] = 1;
return output;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return [u8];", stop.toString());
- assertEquals("\u0001", Evaluator.evaluate(stop, 0).toString());
+ code.parse().opto();
+ assertEquals("return [u8];", code.print());
+ assertEquals("\u0001", Eval2.eval(code, 0));
}
@Test
public void testBasic1() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int[] is = new int[2];
return is[1];
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
- assertEquals(0L, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return 0;", code.print());
+ assertEquals("0", Eval2.eval(code, 0));
}
@Test
public void testBasic2() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int[] is = new int[2];
int[] is2 = new int[2];
return is[1];
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
- assertEquals(0L, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return 0;", code.print());
+ assertEquals("0", Eval2.eval(code, 0));
}
@Test
public void testBasic3() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int[] !a = new int[2];
a[0] = 1;
a[1] = 2;
return a[0];
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 1;", stop.toString());
- assertEquals(1L, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return 1;", code.print());
+ assertEquals("1", Eval2.eval(code, 0));
}
@Test
public void testBasic4() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct A { int i; };
!A?[] !a = new !A?[2];
return a;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return [*A?];", stop.toString());
- assertEquals("Obj<[*A?]>{#=2,[]=[null,null]}", Evaluator.evaluate(stop, 0).toString());
+ code.parse().opto();
+ assertEquals("return [*A?];", code.print());
+ assertEquals("*A {int !i; }?[ null,null]", Eval2.eval(code, 0));
}
@Test
public void testBasic5() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct S { int x; flt y; };
// A new S
@@ -130,15 +127,15 @@ else {
}
return rez;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Region,1.2,Phi(Region,2.3,.y));", stop.toString());
- assertEquals(3.14, Evaluator.evaluate(stop, 0));
- assertEquals(1.2 , Evaluator.evaluate(stop, 1));
+ code.parse().opto();
+ assertEquals("return Phi(Region,1.2,Phi(Region,2.3,.y));", code.print());
+ assertEquals("3.14", Eval2.eval(code, 0));
+ assertEquals("1.2", Eval2.eval(code, 1));
}
@Test
public void testBasic6() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct S { int x; flt y; };
// A new S
@@ -156,13 +153,13 @@ if( iss[arg] )
rez = iss[arg][2].y;
return rez;
""");
- try { parser.parse().iterate(); fail(); }
+ try { code.parse().opto().typeCheck(); fail(); }
catch( Exception e ) { assertEquals("Might be null accessing '[]'",e.getMessage()); }
}
@Test
public void testTree() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
// Can we define a forward-reference array?
struct Tree { !Tree?[]? !_kids; };
@@ -171,25 +168,25 @@ root._kids = new !Tree?[2]; // NO BANG SO ARRAY IS OF IMMUTABLE TREES????
root._kids[0] = new Tree;
return root;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Tree;", stop.toString());
- assertEquals("Obj<Tree>{_kids=Obj<[*Tree?]>{#=2,[]=[Obj<Tree>{_kids=null},null]}}", Evaluator.evaluate(stop, 0).toString());
+ code.parse().opto();
+ assertEquals("return Tree;", code.print());
+ assertEquals("Tree{_kids=*Tree?[ Tree{_kids=null},null]}", Eval2.eval(code, 0));
}
@Test
public void testNestedStructAddMemProj() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct S { int a; int[] !b; };
return 0;
""");
- StopNode stop = parser.parse();
- assertEquals("return 0;", stop.toString());
+ code.parse().opto();
+ assertEquals("return 0;", code.print());
}
@Test
public void testRollingSum() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int[] !ary = new int[arg];
// Fill [0,1,2,3,4,...]
@@ -206,14 +203,14 @@ while( i < ary# - 1 ) {
}
return ary[1] * 1000 + ary[3]; // 1 * 1000 + 6
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return (.[]+(.[]*1000));", stop.toString());
- assertEquals(1006L, Evaluator.evaluate(stop, 4));
+ code.parse().opto();
+ assertEquals("return (.[]+(.[]*1000));", code.print());
+ assertEquals("1006", Eval2.eval(code, 4));
}
@Test
public void sieveOEratosthenes() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int[] !ary = new int[arg], !primes = new int[arg];
int nprimes = 0, p=2;
@@ -247,19 +244,14 @@ while( j < nprimes ) {
}
return rez;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return [int];", stop.toString());
- Evaluator.Obj obj = (Evaluator.Obj)Evaluator.evaluate(stop, 20);
- assertEquals("[int] {int #; int ![]; }",obj.struct().toString());
- long nprimes = (Long)obj.fields()[0];
- long[] primes = new long[]{2,3,5,7,11,13,17,19};
- for( int i=0; i<nprimes; i++ )
- assertEquals(primes[i],(long)(Long)obj.fields()[i+1]);
+ code.parse().opto();
+ assertEquals("return [int];", code.print());
+ assertEquals("int[ 2,3,5,7,11,13,17,19]",Eval2.eval(code, 20));
}
@Test
public void testNewNodeInit() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct S {int i; flt f;};
!S !s1 = new S;
@@ -269,62 +261,62 @@ s2.f = 2.0;
if (arg) s1 = new S;
return s1.i + s1.f;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return ((flt).i+.f);", stop.toString());
- assertEquals(0.0, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return ((flt).i+.f);", code.print());
+ assertEquals("0.0", Eval2.eval(code, 0));
}
@Test
public void testBad0() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
return new flt;
""");
- try { parser.parse().iterate(); fail(); }
+ try { code.parse().opto(); fail(); }
catch( Exception e ) { assertEquals("Cannot allocate a flt",e.getMessage()); }
}
@Test
public void testBad1() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int is = new int[2];
""");
- try { parser.parse().iterate(); fail(); }
+ try { code.parse().opto(); fail(); }
catch( Exception e ) { assertEquals("Type *[int] is not of declared type int",e.getMessage()); }
}
@Test
public void testBad2() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int[] is = new int[3.14];
return is[1];
""");
- try { parser.parse().iterate(); fail(); }
+ try { code.parse().opto(); fail(); }
catch( Exception e ) { assertEquals("Cannot allocate an array with length 3.14",e.getMessage()); }
}
@Test
public void testBad3() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int[] is = new int[arg];
return is[1];
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
- assertEquals(0L, Evaluator.evaluate(stop, 4));
- try { Evaluator.evaluate(stop,0); }
+ code.parse().opto();
+ assertEquals("return 0;", code.print());
+ assertEquals("0", Eval2.eval(code, 4));
+ try { Eval2.eval(code,0); }
catch( ArrayIndexOutOfBoundsException e ) { assertEquals("Array index 1 out of bounds for array length 0",e.getMessage()); }
- try { Evaluator.evaluate(stop,-1); }
+ try { Eval2.eval(code,-1); }
catch( NegativeArraySizeException e ) { assertEquals("-1",e.getMessage()); }
}
@Test
public void testProgress() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
i8 v1=0&0;
u8 v2=0;
byte v4=0;
@@ -343,14 +335,14 @@ while(v5+(0&0)) {
}
return v1;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
- assertEquals(0L, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return 0;", code.print());
+ assertEquals("0", Eval2.eval(code, 0));
}
@Test
public void testSharpNot() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
if(0>>0) {}
while(0) {}
@@ -358,14 +350,14 @@ u32 v7=0;
int v8=0;
while(0<--1>>>---(v7*0==v8)) {}
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
+ code.parse().opto();
+ assertEquals("return 0;", code.print());
}
@Test
public void testProgress2() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
if(1) {}
else {
@@ -382,7 +374,7 @@ else {
}
}
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
+ code.parse().opto();
+ assertEquals("return 0;", code.print());
}
}
diff --git a/src/test/java/com/seaofnodes/simple/Chapter16Test.java b/src/test/java/com/seaofnodes/simple/Chapter16Test.java
index 996be2a1..fd028d57 100644
--- a/src/test/java/com/seaofnodes/simple/Chapter16Test.java
+++ b/src/test/java/com/seaofnodes/simple/Chapter16Test.java
@@ -12,68 +12,68 @@ public class Chapter16Test {
@Ignore
@Test
public void testJig() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
return 3.14;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 3.14;", stop.toString());
- assertEquals(3.14, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return 3.14;", code.print());
+ assertEquals("3.14", Eval2.eval(code, 0));
}
@Test
public void testMulti0() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int x, y;
return x+y;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
- assertEquals(0L, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return 0;", code.print());
+ assertEquals("0", Eval2.eval(code, 0));
}
@Test
public void testMulti1() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int x=2, y=x+1;
return x+y;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 5;", stop.toString());
- assertEquals(5L, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return 5;", code.print());
+ assertEquals("5", Eval2.eval(code, 0));
}
@Test
public void testConstruct0() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct X { int x=3; };
X z = new X;
return z.x;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 3;", stop.toString());
- assertEquals(3L, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return 3;", code.print());
+ assertEquals("3", Eval2.eval(code, 0));
}
@Test
public void testConstruct2() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct X { int x=3; };
X z = new X { x = 4; };
return z.x;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 4;", stop.toString());
- assertEquals(4L, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return 4;", code.print());
+ assertEquals("4", Eval2.eval(code, 0));
}
@Test
public void testLinkedList1() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct LLI { !LLI? !next; int i; };
!LLI? !head = null;
@@ -86,16 +86,16 @@ LLI? next = head.next;
if( !next ) return 1;
return next.i;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("Stop[ return 0; return 1; return .i; ]", stop.toString());
- assertEquals(0L, Evaluator.evaluate(stop, 0));
- assertEquals(1L, Evaluator.evaluate(stop, 1));
- assertEquals(2L, Evaluator.evaluate(stop, 3));
+ code.parse().opto();
+ assertEquals("return Phi(Region,0,1,.i);", code.print());
+ assertEquals("0", Eval2.eval(code, 0));
+ assertEquals("1", Eval2.eval(code, 1));
+ assertEquals("2", Eval2.eval(code, 3));
}
@Test
public void testLinkedList2() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct LLI { !LLI? !next; int i; };
!LLI? !head = null;
@@ -117,16 +117,16 @@ LLI? next = head.next;
if( !next ) return 1;
return next.i;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("Stop[ return 0; return 1; return .i; ]", stop.toString());
- assertEquals(0L, Evaluator.evaluate(stop, 0));
- assertEquals(1L, Evaluator.evaluate(stop, 1));
- assertEquals(2L, Evaluator.evaluate(stop, 11));
+ code.parse().opto();
+ assertEquals("return Phi(Region,0,1,.i);", code.print());
+ assertEquals("0", Eval2.eval(code, 0));
+ assertEquals("1", Eval2.eval(code, 1));
+ assertEquals("2", Eval2.eval(code, 11));
}
@Test
public void testSquare() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
struct Square {
flt !side = arg;
@@ -142,10 +142,10 @@ struct Square {
};
return new Square;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Square;", stop.toString());
- assertEquals("Obj<Square>{side=3.0,diag=1.7320508075688772}", Evaluator.evaluate(stop, 3).toString());
- assertEquals("Obj<Square>{side=4.0,diag=2.0}", Evaluator.evaluate(stop, 4).toString());
+ code.parse().opto();
+ assertEquals("return Square;", code.print());
+ assertEquals("Square{side=3.0,diag=1.7320508075688772}", Eval2.eval(code, 3));
+ assertEquals("Square{side=4.0,diag=2.0}", Eval2.eval(code, 4));
}
static final String CONSTRUCTOR_MEMORY = """
struct S { int x; int y; };
@@ -166,8 +166,8 @@ return new Square;
""";
@Test public void testConstructorMemory() {
- StopNode stop = new Parser(CONSTRUCTOR_MEMORY).parse().iterate();
- assertEquals(111249L,Evaluator.evaluate(stop,0));
- assertEquals(222352L,Evaluator.evaluate(stop,1));
+ var code = new CodeGen(CONSTRUCTOR_MEMORY).parse().opto();
+ assertEquals("111249",Eval2.eval(code,0));
+ assertEquals("222352",Eval2.eval(code,1));
}
}
diff --git a/src/test/java/com/seaofnodes/simple/Chapter17aTest.java b/src/test/java/com/seaofnodes/simple/Chapter17aTest.java
index 423eade0..ab92d439 100644
--- a/src/test/java/com/seaofnodes/simple/Chapter17aTest.java
+++ b/src/test/java/com/seaofnodes/simple/Chapter17aTest.java
@@ -10,63 +10,63 @@ public class Chapter17aTest {
@Test
public void testFinal1() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
int x=2, y=3;
if( arg ) { int x = y; x = x*x; y=x; } // Shadow final x
return y;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Region,9,3);", stop.toString());
- assertEquals(3L, Evaluator.evaluate(stop, 0));
- assertEquals(9L, Evaluator.evaluate(stop, 1));
+ code.parse().opto();
+ assertEquals("return Phi(Region,9,3);", code.print());
+ assertEquals("3", Eval2.eval(code, 0));
+ assertEquals("9", Eval2.eval(code, 1));
}
@Test
public void testConstruct1() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct X { int ~x; };
X z = new X { x=3; };
return z.x;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 3;", stop.toString());
- assertEquals(3L, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return 3;", code.print());
+ assertEquals("3", Eval2.eval(code, 0));
}
@Test
public void testStructFinal0() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct Point { int ~x, ~y; };
Point p = new Point { x=3; y=4; };
return p;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return (const)Point;", stop.toString());
- assertEquals("Obj<Point>{x=3,y=4}", Evaluator.evaluate(stop, 0).toString());
+ code.parse().opto();
+ assertEquals("return (const)Point;", code.print());
+ assertEquals("Point{x=3,y=4}", Eval2.eval(code, 0));
}
@Test
public void testStructFinal1() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct Point { int x=3, y=4; };
Point p = new Point { x=5; y=6; };
p.x++;
return p;
""");
- try { parser.parse().iterate(); fail(); }
+ try { code.parse().opto().typeCheck(); fail(); }
catch( Exception e ) { assertEquals("Cannot modify final field 'x'",e.getMessage()); }
}
@Test
public void testStructFinal2() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct Point { int x=3, y=4; };
Point p = new Point;
p.x++;
return p;
""");
- try { parser.parse().iterate(); fail(); }
+ try { code.parse().opto().typeCheck(); fail(); }
catch( Exception e ) { assertEquals("Cannot modify final field 'x'",e.getMessage()); }
}
@@ -74,34 +74,34 @@ return p;
public void testStructFinal3() {
for( String fields : new String[] { "var x; var y;", "int[] !x;", "int[] !x;" } ) {
String src = "struct Point { "+fields+" }; Point p = new Point; p.x++; return p;";
- try { new Parser(src).parse().iterate(); fail(fields); }
+ try { new CodeGen(src).parse().opto(); fail(fields); }
catch( Exception e ) { assertEquals("'Point' is not fully initialized, field 'x' needs to be set in a constructor",e.getMessage()); }
}
}
@Test
public void testStructFinal4() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct Point { val x=3; val y=4; };
Point p = new Point;
p.x++;
return p;
""");
- try { parser.parse().iterate(); fail(); }
+ try { code.parse().opto(); fail(); }
catch( Exception e ) { assertEquals("Cannot reassign final 'x'",e.getMessage()); }
}
@Test
public void testStructFinal5() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct Point { var x=3; var y=4; };
!Point !p = new Point;
p.x++;
return p;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Point;", stop.toString());
- assertEquals("Obj<Point>{x=4,y=4}", Evaluator.evaluate(stop, 0).toString());
+ code.parse().opto();
+ assertEquals("return Point;", code.print());
+ assertEquals("Point{x=4,y=4}", Eval2.eval(code, 0));
}
}
diff --git a/src/test/java/com/seaofnodes/simple/Chapter17bTest.java b/src/test/java/com/seaofnodes/simple/Chapter17bTest.java
index 64b606d3..e83b43af 100644
--- a/src/test/java/com/seaofnodes/simple/Chapter17bTest.java
+++ b/src/test/java/com/seaofnodes/simple/Chapter17bTest.java
@@ -1,241 +1,211 @@
package com.seaofnodes.simple;
-import com.seaofnodes.simple.evaluator.Evaluator;
-import com.seaofnodes.simple.node.StopNode;
-import com.seaofnodes.simple.node.StoreNode;
-import org.junit.Test;
import org.junit.Ignore;
+import org.junit.Test;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.fail;
public class Chapter17bTest {
- @Test public void testSinkLoopStores() {
- StopNode stop = new Parser("""
- struct Totals { int sum; int visits; };
- val t = new Totals { sum=7; visits=2; };
- val data = new int[4];
- for( int i=0; i<data#; i++ ) data[i]=arg+i;
- for( int i=0; i<(arg<data# ? arg : data#); i++ ) {
- t.sum = t.sum + data[i];
- t.visits++;
- }
- return t;
- """).parse().iterate();
- stop.typeCheck();
- int[] stores = {0};
- stop.walk(n -> {
- if( n instanceof StoreNode st && !st._name.equals("[]") ) {
- assertEquals(stop.in(0).in(0),st.in(0)); // Both stores at the exit.
- stores[0]++;
- }
- return null;
- });
- assertEquals(2,stores[0]);
- for( int arg : new int[]{-1,0,1,3,4,5} ) {
- long n = Math.max(0,Math.min(arg,4));
- var obj = (Evaluator.Obj)Evaluator.evaluate(stop,arg);
- org.junit.Assert.assertArrayEquals(new Object[]{7+n*arg+n*(n-1)/2,2+n},obj.fields());
- }
- }
-
- @Test public void testKeepObservedLoopStore() {
- StopNode stop = new Parser("""
- struct S { int x; };
- val a = new S;
- val b = new S;
- val p = arg ? a : b;
- int sum=0;
- for( int i=0; i<4; i++ ) {
- a.x=i+1;
- sum+=p.x;
- }
- return sum;
- """).parse().iterate();
- stop.typeCheck();
- assertEquals(0L,Evaluator.evaluate(stop,0));
- assertEquals(10L,Evaluator.evaluate(stop,1));
- }
-
@Ignore
@Test
public void testJig() {
- Parser parser = new Parser("return 1;");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 1;", stop.toString());
- assertEquals(1L, Evaluator.evaluate(stop, 0));
+ CodeGen code = new CodeGen(
+"""
+int i = 0;
+i=i=1;
+return i;
+""");
+ code.parse().opto();
+ assertEquals("return 1;", code.print());
+ assertEquals("1", Eval2.eval(code, 0));
}
// ---------------------------------------------------------------
@Test
public void testInc0() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
return arg++;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return arg;", stop.toString());
- assertEquals(0L, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return arg;", code.print());
+ assertEquals("0", Eval2.eval(code, 0));
}
@Test
public void testInc1() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
return arg+++arg++;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return ((arg*2)+1);", stop.toString());
- assertEquals(1L, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return ((arg*2)+1);", code.print());
+ assertEquals("1", Eval2.eval(code, 0));
}
@Test
public void testInc2() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
// -(arg--)-(arg--)
return -arg---arg--;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return (-((arg*2)+-1));", stop.toString());
- assertEquals(1L, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return (-((arg*2)+-1));", code.print());
+ assertEquals("1", Eval2.eval(code, 0));
}
@Test
public void testInc3() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
int[] !xs = new int[arg];
xs[0]++;
xs[1]++;
return xs[0];
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 1;", stop.toString());
- assertEquals(1L, Evaluator.evaluate(stop, 2));
+ code.parse().opto();
+ assertEquals("return 1;", code.print());
+ assertEquals("1", Eval2.eval(code, 2));
}
@Test
public void testInc4() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
u8[] !xs = new u8[1];
xs[0]--;
return xs[0];
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 255;", stop.toString());
- assertEquals(255L, Evaluator.evaluate(stop, 2));
+ code.parse().opto();
+ assertEquals("return 255;", code.print());
+ assertEquals("255", Eval2.eval(code, 2));
}
@Test
public void testInc5() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct S { u16 x; };
!S !s = new S;
s.x--;
return s.x;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 65535;", stop.toString());
- assertEquals(65535L, Evaluator.evaluate(stop, 2));
+ code.parse().opto();
+ assertEquals("return 65535;", code.print());
+ assertEquals("65535", Eval2.eval(code, 2));
}
@Test
public void testInc6() {
- Parser parser = new Parser("return --arg;");
- StopNode stop = parser.parse().iterate();
- assertEquals("return (arg+-1);", stop.toString());
- assertEquals(-1L, Evaluator.evaluate(stop, 0));
+ CodeGen code = new CodeGen("return --arg;");
+ code.parse().opto();
+ assertEquals("return (arg+-1);", code.print());
+ assertEquals("-1", Eval2.eval(code, 0));
}
@Test
public void testInc7() {
- Parser parser = new Parser("u8 x=0; return --x;");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 255;", stop.toString());
- assertEquals(255L, Evaluator.evaluate(stop, 0));
+ CodeGen code = new CodeGen("u8 x=0; return --x;");
+ code.parse().opto();
+ assertEquals("return 255;", code.print());
+ assertEquals("255", Eval2.eval(code, 0));
}
@Test
public void testInc8() {
- Parser parser = new Parser("int x; x+=2; return x+=3;");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 5;", stop.toString());
- assertEquals(5L, Evaluator.evaluate(stop, 0));
+ CodeGen code = new CodeGen("int x; x+=2; return x+=3;");
+ code.parse().opto();
+ assertEquals("return 5;", code.print());
+ assertEquals("5", Eval2.eval(code, 0));
+ }
+
+ @Test
+ public void testInc9() {
+ CodeGen code = new CodeGen("flt x = 1.5; x++; return x;");
+ code.parse().opto();
+ assertEquals("return 2.5f;", code.print());
+ assertEquals("2.5", Eval2.eval(code, 0));
+ }
+
+ @Test public void testInt10() {
+ CodeGen code = new CodeGen("flt x = 1.5; x++; int i = x; return i;");
+ code.parse().opto();
+ assertEquals("2",Eval2.eval(code,0));
}
+
// ---------------------------------------------------------------
@Test public void testVar0() {
- Parser parser = new Parser("var d; return d;");
- try { parser.parse().iterate(); fail(); }
+ CodeGen code = new CodeGen("var d; return d;");
+ try { code.parse().opto(); fail(); }
catch( Exception e ) { assertEquals("Syntax error, expected =expression: ;",e.getMessage()); }
}
@Test public void testVar1() {
- Parser parser = new Parser("val d; return d;");
- try { parser.parse().iterate(); fail(); }
+ CodeGen code = new CodeGen("val d; return d;");
+ try { code.parse().opto(); fail(); }
catch( Exception e ) { assertEquals("Syntax error, expected =expression: ;",e.getMessage()); }
}
@Test public void testVar2() {
- Parser parser = new Parser("int x; x=3; x++; return x; // Ok, no initializer so x is mutable ");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 4;", stop.toString());
- assertEquals(4L, Evaluator.evaluate(stop, 0));
+ CodeGen code = new CodeGen("int x; x=3; x++; return x; // Ok, no initializer so x is mutable ");
+ code.parse().opto();
+ assertEquals("return 4;", code.print());
+ assertEquals("4", Eval2.eval(code, 0));
}
@Test public void testVar3() {
- Parser parser = new Parser("int x=3; x++; return x; // Ok, primitive so x is mutable despite initializer ");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 4;", stop.toString());
- assertEquals(4L, Evaluator.evaluate(stop, 0));
+ CodeGen code = new CodeGen("int x=3; x++; return x; // Ok, primitive so x is mutable despite initializer ");
+ code.parse().opto();
+ assertEquals("return 4;", code.print());
+ assertEquals("4", Eval2.eval(code, 0));
}
@Test public void testVar4() {
- Parser parser = new Parser("struct S{int x;}; !S !s; s=new S; s.x++; return s.x; // Ok, no initializer so x is mutable ");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 1;", stop.toString());
- assertEquals(1L, Evaluator.evaluate(stop, 0));
+ CodeGen code = new CodeGen("struct S{int x;}; !S? !s; s=new S; s.x++; return s.x; // Ok, no initializer so x is mutable ");
+ code.parse().opto();
+ assertEquals("return 1;", code.print());
+ assertEquals("1", Eval2.eval(code, 0));
}
@Test public void testVar5() {
- Parser parser = new Parser("struct S{int x;}; !S !s; s=new S{x=3;}; s.x++; return s.x; // Ok, no initializer so x is mutable ");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 4;", stop.toString());
- assertEquals(4L, Evaluator.evaluate(stop, 0));
+ CodeGen code = new CodeGen("struct S{int x;}; !S? !s; s=new S{x=3;}; s.x++; return s.x; // Ok, no initializer so x is mutable ");
+ code.parse().opto();
+ assertEquals("return 4;", code.print());
+ assertEquals("4", Eval2.eval(code, 0));
}
@Test public void testVar6() {
- Parser parser = new Parser("struct S{int x;}; S s=new S; s.x++; return s.x; // Error initializer so x is immutable ");
- try { parser.parse().iterate(); fail(); }
+ CodeGen code = new CodeGen("struct S{int x;}; S s=new S; s.x++; return s.x; // Error initializer so x is immutable ");
+ try { code.parse().opto().typeCheck(); fail(); }
catch( Exception e ) { assertEquals("Cannot modify final field 'x'",e.getMessage()); }
}
@Test public void testVar7() {
- Parser parser = new Parser("struct S{int x;}; S s=new S{x=3;}; s.x++; return s.x; // Error initializer so x is immutable ");
- try { parser.parse().iterate(); fail(); }
+ CodeGen code = new CodeGen("struct S{int x;}; S s=new S{x=3;}; s.x++; return s.x; // Error initializer so x is immutable ");
+ try { code.parse().opto().typeCheck(); fail(); }
catch( Exception e ) { assertEquals("Cannot modify final field 'x'",e.getMessage()); }
}
@Test public void testVar8() {
- Parser parser = new Parser("struct S{int x;}; !S !s=new S; s.x++; return s.x; // Ok, has '!' so s.x is mutable ");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 1;", stop.toString());
- assertEquals(1L, Evaluator.evaluate(stop, 0));
+ CodeGen code = new CodeGen("struct S{int x;}; !S !s=new S; s.x++; return s.x; // Ok, has '!' so s.x is mutable ");
+ code.parse().opto();
+ assertEquals("return 1;", code.print());
+ assertEquals("1", Eval2.eval(code, 0));
}
@Test public void testVar9() {
- Parser parser = new Parser("struct S{int x;}; var s=new S; s.x++; return s.x; // Ok, has var so s.x is mutable ");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 1;", stop.toString());
- assertEquals(1L, Evaluator.evaluate(stop, 0));
+ CodeGen code = new CodeGen("struct S{int x;}; var s=new S; s.x++; return s.x; // Ok, has var so s.x is mutable ");
+ code.parse().opto();
+ assertEquals("return 1;", code.print());
+ assertEquals("1", Eval2.eval(code, 0));
}
@Test public void testVar10() {
- Parser parser = new Parser("struct S{int x;}; ~S s=new S; s.x++; return s.x; // Error, has val so x is immutable ");
- try { parser.parse().iterate(); fail(); }
+ CodeGen code = new CodeGen("struct S{int x;}; ~S s=new S; s.x++; return s.x; // Error, has val so x is immutable ");
+ try { code.parse().opto().typeCheck(); fail(); }
catch( Exception e ) { assertEquals("Cannot modify final field 'x'",e.getMessage()); }
}
@Test public void testVar11() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct Bar { int x; };
!Bar !bar = new Bar;
bar.x = 3; // Ok, bar is mutable
@@ -248,12 +218,12 @@ foo.bar.x++; // Ok foo and foo.bar and foo.bar.x are all mutable
~Foo xfoo = foo; // Throw away mutability
xfoo.bar.x++; // Error, cannot mutate through xfoo
""");
- try { parser.parse().iterate(); fail(); }
+ try { code.parse().opto().typeCheck(); fail(); }
catch( Exception e ) { assertEquals("Cannot modify final field 'x'",e.getMessage()); }
}
@Test public void testVar12() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct Bar { int x; };
!Bar !bar = new Bar;
bar.x = 3; // Ok, bar is mutable
@@ -269,24 +239,24 @@ foo.bar.x++; // Bumps to 5
int x5 = xfoo.bar.x; // Ok to read through xfoo, gets 5
return x4*10+x5;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 45;", stop.toString());
- assertEquals(45L, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return 45;", code.print());
+ assertEquals("45", Eval2.eval(code, 0));
}
@Test
public void testVar13() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
int i,i++;
""");
- try { parser.parse().iterate(); fail(); }
+ try { code.parse().opto().typeCheck(); fail(); }
catch( Exception e ) { assertEquals("Redefining name 'i'",e.getMessage()); }
}
@Test
public void testVar14() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct B {};
struct A { !B !b; };
A x = new A {
@@ -294,127 +264,171 @@ A x = new A {
b = new B;
};
""");
- try { parser.parse().iterate(); fail(); }
+ try { code.parse().opto(); fail(); }
catch( Exception e ) { assertEquals("Cannot read uninitialized field 'b'",e.getMessage()); }
}
@Test
public void testVar15() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct B {};
struct A { !B !b; };
return new A {
if (arg) b = new B; // Constructor ends with partial init of b
}.b;
""");
- try { parser.parse().iterate(); fail(); }
+ try { code.parse().opto(); fail(); }
catch( Exception e ) { assertEquals("'A' is not fully initialized, field 'b' needs to be set in a constructor",e.getMessage()); }
}
+ @Test
+ public void testVar16() {
+ CodeGen code = new CodeGen(
+"""
+struct S{};
+val x = 1;
+val s = new S{x = 2;};
+return x;
+"""
+);
+ try { code.parse().opto().typeCheck(); fail(); }
+ catch( Exception e ) { assertEquals("Cannot reassign final 'x'",e.getMessage()); }
+ }
+
+ @Test
+ public void testVar17() {
+ CodeGen code = new CodeGen(
+"""
+struct Person {
+ bool focused;
+};
+val focus = { !Person p ->
+ p.focused = true;
+};
+!Person !me; // !Person !me = new Person;
+focus(me);
+return me;
+"""
+);
+ try { code.parse().opto().typeCheck(); fail(); }
+ catch( Exception e ) { assertEquals("Syntax error, expected =expression: ;",e.getMessage()); }
+ }
+
// ---------------------------------------------------------------
@Test
public void testTrinary0() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
return arg ? 1 : 2;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Region,1,2);", stop.toString());
- assertEquals(2L, Evaluator.evaluate(stop, 0));
- assertEquals(1L, Evaluator.evaluate(stop, 1));
+ code.parse().opto();
+ assertEquals("return Phi(Region,1,2);", code.print());
+ assertEquals("2", Eval2.eval(code, 0));
+ assertEquals("1", Eval2.eval(code, 1));
}
@Test
public void testTrinary1() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
return arg ? 0 : arg;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return 0;", stop.toString());
- assertEquals(0L, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return 0;", code.print());
+ assertEquals("0", Eval2.eval(code, 0));
}
@Test
public void testTrinary2() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct Bar { int x; };
var b = arg ? new Bar : null;
return b ? b.x++ + b.x++ : -1;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Region,1,-1);", stop.toString());
- assertEquals(-1L, Evaluator.evaluate(stop, 0));
- assertEquals( 1L, Evaluator.evaluate(stop, 1));
+ code.parse().opto();
+ assertEquals("return Phi(Region,((.x*2)+1),-1);", code.print());
+ assertEquals("-1", Eval2.eval(code, 0));
+ assertEquals("1", Eval2.eval(code, 1));
}
@Test
public void testTrinary3() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct Bar { int x; };
var b = arg ? new Bar;
return b ? b.x++ + b.x++ : -1;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Region,1,-1);", stop.toString());
- assertEquals(-1L, Evaluator.evaluate(stop, 0));
- assertEquals( 1L, Evaluator.evaluate(stop, 1));
+ code.parse().opto();
+ assertEquals("return Phi(Region,((.x*2)+1),-1);", code.print());
+ assertEquals("-1", Eval2.eval(code, 0));
+ assertEquals("1", Eval2.eval(code, 1));
}
@Test
public void testTrinary4() {
// This test case will benefit from an unzipping transformation
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct Bar { !Bar? !next; int x; };
var b = arg ? new Bar { next = (arg==2) ? new Bar{x=2;}; x=1; };
return b ? b.next ? b.next.x : b.x; // parses "b ? (b.next ? b.next.x : b.x) : 0"
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Region,Phi(Region,.x,.x),0);", stop.toString());
- assertEquals( 0L, Evaluator.evaluate(stop, 0));
- assertEquals( 1L, Evaluator.evaluate(stop, 1));
- assertEquals( 2L, Evaluator.evaluate(stop, 2));
+ code.parse().opto();
+ assertEquals("return Phi(Region,Phi(Region,.x,.x),0);", code.print());
+ assertEquals("0", Eval2.eval(code, 0));
+ assertEquals("1", Eval2.eval(code, 1));
+ assertEquals("2", Eval2.eval(code, 2));
}
@Test
public void testTrinary5() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
flt f=arg?1:1.2;
return f; // missing widening
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Region,1.0,1.2);", stop.toString());
- assertEquals(1.2, Evaluator.evaluate(stop, 0));
+ code.parse().opto();
+ assertEquals("return Phi(Region,1.0f,1.2);", code.print());
+ assertEquals("1.2", Eval2.eval(code, 0));
+ }
+
+
+ @Test
+ public void testTrinary6() {
+ CodeGen code = new CodeGen("""
+struct S{};
+return arg ? 7 : new S;
+""");
+ try { code.parse().opto().typeCheck(); fail(); }
+ catch( Exception e ) { assertEquals("No common type amongst int and reference",e.getMessage()); }
}
// ---------------------------------------------------------------
@Test
public void testFor0() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
int sum=0;
for( int i=0; i<arg; i++ )
sum += i;
return sum;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Loop,0,(Phi_sum+Phi(Loop,0,(Phi_i+1))));", stop.toString());
- assertEquals(3L, Evaluator.evaluate(stop, 3));
- assertEquals(45L, Evaluator.evaluate(stop, 10));
+ code.parse().opto();
+ assertEquals("return Phi(Loop,0,(Phi_sum+Phi(Loop,0,(Phi_i+1))));", code.print());
+ assertEquals("3", Eval2.eval(code, 3));
+ assertEquals("45", Eval2.eval(code, 10));
}
@Test
public void testFor1() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
int sum=0, i=0;
for( ; i<arg; i++ )
sum += i;
return sum;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Loop,0,(Phi_sum+Phi(Loop,0,(Phi_i+1))));", stop.toString());
- assertEquals(3L, Evaluator.evaluate(stop, 3));
- assertEquals(45L, Evaluator.evaluate(stop, 10));
+ code.parse().opto();
+ assertEquals("return Phi(Loop,0,(Phi_sum+Phi(Loop,0,(Phi_i+1))));", code.print());
+ assertEquals("3", Eval2.eval(code, 3));
+ assertEquals("45", Eval2.eval(code, 10));
}
@Test
public void testFor2() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
int sum=0;
for( int i=0; ; i++ ) {
if( i>=arg ) break;
@@ -422,41 +436,41 @@ for( int i=0; ; i++ ) {
}
return sum;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Loop,0,(Phi_sum+Phi(Loop,0,(Phi_i+1))));", stop.toString());
- assertEquals(3L, Evaluator.evaluate(stop, 3));
- assertEquals(45L, Evaluator.evaluate(stop, 10));
+ code.parse().opto();
+ assertEquals("return Phi(Loop,0,(Phi_sum+Phi(Loop,0,(Phi_i+1))));", code.print());
+ assertEquals("3", Eval2.eval(code, 3));
+ assertEquals("45", Eval2.eval(code, 10));
}
@Test
public void testFor3() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
int sum=0;
for( int i=0; i<arg; )
sum += i++;
return sum;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Loop,0,(Phi_sum+Phi(Loop,0,(Phi_i+1))));", stop.toString());
- assertEquals(3L, Evaluator.evaluate(stop, 3));
- assertEquals(45L, Evaluator.evaluate(stop, 10));
+ code.parse().opto();
+ assertEquals("return Phi(Loop,0,(Phi_sum+Phi(Loop,0,(Phi_i+1))));", code.print());
+ assertEquals("3", Eval2.eval(code, 3));
+ assertEquals("45", Eval2.eval(code, 10));
}
@Test
public void testFor4() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
int sum=0;
for( int i=0; i<arg; i++ )
sum += i;
return i;
""");
- try { parser.parse().iterate(); fail(); }
+ try { code.parse().opto(); fail(); }
catch( Exception e ) { assertEquals("Undefined name 'i'",e.getMessage()); }
}
@Test
public void testFor5() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
for(;;arg++;) {}
""");
- try { parser.parse().iterate(); fail(); }
+ try { code.parse().opto(); fail(); }
catch( Exception e ) { assertEquals("Syntax error, expected Unexpected code after expression: ;",e.getMessage()); }
}
@@ -465,36 +479,36 @@ for(;;arg++;) {}
// ---------------------------------------------------------------
@Test
public void testForward0() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct A{
!B? !f1;
!B? !f2;
};
return new A;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return A;", stop.toString());
- assertEquals("Obj<A>{f1=null,f2=null}", Evaluator.evaluate(stop).toString());
+ code.parse().opto();
+ assertEquals("return A;", code.print());
+ assertEquals("A{f1=null,f2=null}", Eval2.eval(code,0));
}
@Test
public void testForward1() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct A{
!B?[]? !nil_array_of_b;
!B?[] not_array_of_b = new !B?[0];
};
return new A.not_array_of_b;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return [*B?];", stop.toString());
- assertEquals("Obj<[*B?]>{#=0,[]=[]}", Evaluator.evaluate(stop).toString());
+ code.parse().opto();
+ assertEquals("return [*B?];", code.print());
+ assertEquals("*B?[]", Eval2.eval(code,0));
}
// ---------------------------------------------------------------
@Test
public void testLinkedList2() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct LLI { !LLI? !next; int i; };
!LLI? !head = null;
while( arg-- )
@@ -505,14 +519,14 @@ for( ; ptr; ptr = ptr.next )
sum += ptr.i;
return sum;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return Phi(Loop,0,(Phi_sum+.i));", stop.toString());
- assertEquals(45L, Evaluator.evaluate(stop, 10));
+ code.parse().opto();
+ assertEquals("return Phi(Loop,0,(Phi_sum+.i));", code.print());
+ assertEquals("45", Eval2.eval(code, 10));
}
@Test
public void sieveOfEratosthenes() {
- Parser parser = new Parser(
+ CodeGen code = new CodeGen(
"""
var ary = new bool[arg], primes = new int[arg];
var nprimes=0, p=0;
@@ -536,14 +550,9 @@ for( int j=0; j<nprimes; j++ )
rez[j] = primes[j];
return rez;
""");
- StopNode stop = parser.parse().iterate();
- assertEquals("return [int];", stop.toString());
- Evaluator.Obj obj = (Evaluator.Obj)Evaluator.evaluate(stop, 20);
- assertEquals("[int] {int #; int ![]; }",obj.struct().toString());
- long nprimes = (Long)obj.fields()[0];
- long[] primes = new long[]{2,3,5,7,11,13,17,19};
- for( int i=0; i<nprimes; i++ )
- assertEquals(primes[i],(long)(Long)obj.fields()[i+1]);
+ code.parse().opto().typeCheck().GCM();
+ assertEquals("return [int];", code.print());
+ assertEquals("int[ 2,3,5,7,11,13,17,19]",Eval2.eval(code, 20));
}
}
diff --git a/src/test/java/com/seaofnodes/simple/Chapter18Test.java b/src/test/java/com/seaofnodes/simple/Chapter18Test.java
new file mode 100644
index 00000000..7f2b92ac
--- /dev/null
+++ b/src/test/java/com/seaofnodes/simple/Chapter18Test.java
@@ -0,0 +1,551 @@
+package com.seaofnodes.simple;
+import com.seaofnodes.simple.type.*;
+import com.seaofnodes.simple.node.*;
+
+
+import org.junit.Test;
+import static org.junit.Assert.*;
+import static org.junit.Assert.fail;
+import org.junit.Ignore;
+
+public class Chapter18Test {
+ @Test public void testFloatArrays() {
+ for( String type : new String[]{"flt","f64","f32"} ) {
+ CodeGen zero = new CodeGen("var a = new "+type+"[arg]; return a[arg-1];")
+ .parse().opto().typeCheck();
+ assertEquals("0.0",Eval2.eval(zero,3));
+ new CodeGen(type+" x = arg; var a = new "+type+"[arg]; a[0] = x; return a[0];")
+ .parse().opto().typeCheck();
+ CodeGen loop = new CodeGen("var a = new "+type+"[arg]; "+
+ "for(int i=0; i<arg; i++) a[i] += i+0.25; return a[0]+a[arg-1];")
+ .parse().opto().typeCheck();
+ assertEquals("0.5",Eval2.eval(loop,1));
+ assertEquals("3.5",Eval2.eval(loop,4));
+
+ CodeGen rounded = new CodeGen("var a = new "+type+"[arg]; "+
+ "for(int i=0; i<arg; i++) a[i] = 16777216.0+i; return a[arg-1];")
+ .parse().opto().typeCheck();
+ assertEquals(type.equals("f32") ? "1.6777216E7" : "1.6777217E7",Eval2.eval(rounded,2));
+ }
+ CodeGen rounded = new CodeGen("var a = new f32[arg]; "+
+ "for(int i=0; i<arg; i++) a[i] = 16777217.0; return a[arg-1];")
+ .parse().opto().typeCheck();
+ assertEquals("1.6777216E7",Eval2.eval(rounded,2));
+ }
+
+ @Test public void testNeverExitLoopDepth() {
+ String[] sources = {
+ "if(arg) while(1) {} return 7;",
+ "if(arg==1) while(1) {} if(arg==2) while(1) {} return 7;",
+ "while(1) {}",
+ "int x=0; while(arg) { if(arg==2) while(1) { x++; } x++; arg--; } return x;"
+ };
+ for( String src : sources ) {
+ CodeGen code = new CodeGen(src).parse().opto().typeCheck();
+ code._start.buildLoopTree(code._stop);
+ int[] nevers = {0};
+ code._stop.walk(n -> {
+ if( n instanceof FunNode fun )
+ assertEquals("Function entry is outside its loops",0,fun.loopDepth());
+ if( n instanceof ReturnNode ret ) {
+ assertEquals(ret.fun().loopDepth(),ret.loopDepth());
+ assertEquals(ret.fun().loopDepth(),ret.cfg0().loopDepth());
+ }
+ if( n instanceof LoopNode loop && !(loop instanceof StartNode) &&
+ loop.back() instanceof CProjNode back && back.in(0) instanceof NeverNode never ) {
+ nevers[0]++;
+ assertSame(loop,never.loop());
+ assertSame(loop,back.loop());
+ CProjNode exit = never.cproj(1-back._idx);
+ CFGNode fun = loop;
+ while( !(fun instanceof FunNode) ) fun=fun.idom();
+ assertSame(fun.loop(),exit.loop());
+ assertEquals(fun.loopDepth(),exit.loopDepth());
+ assertTrue(loop.loopDepth()>fun.loopDepth());
+ }
+ return null;
+ });
+ assertTrue("Exercise a synthetic exit",nevers[0]>0);
+ }
+ }
+
+ @Test public void testFunctionLocalConstantChains() {
+ String src = "val f = { int x -> x ? f(x-1)*305420988+x/305420988 : 1; }; "+
+ "val g = { int x -> x ? g(x-1)/305420988+x*305420988 : 1; }; "+
+ "return f(arg)+g(arg);";
+ CodeGen code = new CodeGen(src);
+ code.parse().opto().typeCheck();
+ Node con = code._stop.walk(n -> n instanceof ConstantNode &&
+ n._type==TypeInteger.constant(305420988) ? n : null);
+ assertNotNull(con);
+ Node[] uses = con._outputs.asAry();
+ // Preserve a stacked Cast/Constant chain through scheduling.
+ Node cast = new CastNode(TypeInteger.BOT,code._start,con);
+ cast = new CastNode(TypeInteger.BOT,code._start,cast);
+ for( Node use : uses )
+ for( int i=1; i<use.nIns(); i++ )
+ if( use.in(i)==con ) use.setDef(i,cast);
+ code.GCM();
+ var owners = new java.util.IdentityHashMap<CFGNode,Boolean>();
+ code._stop.walk(n -> {
+ if( !(n instanceof CastNode) || !(n.in(1) instanceof CastNode) ) return null;
+ CFGNode fun = n.cfg0();
+ while( fun!=null && !(fun instanceof FunNode) ) fun = fun.idom();
+ assertTrue("Constant must belong to a function",fun instanceof FunNode);
+ assertNull("Share one constant chain within each function",owners.put(fun,true));
+ // Follow all parts of the constant chain, including shared inputs.
+ var todo = new java.util.ArrayList<Node>();
+ var seen = new java.util.IdentityHashMap<Node,Boolean>();
+ todo.add(n);
+ for( int j=0; j<todo.size(); j++ ) {
+ Node part = todo.get(j);
+ if( seen.put(part,true)!=null ) continue;
+ CFGNode owner = part.cfg0();
+ while( owner!=null && !(owner instanceof FunNode) ) owner = owner.idom();
+ assertSame("Every constant-building operation is function-local",fun,owner);
+ for( int i=1; i<part.nIns(); i++ ) {
+ Node def = part.in(i);
+ if( def==null || def instanceof CFGNode ) continue;
+ assertTrue("Copies must register their data edges",def._outputs.find(part)!=-1);
+ if( def._type.isConstant() ) todo.add(def);
+ }
+ }
+ return null;
+ });
+ assertTrue("Exercise constants shared across functions",owners.size()>=2);
+ }
+
+ @Test public void testReachableMixedReturns() {
+ for( String[] test : new String[][] {
+ {"if(arg) return 7; else return 2.5;", "No common type amongst int and f64"},
+ {"struct S { int x; }; if(arg) return new S; else return 0;",
+ "No common type amongst int and reference"}
+ } ) {
+ try {
+ new CodeGen(test[0]).parse().opto().typeCheck();
+ fail("Expected incompatible return types: " + test[0]);
+ } catch( Parser.ParseException e ) {
+ assertEquals(test[1],e.getMessage());
+ }
+ }
+ }
+
+
+ @Test public void testPrintingForwardReferenceScope() throws Exception {
+ new CodeGen("return 0;").parse();
+ var declared = TypeMemPtr.make(TypeStruct.makeFRef("PrintForward"));
+ var scope = new ScopeNode();
+ scope.define("ptr",declared,false,new ConstantNode(TypeInteger.ZERO),null);
+ Parser.TYPES.put("PrintForward",TypeMemPtr.make(TypeStruct.make("PrintForward")));
+ var field = Var.class.getDeclaredField("_type");
+ field.setAccessible(true);
+ var v = scope._vars.get(0);
+ org.junit.Assert.assertSame(declared,field.get(v));
+ scope.toString();
+ org.junit.Assert.assertSame(declared,field.get(v));
+ }
+
+
+ @Ignore
+ @Test
+ public void testJig() {
+ CodeGen code = new CodeGen(
+"""
+return 0;
+""");
+ code.parse().opto().typeCheck().GCM().localSched();
+ assertEquals("return 0;", code._stop.toString());
+ assertEquals("0", Eval2.eval(code, 2));
+ }
+
+ @Test
+ public void testPhiParalleAssign() {
+ CodeGen code = new CodeGen(
+"""
+int a = 1;
+int b = 2;
+while(arg--) {
+ int t = a;
+ a = b;
+ b = t;
+}
+return a;
+""");
+ code.parse().opto().typeCheck().GCM();
+ assertEquals("return Phi(Loop,1,Phi(Loop,2,Phi_a));", code._stop.toString());
+ assertEquals("1", Eval2.eval(code, 0));
+ assertEquals("2", Eval2.eval(code, 1));
+ assertEquals("1", Eval2.eval(code, 2));
+ assertEquals("2", Eval2.eval(code, 3));
+ }
+
+
+ // ---------------------------------------------------------------
+ @Test
+ public void testType0() {
+ CodeGen code = new CodeGen(
+"""
+{int -> int}? x2 = null; // null function ptr
+return x2;
+""");
+ code.parse().opto();
+ assertEquals("return null;", code._stop.toString());
+ assertEquals("null", Eval2.eval(code, 0 ) );
+ }
+
+ @Test
+ public void testFcn0() {
+ CodeGen code = new CodeGen(
+"""
+{int -> int}? sq = { int x ->
+ x*x;
+};
+return sq;
+""");
+ code.parse().opto();
+ assertEquals("Stop[ return { sq}; return (Parm_x(sq,int)*x); ]", code._stop.toString());
+ assertEquals("{ sq}", Eval2.eval(code, 3));
+ }
+
+ @Test
+ public void testFcn1() {
+ CodeGen code = new CodeGen(
+"""
+var sq = { int x ->
+ x*x;
+};
+return sq(arg)+sq(3);
+""");
+ code.parse().opto();
+ assertEquals("Stop[ return (sq( 3)+sq( arg)); return (Parm_x(sq,int,3,arg)*x); ]", code._stop.toString());
+ assertEquals("13", Eval2.eval(code, 2));
+ }
+
+ // Function scope test
+ @Test
+ public void testFcn2() {
+ CodeGen code = new CodeGen(
+"""
+int cnt=1;
+return { -> cnt; };
+""");
+ try { code.parse().opto(); fail(); }
+ catch( Exception e ) { assertEquals("Variable 'cnt' is out of function scope and must be a final constant",e.getMessage()); }
+ }
+
+ // Function scope test
+ @Test
+ public void testFcn3() {
+ CodeGen code = new CodeGen(
+"""
+val cnt=2;
+return { -> cnt; }();
+""");
+ code.parse().opto();
+ assertEquals("return 2;", code._stop.toString());
+ assertEquals("2", Eval2.eval(code, 0));
+ }
+
+ // Function variables
+ @Test
+ public void testFcn4() {
+ CodeGen code = new CodeGen(
+"""
+var fcn = arg ? { int x -> x*x; } : { int x -> x+x; };
+return fcn(3);
+""");
+ code.parse().opto();
+ assertEquals("Stop[ return Phi(Region,{ int -> int #1},{ int -> int #2})( 3); return (Parm_x($fun,int,3)*x); return (Parm_x($fun,int,3)*2); ]", code._stop.toString());
+ assertEquals("6", Eval2.eval(code, 0));
+ assertEquals("9", Eval2.eval(code, 1));
+ }
+
+ // Recursive factorial test
+ @Test
+ public void testFcn5() {
+ CodeGen code = new CodeGen("val fact = { int x -> x <= 1 ? 1 : x*fact(x-1); }; return fact(arg);");
+ code.parse().opto();
+ assertEquals("Stop[ return fact( arg); return Phi(Region,1,(Parm_x(fact,int,arg,(x-1))*fact( Sub))); ]", code._stop.toString());
+ assertEquals( "1", Eval2.eval(code, 0));
+ assertEquals( "1", Eval2.eval(code, 1));
+ assertEquals( "2", Eval2.eval(code, 2));
+ assertEquals( "6", Eval2.eval(code, 3));
+ assertEquals("24", Eval2.eval(code, 4));
+ }
+
+ @Test
+ public void testFcn6() {
+ CodeGen code = new CodeGen(
+"""
+struct S { int i; };
+val newS = { int x -> return new S { i=x; }; };
+return newS(1).i;
+""");
+ code.parse().opto().typeCheck().GCM();
+ assertEquals("return 1;", code._stop.toString());
+ assertEquals("1", Eval2.eval(code, 0));
+ }
+
+ // Double forward reference
+ @Test
+ public void testFcn7() {
+ CodeGen code = new CodeGen(
+"""
+if( arg ? f : g ) return 1;
+val f = {->1;};
+val g = {->2;};
+return 2;
+""");
+ code.parse().opto().typeCheck().GCM();
+ assertEquals("Stop[ return 1; return 1; return 2; ]", code._stop.toString());
+ assertEquals("1", Eval2.eval(code, 0));
+ }
+
+ @Test
+ public void testFcn8() {
+ CodeGen code = new CodeGen(
+"""
+{int -> int}? !i2i = null;
+var id = {{int->int} f-> return f;};
+for(;;) {
+ if (i2i) return i2i(arg);
+ var x = {int i-> return i;};
+ arg = x(3);
+ i2i = id(x);
+}
+""");
+ code.parse().opto().typeCheck().GCM().localSched();
+ assertEquals("Stop[ return x( Phi(Loop,arg,x( 3))); return Parm_i(x,int,3,Phi_arg); ]", code._stop.toString());
+ assertEquals("3", Eval2.eval(code, 0));
+ }
+
+
+ @Test
+ public void testFcn9() {
+ CodeGen code = new CodeGen(
+"""
+{int -> int}? !i2i = null;
+for(;;) {
+ if (i2i) return i2i(arg);
+ var x = {int i-> return i;};
+ arg = x(3);
+}
+""");
+ code.parse().opto().typeCheck().GCM().localSched();
+ assertEquals("return Top;", code._stop.toString());
+ assertEquals(null, Eval2.eval(code, 0));
+ }
+
+ // Function break
+ @Test
+ public void testErr1() {
+ CodeGen code = new CodeGen(
+"""
+for(;;) {
+ val f = { ->
+ break;
+ };
+ f();
+ return 2;
+}
+return 1;
+""");
+ try { code.parse().opto(); fail(); }
+ catch( Exception e ) { assertEquals("No active loop for a break or continue",e.getMessage()); }
+ }
+
+ // Calling and inlining a null function
+ @Test
+ public void testErr2() {
+ CodeGen code = new CodeGen(
+"""
+{int -> int}? !i2i = { int i -> return i; };
+for(;;) {
+ if (i2i(2) == arg) break;
+ i2i = null;
+}
+""");
+ try { code.parse().opto().typeCheck(); fail(); }
+ catch( Exception e ) { assertEquals("Might be null calling { int -> int #1}?",e.getMessage()); }
+ }
+
+
+ @Test
+ public void testErr3() {
+ CodeGen code = new CodeGen(
+"""
+val f = { int i, int j -> return i+j; };
+return f();
+""");
+ try { code.parse().opto().typeCheck(); fail(); }
+ catch( Exception e ) { assertEquals("Expecting 2 arguments, but found 0",e.getMessage()); }
+ }
+
+
+ @Test
+ public void testErr4() {
+ CodeGen code = new CodeGen(
+"""
+struct S {
+ {int} f = { -> x(); return 0; }; // Do not let fref x be a field
+};
+val x = { -> return 1; };
+!S? !s = null;
+for(;;) {
+ if (s) return s.x;
+}
+""");
+ try { code.parse().opto().typeCheck(); fail(); }
+ catch( Exception e ) { assertEquals("Accessing unknown field 'x' from '*S'",e.getMessage()); }
+ }
+
+ @Test
+ public void testErr5() {
+ CodeGen code = new CodeGen(
+"""
+val g = { ->
+ g();
+};
+return 0;
+""");
+ try { code.parse().opto().typeCheck(); fail(); }
+ catch( Exception e ) { assertEquals("No defined return type",e.getMessage()); }
+ }
+
+
+ // Mutual recursion. Fails without SCCP to lift the recursive return types.
+ @Ignore @Test
+ public void testFcnMutRec() {
+ CodeGen code = new CodeGen(
+"""
+val is_even = { int x -> x ? is_odd (x-1) : true ; };
+val is_odd = { int x -> x ? is_even(x-1) : false; };
+return is_even(arg);
+""");
+ code.parse().opto();
+ assertEquals("Stop[ return is_even( arg); return Phi(Region,Phi(Region,is_even( ((Parm_x(is_even,int,arg,Sub)-1)-1)),0),1); ]", code._stop.toString());
+ assertEquals("1", Eval2.eval(code, 0));
+ assertEquals("0", Eval2.eval(code, 1));
+ assertEquals("1", Eval2.eval(code, 2));
+ assertEquals("0", Eval2.eval(code, 3));
+ }
+
+ // Forward ref to 'x' means that
+ @Ignore @Test
+ public void testForwardRef1() {
+ CodeGen code = new CodeGen(
+"""
+struct S {
+ { int } f = { -> return x(); };
+};
+val x = { -> return 1; };
+!S? !s = null;
+for(;;) {
+ if (s) return s.f;
+}
+""");
+ code.parse().opto().typeCheck().GCM();
+ assertEquals("return 0;", code._stop.toString());
+ assertEquals("0", Eval2.eval(code, 0));
+ }
+
+ // Inline hidden called more than once
+ @Test
+ public void testInline() {
+ CodeGen code = new CodeGen(
+"""
+{int->int}?! i2i = {int i->return i;};
+{{int->int}->{int->int}}! f2f = {{int->int} f->return f;};
+val o = i2i;
+if (arg) i2i = null;
+if (i2i) return i2i(arg);
+return f2f(o)(1);
+""");
+ code.parse().opto().typeCheck().GCM().localSched();
+ assertEquals("Stop[ return Phi(Region,o( arg),o( 1)); return Parm_i(o,int,arg,1); ]", code._stop.toString());
+ assertEquals("1", Eval2.eval(code, 2));
+ }
+
+ @Test
+ public void testOperField() {
+ CodeGen code = new CodeGen(
+"""
+struct Person {
+ int coffee_count;
+};
+!Person !p = new Person;
+p.coffee_count += 1;
+return p.coffee_count;
+""");
+ code.parse().opto().typeCheck().GCM().localSched();
+ assertEquals("return 1;", code._stop.toString());
+ assertEquals("1", Eval2.eval(code, 2));
+ }
+
+ static final String CALL_MEMORY = """
+ struct S { int x; int y; };
+ val bump = { !S !s, int d -> int old=s.x; s.x=old+d; return old; };
+ !S !a = new S { x=10; y=7; };
+ !S !b = new S { x=20; y=9; };
+ !S !p=a; if (arg) p=b;
+ int before=p.x;
+ int old=bump(p,3);
+ int after=p.x;
+ bump(a,5);
+ return before*1000000+old*10000+after*100+a.x+a.y;
+ """;
+
+ @Test public void testCallMemory() {
+ var code = new CodeGen(CALL_MEMORY).parse().opto();
+ int[] calls={0};
+ code._stop.walk(n -> { if(n instanceof CallNode) calls[0]++; return null; });
+ assertEquals(2,calls[0]); // Keep real calls so this checks scheduling across them.
+ assertEquals("10101325",Eval2.eval(code,0));
+ assertEquals("20202322",Eval2.eval(code,1));
+ code._stop.walk(n -> {
+ if(n instanceof CallNode call) {
+ assertEquals(5,call.nIns()); // No scheduling edges may become extra arguments.
+ assertTrue(call.fptr()._type instanceof TypeFunPtr);
+ }
+ return null;
+ });
+ }
+
+ static final String RECURSIVE_MEMORY = """
+ struct S { int x; };
+ val rec = { !S !s, int n ->
+ if (n==0) return s.x;
+ int before=s.x;
+ s.x=before+1;
+ return before+rec(s,n-1);
+ };
+ !S !s=new S { x=10; };
+ int value=rec(s,arg);
+ return value*100+s.x;
+ """;
+
+ @Test public void testRecursiveMemory() {
+ var code = new CodeGen(RECURSIVE_MEMORY).parse().opto();
+ for(int n=0; n<7; n++)
+ assertEquals(Long.toString((10L*(n+1)+n*(n+1)/2)*100+10+n),Eval2.eval(code,n));
+ }
+
+ static final String INLINE_MEMORY = """
+ struct S { int x; int y; };
+ val make = { !S s ->
+ S t = new S { x=s.x+1; y=3; };
+ s.y=9;
+ return t;
+ };
+ !S !a = new S { x=arg+40; y=7; };
+ S t=make(a);
+ return a.x*10000+a.y*100+t.x+t.y;
+ """;
+
+ @Test public void testInlineAllocationMemory() {
+ var code = new CodeGen(INLINE_MEMORY).parse().opto();
+ assertNull(code._stop.walk(n -> n instanceof CallNode ? n : null));
+ assertEquals("400944",Eval2.eval(code,0));
+ assertEquals("420946",Eval2.eval(code,2));
+ }
+}
diff --git a/src/test/java/com/seaofnodes/simple/CompoundAssignmentTest.java b/src/test/java/com/seaofnodes/simple/CompoundAssignmentTest.java
index 0fa4283b..860827d7 100644
--- a/src/test/java/com/seaofnodes/simple/CompoundAssignmentTest.java
+++ b/src/test/java/com/seaofnodes/simple/CompoundAssignmentTest.java
@@ -1,6 +1,6 @@
package com.seaofnodes.simple;
-import com.seaofnodes.simple.evaluator.Evaluator;
+
import org.junit.Test;
import static org.junit.Assert.*;
@@ -64,14 +64,31 @@ public class CompoundAssignmentTest {
check(src, 0, 0);
fail("Accepted invalid assignment: " + src);
} catch (RuntimeException e) {
- assertEquals("Must report a language error", RuntimeException.class, e.getClass());
+ assertTrue("Must report a language error: " + e, e instanceof Parser.ParseException);
assertNotNull(e.getMessage());
assertFalse("Must report a language error: " + e, e.getMessage().contains("Not yet implemented"));
}
}
+ @Test public void testFields() {
+ for (String op : OPS) {
+ long expected = apply(op, -8, 3);
+ check("struct S { int x; }; !S !s=new S; s.x=arg; int r=(s.x " +
+ op + " 3); return s.x*10+r;", -8, expected*11);
+ }
+ }
+
+ @Test public void testArrayAddressAndRhsOnce() {
+ for (String op : OPS) {
+ long expected = apply(op, 5, 1);
+ check("int[] !a=new int[2]; a[0]=arg; int i=0; int count=0; " +
+ "int r=(a[i++] " + op + " (count=count+1)); " +
+ "return i*1000+count*100+a[0]*10+r;", 5, 1100+expected*11);
+ }
+ }
+
private static void check(String src, long arg, long expected) {
- var stop = new Parser(src).parse().iterate();
- assertEquals(src, Long.valueOf(expected), Evaluator.evaluate(stop, arg));
+ var code = new CodeGen(src).parse().opto().typeCheck();
+ assertEquals(src, Long.toString(expected), Eval2.eval(code, arg));
}
}
diff --git a/src/test/java/com/seaofnodes/simple/Eval2.java b/src/test/java/com/seaofnodes/simple/Eval2.java
new file mode 100644
index 00000000..3f337e86
--- /dev/null
+++ b/src/test/java/com/seaofnodes/simple/Eval2.java
@@ -0,0 +1,454 @@
+package com.seaofnodes.simple;
+
+import com.seaofnodes.simple.type.*;
+import com.seaofnodes.simple.node.*;
+import java.util.*;
+
+public abstract class Eval2 {
+
+ // A mapping from Node ID to evaluation data Object.
+ // Data Objsts are a boxed Long or Double; or an Object[] of fields, which
+ // themselves are just more Objects.
+ private static class Frame {
+ private static int UID=1;
+
+ private final IdentityHashMap<Node,Object> _data;
+ private Frame _prior; // Prior frame in this sequence, means when making a new frame we can find old stuff
+ private int _refcnt; // TODO: Use this in a sentence (free/recycle unused stack frames)
+ final int _uid = UID++; // Debugging aid
+ Frame(Frame prior) {
+ _prior = prior;
+ if( prior!=null ) prior._refcnt++;
+ _data = new IdentityHashMap<>();
+ _refcnt = 1;
+ }
+
+ // Dec ref count
+ void dec() {
+ assert _refcnt>0;
+ if( --_refcnt == 0 ) {
+ Frame prior = _prior;
+ _prior = null;
+ _data.clear();
+ // TODO: FREE LIST?
+ if( prior!=null )
+ prior.dec();
+ }
+ }
+
+ // Put a mapping from Node->Object
+ Node put(Node n, Object d) {
+ assert d!=null;
+ return put0(n,d);
+ }
+ // Put a mapping from Node->Object?
+ Node put0(Node n, Object d) {
+ assert _refcnt>0;
+ _data.put(n,d);
+ return n;
+ }
+ // Get a mapped Node, perhaps using the prior stack frame crawl
+ Object get(Node n) {
+ assert _refcnt>0;
+ Object d = _data.get(n);
+ return d != null ? d
+ : _prior == null ? null
+ : _prior.get(n);
+ }
+
+ // Short debugging print
+ public String p() {
+ return "#"+_uid + (_prior==null ? "" : " >> " + _prior.p());
+ }
+ // Long debugging print
+ @Override public String toString() {
+ String s = "";
+ if( _prior != null ) s+= _prior+" << ";
+ s += "#"+_uid+"[ ";
+ for( Node n : _data.keySet() )
+ s += n + ":" + _data.get(n) + ",";
+ s += "]";
+
+ return s;
+ }
+ }
+
+ // Classic Closure; an environment (stack of frames) and an execution point
+ private static class Closure {
+ // Where to return too; either a CallEnd or a Function
+ final CFGNode _cc;
+
+ // Stack frame at the execution point. Includes Closures which
+ // recursively include other stack frames
+ private Frame _frame;
+
+ Closure(CFGNode cc, Frame frame) {
+ _cc = cc; // One of Fun, CallEnd or Stop (null)
+ _frame = frame;
+ assert _frame._refcnt >=0;
+ _frame._refcnt++;
+ }
+
+ FunNode fun() { return (FunNode)_cc; }
+ CallEndNode cend() { return (CallEndNode)_cc; }
+ boolean isStop() { return _cc instanceof StopNode; } // or Stop
+
+ //
+ void pushFrame() {
+ _frame = new Frame(_frame);
+ _frame._refcnt++;
+ }
+
+ @Override public String toString() {
+ return _cc.toString();
+ }
+ }
+
+ // CodeGen has the linker tables
+ public static CodeGen CODE;
+
+ // Current active Frame, to avoid having to pass it everywhere
+ public static Frame F;
+
+ public static String eval( CodeGen code, long arg ) { return eval(code,arg,1000); }
+ public static String eval( CodeGen code, long arg, int timeout ) {
+ SB trace = null; // new SB(); // TRACE, set to null for off, new SB() for on
+ // Force local scheduling phase
+ if( code._phase.ordinal() < CodeGen.Phase.TypeCheck .ordinal() ) code.typeCheck();
+ if( code._phase.ordinal() < CodeGen.Phase.Schedule .ordinal() ) code.GCM();
+ if( code._phase.ordinal() < CodeGen.Phase.LocalSched.ordinal() ) code.localSched();
+ // Set global, so don't have to pass everywhere
+ CODE = code;
+
+ // Timer for when we run too long. Ticks once per backedge or function call
+ int loopCnt = 0;
+
+ // Current value for each Node; boxed Long or Double; or an Object[] of
+ // fields, which themselves are just more Objects.
+ F = new Frame(null);
+
+ // Start at the START
+ CFGNode BB = code._start, prior = null;
+ // Return from main hits Stop
+ F.put(BB,new Closure(code._stop,F));
+
+
+ // ------------
+ // Evaluate until exit or timeout. Each outer loop step computes
+ // all data nodes under some new Control.
+ while( true ) {
+ assert BB!=null;
+ traceCtrl(BB,trace);
+ if( trace!=null ) System.out.println(F.p());
+
+ // Parallel assign Phis
+ int i = BB instanceof RegionNode r
+ ? parallelAssignPhis(r,prior,arg,trace)
+ : 0;
+
+ // Compute the data nodes until BB control
+ for( ; i < BB.nOuts(); i++ )
+ if( !(BB.out(i) instanceof CFGNode) )
+ step(BB.out(i), trace);
+
+ // Find the next control target
+ prior = BB;
+ BB = BB.uctrl(); // Next unique control target
+ switch( prior ) {
+ case StartNode start: F = new Frame(F); break; // Frame for the call to main, as-if Called
+ case CallNode call : BB = call(call); break;
+ case IfNode iff : Object p = val(iff.pred()); BB = iff.cproj( p==null || (p instanceof Long x && x==0L) ? 1 : 0); break;
+ case ReturnNode ret : if( clj(ret.rpc()).isStop() ) return exit(ret); else BB = ret(ret); break;
+ case FunNode fun : if( loopCnt++ > timeout ) return null; break; // Timeout
+ case LoopNode loop : if( loopCnt++ > timeout ) return null; break; // Timeout
+ case CallEndNode cend: break;
+ case CProjNode cproj: break;
+ case RegionNode r : break;
+ default: throw Utils.TODO();
+ }
+ assert !BB.isDead();
+ }
+ }
+
+
+ // Phi cache; size is limited to number of Phis at a merge point
+ private static final Object[] PHICACHE = new Object[256];
+ static int parallelAssignPhis(RegionNode r, CFGNode prior, long arg, SB trace) {
+
+ // Compute input path on Phis for this Region
+ int path = r._inputs.find( prior );
+ // Parameters read from prior frame, Phis from local frame
+ Frame frame = (r instanceof FunNode ? F._prior : F);
+ boolean isMain = r instanceof FunNode fun && fun.sig().isa(TypeFunPtr.MAIN);
+
+ // Parallel assign Phis. First parallel read and cache
+ int i;
+ for( i = 0; i < r.nOuts(); i++ ) {
+ if( !(r.out(i) instanceof PhiNode phi) ) break;
+ if( isMain && phi instanceof ParmNode parm && parm._idx==2 )
+ PHICACHE[i] = arg; // Reading the initial arguments to main()
+ else {
+ Node n = phi instanceof ParmNode parm
+ // RPC reads the Call directly;
+ // Parms may not be linked, so read call args directly
+ ? (parm._idx==0 ? prior : prior.in(parm._idx))
+ // Phis read from path input
+ : phi.in(path);
+ PHICACHE[i] = frame.get(n);
+ }
+ }
+ // Parallel assign; might assign before read, so read from cache
+ for( int j=0; j < i; j++ )
+ traceData(F.put0(r.out(j),PHICACHE[j]),trace);
+ // Return point in basic block past last Phi
+ return i;
+ }
+
+
+ // Make a call.
+ private static CFGNode call( CallNode call ) {
+ // Set up the Return PC and return frame (which is just the current frame).
+ // Really making a Continuation, but it's just a Closure
+ Closure cont = new Closure(call.cend(),F);
+ // Set the return continuation into the current frame RPC
+ F.put(call, cont );
+ // Next Frame to use
+ F = new Frame(F);
+ // Target function and environment
+ return CODE.link(tfp(call.fptr()));
+ }
+
+ private static CFGNode ret( ReturnNode ret ) {
+ // Fetch return expression value and continuation from current frame
+ Object rez = val(ret.expr());
+ Closure cont = clj(ret.rpc());
+ // Lower Frame reference count; might delete frame
+ F.dec(); // Lower ref count
+ // Install replacement Frame; set return result over the CallEnd
+ F = cont._frame;
+ F.put0(cont._cc,rez); // Set return value into CallEnd
+ return cont._cc; // Return CallEnd as the new control
+ }
+
+ private static String exit( ReturnNode ret ) {
+ return prettyPrint(ret.expr()._type,val(ret.expr()));
+ }
+
+ // Take a worklist step: one data op from the current Control is updated.
+ private static void step(Node n, SB trace) {
+ if( n instanceof PhiNode ) return;
+ // Compute new value
+ F.put0(n,compute(n));
+ traceData(n,trace);
+ // Also do any following projections, which are not in the local schedule otherwise
+ if( n instanceof MultiNode )
+ for( Node use : n._outputs )
+ step(use,trace);
+ }
+
+ // From here down shamelessly copied from Evaluator, written by @Xmilia
+ private static Object compute( Node n ) {
+ return switch( n ) {
+ case AddFNode adf -> d(adf.in(1)) + d(adf.in(2));
+ case AddNode add -> x(add.in(1)) + x(add.in(2));
+ case AndNode and -> x(and.in(1)) & x(and.in(2));
+ case BoolNode.EQF eqf -> d(eqf.in(1)) == d(eqf.in(2)) ? 1L : 0L;
+ case BoolNode.LEF lef -> d(lef.in(1)) <= d(lef.in(2)) ? 1L : 0L;
+ case BoolNode.LTF ltf -> d(ltf.in(1)) < d(ltf.in(2)) ? 1L : 0L;
+ case BoolNode.EQ eq -> Objects.equals(val(eq.in(1)), val(eq.in(2))) ? 1L : 0L; // Bool EQ supports pointers, nil, and integers
+ case BoolNode.LE le -> x(le .in(1)) <= x(le .in(2)) ? 1L : 0L;
+ case BoolNode.LT lt -> x(lt .in(1)) < x(lt .in(2)) ? 1L : 0L;
+ case CastNode cast -> val(cast.in(1));
+ case ConstantNode con -> con(con._con);
+ case DivFNode dvf -> d(dvf.in(2))==0 ? 0D : d(dvf.in(1)) / d(dvf.in(2));
+ case DivNode div -> x(div.in(2))==0 ? 0L : x(div.in(1)) / x(div.in(2));
+ case LoadNode ld -> load(ld);
+ case MinusFNode mnf -> - d(mnf.in(1));
+ case MinusNode sub -> - x(sub.in(1));
+ case MulFNode mlf -> d(mlf.in(1)) * d(mlf.in(2));
+ case MulNode mul -> x(mul.in(1)) * x(mul.in(2));
+ case NewNode alloc-> alloc(alloc);
+ case NotNode not -> not(not);
+ case OrNode or -> x(or .in(1)) | x(or .in(2));
+ case ProjNode proj -> proj._type instanceof TypeMem ? "$mem" : val(proj.in(0));
+ case ReadOnlyNode read -> val(read.in(1));
+ case SarNode sar -> x(sar.in(1)) >> x(sar.in(2));
+ case MemMergeNode merge-> "$mem";
+ case ShlNode shl -> x(shl.in(1)) << x(shl.in(2));
+ case ShrNode shr -> x(shr.in(1)) >>>x(shr.in(2));
+ case StoreNode st -> store(st);
+ case SubNode sub -> x(sub.in(1)) - x(sub.in(2));
+ case SubFNode sbf -> d(sbf.in(1)) - d(sbf.in(2));
+ case RoundF32Node rnd -> (double)(float)d(rnd.in(1));
+ case ToIntegerNode cvt -> (long)d(cvt.in(1));
+ case ToFloatNode toflt-> (double)x(toflt.in(1));
+ case XorNode xor -> x(xor.in(1)) ^ x(xor.in(2));
+ default -> throw Utils.TODO();
+ };
+ }
+
+ private static Object not( NotNode not ) {
+ Object n = val(not.in(1));
+ return ( n==null || (n instanceof Double D && D==0.0) || n instanceof Long L && L==0 )
+ ? 1L : 0L;
+ }
+
+ // Fetch without unboxing, searching up-Frame
+ static Object val( Node n ) { return F.get(n); }
+ // Fetch and unbox as primitive long
+ static long x( Node n ) { Object d = F.get(n); return d==null ? 0 : (Long) F.get(n); }
+ // Fetch and unbox as primitive double
+ static double d( Node n ) { Object d = F.get(n); return d==null ? 0 : (Double)F.get(n); }
+ // Fetch and unbox a function constant
+ static TypeFunPtr tfp(Node n) { return (TypeFunPtr)F.get(n); }
+ // Fetch and unbox a closure
+ static Closure clj(Node n) { return (Closure)F.get(n); }
+
+ // Java box ints and floats. Other things can just be null or some informative string
+ private static Object con( Type t ) {
+ return switch ( t ) {
+ case TypeInteger i -> i.isConstant() ? (Long )i.value() : "INT";
+ case TypeFloat f -> f.isConstant() ? (Double)f.value() : "FLT";
+ case TypeMemPtr tmp -> tmp;
+ case TypeFunPtr tfp -> tfp;
+ case TypeMem mem -> "MEM";
+ default -> null;
+ };
+ }
+
+ // Convert array size to array element count
+ private static int offToIdx( long off, TypeStruct t) {
+ off -= t.aryBase();
+ int scale = t.aryScale();
+ long mask = (1L << scale)-1;
+ assert (off & mask) == 0;
+ return (int)(off>>scale);
+ }
+
+ // Builds and returns a pointer Object
+ private static Object alloc(NewNode alloc) {
+ TypeStruct type = alloc._ptr._obj;
+ if( type.isAry() ) {
+ long sz = (Long)val(alloc.size());
+ long x = offToIdx(sz, type);
+ int n = (int)x;
+ if( n!=x || n<0 )
+ throw new NegativeArraySizeException(""+n);
+ Object[] ary = new Object[n]; // Array body
+ var elem = type._fields[1]._type;
+ if (elem instanceof TypeInteger) {
+ Arrays.fill( ary, 0L );
+ } else if (elem instanceof TypeFloat) {
+ Arrays.fill( ary, 0D );
+ } else {
+ assert elem instanceof TypeMemPtr || elem instanceof TypeFunPtr;
+ }
+ return ary;
+ }
+
+ int num = type._fields.length;
+ Object[] ptr = new Object[num];
+ for( int i=0; i<num; i++ )
+ ptr[i] = val(alloc.in(3+i));
+ return ptr;
+ }
+
+ private static Object load( LoadNode ld ) {
+ TypeMemPtr tmp = (TypeMemPtr)ld.ptr()._type;
+ Object[] fs = (Object[])val(ld.ptr());
+ if( ld._name.equals("#") )
+ return (long)fs.length;
+ int idx = tmp._obj.isAry()
+ ? offToIdx(x(ld.off()),tmp._obj)
+ : tmp._obj.find(ld._name);
+ return fs[idx];
+ }
+
+ private static Object store( StoreNode st ) {
+ TypeMemPtr tmp = (TypeMemPtr)st.ptr()._type;
+ Object[] fs = (Object[])val(st.ptr());
+ int idx = tmp._obj.isAry()
+ ? offToIdx(x(st.off()),tmp._obj)
+ : tmp._obj.find(st._name);
+ Object val = val(st.val());
+ fs[idx] = val;
+ return "$mem";
+ }
+
+
+ // ------------------------------------------------------------------------
+ private static final IdentityHashMap<Object,Object> VISIT = new IdentityHashMap<>();
+
+
+ static void traceCtrl( CFGNode BB, SB sb ) {
+ if( sb==null ) return;
+ IRPrinter.printLine(BB,sb.p("--- "));
+ System.out.print(sb);
+ sb.clear();
+ }
+ static void traceData( Node n, SB sb ) {
+ if( sb==null ) return;
+ IRPrinter.printLine(n,sb).unchar();
+ _print( n._type, F.get(n), sb.p('\t'), VISIT );
+ System.out.println(sb);
+ sb.clear();
+ VISIT.clear();
+ }
+
+ // Use type to print x as a string. Uses a new VISIT table so the debugger
+ // doesn't try to reuse VISIT if stopping mid-print. The trace code reuses
+ // VISIT endlessly for some minor speed hope
+ static String prettyPrint( Type t, Object x ) { return _print(t,x,new SB(), new IdentityHashMap<>()).toString(); }
+ static SB _print( Type t, Object x, SB sb, IdentityHashMap<Object,Object> visit ) {
+ if( x instanceof String s ) return sb.p(s);
+ if( x == null ) return sb.p("null");
+ return switch( t ) {
+ case TypeInteger i -> sb.p( (Long)x);
+ case TypeFloat f -> sb.p((Double)x);
+ case TypeMemPtr tmp -> {
+ if( visit.containsKey(x) ) yield sb.p("$cyclic");
+ visit.put(x,x);
+ // Since never can close the type cycle, without cyclic types, have
+ // to handle FRefs even here
+ if( tmp.isFRef() )
+ tmp = tmp.makeFrom(((TypeMemPtr)Parser.TYPES.get(tmp._obj._name))._obj);
+
+ Object[] xs = (Object[])x; // Array of fields
+ if( tmp._obj.isAry() ) {
+ Type elem = tmp._obj._fields[1]._type;
+ if( elem == TypeInteger.U8 ) {
+ // Shortcut u8[] as a String
+ for( Object o : xs )
+ sb.p((char)(long)(Long)o);
+ } else {
+ // Array of elements
+ elem.print(sb).p("[ ");
+ for( Object o : xs )
+ _print( elem, o, sb, visit ).p( "," );
+ sb.unchar().p("]");
+ }
+ } else {
+ sb.p(tmp._obj._name).p("{");
+ Field[] flds = tmp._obj._fields;
+ for( int i=0; i<flds.length; i++ )
+ _print( flds[i]._type,xs[i], sb.p(flds[i]._fname).p("="), visit ).p(",");
+ sb.unchar().p("}");
+ }
+ yield sb;
+ }
+ case TypeFunPtr tfp -> sb.p(x.toString());
+ case TypeRPC rpc -> sb.p(x.toString());
+ case TypeMem mem -> sb.p("$mem");
+ case TypeTuple tt -> {
+ if( tt._types.length>1 && tt._types[0] instanceof TypeMemPtr )
+ // Assume a NewNode
+ yield _print( tt._types[0], x, sb, visit );
+ throw Utils.TODO();
+ }
+ case Type tt -> {
+ if( tt == Type.NIL ) yield sb.p("null");
+ throw Utils.TODO();
+ }
+ };
+ }
+}
diff --git a/src/test/java/com/seaofnodes/simple/FuzzerWrap.java b/src/test/java/com/seaofnodes/simple/FuzzerWrap.java
index 2c98f405..143828e6 100644
--- a/src/test/java/com/seaofnodes/simple/FuzzerWrap.java
+++ b/src/test/java/com/seaofnodes/simple/FuzzerWrap.java
@@ -7,9 +7,10 @@ import org.junit.Test;
import static org.junit.Assert.assertTrue;
/**
- * Normal tests run chapter-local regression seeds. Open failures and exploratory
- * fuzzing are opt-in (run directly in the IDE or temporarily remove Ignore).
- * Seeds depend on this chapter's generator; do not copy them between chapters.
+ * Normal tests run only this chapter's fixed regression seeds. Open failures
+ * and exploratory fuzzing are opt-in: run their methods directly in the IDE,
+ * or temporarily remove the relevant Ignore annotation when investigating.
+ * Seeds belong to this chapter's generator; do not copy them between chapters.
*/
public class FuzzerWrap {
@@ -43,7 +44,7 @@ public class FuzzerWrap {
Random R = new Random(System.currentTimeMillis());
var fuzzer = new Fuzzer();
for (int i=0; i<100; i++)
- fuzzer.fuzzPeeps(R.nextLong());
+ fuzzer.fuzzPeeps( R.nextLong());
assertTrue(fuzzer.noExceptions());
}
diff --git a/src/test/java/com/seaofnodes/simple/MergeSortTest.java b/src/test/java/com/seaofnodes/simple/MergeSortTest.java
new file mode 100644
index 00000000..a352530f
--- /dev/null
+++ b/src/test/java/com/seaofnodes/simple/MergeSortTest.java
@@ -0,0 +1,65 @@
+package com.seaofnodes.simple;
+
+import org.junit.Test;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
+
+public class MergeSortTest {
+
+ @Test
+ public void testMergeSort() {
+ CodeGen code = new CodeGen(
+"""
+// based on the top-down version from https://en.wikipedia.org/wiki/Merge_sort
+
+val merge_sort = { int[] !a, int[] !b, int n ->
+ copy_array(a, 0, n, b);
+ split_merge(a, 0, n, b);
+};
+
+val split_merge = { int[] !b, int begin, int end, int[] a ->
+ if (end - begin <= 1)
+ return 0;
+ int middle = (end + begin) / 2;
+ split_merge(a, begin, middle, b);
+ split_merge(a, middle, end, b);
+ merge(b, begin, middle, end, a);
+ return 0;
+};
+
+val merge = { int[] !b, int begin, int middle, int end, int[] a ->
+ int i = begin, j = middle;
+
+ for (int k = begin; k < end; k++) {
+ // && and ||
+ bool cond = false;
+ if (i < middle) {
+ if (j >= end) cond = true;
+ else if (a[i] <= a[j]) cond = true;
+ }
+ if (cond) b[k] = a[i++];
+ else b[k] = a[j++];
+ }
+};
+
+val copy_array = { int[] !a, int begin, int end, int[] b ->
+ for (int k = begin; k < end; k++)
+ b[k] = a[k];
+};
+
+int[] !a = new int[arg];
+int[] !b = new int[a#];
+
+for (int i = 0; i < a#; i++)
+ a[i] = a# - i;
+
+merge_sort(a, b, a#);
+
+return a;
+""");
+ code.parse().opto();
+ assertEquals("Stop[ return [int]; return 0; ]", code._stop.toString());
+ assertEquals("int[ 1,2,3,4,5,6,7,8,9,10,11]", Eval2.eval(code, 11));
+ }
+
+}
diff --git a/src/test/java/com/seaofnodes/simple/MutabilityTest.java b/src/test/java/com/seaofnodes/simple/MutabilityTest.java
index 8f99a059..0861424f 100644
--- a/src/test/java/com/seaofnodes/simple/MutabilityTest.java
+++ b/src/test/java/com/seaofnodes/simple/MutabilityTest.java
@@ -5,16 +5,16 @@ import static org.junit.Assert.*;
public class MutabilityTest {
private static void ok(String src, String result) {
- var stop = new Parser(src).parse().iterate();
- assertEquals(result,com.seaofnodes.simple.evaluator.Evaluator.evaluate(stop,0).toString());
+ var code = new CodeGen(src).parse().opto().typeCheck();
+ assertEquals(result,Eval2.eval(code,0));
}
private static void bad(String src) {
try {
- new Parser(src).parse().iterate();
+ new CodeGen(src).parse().opto().typeCheck();
} catch( RuntimeException expected ) {
String msg = expected.getMessage();
assertTrue("Expected a permission error, got: "+expected,
- msg!=null && (msg.contains("final") || msg.contains("not of declared type") || msg.contains("Cannot store")));
+ msg!=null && (msg.contains("final") || msg.contains("not of declared type") || msg.contains("Cannot store") || msg.contains("Argument #")));
return;
}
fail("Accepted forbidden write: "+src);
@@ -43,6 +43,15 @@ public class MutabilityTest {
bad("struct P { int x; }; P p=new P; var q=p; q.x=7; return 0;");
}
+ @Test public void testParameterPermissions() {
+ ok("struct P { int x; }; val f={ !P p -> p.x=7; return p.x; }; return f(new P);", "7");
+ ok("val f={ int ~x -> return x; }; return f(7);", "7");
+ bad("val f={ int ~x -> x=7; return x; }; return f(3);");
+ bad("struct P { int x; }; val f={ P p -> p.x=7; return p.x; }; return f(new P);");
+ bad("struct P { int x; }; val f={ !P p -> p.x=7; return p.x; }; P p=new P; return f(p);");
+ bad("struct P { int x; }; val f={ P?[] a -> return a#; }; !P?[] a=new !P?[1]; return f(a);");
+ }
+
@Test public void testConstructorScope() {
ok("struct P { int ~x; }; P p=new P{if(arg) x=3; else x=7;}; return p.x;", "7");
bad("int ~outer=1; struct P { int x; }; P p=new P{outer=7;}; return outer;");
diff --git a/src/test/java/com/seaofnodes/simple/SchedulerTest.java b/src/test/java/com/seaofnodes/simple/SchedulerTest.java
index d8a22fd3..d29166a7 100644
--- a/src/test/java/com/seaofnodes/simple/SchedulerTest.java
+++ b/src/test/java/com/seaofnodes/simple/SchedulerTest.java
@@ -20,7 +20,7 @@ public class SchedulerTest {
@Test
@Ignore
public void testJig() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct S {
int f;
}
@@ -30,14 +30,14 @@ int i=v.f;
if (arg) v.f=1;
return i;
""");
- StopNode stop = parser.parse();//.iterate();
- var eval = new Evaluator(stop);
+ code.parse();//.opto();
+ var eval = new Evaluator(code._stop);
assertEquals(2L, eval.evaluate(1, 10));
}
@Test
public void testStoreInIf() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct S {
int f;
};
@@ -45,15 +45,15 @@ struct S {
if(arg) v0.f=1;
return v0;
""");
- StopNode stop = parser.parse().iterate();
- var eval = new Evaluator(stop);
+ code.parse().opto();
+ var eval = new Evaluator(code._stop);
assertObj(eval.evaluate(0, 10), "S", 0L);
assertObj(eval.evaluate(1, 10), "S", 1L);
}
@Test
public void testStoreInIf2() {
- Parser parser = new Parser("""
+ CodeGen code = new CodeGen("""
struct S {
int f;
};
@@ -64,8 +64,8 @@ i=v.f;
if (arg) v.f=1;
return i;
""");
- StopNode stop = parser.parse().iterate();
- var eval = new Evaluator(stop);
+ code.parse().opto();
+ var eval = new Evaluator(code._stop);
assertEquals(2L, eval.evaluate(0, 10));
assertEquals(2L, eval.evaluate(1, 10));
}
diff --git a/src/test/java/com/seaofnodes/simple/TypeTest.java b/src/test/java/com/seaofnodes/simple/TypeTest.java
index 3fac1641..dee033bc 100644
--- a/src/test/java/com/seaofnodes/simple/TypeTest.java
+++ b/src/test/java/com/seaofnodes/simple/TypeTest.java
@@ -2,9 +2,7 @@ package com.seaofnodes.simple;
import com.seaofnodes.simple.type.*;
import org.junit.Assert;
-import org.junit.Ignore;
import org.junit.Test;
-import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertSame;
public class TypeTest {
@@ -12,19 +10,23 @@ public class TypeTest {
// Test basic properties and GLB
@Test
public void testTypeAdHoc() {
+ Assert.assertEquals( Type.BOTTOM, TypeInteger.TRUE.meet(TypeNil.NIL) );
+ Assert.assertEquals( Type.BOTTOM, TypeInteger.TOP.meet(TypeNil.NIL) );
+
+
TypeStruct s1 = TypeStruct.make("s1", new Field[]{
Field.make("a", TypeInteger.BOT,-1, false),
Field.make("b", TypeInteger.BOT,-2, false) });
TypeStruct s2 = TypeStruct.make("s2", new Field[]{
Field.make("a", TypeInteger.BOT,-3, false),
Field.make("b", TypeInteger.BOT,-4, false) });
- Assert.assertEquals(s1, s1.glb());
+ Assert.assertEquals(s1.makeRO(), s1.glb());
Assert.assertNotEquals(s1, s1.dual());
Assert.assertEquals(s1.makeRO(), s1.dual().glb());
- TypeMem m1 = TypeMem.make(1,TypeInteger.ZERO);
+ TypeMem m1 = TypeMem.make(1,TypeNil.NIL);
TypeMem m2 = TypeMem.make(2,TypeInteger.U16);
- TypeMem m3 = TypeMem.make(3,TypeFloat.BOT);
+ TypeMem m3 = TypeMem.make(3,TypeFloat.F64);
TypeMem m4 = TypeMem.make(4,TypeInteger.BOT);
Assert.assertNotEquals(m1, m2);
@@ -32,12 +34,12 @@ public class TypeTest {
Assert.assertNotEquals(m3, m4);
Assert.assertEquals(TypeStruct.BOT, s1.meet(s2));
- Assert.assertEquals(TypeMem.make(-1,TypeInteger.U16), m1.meet(m2));
- Assert.assertEquals(TypeMem .BOT, m2.meet(m3));
+ Assert.assertEquals(TypeMem .BOT, m1.meet(m2));
+ Assert.assertEquals(TypeMem.make(0,Type.BOTTOM), m1.meet(m3));
Assert.assertEquals(TypeMem .BOT, m3.meet(m4));
- Assert.assertEquals(TypeMem.make(1,TypeInteger.BOT), m1.glb());
- Assert.assertEquals(TypeMem.make(1,TypeInteger.ZERO), m1.dual());
+ Assert.assertEquals(TypeMem.make(1,Type.BOTTOM), m1.glb());
+ Assert.assertEquals(TypeMem.make(1,Type.XNIL), m1.dual());
Assert.assertEquals(m4.dual(), m4.glb().dual());
TypeMemPtr ptr1 = TypeMemPtr.make(s1);
@@ -45,34 +47,34 @@ public class TypeTest {
TypeMemPtr ptr2 = TypeMemPtr.make(s2);
Assert.assertEquals(s2, ptr2._obj);
- TypeMemPtr ptr1nil = TypeMemPtr.make(s1, true);
+ TypeMemPtr ptr1nil = TypeMemPtr.makeNullable(s1);
Assert.assertEquals(s1, ptr1nil._obj);
- Assert.assertTrue(ptr1nil._nil);
- Assert.assertFalse(ptr1nil._obj==null);
- TypeMemPtr ptr2nil = TypeMemPtr.make(s2, true);
+ Assert.assertTrue( ptr1nil.nullable() );
+ Assert.assertNotNull( ptr1nil._obj );
+ TypeMemPtr ptr2nil = TypeMemPtr.makeNullable( s2);
Assert.assertEquals(s2, ptr2nil._obj);
Assert.assertNotEquals(ptr1, ptr2);
Assert.assertNotEquals(ptr1, ptr1.glb());
- Assert.assertEquals(ptr1nil.withAccess(true), ptr1.glb());
+ Assert.assertEquals(ptr1nil.makeFrom(s1.glb()).makeRO(), ptr1.glb());
Assert.assertEquals(ptr1, ptr1.dual().dual());
Assert.assertEquals(ptr1.glb().makeFrom(s1.dual().glb()), ptr1.dual().glb());
- Assert.assertEquals(TypeMemPtr.make(TypeStruct.BOT,true).withAccess(false), ptr1.meet(ptr2nil));
- Assert.assertEquals(ptr1nil, ptr1.meet(TypeMemPtr.NULLPTR));
+ Assert.assertEquals(TypeMemPtr.makeNullable(TypeStruct.BOT).withAccess(false), ptr1.meet(ptr2nil));
+ Assert.assertEquals(ptr1nil, ptr1.meet(TypeNil.NIL));
TypeMemPtr TOP = TypeMemPtr.TOP;
- TypeMemPtr BOT = TypeMemPtr.make(TypeStruct.BOT,true );
- TypeMemPtr PTR = TypeMemPtr.make(TypeStruct.BOT,false);
- TypeMemPtr NULL = TypeMemPtr.NULLPTR;
+ TypeMemPtr BOT = TypeMemPtr.makeNullable(TypeStruct.BOT);
+ TypeMemPtr PTR = TypeMemPtr.make(TypeStruct.BOT);
+ Type NULL = TypeNil.NIL;
Type PTR_meet_NULL = NULL.meet(PTR);
Assert.assertEquals(BOT, PTR_meet_NULL);
Type ptr1_meet_ptr2 = ptr1.meet(ptr2);
Assert.assertEquals(PTR.withAccess(false), ptr1_meet_ptr2);
Type NULL_join_ptr1 = NULL.join(ptr1);
- Assert.assertEquals(TOP, NULL_join_ptr1);
+ Assert.assertEquals(TypePtr.XNPTR, NULL_join_ptr1);
Type NULL_join_PTR = PTR.join(NULL);
- Assert.assertEquals(TOP, NULL_join_PTR);
+ Assert.assertEquals(TypePtr.XNPTR, NULL_join_PTR);
Type ptr1_dual = ptr1.dual();
Type nullableptr1_dual = ptr1nil.dual();
}
@@ -153,5 +155,4 @@ public class TypeTest {
assertSame(TypeStruct.S1,d1);
}
-
}
diff --git a/src/test/java/com/seaofnodes/simple/evaluator/Evaluator.java b/src/test/java/com/seaofnodes/simple/evaluator/Evaluator.java
index 0721402f..7dbc551e 100644
--- a/src/test/java/com/seaofnodes/simple/evaluator/Evaluator.java
+++ b/src/test/java/com/seaofnodes/simple/evaluator/Evaluator.java
@@ -4,8 +4,6 @@ import com.seaofnodes.simple.Utils;
import com.seaofnodes.simple.node.*;
import com.seaofnodes.simple.type.*;
-import java.lang.invoke.MethodHandle;
-import java.lang.invoke.MethodHandles;
import java.util.*;
public class Evaluator {
@@ -207,7 +205,8 @@ public class Evaluator {
for (int i=0; i<num; i++)
body[i] = val(alloc.in(3+i));
}
- return new Object[]{new Obj(type,body),MEMORY};
+ return new Object[]{new Obj(type,body),null};
+
}
private Object load(LoadNode load) {
@@ -259,14 +258,14 @@ public class Evaluator {
private double vald(Node node) {
var v = val(node);
if (v instanceof Number n) return n.doubleValue();
+ if( v == null ) return 0;
throw new AssertionError("Not a double " + v);
}
private Object cons(ConstantNode cons) {
var type = cons.compute();
- if (type instanceof TypeInteger i) return i.value();
+ if (type instanceof TypeInteger i) return i.isConstant() ? i.value() : Integer.MAX_VALUE;
if (type instanceof TypeFloat i) return i.value();
- assert type instanceof TypeMemPtr;
return null;
}
@@ -302,11 +301,12 @@ public class Evaluator {
case ToFloatNode cast -> (double)vall(cast.in(1));
case LoadNode load -> load(load);
case StoreNode store -> store(store);
- case MemMergeNode merge -> MEMORY;
case NewNode alloc -> alloc(alloc);
case CProjNode cproj -> ((Object[])val(cproj.ctrl()))[cproj._idx];
case ProjNode proj -> ((Object[])val( proj.in(0) ))[ proj._idx];
+ case MemMergeNode mem -> null;
case ReadOnlyNode ro -> val(ro.in(1));
+ case CallNode call -> Utils.TODO(); // should not reach here, go the IfNode route
default -> throw new AssertionError("Unexpected node " + node);
};
}
@@ -326,31 +326,33 @@ public class Evaluator {
for(; i<block.nodes().length;i++) values[block.nodes()[i]._nid] = exec(block.nodes()[i]);
i=0;
switch (block.exit()) {
- case null:
- return Status.FALLTHROUGH;
- case ReturnNode ret:
- return val(ret.expr());
- case IfNode ifn:
- block = block.next()[isTrue(val(ifn.in(1))) ? 0 : 1];
- if (block == null) return Status.FALLTHROUGH;
- break;
- case RegionNode region:
- if (loops-- <= 0) return Status.TIMEOUT;
- int exit = block.exitId();
- assert exit > 0 && region.nIns() > exit;
- block = block.next()[0];
- assert block != null;
- for (; i < block.nodes().length; i++) {
- if (!(block.nodes()[i] instanceof PhiNode)) break;
- phiCache.add(val(block.nodes()[i].in(exit)));
- }
- for (i=0; i<phiCache.size(); i++) {
- values[block.nodes()[i]._nid] = phiCache.get(i);
- }
- phiCache.clear();
- break;
- default:
- throw Utils.TODO("Unexpected control node " + block.exit());
+ case null:
+ return Status.FALLTHROUGH;
+ case ReturnNode ret : return val(ret .expr());
+ case IfNode ifn:
+ block = block.next()[isTrue(val(ifn.in(1))) ? 0 : 1];
+ if (block == null) return Status.FALLTHROUGH;
+ break;
+ case RegionNode region:
+ if (loops-- <= 0) return Status.TIMEOUT;
+ int exit = block.exitId();
+ assert exit > 0 && region.nIns() > exit;
+ block = block.next()[0];
+ assert block != null;
+ for (; i < block.nodes().length; i++) {
+ if (!(block.nodes()[i] instanceof PhiNode phi)) break;
+ var val = region instanceof FunNode fun && "main".equals(fun.sig()._name) && ((ParmNode)phi)._idx==2 && exit==1
+ ? parameter
+ : val(phi.in(exit));
+ phiCache.add(val);
+ }
+ for (i=0; i<phiCache.size(); i++) {
+ values[block.nodes()[i]._nid] = phiCache.get(i);
+ }
+ phiCache.clear();
+ break;
+ default:
+ throw Utils.TODO("Unexpected control node " + block.exit());
}
}
}
diff --git a/src/test/java/com/seaofnodes/simple/evaluator/Scheduler.java b/src/test/java/com/seaofnodes/simple/evaluator/Scheduler.java
index afcc700f..52d8f3e3 100644
--- a/src/test/java/com/seaofnodes/simple/evaluator/Scheduler.java
+++ b/src/test/java/com/seaofnodes/simple/evaluator/Scheduler.java
@@ -31,8 +31,6 @@ import java.util.*;
*/
public class Scheduler {
- private final HashMap<Node,ArrayList<NodeData>> readers = new HashMap<>();
-
/**
* A basic block with a schedule of the containing nodes.
*
@@ -89,6 +87,9 @@ public class Scheduler {
this.entry = entry;
this.prev = prev;
}
+ BasicBlock(Node entry, BasicBlock prev) {
+ this(entry,prev.depth+1,prev);
+ }
}
@@ -254,7 +255,7 @@ public class Scheduler {
// but they did not refine the placement
// so do that now.
var mem = l.in(1);
- for(var out : l.antiDeps()) {
+ for(var out : mem._outputs) {
if (out instanceof PhiNode p) {
var r = p.in(0);
for (int i = 1; i < p.nIns(); i++) {
@@ -272,9 +273,13 @@ public class Scheduler {
for(var in:data.node._inputs) {
if (in!=null) update(d(in), data.block);
}
- var loads = readers.get(data.node);
- if (loads != null)
- for (var load : loads) decUsers(load);
+ if (data.node instanceof StoreNode s) {
+ // Store nodes have anti-deps to load nodes.
+ // So decrease the uses of these loads when the store is placed.
+ for (var out: s.in(1)._outputs) {
+ if (out instanceof LoadNode) od(out).ifPresent(this::decUsers);
+ }
+ }
}
// Now all nodes should be placed and have a block assigned
@@ -356,35 +361,29 @@ public class Scheduler {
var queue = new Stack<NodeData>();
var phiQueue = new Stack<NodeData>();
queue.push(d(start));
- int depth = 0;
while (!queue.isEmpty()) {
var data = queue.pop();
var node = data.node;
assert node instanceof CFGNode;
- BasicBlock block;
- switch (node) {
- case StartNode s:
- block = new BasicBlock(s, depth++);
- break;
- case LoopNode l:
- block = new BasicBlock(l, depth++, d(l.in(1)).block);
- break;
- case RegionNode r:
+ BasicBlock block = switch (node) {
+ case StartNode s -> new BasicBlock(s, 0);
+ case LoopNode l -> new BasicBlock(l, d(l.in(1)).block);
+ case RegionNode r -> {
var prev = new ArrayList<BasicBlock>();
+ int depth = 0;
for(int i=1; i<r.nIns(); i++) {
- od(r.in(i)).ifPresent(d->prev.add(d.block));
+ if( !od(r.in(i)).isPresent() ) continue;
+ BasicBlock bb = d(r.in(i)).block;
+ prev.add(bb);
+ depth = Math.max(depth,bb.depth);
}
- block = new BasicBlock(r, depth++, prev.toArray(BasicBlock[]::new));
- break;
- case IfNode i:
- block = d(i.in(0)).block;
- break;
- case ReturnNode r:
- block = d(r.in(0)).block;
- break;
- default:
- block = new BasicBlock(node, depth++, d(node.in(0)).block);
+ yield new BasicBlock(r, depth+1, prev.toArray(BasicBlock[]::new));
}
+ case IfNode i -> d(i.in(0)).block;
+ case ReturnNode ret -> d(ret .in(0)).block;
+ case CallNode call -> throw Utils.TODO();
+ default -> new BasicBlock(node, d(node.in(0)).block);
+ };
data.block = block;
if (node instanceof RegionNode r) {
// Regions might have phis which need to be scheduled.
@@ -399,10 +398,17 @@ public class Scheduler {
}
}
}
- if (!(node instanceof ReturnNode))
+ if( node instanceof FunNode fun ) {
+ // Cannot find CFG user from fun via a naive search, because always find
+ // Return but Return is not always the one CFG user.
+ CFGNode n = fun.uctrl();
+ assert isCFGNodeReady(n) && d(n).block==null;
+ queue.push(d(n));
+ } else if( !(node instanceof ReturnNode) ) {
for (Node n : node._outputs)
if(n instanceof CFGNode && isCFGNodeReady(n) && d(n).block == null)
queue.push(d(n));
+ }
var b = block;
for(var in:data.node._inputs) od(in).ifPresent(d->update(d, b));
}
@@ -440,13 +446,14 @@ public class Scheduler {
private void doMarkAlive(Node node) {
var cfgQueue = new Stack<NodeData>();
var dataQueue = new Stack<NodeData>();
+ var mem = new Stack<NodeData>();
markAlive(cfgQueue, node, true);
// Mark all CFG nodes.
while (!cfgQueue.isEmpty()) {
var data = cfgQueue.pop();
node = data.node;
assert node instanceof CFGNode;
- if (!(node instanceof ReturnNode)) {
+ if (!(node instanceof ReturnNode) ) {
for (var out : node._outputs) if (out!=null && out instanceof CFGNode && isNotXCtrl(out)) markAlive(cfgQueue, out, true);
}
for (var in : node._inputs) if(in!=null && !(in instanceof CFGNode) && isNotXCtrl(in)) markAlive(dataQueue, in, false);
@@ -464,16 +471,16 @@ public class Scheduler {
} else {
for (var in : node._inputs) if (in != null && !(in instanceof CFGNode)) markAlive(dataQueue, in, false);
}
+ if (node instanceof StoreNode) mem.push(data);
+ }
+ // Handle store nodes and increase load with an anti-dep to the store.
+ while (!mem.isEmpty()) {
+ var data = mem.pop();
+ node = data.node;
+ for(var out:node.in(1)._outputs) {
+ if (out instanceof LoadNode) od(out).ifPresent(d->d.users++);
+ }
}
- // Writes, including New behind an aggregate, schedule before their
- // anti-dependent reads in this reverse scheduling pass.
- for (var load : data.values())
- if (load.node instanceof LoadNode l)
- for (var use : l.antiDeps())
- if ((use instanceof StoreNode || use instanceof NewNode) && data.containsKey(use)) {
- load.users++;
- readers.computeIfAbsent(use,k->new ArrayList<>()).add(load);
- }
}
/**
@@ -496,15 +503,18 @@ public class Scheduler {
/**
* Find the CFG output of a node
* @param node The node
- * @return THe CFG output of the node.
+ * @return The CFG output of the node.
*/
- private static Node findSingleCFGOut(Node node) {
+ private static CFGNode findSingleCFGOut(Node node) {
if (node instanceof StartNode) {
- for(var n:node._outputs) if (n instanceof CProjNode p && p._idx==0) return p;
+ for(var n:node._outputs)
+ if (n instanceof FunNode fun && "main".equals(fun.sig()._name) )
+ return fun;
return null;
}
+ if( node instanceof FunNode fun ) return fun.uctrl();
assert node._outputs.stream().filter(x -> x instanceof CFGNode).limit(2).count()<=1;
- for(var n:node._outputs) if(n instanceof CFGNode) return n;
+ for(var n:node._outputs) if(n instanceof CFGNode cfg) return cfg;
return null;
}
@@ -558,7 +568,7 @@ public class Scheduler {
case null -> new Block(arr, null, -1, new Block[0]);
case IfNode i -> new Block(arr, i, -1, new Block[2]);
case RegionNode r -> new Block(arr, r, r._inputs.find(prev), new Block[1]);
- case ReturnNode r -> new Block(arr, r, -1, new Block[0]);
+ case ReturnNode r -> new Block(arr, r , -1, new Block[0]);
default -> throw new AssertionError("Unexpected block exit node");
});
}
diff --git a/src/test/java/com/seaofnodes/simple/fuzzer/Fuzzer.java b/src/test/java/com/seaofnodes/simple/fuzzer/Fuzzer.java
index 7dcb88e5..a5634e82 100644
--- a/src/test/java/com/seaofnodes/simple/fuzzer/Fuzzer.java
+++ b/src/test/java/com/seaofnodes/simple/fuzzer/Fuzzer.java
@@ -1,10 +1,9 @@
package com.seaofnodes.simple.fuzzer;
import com.seaofnodes.simple.Parser;
-import com.seaofnodes.simple.evaluator.Evaluator;
+import com.seaofnodes.simple.Eval2;
+import com.seaofnodes.simple.CodeGen;
import com.seaofnodes.simple.node.Node;
-import com.seaofnodes.simple.node.StopNode;
-
import java.util.ArrayList;
import java.util.Objects;
import java.util.Random;
@@ -46,8 +45,8 @@ public class Fuzzer {
e.printStackTrace(System.out);
System.out.println("========== Seed ==========");
System.out.println(seed);
- System.out.println("========== Code ===========");
- System.out.println(script);
+ //System.out.println("========== Code ===========");
+ //System.out.println(script);
System.out.println("========= Reduced =========");
System.out.println(Reducer.reduce(script, e, reproducer));
System.out.println("===========================");
@@ -56,13 +55,6 @@ public class Fuzzer {
private static boolean neq(Object a, Object b) {
if (Objects.equals(a, b)) return false;
- if (a instanceof Evaluator.Obj ea && b instanceof Evaluator.Obj eb) {
- if (ea.struct() != eb.struct()) return true;
- for(int i=0;i<ea.fields().length;i++) {
- if (neq(ea.fields()[i], eb.fields()[i])) return true;
- }
- return false;
- }
return true;
}
@@ -72,11 +64,11 @@ public class Fuzzer {
* @param e2 Evaluator for the second graph
* @param in The input value to both graphs to test for an equal output
*/
- private static void checkGraphs(Evaluator e1, Evaluator e2, long in) {
- var r1 = e1.evaluate(in, EVAL_TIMEOUT);
- var r2 = e2.evaluate(in, EVAL_TIMEOUT);
- if (r1 == Evaluator.Status.TIMEOUT || r2 == Evaluator.Status.TIMEOUT) return;
- if (neq(r1, r2))
+ private static void checkGraphs(CodeGen code1, CodeGen code2, long in) {
+ var r1 = Eval2.eval(code1, in, EVAL_TIMEOUT);
+ var r2 = Eval2.eval(code2, in, EVAL_TIMEOUT);
+ if( r1 == null || r2 == null ) return; // Timeout test invalid
+ if( neq(r1, r2) )
throw new RuntimeException("Different calculations values " + r1 + " vs " + r2);
}
@@ -88,27 +80,25 @@ public class Fuzzer {
* @param valid If the script is definitely valid. If not some exceptions may be suppressed.
*/
private static void runCheck(String script, boolean valid) {
- StopNode stop1;
+ CodeGen code1;
try {
- stop1 = FuzzerUtils.parse(script, 123);
+ code1 = FuzzerUtils.parse(script, 123);
} catch (RuntimeException e1) {
try {
FuzzerUtils.parse(script, 456);
} catch (RuntimeException e2) {
if (FuzzerUtils.isExceptionFromSameCause(e1, e2)) {
- if (!valid || e1.getClass() == RuntimeException.class) return;
+ if (!valid || e1.getClass() == Parser.ParseException.class) return;
} else {
e1.addSuppressed(e2);
}
}
throw e1;
}
- var stop2 = FuzzerUtils.parse(script, 456);
- var e1 = new Evaluator(stop1);
- var e2 = new Evaluator(stop2);
- checkGraphs(e1, e2, 0);
- checkGraphs(e1, e2, 1);
- checkGraphs(e1, e2, 10);
+ CodeGen code2 = FuzzerUtils.parse(script, 456);
+ checkGraphs(code1, code2, 0);
+ checkGraphs(code1, code2, 1);
+ checkGraphs(code1, code2, 10);
}
/**
@@ -133,9 +123,9 @@ public class Fuzzer {
var sb = new StringBuilder();
new ScriptGenerator(rand, sb, true).genProgram();
try {
- var parser = new Parser(sb.toString());
+ var code = new CodeGen(sb.toString());
- var stop = parser.parse();
+ code.parse();
int parse_peeps= Node.ITER_CNT;
int parse_nops = Node.ITER_NOP_CNT;
double parse_nop_ratio = (double)parse_nops/parse_peeps;
@@ -144,7 +134,7 @@ public class Fuzzer {
double parse_peeps_per_node = (double)parse_peeps/nids;
- stop.iterate();
+ code.opto();
int iter_peeps= Node.ITER_CNT;
int iter_nops = Node.ITER_NOP_CNT;
double iter_nop_ratio = (double)iter_nops/iter_peeps;
@@ -183,7 +173,7 @@ public class Fuzzer {
return exceptions.isEmpty();
}
- /** Run a fixed chapter-local seed without reducing or swallowing failures. */
+ /** Run a fixed seed without reducing or swallowing failures. */
public void fuzzPeepsRegression(long seed) {
var rand = new Random(seed);
var sb = new StringBuilder();
diff --git a/src/test/java/com/seaofnodes/simple/fuzzer/FuzzerUtils.java b/src/test/java/com/seaofnodes/simple/fuzzer/FuzzerUtils.java
index f947a234..4509c6fc 100644
--- a/src/test/java/com/seaofnodes/simple/fuzzer/FuzzerUtils.java
+++ b/src/test/java/com/seaofnodes/simple/fuzzer/FuzzerUtils.java
@@ -1,10 +1,9 @@
package com.seaofnodes.simple.fuzzer;
+import com.seaofnodes.simple.CodeGen;
import com.seaofnodes.simple.IterPeeps;
-import com.seaofnodes.simple.Parser;
import com.seaofnodes.simple.node.Node;
import com.seaofnodes.simple.node.StopNode;
-
import java.io.OutputStream;
import java.io.PrintStream;
import java.lang.invoke.MethodHandle;
@@ -117,7 +116,7 @@ class FuzzerUtils {
/**
* Parse and optimize using the given worklist seed
*/
- public static StopNode parse(String script, long workListSeed) {
+ public static CodeGen parse(String script, long workListSeed) {
var err = System.err;
var out = System.out;
try {
@@ -128,10 +127,10 @@ class FuzzerUtils {
} catch (Throwable e) {
throw rethrow(e);
}
- var parser = new Parser(script);
+ var code = new CodeGen(script);
+ code.parse();
WorkRandom.setSeed(workListSeed);
- var stop = parser.parse();
- return stop.iterate();
+ return code.opto().typeCheck().GCM().localSched();
} finally {
NodeWalkVisit.clear();
System.setErr(err);
diff --git a/src/test/java/com/seaofnodes/simple/fuzzer/ScriptGenerator.java b/src/test/java/com/seaofnodes/simple/fuzzer/ScriptGenerator.java
index 183dcb84..d061a656 100644
--- a/src/test/java/com/seaofnodes/simple/fuzzer/ScriptGenerator.java
+++ b/src/test/java/com/seaofnodes/simple/fuzzer/ScriptGenerator.java
@@ -483,7 +483,7 @@ public class ScriptGenerator {
fields[i] = new TypeStruct.Field(fieldName.toString(), type, struct);
}
indentation -= INDENTATION;
- printIndentation().append("}");
+ printIndentation().append("};");
struct.fields = fields;
forwardStructs.remove(struct);
structs.add(struct);
@@ -685,6 +685,7 @@ public class ScriptGenerator {
public int genDecl() {
var type = getType();
var name = getVarName();
+ // Always make them mutable
sb.append(generateInvalid() ? getRandomName() : declType(type)).append(" !").append(name);
if (!(type instanceof TypeNullable) || random.nextBoolean()) {
sb.append("=");