summaryrefslogtreecommitdiff
path: root/chapter13
diff options
context:
space:
mode:
Diffstat (limited to 'chapter13')
-rw-r--r--chapter13/src/main/java/com/seaofnodes/simple/Parser.java4
-rw-r--r--chapter13/src/main/java/com/seaofnodes/simple/node/LoadNode.java2
-rw-r--r--chapter13/src/main/java/com/seaofnodes/simple/node/MemOpNode.java9
-rw-r--r--chapter13/src/main/java/com/seaofnodes/simple/node/StoreNode.java6
-rw-r--r--chapter13/src/test/java/com/seaofnodes/simple/Chapter11Test.java17
-rw-r--r--chapter13/src/test/java/com/seaofnodes/simple/Chapter13Test.java2
6 files changed, 26 insertions, 14 deletions
diff --git a/chapter13/src/main/java/com/seaofnodes/simple/Parser.java b/chapter13/src/main/java/com/seaofnodes/simple/Parser.java
index f04bf5c3..53448e4d 100644
--- a/chapter13/src/main/java/com/seaofnodes/simple/Parser.java
+++ b/chapter13/src/main/java/com/seaofnodes/simple/Parser.java
@@ -598,7 +598,7 @@ public class Parser {
Node n = new NewNode(TypeMemPtr.make(obj), ctrl()).peephole().keep();
int alias = START._aliasStarts.get(obj._name);
for( Field field : obj._fields ) {
- memAlias(alias, new StoreNode(field._fname, alias, field._type, memAlias(alias), n, new ConstantNode(field._type.makeInit()).peephole(),true).peephole());
+ memAlias(alias, new StoreNode(field._fname, alias, field._type, ctrl(), memAlias(alias), n, new ConstantNode(field._type.makeInit()).peephole(),true).peephole());
alias++;
}
return n.unkeep();
@@ -640,7 +640,7 @@ public class Parser {
else {
Node val = parseExpression();
Type glb = base._fields[idx]._type;
- memAlias(alias, new StoreNode(name, alias,glb, memAlias(alias), expr, val, false).peephole());
+ memAlias(alias, new StoreNode(name, alias,glb, ctrl(), memAlias(alias), expr, val, false).peephole());
return expr; // "obj.a = expr" returns the expression while updating memory
}
}
diff --git a/chapter13/src/main/java/com/seaofnodes/simple/node/LoadNode.java b/chapter13/src/main/java/com/seaofnodes/simple/node/LoadNode.java
index 4e1421fa..a033a7cf 100644
--- a/chapter13/src/main/java/com/seaofnodes/simple/node/LoadNode.java
+++ b/chapter13/src/main/java/com/seaofnodes/simple/node/LoadNode.java
@@ -19,7 +19,7 @@ public class LoadNode extends MemOpNode {
* @param memPtr The ptr to the struct from where we load a field
*/
public LoadNode(String name, int alias, Type glb, Node memSlice, Node memPtr) {
- super(name, alias, glb, memSlice, memPtr);
+ super(name, alias, glb, null, memSlice, memPtr);
}
@Override public String label() { return _name; }
diff --git a/chapter13/src/main/java/com/seaofnodes/simple/node/MemOpNode.java b/chapter13/src/main/java/com/seaofnodes/simple/node/MemOpNode.java
index bc8e46d3..95319c24 100644
--- a/chapter13/src/main/java/com/seaofnodes/simple/node/MemOpNode.java
+++ b/chapter13/src/main/java/com/seaofnodes/simple/node/MemOpNode.java
@@ -14,16 +14,11 @@ public abstract class MemOpNode extends Node {
public final Type _declaredType;
- public MemOpNode(String name, int alias, Type glb, Node memSlice, Node memPtr) {
- super(null, memSlice, memPtr);
+ public MemOpNode(String name, int alias, Type glb, Node... nodes ) {
+ super(nodes);
_name = name;
_alias = alias;
_declaredType = glb;
-
- }
- public MemOpNode(String name, int alias, Type glb, Node memSlice, Node memPtr, Node value) {
- this(name, alias, glb, memSlice, memPtr);
- addDef(value);
}
public Node mem() { return in(1); }
diff --git a/chapter13/src/main/java/com/seaofnodes/simple/node/StoreNode.java b/chapter13/src/main/java/com/seaofnodes/simple/node/StoreNode.java
index 44a14be1..57e8b3ad 100644
--- a/chapter13/src/main/java/com/seaofnodes/simple/node/StoreNode.java
+++ b/chapter13/src/main/java/com/seaofnodes/simple/node/StoreNode.java
@@ -19,12 +19,12 @@ public class StoreNode extends MemOpNode {
* @param memPtr The ptr to the struct where we will store a value
* @param value Value to be stored
*/
- public StoreNode(String name, int alias, Type glb, Node memSlice, Node memPtr, Node value, boolean init) {
- super(name, alias, glb, memSlice, memPtr, value);
+ public StoreNode(String name, int alias, Type glb, Node ctrl, Node memSlice, Node memPtr, Node value, boolean init) {
+ super(name, alias, glb, ctrl, memSlice, memPtr, value);
_init = init;
}
- @Override public String label() { return "ST"+_name; }
+ @Override public String label() { return "." +_name+"="; }
@Override public String glabel() { return "." +_name+"="; }
@Override public boolean isMem() { return true; }
diff --git a/chapter13/src/test/java/com/seaofnodes/simple/Chapter11Test.java b/chapter13/src/test/java/com/seaofnodes/simple/Chapter11Test.java
index e367184c..a47bf471 100644
--- a/chapter13/src/test/java/com/seaofnodes/simple/Chapter11Test.java
+++ b/chapter13/src/test/java/com/seaofnodes/simple/Chapter11Test.java
@@ -511,4 +511,21 @@ return v;
StopNode stop = parser.parse(false).iterate(true);
//assertEquals("return new S;", stop.toString());
}
+
+ @Test
+ public void testSplit() {
+ Parser parser = new Parser(
+ """
+struct S { int f; }
+S s = new S;
+if( arg==0 ) s.f = 1;
+else if (arg == 1) s.f = 1;
+return s.f;
+""");
+ StopNode stop = parser.parse(false).iterate(true);
+ assertEquals("return Phi(Region37,1,Phi(Region35,1,0));", stop.toString());
+ assertEquals(1L, Evaluator.evaluate(stop, 0));
+ assertEquals(1L, Evaluator.evaluate(stop, 1));
+ assertEquals(0L, Evaluator.evaluate(stop, 2));
+ }
}
diff --git a/chapter13/src/test/java/com/seaofnodes/simple/Chapter13Test.java b/chapter13/src/test/java/com/seaofnodes/simple/Chapter13Test.java
index f7d4d5a8..a58ad583 100644
--- a/chapter13/src/test/java/com/seaofnodes/simple/Chapter13Test.java
+++ b/chapter13/src/test/java/com/seaofnodes/simple/Chapter13Test.java
@@ -35,7 +35,7 @@ while( arg ) {
return head.next.i;
""");
try { parser.parse(true).iterate(true); fail(); }
- catch( Exception e ) { assertEquals("Might be null accessing 'i'",e.getMessage()); }
+ catch( Exception e ) { assertEquals("Might be null accessing 'next'",e.getMessage()); }
}
@Test