From 736c658c274404084b15b450b2ab72d0e7569586 Mon Sep 17 00:00:00 2001 From: Dibyendu Majumdar Date: Fri, 3 Nov 2023 21:21:54 +0000 Subject: Backport changes in Chapter 5 to previous chapters and update Chapter5 documentation (#34) * Backport changes from chapter 5 to older chapters (#30) * Fix wrong indent * Backport to chapter 4 * Backport to chapter 3 * Backport to chapter 2 * Backport to chapter 1 * Add if statement to comment (#32) * Update visuals for chapters 1,2 & 3. Reenable drawing of edges from constants to Start for these chapters. * Update visuals for chapters 4. Revise text to explain the labeling of edges in graphs and that we omit edge from Constant to Start nodes from chapter 4. * Add code snippets for if statement parsing and the duplication and merging of ScopeNodes. Explain how scopeNodes are duplicated and merged. * Add constant check to minus node (#31) * Fix closing root block with } (#33) * Backport fix closing root block with } to chapter 4 and 3 (#35) * Show use-def edge from Phi to Region as dotted edge. Add example of Phi peephole. Update visuals. Add more examples. * Fix visuals in chapter 1 and README in chapter 4. * Remove subheading * Adjust spaces --------- Co-authored-by: XmiliaH <45106915+XmiliaH@users.noreply.github.com> --- chapter02/README.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'chapter02/README.md') diff --git a/chapter02/README.md b/chapter02/README.md index b89a3059..e1ee19aa 100644 --- a/chapter02/README.md +++ b/chapter02/README.md @@ -117,9 +117,10 @@ The following visual shows how the graph looks like pre-peephole optimization: ![Example Visual](./docs/02-pre-peephole-ex1.svg) -* Control nodes appear as square boxes +* Control nodes appear as square boxes with yellow background * Control edges are in bold red -* The edges from Start to Constants are shown in dotted lines as these are not true def-use edges +* The edges from Constants to Start are shown in dotted lines as these are not true control edges +* We label each edge with its position in the node's list of inputs. ## Post-peephole -- cgit v1.2.3