From 703f88dbb2e1e4352a0725b7e742151739b82ea1 Mon Sep 17 00:00:00 2001 From: Cliff Click Date: Fri, 13 Sep 2024 09:23:19 -0700 Subject: x-x==0 Move x-x==0 to compute. Add x/1 ==> x All chapters --- chapter05/src/main/java/com/seaofnodes/simple/node/DivNode.java | 7 ++++++- chapter05/src/main/java/com/seaofnodes/simple/node/SubNode.java | 7 +++---- 2 files changed, 9 insertions(+), 5 deletions(-) (limited to 'chapter05/src/main') diff --git a/chapter05/src/main/java/com/seaofnodes/simple/node/DivNode.java b/chapter05/src/main/java/com/seaofnodes/simple/node/DivNode.java index bf025453..519a8c8a 100644 --- a/chapter05/src/main/java/com/seaofnodes/simple/node/DivNode.java +++ b/chapter05/src/main/java/com/seaofnodes/simple/node/DivNode.java @@ -31,7 +31,12 @@ public class DivNode extends Node { } @Override - public Node idealize() { return null; } + public Node idealize() { + // Div of 1. + if( in(2)._type.isConstant() && in(2)._type instanceof TypeInteger i && i.value()==1 ) + return in(1); + return null; + } @Override Node copy(Node lhs, Node rhs) { return new DivNode(lhs,rhs); } } diff --git a/chapter05/src/main/java/com/seaofnodes/simple/node/SubNode.java b/chapter05/src/main/java/com/seaofnodes/simple/node/SubNode.java index 0d0ed7dc..5e7243ba 100644 --- a/chapter05/src/main/java/com/seaofnodes/simple/node/SubNode.java +++ b/chapter05/src/main/java/com/seaofnodes/simple/node/SubNode.java @@ -25,15 +25,14 @@ public class SubNode extends Node { return TypeInteger.constant(i0.value()-i1.value()); return i0.meet(i1); } + // Sub of same is 0 + if( in(1)==in(2) ) + return TypeInteger.ZERO; return Type.BOTTOM; } @Override public Node idealize() { - // Sub of same is 0 - if( in(1)==in(2) ) - return new ConstantNode(TypeInteger.constant(0)); - return null; } -- cgit v1.2.3