From 703f88dbb2e1e4352a0725b7e742151739b82ea1 Mon Sep 17 00:00:00 2001 From: Cliff Click Date: Fri, 13 Sep 2024 09:23:19 -0700 Subject: x-x==0 Move x-x==0 to compute. Add x/1 ==> x All chapters --- chapter09/src/main/java/com/seaofnodes/simple/node/DivNode.java | 7 ++++++- chapter09/src/main/java/com/seaofnodes/simple/node/SubNode.java | 7 +++---- 2 files changed, 9 insertions(+), 5 deletions(-) (limited to 'chapter09') diff --git a/chapter09/src/main/java/com/seaofnodes/simple/node/DivNode.java b/chapter09/src/main/java/com/seaofnodes/simple/node/DivNode.java index ba06d037..08ce70b8 100644 --- a/chapter09/src/main/java/com/seaofnodes/simple/node/DivNode.java +++ b/chapter09/src/main/java/com/seaofnodes/simple/node/DivNode.java @@ -32,7 +32,12 @@ public class DivNode extends Node { } @Override - public Node idealize() { return null; } + public Node idealize() { + // Div of 1. + if( in(2)._type.isConstant() && in(2)._type instanceof TypeInteger i && i.value()==1 ) + return in(1); + return null; + } @Override Node copy(Node lhs, Node rhs) { return new DivNode(lhs,rhs); } } diff --git a/chapter09/src/main/java/com/seaofnodes/simple/node/SubNode.java b/chapter09/src/main/java/com/seaofnodes/simple/node/SubNode.java index ce83122c..7273c02a 100644 --- a/chapter09/src/main/java/com/seaofnodes/simple/node/SubNode.java +++ b/chapter09/src/main/java/com/seaofnodes/simple/node/SubNode.java @@ -26,15 +26,14 @@ public class SubNode extends Node { if (i0.isConstant() && i1.isConstant()) return TypeInteger.constant(i0.value()-i1.value()); } + // Sub of same is 0 + if( in(1)==in(2) ) + return TypeInteger.ZERO; return in(1)._type.meet(in(2)._type); } @Override public Node idealize() { - // Sub of same is 0 - if( in(1)==in(2) ) - return new ConstantNode(TypeInteger.constant(0)); - return null; } -- cgit v1.2.3