From 4be43794169610d45e47468702c63cdfbc5deb5a Mon Sep 17 00:00:00 2001 From: Cliff Click Date: Fri, 13 Sep 2024 09:40:38 -0700 Subject: move x-x check up front --- chapter13/src/main/java/com/seaofnodes/simple/node/SubNode.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'chapter13/src/main/java/com/seaofnodes') diff --git a/chapter13/src/main/java/com/seaofnodes/simple/node/SubNode.java b/chapter13/src/main/java/com/seaofnodes/simple/node/SubNode.java index 0f2deb33..81cc6076 100644 --- a/chapter13/src/main/java/com/seaofnodes/simple/node/SubNode.java +++ b/chapter13/src/main/java/com/seaofnodes/simple/node/SubNode.java @@ -22,14 +22,15 @@ public class SubNode extends Node { @Override public Type compute() { + // Sub of same is 0 + if( in(1)==in(2) ) + return TypeInteger.ZERO; + if (in(1)._type instanceof TypeInteger i0 && in(2)._type instanceof TypeInteger i1) { if (i0.isConstant() && i1.isConstant()) return TypeInteger.constant(i0.value()-i1.value()); } - // Sub of same is 0 - if( in(1)==in(2) ) - return TypeInteger.ZERO; return in(1)._type.meet(in(2)._type); } -- cgit v1.2.3