From 45039c5f9805bbcf9ffe0dbe4a31dd8bc95b221c Mon Sep 17 00:00:00 2001 From: Hsiang-Ying Fu <66062782+fuhsnn@users.noreply.github.com> Date: Sat, 4 Jul 2026 05:23:25 +0800 Subject: Move `addUse()` return statement to `keep()` (#243) --- chapter21/src/main/java/com/seaofnodes/simple/node/Node.java | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) (limited to 'chapter21/src/main/java/com') diff --git a/chapter21/src/main/java/com/seaofnodes/simple/node/Node.java b/chapter21/src/main/java/com/seaofnodes/simple/node/Node.java index c0c2e606..4ca95cae 100644 --- a/chapter21/src/main/java/com/seaofnodes/simple/node/Node.java +++ b/chapter21/src/main/java/com/seaofnodes/simple/node/Node.java @@ -226,8 +226,7 @@ public abstract class Node implements Cloneable { } // Breaks the edge invariants, used temporarily - @SuppressWarnings("unchecked") - protected N addUse(Node n) { _outputs.add(n); return (N)this; } + protected void addUse(N n) { _outputs.add(n); } // Remove node 'use' from 'def's (i.e. our) output list, by compressing the list in-place. // Return true if the output list is empty afterward. @@ -282,13 +281,11 @@ public abstract class Node implements Cloneable { // Shortcuts to stop DCE mid-parse // Add bogus null use to keep node alive - public N keep() { return addUse(null); } + @SuppressWarnings("unchecked") + public N keep() { addUse(null); return (N)this; } // Remove bogus null. @SuppressWarnings("unchecked") - public N unkeep() { - delUse(null); - return (N)this; - } + public N unkeep() { delUse(null); return (N)this; } // Test "keep" status public boolean iskeep() { return _outputs.find(null) != -1; } public void unkill() { -- cgit v1.2.3