From f4bd723d929e53475f7990374dca7b7dfcbbdc42 Mon Sep 17 00:00:00 2001
From: Cliff Click <cliffc@acm.org>
Date: Sun, 1 Nov 2026 10:33:55 -0800
Subject: Add Chapter 29 for tech debt cleanup with the parser split

Keep Chapter 28b intact and carry the grammar-oriented parser package, Var move, IterPeeps move, and parser regression tests into Chapter 29. Defer privacy and exclude its experimental tests and fixture changes.

Register the chapter in the indexes, IntelliJ modules and run configurations, Maven reactor, roadmap, and linear-history publisher. Windows and Linux each pass 573 tests, release builds, 199 allocation replays, and 29 native checks.
---
 .../seaofnodes/simple/FinalConstructionTest.java   | 66 ++++++++++++++++++++++
 1 file changed, 66 insertions(+)
 create mode 100644 chapter29/src/test/java/com/seaofnodes/simple/FinalConstructionTest.java

(limited to 'chapter29/src/test/java/com/seaofnodes/simple/FinalConstructionTest.java')

diff --git a/chapter29/src/test/java/com/seaofnodes/simple/FinalConstructionTest.java b/chapter29/src/test/java/com/seaofnodes/simple/FinalConstructionTest.java
new file mode 100644
index 00000000..38b94693
--- /dev/null
+++ b/chapter29/src/test/java/com/seaofnodes/simple/FinalConstructionTest.java
@@ -0,0 +1,66 @@
+package com.seaofnodes.simple;
+
+import com.seaofnodes.simple.parser.Parser;
+import com.seaofnodes.simple.codegen.CodeGen;
+import com.seaofnodes.simple.node.StoreNode;
+import org.junit.Test;
+import static org.junit.Assert.*;
+
+public class FinalConstructionTest {
+    private static final String LOOP = """
+        val step={int x -> x*2+1;};
+        struct C {
+            val x=1;
+            new C={int n ->
+                x=0; x=1;
+                for(int i=0; i<n; i++) x=step(x);
+            };
+            val get={->x;};
+        };
+        return new C(arg).get();
+        """;
+
+    @Test public void testFinalConstructorLocals() throws java.io.IOException {
+        var code=new CodeGen(LOOP).driver(CodeGen.Phase.LocalSched);
+        assertEquals("1",Eval2.eval(code,0));
+        assertEquals("15",Eval2.eval(code,3));
+        assertEquals("63",Eval2.eval(code,5));
+        code._stop.walk(n -> {
+            if( n instanceof StoreNode st && st._name.equals("x") )
+                assertEquals("Final field writes belong after the loop",0,st.cfg0().loopDepth());
+            return null;
+        });
+        String[] sources={
+            "struct C { val x=1; new C={->x=1; x=2;}; }; return new C().x;",
+            "struct C { int ~x; new C={int n -> self.x=1; for(int i=0;i<n;i++) self.x*=2;}; }; return new C(arg).x;",
+            "struct C { val x=1; new C={int n -> for(int i=0;i<n;i++) ++x;}; }; return new C(arg).x;",
+            "struct C { val x=1.5; new C={->x=2.5;}; }; return new C().x;",
+            "struct C { val x=\"a\"; new C={int n -> for(int i=0;i<n;i++) x=\"b\";}; }; return new C(arg).x[0];",
+            "struct C { val x=new int[1]; new C={->x=new int[2]; x=new int[3];}; }; return new C().x#;"
+        };
+        String[] results={"2","8","4","2.5","98","3"};
+        for( int i=0; i<sources.length; i++ )
+            assertEquals(results[i],Eval2.eval(new CodeGen(sources[i]).driver(CodeGen.Phase.TypeCheck),3));
+
+        String[] rejected={
+            "struct C { val x=1; }; val c=new C(); c.x=2; return c.x;",
+            "struct C { new C={->val x=1; x=2;}; }; return new C();",
+            "struct C { val f={->1;}; new C={->f={->2;};}; }; return new C().f();"
+        };
+        for( String src : rejected ) {
+            try { new CodeGen(src).driver(CodeGen.Phase.TypeCheck); fail(src); }
+            catch( Parser.ParseException e ) { assertTrue(e.getMessage(),e.getMessage().startsWith("Cannot")); }
+        }
+
+        var dir=java.nio.file.Path.of("build/objs");
+        java.nio.file.Files.createDirectories(dir);
+        java.nio.file.Files.writeString(dir.resolve("finalConstruction.smp"),"val buildFinal={int arg ->"+LOOP+"};");
+        java.nio.file.Files.writeString(dir.resolve("finalConstruction.c"),"""
+            extern long long buildFinal(long long);
+            int main(void) { return buildFinal(0)!=1 || buildFinal(3)!=15 || buildFinal(5)!=63; }
+            """);
+        TestC.run("val buildFinal={int arg ->"+LOOP+"};","finalConstruction",null,TestC.CALL_CONVENTION,
+                  TestC.CALL_CONVENTION.equals("win64") ? "ms_abi" : "sysv_abi",
+                  dir.resolve("finalConstruction.c").toString(),"",-1);
+    }
+}
-- 
cgit v1.2.3